May 2007 - Wine-Devel - list.winehq.org

Re: crypt32: implement CryptSIPLoad (resend)

by Juan Lang

> It's causing test failures: > > ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p > rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok > rsaenh.c:64: Test failed: 0, 00000057 > rsaenh.c:68: Test failed: 00000057 > make: *** [rsaenh.ok] Error 2 How very odd, those failures aren't anywhere in the code path modified by this. In fact, crypt32 shouldn't even be loaded at that point in the tests: the failing calls are through advapi32 to rsaenh, and crypt32 isn't loaded explicitly or implicitly by the tests. Are you sure there isn't something else going on? --Juan ____________________________________________________________________________________Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

May 23, 2007

Re: Bugzilla outcome?

by Tom Spear

On 5/23/07, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > On Wed, 2007-05-23 at 04:36 +0200, Jan Zerebecki wrote: > > I'll ask what the progress is with our Bugzilla upgrade when > > the one who offered this comes online again. > > While you are asking, make sure they are going to Bugzilla 3.0. Since that just went stable not very long ago. > > I may make a suggestion for upgrading. It may be easier to start a new DB for Bugzilla, > and write a script that imports all the old data to the new tables. I think I would even prefer that.. Maybe it could be set to not import anything that had the abandoned or invalid flags so that we have a leaner meaner db as well? -- Thanks Tom

May 23, 2007

Re: Application deletion!

by Ed Black

On Wednesday 23 May 2007 12:49, EA Durbin wrote: > Someone using Molle Bestefich's account has been attacking the AppDB. I've > lost my AppDB admin privileges as well as a bunch of things are being > deleted. > If anyone's able to contact Molle *other than* via gmail, it might be a good idea to do so - if something of his has been compromised/stolen, the implications could be wider than appdb for him and other projects he might be involved in.

May 23, 2007

Re: Bugzilla outcome?

by Jeremy Newman

On Wed, 2007-05-23 at 04:36 +0200, Jan Zerebecki wrote: > I'll ask what the progress is with our Bugzilla upgrade when > the one who offered this comes online again. While you are asking, make sure they are going to Bugzilla 3.0. Since that just went stable not very long ago. I may make a suggestion for upgrading. It may be easier to start a new DB for Bugzilla, and write a script that imports all the old data to the new tables.

May 23, 2007

Re: Bugzilla outcome?

by Tom Spear

On 5/22/07, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > I'll ask what the progress is with our Bugzilla upgrade when > the one who offered this comes online again. Thanks > I would consider neither of hang, stuck, 100% cpu usage, freeze > to be a crash. Out of curiosity, why not? > I think that regardless of the result of the bug it might be > useful to check that it gets debugged. > > So we might distinguish two boolean variables for bugs: > - (1) Has it all the information that can be provided (e.g. > crash log and back-trace with debug symbols)? This would also > contain checking that all the fields are properly set. > - (2) Do we know the cause for the bug? ( E.g. for a > segmentation fault AKA crash in the application, do we know > what in Wine caused it? ) > > Should we include in (1) if it can be reproduced independently? That would be helpful to you guys, so I see no problem with it. -- Thanks Tom

May 23, 2007

Re: RegDeleteTree [8]

by Alexandre Julliard

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Recursively delete all the subkeys */ > + for (i = 0; i < dwKeyCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumKeyExW(hSubKey, 0, lpszName, &dwSize, NULL, > + NULL, NULL, NULL); There's no reason to use the key count, you should enum until you get an error, it's more reliable. > + for (i = 0; i < dwValCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumValueW(hKey, 0, lpszName, &dwSize, NULL, NULL, NULL, NULL); Same here. -- Alexandre Julliard julliard(a)winehq.org

May 23, 2007

RE: Application deletion!

by EA Durbin

Someone using Molle Bestefich's account has been attacking the AppDB. I've lost my AppDB admin privileges as well as a bunch of things are being deleted. >From: James Bond <tehstealth(a)yahoo.com> >To: appdb(a)winehq.org >Subject: Application deletion! >Date: Wed, 23 May 2007 04:40:49 -0700 (PDT) > >I'm sorry, I do not know who to contact for this, but the 2 apps I've been >maintaining Soldat, and Battlefield 2 have BOTH been completely deleted! >At first it was Soldat, and I thought maybe since it was a small game made >by a lone developer, it was removed. I e-mailed the person resposnible, toa >ask why. But I just got another mass spam of e-mails this morning saying >this and that were deleted from Battlefield 2, a very popular game! I think >something is wrong. Molle Bestefich (molle.bestefich(a)gmail.com) is the one >whose deleted all of that stuff. What is going on? > >-Brian > > > >____________________________________________________________________________________Ready >for the edge of your seat? >Check out tonight's top picks on Yahoo! TV. >http://tv.yahoo.com/ _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

May 23, 2007

Re: crypt32: implement CryptSIPLoad (resend)

by Alexandre Julliard

Juan Lang <juan_lang(a)yahoo.com> writes: > Hi, any problems with this one? It's causing test failures: ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok rsaenh.c:64: Test failed: 0, 00000057 rsaenh.c:68: Test failed: 00000057 make: *** [rsaenh.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

May 23, 2007

Re: [1/3] DDraw: Hold the dll lock in IDirectDrawSurfaceX methods

by Alexandre Julliard

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -810,8 +841,12 @@ IDirectDrawSurfaceImpl_AddAttachedSurface(IDirectDrawSurfaceImpl *This, > { > TRACE("(%p)->(%p)\n", This, Surf); > > + EnterCriticalSection(&ddraw_cs); > if(Surf == This) > + { > + LeaveCriticalSection(&ddraw_cs); > return DDERR_CANNOTATTACHSURFACE; /* unchecked */ > + } Parameter checks can be done outside the section, it simplifies the code. There are many more such cases in the patch. -- Alexandre Julliard julliard(a)winehq.org

May 23, 2007

Re: [PATCH] check return code of ICreateDevEnum_CreateClassEnumerator

by Alexandre Julliard

Marcus Meissner <marcus(a)jet.franken.de> writes: > diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c > index 6adce61..841b130 100644 > --- a/dlls/quartz/filtermapper.c > +++ b/dlls/quartz/filtermapper.c > @@ -966,6 +966,9 @@ static HRESULT WINAPI FilterMapper2_Enum > if (SUCCEEDED(hr)) > hr = ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &CLSID_ActiveMovieCategories, &pEnumCat, 0); > > + if (!SUCCEEDED(hr)) > + return hr; You are potentially leaking an object here. -- Alexandre Julliard julliard(a)winehq.org

May 23, 2007

Re: [1/5] basetsd.h: Fix a typo in the parameter name

by Dmitry Timoshkov

"Marcus Meissner" <meissner(a)suse.de> wrote: >> -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) >> +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) > > I do not think this is right. Why? -- Dmitry.

May 23, 2007

Re: [1/5] basetsd.h: Fix a typo in the parameter name

by Marcus Meissner

On Wed, May 23, 2007 at 05:04:39PM +0900, Dmitry Timoshkov wrote: > "Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > > >I think this patch is not correct. > > > >-#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > >+#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) > > > >I dont see 'l' defined or sent to this macro any where. > > If you will inspect more closely all appropriate macros you will > notice why it's a typo. Well, I meant more that you should have changed "h" in both occurences, instead of just one. Like this: > >-#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > >+#define LongToHandle(l) ((HANDLE)(LONG_PTR)(l)) Ciao, Marcus

May 23, 2007

Re: [1/5] basetsd.h: Fix a typo in the parameter name

by Dmitry Timoshkov

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > I think this patch is not correct. > > -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) > > I dont see 'l' defined or sent to this macro any where. If you will inspect more closely all appropriate macros you will notice why it's a typo. -- Dmitry.

May 23, 2007

Re: [1/5] basetsd.h: Fix a typo in the parameter name

by Marcus Meissner

On Wed, May 23, 2007 at 04:35:33PM +0900, Dmitry Timoshkov wrote: > Hello, > > Changelog: > basetsd.h: Fix a typo in the parameter name. > > --- > include/basetsd.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index e0d04f6..fe3639f 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -219,7 +219,7 @@ typedef unsigned short UHALF_PTR, *PUHALF_PTR; > #define HandleToULong(h) ((ULONG)(ULONG_PTR)(h)) > #define HandleToLong(h) ((LONG)(LONG_PTR)(h)) > #define ULongToHandle(ul) ((HANDLE)(ULONG_PTR)(ul)) > -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I do not think this is right. Ciao, Marcus

May 23, 2007

[1/5] basetsd.h: Fix a typo in the parameter name

by Vijay Kiran Kamuju

Hi I think this patch is not correct. -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I dont see 'l' defined or sent to this macro any where. Thanks, VJ

May 23, 2007

APPDB ROGE USER

by Vitaliy Margolen

ANYONE WITH appdb admin rights check into IRC!!!

May 22, 2007

Re: New Gecko package

by Vitaliy Margolen

Jacek Caban wrote: > Hi Vitaliy, > > Vitaliy Margolen wrote: >> Jacek Caban wrote: >> >> wine iexplore http://winehq.org/ crashes for me. >> > Could you please send me seh,tid,mshtml,shdocvw logs? Never mind. It was some testing patch in my tree that broke things. >> BTW why JavaScript doesn't work or any pop-up windows don't open? I know >> this works fine with Firefox. >> > It needs some support from Gecko embedder (MSHTML in our case) and I > haven't worked on it yet (with exception of built in alert pop-up). You mean that what Wine has now uses gecko for just HTML rendering and nothing else?! That you are pretty much rewriting the whole browser from the scratch?!! How is that better then what we had before?!!! The impression you gave about a year ago that Mozilla active-X controls needed number of things modified, but other then that it worked fine. Here I see only most rudimentary things work, and everything else would probably never work. And Wine is open for stream of never ending security issues, that so far no one even risen. I hate to sound negative about things here, but how hard will it be to put things back the way they were before? Or at least make it possible to use Mozilla ActiveX controls instead of wine_gecko? Vitaliy Margolen.

May 22, 2007

Re: Bugzilla outcome?

by Jan Zerebecki

I'll ask what the progress is with our Bugzilla upgrade when the one who offered this comes online again. On Tue, May 22, 2007 at 03:25:40PM -0500, Tom Spear wrote: > On 5/22/07, Robert Shearman <rob(a)codeweavers.com> wrote: > >Searching for "Unhandled exception" is too hard? > > Not all bugs have a proper trace, not all crashes result in the > unhandled exception message (100% cpu usage being one case), not all > bugs say crash (some say hang, or stuck, 100% cpu usage, freeze, etc). > So If we had a crash keyword, then as people look at the new bugs, it > can be added. Then people who are looking for crashes to fix or at > least debug further (as I do), can find those bugs easier. I would consider neither of hang, stuck, 100% cpu usage, freeze to be a crash. I think that regardless of the result of the bug it might be useful to check that it gets debugged. So we might distinguish two boolean variables for bugs: - (1) Has it all the information that can be provided (e.g. crash log and back-trace with debug symbols)? This would also contain checking that all the fields are properly set. - (2) Do we know the cause for the bug? ( E.g. for a segmentation fault AKA crash in the application, do we know what in Wine caused it? ) Should we include in (1) if it can be reproduced independently? Jan

May 22, 2007

Re: FPS tool for wine

by Jan Zerebecki

On Mon, May 21, 2007 at 06:13:25PM -0500, EA Durbin wrote: > does fraps not work in wine? http://appdb.winehq.org/appview.php?iVersionId=5065 Last I tested it crashed on startup: http://bugs.winehq.org/show_bug.cgi?id=5601 . Jan

May 22, 2007

Re: New Gecko package

by Luke Bratch

--- Jacek Caban <jacek(a)codeweavers.com> wrote: > Okay, I think I found the fix. I've uploaded a new > package. It's the > same URL as before: > http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko.tar.bz2 > It fixes the crash for me. Yup this fixes that problem for me, however I've found another regression. If you view for instance this page in most browsers including the old wine Gecko, you will see "Buy Now" buttons: http://www.tghost.co.uk/sale.html But with the new one, they are rendered as the alternative text rather the image. ___________________________________________________________ New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes. http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk

May 22, 2007

Re: winscard: small stub implementation of winscard dll (Try 2)

by Mounir IDRASSI

Hi Alexandre, You are completely right...these variables are definitely useless!! I don't remember when I coded that but it must have been very late at night! Anyway, I'll purge them from the patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: >> Thank you for your comments Alexandre. >> Concerning the SCARD_PCI_xxx , I implemented them as variables instead >> of defines because it's impossible using winelib to link against the >> exported variables g_rgSCardXXX (please see my discussion with Eric >> Pouech about that). Well, I should create variables with other names to >> achieve the same goal. >> > Linking against SCARD_PCI_xxx would be just as impossible, so I still > don't understand why you need any extra variables. Could you give an > example? >

May 22, 2007

Re: Bugzilla outcome?

by Tom Spear

On 5/22/07, James Hawkins <truiken(a)gmail.com> wrote: > I don't see how a 'crash' keyword will add any utility to bugzilla. > Is someone planning on focusing solely on apps that crash, and if so, > why? Well, when I look thru bugzilla, that is my main focus is find bugs with crashes, and try to debug them as far as I can so that all the info is there to write a fix without a real developer having to sit there and hold a user's hands thru the dirty part. -- Thanks Tom

May 22, 2007

Re: Bugzilla outcome?

by James Hawkins

On 5/22/07, Tom Spear <speeddymon(a)gmail.com> wrote: > On 5/22/07, Robert Shearman <rob(a)codeweavers.com> wrote: > > Searching for "Unhandled exception" is too hard? > > Not all bugs have a proper trace, not all crashes result in the > unhandled exception message (100% cpu usage being one case), not all > bugs say crash (some say hang, or stuck, 100% cpu usage, freeze, etc). > So If we had a crash keyword, then as people look at the new bugs, it > can be added. Then people who are looking for crashes to fix or at > least debug further (as I do), can find those bugs easier. > I don't see how a 'crash' keyword will add any utility to bugzilla. Is someone planning on focusing solely on apps that crash, and if so, why? -- James Hawkins

May 22, 2007

Re: New Gecko package

by Jacek Caban

Hi Vitaliy, Vitaliy Margolen wrote: > Jacek Caban wrote: > >> Hi all, >> >> It's time to update our Gecko package. I've prepared a new one. I'd like >> to avoid any regression, esp. ones that would require changing the >> package again. That's why I'd like to do a good test. I'm interested in >> regressions, so just a simple test if app that worked before still works >> will be fine. To do so download: >> >> > wine iexplore http://winehq.org/ crashes for me. > Could you please send me seh,tid,mshtml,shdocvw logs? > >> Expected visible difference should be: >> - Working scrollbars (still not perfect, they will be visible even if >> app sets it to not be, but it's better than before - I will work on it >> later) >> > Sweet, they finally do work in steam! > Seriously it still doesn't work as expected (Steam draws its own scrollbar, while currently Gecko's ones are painted, but it's a step forward). > > BTW why JavaScript doesn't work or any pop-up windows don't open? I know > this works fine with Firefox. > It needs some support from Gecko embedder (MSHTML in our case) and I haven't worked on it yet (with exception of built in alert pop-up). Thanks for testing! Jacek

May 22, 2007

Re: New Gecko package

by Jacek Caban

Jacek Caban wrote: >> - Extracting it to install it manually works, as do >> the scroll bars (which work fine) >> - It crashes after submitting more than one form on >> websites. For instance searching for something on >> Google, then searching again will cause a crash. >> >> > > Thanks for testing. I've reproduced the crash and I'm trying to fix it. > I've found that using older nspr4.dll fixes it so far. > > Okay, I think I found the fix. I've uploaded a new package. It's the same URL as before: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko.tar.bz2 It fixes the crash for me. Thanks, Jacek

May 22, 2007

Re: FPS tool for wine

by Tomas Carnecky

Tomas.Zijdemans(a)student.uib.no wrote: > The largest gaming site in Norway recently did an extensive review of gaming on > Linux, but Wine was left out of the benchmark because "no FPS tool exists for > Wine". Surely this can't be true? > I guess I could modify yukon [1] to not capture the actual frames but only save info about swapuffer timings. Would you be interested in that? tom [1] http://www.neopsis.com/projects/yukon

May 22, 2007

Re: RegDeleteTree [7] [resend]

by Laurent Vromman

Stefan Leichter a écrit : > Am Tuesday 22 May 2007 18:05 schrieb Laurent Vromman: > >> There is a few tabs in the file : >> >> Here (line 92), first blank character : >> + &dwValCount, NULL, NULL, NULL, NULL); >> >> Here (line 103) >> + } >> >> Laurent >> >> > Hello Laurent, > > thank you for the comment. How did you spot the first tab? Rechecking the > indentation i can see the second one, but not the first. > > Bye Stefan > > If have a software which displays arrows where there are tabs in the file. I opened it and I just saw the two arrows. Laurent

May 22, 2007

Re: Bugzilla outcome?

by Tom Spear

On 5/22/07, Robert Shearman <rob(a)codeweavers.com> wrote: > Searching for "Unhandled exception" is too hard? Not all bugs have a proper trace, not all crashes result in the unhandled exception message (100% cpu usage being one case), not all bugs say crash (some say hang, or stuck, 100% cpu usage, freeze, etc). So If we had a crash keyword, then as people look at the new bugs, it can be added. Then people who are looking for crashes to fix or at least debug further (as I do), can find those bugs easier. -- Thanks Tom

May 22, 2007

Re: Bugzilla outcome?

by Robert Shearman

Tom Spear wrote: > Just curious to see if anything was ever done with the offer to > upgrade bugzilla? > > On a side note, it would be nice if there was a crash keyword to make > finding crashes easier Searching for "Unhandled exception" is too hard? -- Rob Shearman

May 22, 2007

Re: tests: show summary and last executed test in case of a crash

by Paul Vriens

Peter Oberndorfer wrote: > Some tests on http://test.winehq.org/data/ seem to crash silently. > Hi, Remember that not all 'Crashes' on the mentioned site are real crashes. Most Vista tests I'm running have 'Crash' mentioned on those pages. The reason is that the generated results file is bigger than 1.5 MB and this means the file will only be sent partly. If you're talking about the 'failed' ones with no good data (as it looks from you're patch), ignore the above. I did some work on the parser (dissect Perl-script) a few months ago. You're output will not be handled properly (from a first glance). A normal test looks like: a:b start <filename> <cvs-version> .. .. .. .. b: w tests executed (x marked as todo, y failure[s]), z skipped. a:b done (0) As you're new output doesn't result in the 'done' line the parser will not correctly use that information. Maybe another line should be added at the end of you're output: a:b done (some number not being 0 or 258) The 258 is used for tests that timeout (0 being for tests that have run without crashes or timeouts). Obviously the parser (in this case it's actually the gather Perl-script) has to be changed to accommodate this new number. Cheers, Paul.

May 22, 2007

Re: Bugzilla outcome?

by Tom Spear

I sent this to the wrong list before, sorry for that.. Just curious to see if anything was ever done with the offer to upgrade bugzilla? On a side note, it would be nice if there was a crash keyword to make finding crashes easier -- Thanks Tom

May 22, 2007

tests: show summary and last executed test in case of a crash

by Peter Oberndorfer

Some tests on http://test.winehq.org/data/ seem to crash silently. This patch might be useful for debugging such crashes. It prints out the last ok/trace that was executed before the crash, the exception address and the type of the crash. It also print out the summary that is normally printed at the end of the test instead of exiting silently[1]. On wine it still executes winedbg for better debugging after dumping out the info. My concern now is that it requires a change to the parser which accepts the test reports, so those crashes are not lost. And don't know much about this parser. Suggestions, ideas anyone? Greetings Peter [1] example output: file.c:1228:FileSize: 0 file.c:1229:Unknown2[0]: 0 Test crashed at B7D0DF47 with error c0000005 Last test before crash: file.c:1239 file: 19 tests executed (0 marked as todo, 3 failures), 0 skipped. wine: Unhandled page fault on write access to 0x00001234 at address 0xb7d0df47 (thread 0009), starting debugger... Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b ...

May 22, 2007

Re: winscard: small stub implementation of winscard dll (Try 2)

by Alexandre Julliard

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("%p,%x,%p\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + { > + DisableThreadLibraryCalls(hinstDLL); > + WINSCARD_hModule = hinstDLL; > + /* initialize protocol requests pointers */ > + SCARD_PCI_T0 = &g_rgSCardT0Pci; > + SCARD_PCI_T1 = &g_rgSCardT1Pci; > + SCARD_PCI_RAW = &g_rgSCardRawPci; AFAICT these are supposed to be macros, not variables. Also your indentation is messed up. -- Alexandre Julliard julliard(a)winehq.org

May 22, 2007

Re: RegDeleteTree [7] [resend]

by Stefan Leichter

Am Tuesday 22 May 2007 18:05 schrieb Laurent Vromman: > There is a few tabs in the file : > > Here (line 92), first blank character : > + &dwValCount, NULL, NULL, NULL, NULL); > > Here (line 103) > + } > > Laurent > Hello Laurent, thank you for the comment. How did you spot the first tab? Rechecking the indentation i can see the second one, but not the first. Bye Stefan

May 22, 2007

Re: RegDeleteTree [7] [resend]

by Laurent Vromman

There is a few tabs in the file : Here (line 92), first blank character : + &dwValCount, NULL, NULL, NULL, NULL); Here (line 103) + } Laurent > Hello, > > any comment on the current version of this patch? > > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > >

May 22, 2007

Re: FPS tool for wine

by Tomas Zijdemans

I've informed them about this. Let's hope they consider it! Lei Zhang wrote: > Right, for instance Tom Wickline ran 3dmark2000 and posted the results > here: > > http://wiki.winehq.org/BenchMark-0.9.33 > > On 5/21/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: >> Tirsdag 22 mai 2007 00:13, skrev Tomas.Zijdemans(a)student.uib.no: >> > The largest gaming site in Norway recently did an extensive review of >> > gaming on Linux, but Wine was left out of the benchmark because "no FPS >> > tool exists for Wine". Surely this can't be true? >> >> Isn't the point rather to test how actual games run in Wine? Then you >> can use >> a game or a benchmarking tool like 3DMark. >> >> >> Regards, >> >> Alexander N. Sørnes >> >> >> > > >

May 22, 2007

Re: loading windows DLL in a linux app

by Damjan Jovanovic

On 5/22/07, ml <ml(a)dasir.net> wrote: > Hi! > > I have a third party library which is a Windows DLL. Is it possible to > use Wine to call its functions under Linux? > I tried a simple code > > #include <library.h> > > int main(int argc, char**argv) > { > HMODULE dll; > dll = LoadLibrary("atouch32.dll"); > return 0; > } > > compiled successfully but runtime fails with "Segmentation fault". > Perhaps I missed some initialization. > > I didn't found any examples of Wine API usage. Can anyone give me any clue? You can't link a Linux applicaton to a Windows DLL. The project which would allow you to do that is called the wine plugin API (http://wiki.winehq.org/WinePluginApi) but it isn't written yet. What you can do at the moment is write a winelib application, that is, a Windows application compiled with winegcc which can use both Windows and Linux APIs. > Thank you! > > David Damjan

May 22, 2007

Re: msi ole automation: where to next?

by Misha Koshelev

On Tue, 2007-05-22 at 16:06 +0100, Robert Shearman wrote: > Misha Koshelev wrote: > > One more question: Will the COMification of msi somehow require OLE > > automation, as Mike's email excerpt seems to suggest (this would be > > another reason then to continue implementing it)? If so, how? > > > > I believe James is planning to implement it, but it doesn't really > make > sense to use the OLE automation objects because: > 1. There is no Package object. > 2. The methods have to closely resemble those of the C interface to > avoid different behaviour. Ok, this is what I thought... that is why I had the hardest time trying to figure out what Mike meant in his email. Misha

May 22, 2007

loading windows DLL in a linux app

by ml

Hi! I have a third party library which is a Windows DLL. Is it possible to use Wine to call its functions under Linux? I tried a simple code #include <library.h> int main(int argc, char**argv) { HMODULE dll; dll = LoadLibrary("atouch32.dll"); return 0; } compiled successfully but runtime fails with "Segmentation fault". Perhaps I missed some initialization. I didn't found any examples of Wine API usage. Can anyone give me any clue? Thank you! David

May 22, 2007

Re: msi ole automation: where to next?

by Robert Shearman

Misha Koshelev wrote: > One more question: Will the COMification of msi somehow require OLE > automation, as Mike's email excerpt seems to suggest (this would be > another reason then to continue implementing it)? If so, how? > I believe James is planning to implement it, but it doesn't really make sense to use the OLE automation objects because: 1. There is no Package object. 2. The methods have to closely resemble those of the C interface to avoid different behaviour. -- Rob Shearman

May 22, 2007

Re: msi ole automation: where to next?

by Dan Kegel

On 5/22/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > One more question: Will the COMification of msi somehow require OLE > automation, as Mike's email excerpt seems to suggest (this would be > another reason then to continue implementing it)? If so, how? > > > It will require the OLE interfaces (Session/Installer) to be working > > before the custom actions can run out of process. > (from Mike's email) Shucks, I don't know, you'd have to ask Rob / James / Mike. > p.s. meanwhile, I hope to submit a few shlexec.c patches in the next > couple of days/week as some of the DDE stuff does not seem to work as > native and this leads to a very minor Vector NTI problem Sounds good to me. - Dan

May 22, 2007

Re: msi ole automation: where to next?

by Misha Koshelev

On Mon, 2007-05-21 at 13:49 -0700, Dan Kegel wrote: > I doubt anyone knows the complete set of those functions > that actually get used by real-world installers. > > I think your choice is either a) keep plugging along on msi > automation on the theory that it's good for msi in general > and might help a few as yet unknown apps, or b) put this > on the back burner and go work on something known to > be blocking some app you care about. > - Dan Thanks Dan. One more question: Will the COMification of msi somehow require OLE automation, as Mike's email excerpt seems to suggest (this would be another reason then to continue implementing it)? If so, how? > It will require the OLE interfaces (Session/Installer) to be working > before the custom actions can run out of process. (from Mike's email) Thanks Misha p.s. meanwhile, I hope to submit a few shlexec.c patches in the next couple of days/week as some of the DDE stuff does not seem to work as native and this leads to a very minor Vector NTI problem

May 22, 2007

Re: FPS tool for wine

by Francois Gouget

On Tue, 22 May 2007, Stefan Dösinger wrote: [...] > But why would they prefer external stuff over the games' built-in > benchmark features? I believe some test sites like to build graphs of framerate over time. This lets them extract not only the average framerate, but also the minimum and maximum framerate, compare the graphs of different graphics cards / machines, etc. I assume that games don't always provide enough data which is why they'd use third party tools. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

May 22, 2007

Re: New Gecko package

by Vitaliy Margolen

Jacek Caban wrote: > Hi all, > > It's time to update our Gecko package. I've prepared a new one. I'd like > to avoid any regression, esp. ones that would require changing the > package again. That's why I'd like to do a good test. I'm interested in > regressions, so just a simple test if app that worked before still works > will be fine. To do so download: > wine iexplore http://winehq.org/ crashes for me. > Expected visible difference should be: > - Working scrollbars (still not perfect, they will be visible even if > app sets it to not be, but it's better than before - I will work on it > later) Sweet, they finally do work in steam! BTW why JavaScript doesn't work or any pop-up windows don't open? I know this works fine with Firefox. Vitaliy.

May 22, 2007

Re: hnetcfg: [resend 2] 1/6 uuids for INetFwMgr interface

by Jeff L

Robert Shearman wrote: > Jeff Latimer wrote: >> +OUR_GUID_ENTRY(IID_INetFwMgr, 0xf7898af5, >> 0xcac4, 0x4632, 0xa2, 0xec, 0xda ,0x06, 0xe5, 0x11, 0x1a, 0xf2) >> +OUR_GUID_ENTRY(CLSID_NetFwMgr, 0x304ce942, >> 0x6e39, 0x40d8, 0x94, 0x3a, 0xb9, 0x13, 0xc4, 0x0c, 0x9c, 0xd4) >> >> #undef OUR_GUID_ENTRY > This isn't in the PSDK version of uuids.h and also uuid.lib from the > PSDK doesn't contain these symbols either (although there are a bunch > of IID_INetFwV6... symbols that might be related). > Well I did ask about this a few days ago. I can make them local to the dll. Jeff

May 22, 2007

Re: hnetcfg: [resend 2] 3/6 add local header file

by Jeff L

Michael Stefaniuc wrote: > Jeff Latimer wrote: >> --- >> dlls/hnetcfg/hnetcfg_dll.h | 70 >> ++++++++++++++++++++++++++++++++++++++++++++ >> >> + >> +/* __stdcall HNETCFG_HNetDeleteRasConnection(); */ > It's only the comments but why don't you use WINAPI instead of __stdcall? > > bye > michael > This is more a case of minimal change and as I was not able to test the comments, I did not do it. But I can fix if it helps. Jeff

May 22, 2007

Re: ADVAPI32: (1 of 4) Implement EnumServicesStatusExW

by Alexandre Julliard

Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> writes: > + r = QueryServiceStatusEx(handle, SC_STATUS_PROCESS_INFO, (LPBYTE)&svcStatusData, > + sizeof(SERVICE_STATUS_PROCESS), &sz); > + if (r) > + { > + switch (dwServiceType) > + { > + case SERVICE_DRIVER: > + r = SERVICE_KERNEL_DRIVER == svcStatusData.dwServiceType || > + SERVICE_FILE_SYSTEM_DRIVER == svcStatusData.dwServiceType; > + break; > + case SERVICE_WIN32: > + r = SERVICE_WIN32_OWN_PROCESS == svcStatusData.dwServiceType || > + SERVICE_WIN32_SHARE_PROCESS == svcStatusData.dwServiceType; > + break; > + default: > + FIXME("Unknown dwServiceType: %x", dwServiceType); > + r = FALSE; > + break; > + } > + } > + > + if (r) > + { Some sort of 'goto next' would be cleaner than this complex code to set r and then test it again and again. > + } > + sz = sizeof(name); You probably meant namesz here. -- Alexandre Julliard julliard(a)winehq.org

May 22, 2007

Re: FPS tool for wine

by Tomas Zijdemans

Good point. What they probably want, is an external tool (like fraps) that gives them some nice numbers. I have informed them of your comments, and hope they consider it. This is the largest computer-related site in Norway, so I hope Wine can get some good PR here.. Stefan Dösinger wrote: > Am Dienstag 22 Mai 2007 00:13 schrieb Tomas.Zijdemans(a)student.uib.no: >> The largest gaming site in Norway recently did an extensive review of >> gaming on Linux, but Wine was left out of the benchmark because "no FPS >> tool exists for Wine". Surely this can't be true? > What exactly do they mean with FPS tools? After working with all this 3D > business since almost 2 years I do not know what this term would precicely > mean :-o If they mean built-in benchmark tools, then we have something like > that, the fps debug channel which shows the ddraw / d3d / opengl buffer flips > per secound. But why would they prefer external stuff over the games' > built-in benchmark features? > > >

May 22, 2007

Re: [PATCH](updated) wined3d: Implemented converting X1R5G5B5 format to R5G5B5A1 to emulate color-keying

by Stefan Dösinger

Am Dienstag 22 Mai 2007 03:32 schrieb hightower(a)tregt.net: Looks ok

May 22, 2007

Re: FPS tool for wine

by Stefan Dösinger

Am Dienstag 22 Mai 2007 00:13 schrieb Tomas.Zijdemans(a)student.uib.no: > The largest gaming site in Norway recently did an extensive review of > gaming on Linux, but Wine was left out of the benchmark because "no FPS > tool exists for Wine". Surely this can't be true? What exactly do they mean with FPS tools? After working with all this 3D business since almost 2 years I do not know what this term would precicely mean :-o If they mean built-in benchmark tools, then we have something like that, the fps debug channel which shows the ddraw / d3d / opengl buffer flips per secound. But why would they prefer external stuff over the games' built-in benchmark features?

May 21, 2007

Re: FPS tool for wine

by Lei Zhang

Right, for instance Tom Wickline ran 3dmark2000 and posted the results here: http://wiki.winehq.org/BenchMark-0.9.33 On 5/21/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > Tirsdag 22 mai 2007 00:13, skrev Tomas.Zijdemans(a)student.uib.no: > > The largest gaming site in Norway recently did an extensive review of > > gaming on Linux, but Wine was left out of the benchmark because "no FPS > > tool exists for Wine". Surely this can't be true? > > Isn't the point rather to test how actual games run in Wine? Then you can use > a game or a benchmarking tool like 3DMark. > > > Regards, > > Alexander N. Sørnes > > >

May 21, 2007

Re: FPS tool for wine

by Alexander Nicolaysen Sørnes

Tirsdag 22 mai 2007 00:13, skrev Tomas.Zijdemans(a)student.uib.no: > The largest gaming site in Norway recently did an extensive review of > gaming on Linux, but Wine was left out of the benchmark because "no FPS > tool exists for Wine". Surely this can't be true? Isn't the point rather to test how actual games run in Wine? Then you can use a game or a benchmarking tool like 3DMark. Regards, Alexander N. Sørnes

May 21, 2007

RE: FPS tool for wine

by EA Durbin

does fraps not work in wine? >From: Tomas.Zijdemans(a)student.uib.no >To: wine-devel(a)winehq.org >Subject: FPS tool for wine >Date: Tue, 22 May 2007 00:13:22 +0200 > >The largest gaming site in Norway recently did an extensive review of >gaming on >Linux, but Wine was left out of the benchmark because "no FPS tool exists >for >Wine". Surely this can't be true? > > _________________________________________________________________ Catch suspicious messages before you open themwith Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

May 21, 2007

Re: shlwapi: stub implementation for SHSetTimerQueueTimer (try 2)

by James Hawkins

On 5/21/07, Nigel Liang (梁乃強) <ncliang(a)gmail.com> wrote: > Hi, > > I am not quite sure I understand what you mean? CreateTimerQueueTimer > should return a Boolean indicating whether the operation has > succeeded. Checking the return value in a ternary operation should > return the correct handle if CreateTimerQueueTimer succeeds and NULL > otherwise. Unless I have misunderstood the msdn documentation? > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… > > + return CreateTimerQueueTimer(&hNewTimer, hQueue, pfnCallback, pContext, > + dwDueTime, dwPeriod, dwFlags)?hNewTimer:NULL; I'm pretty sure Dmitry did what I did. That last little blurb at the end (?hNewTimer:NULL;) is not very noticeable, and looks like the end of the function arguments at first glance. You really should get rid of the ternary condition and split it out for code readability. Also, please bottom-post on this list. > > On 5/21/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > > "Nigel Liang" <ncliang(a)gmail.com> wrote: > > > > > +HANDLE WINAPI SHSetTimerQueueTimer(HANDLE hQueue, > > > + WAITORTIMERCALLBACK pfnCallback, LPVOID pContext, DWORD dwDueTime, > > > + DWORD dwPeriod, LPCSTR lpszLibrary, DWORD dwFlags) > > > +{ > > ... > > > + return CreateTimerQueueTimer(&hNewTimer, hQueue, pfnCallback, pContext, > > > + dwDueTime, dwPeriod, dwFlags)?hNewTimer:NULL; > > > > This can't work: CreateTimerQueueTimer and SHSetTimerQueueTimer > > return different things. > > > > -- > > Dmitry. > > > > > -- James Hawkins

May 21, 2007

FPS tool for wine

by Tomas.Zijdemans＠student.uib.no

The largest gaming site in Norway recently did an extensive review of gaming on Linux, but Wine was left out of the benchmark because "no FPS tool exists for Wine". Surely this can't be true?

May 21, 2007

Re: ADVAPI32: Start test for service tests

by James Hawkins

On 5/21/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > James Hawkins [mailto:truiken(a)gmail.com] wrote: > > >+ ok(size <= 1, "size should be <= 1 was %d!", size); > > > >This is a bad test. According to msdn, GetServiceDisplayName does not > >modify lpcchBuffer on error, so size should be exactly 0. > > MSDN says a lot of things. On my XP SP2 it returns 1 as size when passed > an empty service name. Also failing here is a bit ambigeuos since the > dunction also fails when a NULL pointer is passed or the buffer is to > small, but it does change the size into what it expects in these two > cases. > ...and msdn is wrong a lot, but that doesn't mean the check is right. If the value you get is 1, then check exactly for 1. > >+static BOOL test_service_info(SC_HANDLE hscm) > > > >test functions are void, not BOOL. You're never going to do anything but > >return, and there's no value >to check by the caller. > > I took this more or less directly from registry.c in the same directory. > No test function in registry.c returns BOOL, and to save you some time replying, set_privileges is not a test function. It's a helper function. > >+ ok(size, "size should be returned!"); > > > >And what is the size? Tests are supposed to be exact. If our > implementation > >is incorrect, and we return size as 39491, that's certainly not correct, > but > >this test won't fail when it should. > > This won't work for localized Windows versions. The display name is possibly > translated. Also, on XP SP2 the A function returns the size in ASCI chars > that > the W function will need in bytes. Not a behaviour I feel Wine should > imitate > without an app that would need that behaviour. > Huh? The function, A or W, returns the number of TCHARS. What behavior should wine not imitate? We don't ignore expected behavior just because we doubt an app will depend on it, especiallly a behavior that is so common. > I'll be gone for two weeks for vacation. If anyone wants to continue on that > please feel free. Otherwise I'll be picking this up afterwards. > > Rolf Kalbermatter > > -- James Hawkins

May 21, 2007

Re: msi ole automation: where to next?

by Dan Kegel

On 5/21/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > I guess the bottom line is I don't mind eventually implementing _all_ > the automation functions as long as I know that I'm not just wasting my > time ... I doubt anyone knows the complete set of those functions that actually get used by real-world installers. I think your choice is either a) keep plugging along on msi automation on the theory that it's good for msi in general and might help a few as yet unknown apps, or b) put this on the back burner and go work on something known to be blocking some app you care about. - Dan

May 21, 2007

Re: msi ole automation: where to next?

by Misha Koshelev

On Mon, 2007-05-21 at 10:05 -0700, Dan Kegel wrote: > On 5/21/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > > I guess what I am still concerned about is this blurb from an email Mike > > McCormack had sent me when I started working on the scripting/automation > > stuff: > > > > > The work that I was doing is aimed at running custom action threads in > > > a separate process. It will require the OLE interfaces > > > (Session/Installer) to be working before the custom actions can run > > > out of process. The custom action queue needs to be exposed by > > > another OLE interface so that msiexec can query it. > > > > Now I really don't understand this or whether this is still the plan for > > custom actions (James?) > > It's still the plan, and James is going to be working on it. > > > or why having custom action threads in a > > separate process would require Session and Installer to be working at > > all, since they are mostly just wrappers around the C functions, which > > seem to be much easier to call from another C program like msiexec than > > the automation functions. However, I want to make sure that the full > > Installer/Session functionality is not required by something like this > > that could potentially improve more than just scripting support before I > > completely move on to something else... > > I'm sure James can fill you in. (FWIW, James, my druthers would be that > you have a good look at the Autocad 2000/2002/2004 installer problems > before diving in on the msi comification task. I'll bring the discs > in tomorrow.) > - Dan I guess the bottom line is I don't mind eventually implementing _all_ the automation functions as long as I know that I'm not just wasting my time (i.e., if these actions are only required by installer scripts, and I bet most installer scripts do not even use most of the functions). Misha

May 21, 2007

Re: msi ole automation: where to next?

by Misha Koshelev

On Mon, 2007-05-21 at 10:05 -0700, Dan Kegel wrote: > On 5/21/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > > I guess what I am still concerned about is this blurb from an email Mike > > McCormack had sent me when I started working on the scripting/automation > > stuff: > > > > > The work that I was doing is aimed at running custom action threads in > > > a separate process. It will require the OLE interfaces > > > (Session/Installer) to be working before the custom actions can run > > > out of process. The custom action queue needs to be exposed by > > > another OLE interface so that msiexec can query it. > > > > Now I really don't understand this or whether this is still the plan for > > custom actions (James?) > > It's still the plan, and James is going to be working on it. > > > or why having custom action threads in a > > separate process would require Session and Installer to be working at > > all, since they are mostly just wrappers around the C functions, which > > seem to be much easier to call from another C program like msiexec than > > the automation functions. However, I want to make sure that the full > > Installer/Session functionality is not required by something like this > > that could potentially improve more than just scripting support before I > > completely move on to something else... > > I'm sure James can fill you in. (FWIW, James, my druthers would be that > you have a good look at the Autocad 2000/2002/2004 installer problems > before diving in on the msi comification task. I'll bring the discs > in tomorrow.) > - Dan I guess I would definitely like to learn more about this, then, as it seems like this, per Mike's comment, would require all the automation functions to be implemented, and I wouldn't mind to keep working on this as I've already got a good tempo going with it and it is kind of nice to make/design a whole part together like this. Plus I feel like I'm catching a fair number of msi bugs in other areas (mostly registry.c) through my conformance tests for automation. But I would definitely like to know more about it, as right now I don't really see how this separate custom action queue would be calling automation objects or why... Misha

May 21, 2007

Re: shlwapi: stub implementation for SHSetTimerQueueTimer (try 2)

by Nigel Liang (梁乃強)

Hi, I am not quite sure I understand what you mean? CreateTimerQueueTimer should return a Boolean indicating whether the operation has succeeded. Checking the return value in a ternary operation should return the correct handle if CreateTimerQueueTimer succeeds and NULL otherwise. Unless I have misunderstood the msdn documentation? http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… -Nigel On 5/21/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > "Nigel Liang" <ncliang(a)gmail.com> wrote: > > > +HANDLE WINAPI SHSetTimerQueueTimer(HANDLE hQueue, > > + WAITORTIMERCALLBACK pfnCallback, LPVOID pContext, DWORD dwDueTime, > > + DWORD dwPeriod, LPCSTR lpszLibrary, DWORD dwFlags) > > +{ > ... > > + return CreateTimerQueueTimer(&hNewTimer, hQueue, pfnCallback, pContext, > > + dwDueTime, dwPeriod, dwFlags)?hNewTimer:NULL; > > This can't work: CreateTimerQueueTimer and SHSetTimerQueueTimer > return different things. > > -- > Dmitry. >

May 21, 2007

Re: msi ole automation: where to next?

by Dan Kegel

On 5/21/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > I guess what I am still concerned about is this blurb from an email Mike > McCormack had sent me when I started working on the scripting/automation > stuff: > > > The work that I was doing is aimed at running custom action threads in > > a separate process. It will require the OLE interfaces > > (Session/Installer) to be working before the custom actions can run > > out of process. The custom action queue needs to be exposed by > > another OLE interface so that msiexec can query it. > > Now I really don't understand this or whether this is still the plan for > custom actions (James?) It's still the plan, and James is going to be working on it. > or why having custom action threads in a > separate process would require Session and Installer to be working at > all, since they are mostly just wrappers around the C functions, which > seem to be much easier to call from another C program like msiexec than > the automation functions. However, I want to make sure that the full > Installer/Session functionality is not required by something like this > that could potentially improve more than just scripting support before I > completely move on to something else... I'm sure James can fill you in. (FWIW, James, my druthers would be that you have a good look at the Autocad 2000/2002/2004 installer problems before diving in on the msi comification task. I'll bring the discs in tomorrow.) - Dan

May 21, 2007

re: msi ole automation: where to next?

by Misha Koshelev

On Mon, 2007-05-21 at 08:23 -0700, Dan Kegel wrote: > Misha wrote: > > [I have the scripting required by the Vector NTI and the iTunes 7 installers > > working. What should I do next?] > > First off, congratulations! > > If you're interested in continuing to work on MSI, I'd suggest > asking James Hawkins for suggestions. > > If you're more interested in adding COM interfaces to things, > perhaps implementing the iTextServices api to riched20 > would be useful. Maarten got started on that, but I think > it's not complete enough for say, Google Talk to function. > > Most useful of all might be for you to look at > improving our COM implementation itself. Rob Shearman > could give you suggestions on where to start there. > - Dan > Thanks Dan for your thoughtful descriptions, I will have to mull over where to head next. I guess what I am still concerned about is this blurb from an email Mike McCormack had sent me when I started working on the scripting/automation stuff: > The work that I was doing is aimed at running custom action threads in > a separate process. It will require the OLE interfaces > (Session/Installer) to be working before the custom actions can run > out of process. The custom action queue needs to be exposed by > another OLE interface so that msiexec can query it. Now I really don't understand this or whether this is still the plan for custom actions (James?) or why having custom action threads in a separate process would require Session and Installer to be working at all, since they are mostly just wrappers around the C functions, which seem to be much easier to call from another C program like msiexec than the automation functions. However, I want to make sure that the full Installer/Session functionality is not required by something like this that could potentially improve more than just scripting support before I completely move on to something else... Thanks Misha

May 21, 2007

localui/tests: Add tests for ConfigurePortUI (try 2)

by Detlef Riekenberg

Changelog: localui/tests: Add tests for ConfigurePortUI Removed the implicit import of msvcrt, as suggested by Alexandre (Replaced swprintf by sprintf with MultiByteToWideChar as Alexandre did in serialui/tests) -- By by ... Detlef

May 21, 2007

Re: [PATCH 2/2] wininet: Implement basic non-proxy authentiction.

by Detlef Riekenberg

On Mo, 2007-05-21 at 14:28 +0100, Robert Shearman wrote: > + int userlen = WideCharToMultiByte(CP_UTF8, 0, > domain_and_username, lstrlenW(domain_and_username), NULL, 0, NULL, > NULL); > + int passlen = WideCharToMultiByte(CP_UTF8, 0, password, > lstrlenW(password), NULL, 0, NULL, NULL); What is the advantage to use lstrlenW() here over -1, as used below? > + > + WideCharToMultiByte(CP_UTF8, 0, domain_and_username, -1, > auth_data, userlen, NULL, NULL); > + auth_data[userlen] = ':'; > + WideCharToMultiByte(CP_UTF8, 0, password, -1, > &auth_data[userlen+1], passlen, NULL, NULL); Using -1 has the advantage to reduce the code-size. Thanks. -- By by ... Detlef

May 21, 2007

re: msi ole automation: where to next?

by Dan Kegel

Misha wrote: > [I have the scripting required by the Vector NTI and the iTunes 7 installers > working. What should I do next?] First off, congratulations! If you're interested in continuing to work on MSI, I'd suggest asking James Hawkins for suggestions. If you're more interested in adding COM interfaces to things, perhaps implementing the iTextServices api to riched20 would be useful. Maarten got started on that, but I think it's not complete enough for say, Google Talk to function. Most useful of all might be for you to look at improving our COM implementation itself. Rob Shearman could give you suggestions on where to start there. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

May 21, 2007

Re: hnetcfg: [resend 2] 1/6 uuids for INetFwMgr interface

by Robert Shearman

Jeff Latimer wrote: > diff --git a/include/uuids.h b/include/uuids.h > index e3fb41b..cf99672 100644 > --- a/include/uuids.h > +++ b/include/uuids.h > @@ -271,5 +271,7 @@ OUR_GUID_ENTRY(CLSID_VideoProcAmpPropertyPage, 0x71f96464, 0x78f3, 0x11d0, > OUR_GUID_ENTRY(CLSID_CameraControlPropertyPage, 0x71f96465, 0x78f3, 0x11d0, 0xa1, 0x8c, 0x00, 0xa0, 0xc9, 0x11, 0x89, 0x56) > OUR_GUID_ENTRY(CLSID_AnalogVideoDecoderPropertyPage, 0x71f96466, 0x78f3, 0x11d0, 0xa1, 0x8c, 0x00, 0xa0, 0xc9, 0x11, 0x89, 0x56) > OUR_GUID_ENTRY(CLSID_VideoStreamConfigPropertyPage, 0x71f96467, 0x78f3, 0x11d0, 0xa1, 0x8c, 0x00, 0xa0, 0xc9, 0x11, 0x89, 0x56) > +OUR_GUID_ENTRY(IID_INetFwMgr, 0xf7898af5, 0xcac4, 0x4632, 0xa2, 0xec, 0xda ,0x06, 0xe5, 0x11, 0x1a, 0xf2) > +OUR_GUID_ENTRY(CLSID_NetFwMgr, 0x304ce942, 0x6e39, 0x40d8, 0x94, 0x3a, 0xb9, 0x13, 0xc4, 0x0c, 0x9c, 0xd4) > > #undef OUR_GUID_ENTRY > This isn't in the PSDK version of uuids.h and also uuid.lib from the PSDK doesn't contain these symbols either (although there are a bunch of IID_INetFwV6... symbols that might be related). -- Rob Shearman

May 21, 2007

Re: hnetcfg: [resend 2] 3/6 add local header file

by Michael Stefaniuc

Jeff Latimer wrote: > --- > dlls/hnetcfg/hnetcfg_dll.h | 70 > ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > create mode 100644 dlls/hnetcfg/hnetcfg_dll.h > > > ------------------------------------------------------------------------ > > diff --git a/dlls/hnetcfg/hnetcfg_dll.h b/dlls/hnetcfg/hnetcfg_dll.h > new file mode 100644 > index 0000000..64b1f0c > --- /dev/null > +++ b/dlls/hnetcfg/hnetcfg_dll.h > @@ -0,0 +1,70 @@ > +/* > + * Copyright (C) 2007 Jeff Latimer > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_HNETCFG_DLL_H > +#define __WINE_HNETCFG_DLL_H > + > +#include "windef.h" > +#include "wine/debug.h" > +#include "winbase.h" > +#include "winnt.h" > + > + > +/* __stdcall HNETCFG_HNetDeleteRasConnection(); */ It's only the comments but why don't you use WINAPI instead of __stdcall? bye michael > +/* __stdcall HNETCFG_HNetFreeSharingServicesPage(); */ > +/* __stdcall HNETCFG_HNetGetSharingServicesPage(); */ > +/* __stdcall HNETCFG_WinBomConfigureWindowsFirewall(); */ > +/* __stdcall HNETCFG_HNetFreeFirewallLoggingSettings(); */ > +/* __stdcall HNETCFG_HNetGetFirewallSettingsPage(); */ > +/* __stdcall HNETCFG_HNetGetShareAndBridgeSettings(); */ > +/* __stdcall HNETCFG_HNetSetShareAndBridgeSettings(); */ > +/* __stdcall HNETCFG_HNetSharedAccessSettingsDlg(); */ > +/* __stdcall HNETCFG_HNetSharingAndFirewallSettingsDlg(); */ > +/* __stdcall HNETCFG_IcfChangeNotificationCreate(); */ > +/* __stdcall HNETCFG_IcfChangeNotificationDestroy(); */ > +/* __stdcall HNETCFG_IcfCheckAppAuthorization(); */ > +/* __stdcall HNETCFG_IcfCloseDynamicFwPort(); */ > +/* __stdcall HNETCFG_IcfConnect(); */ > +/* __stdcall HNETCFG_IcfDisconnect(); */ > +/* __stdcall HNETCFG_IcfFreeAdapters(); */ > +/* __stdcall HNETCFG_IcfFreeDynamicFwPorts(); */ > +/* __stdcall HNETCFG_IcfFreeProfile(); */ > +/* __stdcall HNETCFG_IcfFreeString(); */ > +/* __stdcall HNETCFG_IcfFreeTickets(); */ > +/* __stdcall HNETCFG_IcfGetAdapters(); */ > +/* __stdcall HNETCFG_IcfGetCurrentProfileType(); */ > +/* __stdcall HNETCFG_IcfGetDynamicFwPorts(); */ > +/* __stdcall HNETCFG_IcfGetOperationalMode(); */ > +/* __stdcall HNETCFG_IcfGetProfile(); */ > +/* __stdcall HNETCFG_IcfGetTickets(); */ > +/* __stdcall HNETCFG_IcfIsIcmpTypeAllowed(); */ > +/* __stdcall HNETCFG_IcfIsPortAllowed(); */ > +/* __stdcall HNETCFG_IcfOpenDynamicFwPort(); */ > +/* __stdcall HNETCFG_IcfOpenDynamicFwPortWithoutSocket(); */ > +/* __stdcall HNETCFG_IcfOpenFileSharingPorts(); */ > +/* __stdcall HNETCFG_IcfRefreshPolicy(); */ > +/* __stdcall HNETCFG_IcfRemoveDisabledAuthorizedApp(); */ > +/* __stdcall HNETCFG_IcfSetServicePermission(); */ > +/* __stdcall HNETCFG_IcfSubNetsGetScope(); */ > +/* __stdcall HNETCFG_IcfSubNetsIsStringValid(); */ > +/* __stdcall HNETCFG_IcfSubNetsToString(); */ > + > +HRESULT NetFwMgr_create(IUnknown *, LPVOID *); > + > + > +#endif /* __WINE_HNETCFG_DLL_H */ > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

May 21, 2007

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

by Vit Hrachovy

On Wed, May 16, 2007 at 06:41:33PM +0200, Frank Richter wrote: > > just add all > > "preset" memory sizes, and WM_SETTEXT the value read from the registry. > > Might be code-wise a bit simpler than your GETCURSEL approach, but > otherswise not much different I think. > > -f.r. Hi Frank, I've simplified the code according Your review, see the attached patch. Thanks for help. Vit

May 21, 2007

Re: localui/tests: Add tests for ConfigurePortUI

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > diff --git a/dlls/localui/tests/Makefile.in b/dlls/localui/tests/Makefile.in > index 191a312..634060b 100644 > --- a/dlls/localui/tests/Makefile.in > +++ b/dlls/localui/tests/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = localui.dll > -IMPORTS = kernel32 > +IMPORTS = kernel32 msvcrt winspool You can't import msvcrt without using the headers and the appropriate compiler flags. It would be much better to avoid it though. -- Alexandre Julliard julliard(a)winehq.org

May 21, 2007

Re: shlwapi: stub implementation for SHSetTimerQueueTimer (try 2)

by Dmitry Timoshkov

"Nigel Liang" <ncliang(a)gmail.com> wrote: > +HANDLE WINAPI SHSetTimerQueueTimer(HANDLE hQueue, > + WAITORTIMERCALLBACK pfnCallback, LPVOID pContext, DWORD dwDueTime, > + DWORD dwPeriod, LPCSTR lpszLibrary, DWORD dwFlags) > +{ ... > + return CreateTimerQueueTimer(&hNewTimer, hQueue, pfnCallback, pContext, > + dwDueTime, dwPeriod, dwFlags)?hNewTimer:NULL; This can't work: CreateTimerQueueTimer and SHSetTimerQueueTimer return different things. -- Dmitry.

May 21, 2007

RE: ADVAPI32: Start test for service tests

by Rolf Kalbermatter

James Hawkins [mailto:truiken(a)gmail.com] wrote: >+ ok(size <= 1, "size should be <= 1 was %d!", size); > >This is a bad test. According to msdn, GetServiceDisplayName does not >modify lpcchBuffer on error, so size should be exactly 0. MSDN says a lot of things. On my XP SP2 it returns 1 as size when passed an empty service name. Also failing here is a bit ambigeuos since the dunction also fails when a NULL pointer is passed or the buffer is to small, but it does change the size into what it expects in these two cases. >+static BOOL test_service_info(SC_HANDLE hscm) > >test functions are void, not BOOL. You're never going to do anything but >return, and there's no value >to check by the caller. I took this more or less directly from registry.c in the same directory. >+ ok(size, "size should be returned!"); > >And what is the size? Tests are supposed to be exact. If our implementation >is incorrect, and we return size as 39491, that's certainly not correct, but >this test won't fail when it should. This won't work for localized Windows versions. The display name is possibly translated. Also, on XP SP2 the A function returns the size in ASCI chars that the W function will need in bytes. Not a behaviour I feel Wine should imitate without an app that would need that behaviour. I'll be gone for two weeks for vacation. If anyone wants to continue on that please feel free. Otherwise I'll be picking this up afterwards. Rolf Kalbermatter

May 21, 2007

Re: ADVAPI32: Start test for service tests

by James Hawkins

On 5/20/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/tests/Makefile.in > dlls/advapi32/tests/service.c > Start test for service tests > License: X11/LGPL > > This test will crash without the previous patch > "Return error on NULL service name to GetServiceDisplayNameA/W" > > Rolf Kalbermatter > + ok(size <= 1, "size should be <= 1 was %d!", size); This is a bad test. According to msdn, GetServiceDisplayName does not modify lpcchBuffer on error, so size should be exactly 0. +static BOOL test_service_info(SC_HANDLE hscm) test functions are void, not BOOL. You're never going to do anything but return, and there's no value to check by the caller. + ok(size, "size should be returned!"); And what is the size? Tests are supposed to be exact. If our implementation is incorrect, and we return size as 39491, that's certainly not correct, but this test won't fail when it should. +static BOOL test_service_enum(SC_HANDLE hscm) +{ + return 0; +} Please don't add dead code. -- James Hawkins

May 20, 2007

Re: msi ole automation: where to next?

by Tom Spear

On 5/20/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > Hi everybody, > > Hope you are all having a nice Sunday. Since MSI OLE automation is a bit > overwhelming, I have been using installers that have JScript/VBScript > actions to guide me as to what specific functions/objects to implement > next. I started out by implementing all the functions used by the Vector > NTI installer (which is how I got into wine programming at all; and > which was actually dependent on one of these actions for installing at > the time), and for the past few weeks I have been following the > functions required by the iTunes 7 installer. > > However, now that I have implemented all the functions used by both of > these (yay), I am having trouble finding another installer that uses a > lot of scripting, so I was wondering if anyone had any suggestions? It > really helps to have something like that to guide/motivate me. (I > googled "UNHANDLED ACTION TYPE" and tried the installers I found but all > the installers I actually tried out didn't seem to use scripting or > maybe just unimplmeneted scripting functions anymore). > > Alternately, is there any other use for MSI OLE automation besides > installers with scriptable actions? If so, what functions would be > important for that use? (I know Mike McCormack talked at one point about > using these interfaces to run custom actions in a separate process, but > I am not really clear as to why automation is really necessary for this > and, if so, how exactly it would be used, since all the automation > functions are just wrappers around existing functions anyway.) I'm not sure if this is OLE or not, but AutoIt installers use a lot of scripting and can be wrapped around msi.. I would post locations of where to find quite a few here on the list, but I'm afraid of being flamed for spamming again, so look for my next email. -- Thanks Tom

May 20, 2007

msi ole automation: where to next?

by Misha Koshelev

Hi everybody, Hope you are all having a nice Sunday. Since MSI OLE automation is a bit overwhelming, I have been using installers that have JScript/VBScript actions to guide me as to what specific functions/objects to implement next. I started out by implementing all the functions used by the Vector NTI installer (which is how I got into wine programming at all; and which was actually dependent on one of these actions for installing at the time), and for the past few weeks I have been following the functions required by the iTunes 7 installer. However, now that I have implemented all the functions used by both of these (yay), I am having trouble finding another installer that uses a lot of scripting, so I was wondering if anyone had any suggestions? It really helps to have something like that to guide/motivate me. (I googled "UNHANDLED ACTION TYPE" and tried the installers I found but all the installers I actually tried out didn't seem to use scripting or maybe just unimplmeneted scripting functions anymore). Alternately, is there any other use for MSI OLE automation besides installers with scriptable actions? If so, what functions would be important for that use? (I know Mike McCormack talked at one point about using these interfaces to run custom actions in a separate process, but I am not really clear as to why automation is really necessary for this and, if so, how exactly it would be used, since all the automation functions are just wrappers around existing functions anyway.) Thanks a lot Misha

May 20, 2007

Re: Small Direct3D milestone

by Carl-Daniel Hailfinger

On 19.05.2007 21:55, Stefan Dösinger wrote: >> Did you change something affecting D3D multithreaded apps? > I am currently working on this. Some fundamental work went into wine somewhen > between .33 and .35, but its not active yet. It was just some data structure > modifications to handle multiple contexts for one swapchain. Before that the > state management rework enabled us to keep track of states for multiple > contexts. > > But right now I am working on making things really thread safe, and after that > I can debug some gl crashes with the context selection patches I posted on > this list a few months ago so they can go in finally. Cool. >> Star Trek: >> Bridge Commander doesn't start for me (only blank screen) since 0.9.37. >> http://appdb.winehq.org/appview.php?iVersionId=4207 (AppDB) >> http://www.bridgecommander.com/indepth/bcdemo.htm (downloadable demo) >> I'm using the opensource r300 ATI drivers if that matters. > No idea about that. If it worked before a regression test will help Will do a regression test and report back. Regards, Carl-Daniel

May 20, 2007

Re: [localui} New Korean Resource

by Detlef Riekenberg

On So, 2007-05-20 at 19:54 +0900, Hwang YunSong(황윤성) wrote: > +LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT > + > +STRINGTABLE DISCARDABLE > +{ > + IDS_LOCALPORT " Ʈ" > + IDS_NOTHINGTOCONFIG " Ʈ ɼ ϴ" > +} localui.dll has much more resources now. Please update your Translation-Patch. Thanks -- By by ... Detlef

May 20, 2007

user32: Exclude unused headers

by Andrew Talbot

Apologies for the duplicates: the originals were slow to arrive, so I presumed they got lost and sent them again. -- Andy.

May 20, 2007

winetest.dll (RE: ADVAPI32: service tests)

by Detlef Riekenberg

On So, 2007-05-20 at 11:23 +0200, Rolf Kalbermatter wrote: > Well I have checked and on a clean Wine install from current git there > is no service installed at all. We have the Spooler-Service (only as a stub, but startable), so the entries should be present in the Registry. > Without at least one working service entry (active or not) there won't > be many meaningful tests we could do for the service API. You can take dlls/winspool.drv/tests/info.c as example, what I did for the Monitor-Tests. (Lines starting at 155; 283; 326) > Still on a clean Wine install I don't see how we can currently do many > useful service API tests at all. Because we have no need for a Service in Wine yet.... I mentioned already the idea for a "winetest.dll" / "winetest.drv" to allow tests, that need a dll next to "winetest.exe" (Global Hook, Printmonitor, Printer Driver, .... ). A Service need also a DLL and the with the new "ntoskrnl.exe", a Driver "winetest.sys" might be useful. It's also possible to add the new Files as a Resource in "winetest.exe", to have only a single file to download / start. An Item to discuss is an Option in winetest.exe to Disable the Kernelmode-Testdriver. -- By by ... Detlef

May 20, 2007

Re: Wine keyboard driver+XKB. What am I to do?

by Shachar Shemesh

Oleh R. Nykyforchyn wrote: > Hello, > I need an advice on what to do with some piece of code that I have written for > about 3 years. I started to make changes in Wine keyboard driver because I was > not able to use MS Office under it on my Linux box (3 or 4 XKB groups, 2 overlay > groups used, English, Russian, Ukrainian, Belarusian, German and Polish > layouts). First I submitted a patch that adds koi8-u encoding to Wine, and it was > happily introduced. But my changes to X11DRV (now winex11) keyboard driver were > large and I understand Wine people who didn't want to risk. Meanwhile I > continued to polish my implementation to correct bugs and improve performance. > I am heavily indebted to people that tested my patches, wrote me about problems > with them and suggested possible solutions. I thank to L.Rahyen that supported > me in my efforts. > > Now patched keyboard driver allows user to: > > 1) have up to 4 XKB groups working (current code uses 1 or 2); > 2) detect and use XKB overlays to put 2 or 3 close layouts (e.g. Russian, > Ukrainian and Belarusian) into one XKB group; > 3) freely combine available XKB layouts in any order, e.g. "en,ru,fr"; > 4) list all layouts available at the system, and implement > ActivateKeyboardLayout(); > 5) notify an application (e.g. MS Word) about change of layout, and make > GetKeyboardLayout() work really, not just return LCID for current locale > of Unix box; > 6) input characters that do not fit into current Unix locale, e.g. German and > French accented letters at a system with Cyrillic (not UTF) locale; > 7) override any of detected layouts via registry, if user is not satisfied > with Wine driver choice. > > In fact I made cosmetic changes to 3 files in winex11.drv directory: x11drv.h, > x11drv_main.c, event.c, but the fourth file keyboard.c was changed much more. > About half of functions in it were rewritten, and it now easier to read new > keyboard.c than diff output to understand the changes. > > I got very reasonable advice from L.Rahyen to broke the patch into smaller > parts. The problem is that I preserved the driver logic, but changed > data structures, so any such patch (even very small one) will touch hundreds if > lines across the whole file, probably introducing new bugs and being difficult > to read and understand. Also, there is no reason to change code by a patch > if we can benefit of it only after next patch. > > Now I will be grateful to any help. How can such big changes be introduced in > Wine tree? I also attach a patch against wine-0.9.37 and copies of original and > changed files. Perhaps somebody, who is interested in multilingual keyboard input, > can test it and write me about results. > > Oleh > Also, have a look at http://bugs.winehq.org/show_bug.cgi?id=735, which is an independent attempt to solve the same problem. It's a pity I didn't know about your effort. Shachar

May 20, 2007

Re: ADVAPI32: service tests

by James Hawkins

On 5/20/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > James Hawkins [mailto:truiken(a)gmail.com] wrote > > >Have you looked? regedit HKLM\System\CurrentControlSet\Services. > >I'm not familiar with spooler, but I assume it's installed by default > >on win9x, whereas msi is not. Whichever service you test, though, > >you can just skip if the service doesn't exist. > > Well I have checked and on a clean Wine install from current git there > is no service installed at all. I see a VxD/MSTCP entry in the registry > but no other settings in there that would be needed for a service to be > started nor any other service entry. On that account I wonder what the > VxD/MSTCP entry does at all or if it could be removed? > Then something is wrong with your setup. Both MSIServer and Spooler are registered services when you run wineprefixcreate. > >You won't need any of this. > > Without at least one working service entry (active or not) there won't > be many meaningful tests we could do for the service API. > Read above. > >Just check the return value of OpenSCManager; skip the test if they aren't > >admin. msdn implies that OpenSCManager will return ERROR_ACCESS_DENIED if > >they don't have the correct privileges. It's a trivial issue that most > >tests currently don't bother with. > > I thought skip would be the solution but need to read on that. Last time I > did a Wine test skip didn't exist at all. > > Still on a clean Wine install I don't see how we can currently do many > useful service API tests at all. > On a clean install, there are two services to test. You need to figure out why you don't have those services. This is from a clean .wine: REGEDIT4 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services] [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\MSIServer] "DisplayName"="MSIServer" "ErrorControl"=dword:00000001 "ImagePath"="c:\\windows\\system32\\msiexec.exe" "Start"=dword:00000003 "Type"=dword:00000020 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\Spooler] "Description"="Loads files to memory for later printing." "DisplayName"="Print Spooler" "ErrorControl"=dword:00000001 "Group"="SpoolerGroup" "ImagePath"="spoolsv.exe" "ObjectName"="LocalSystem" "Start"=dword:00000002 "Type"=dword:00000110 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\VxD] [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\VxD\MSTCP] @="" -- James Hawkins

May 20, 2007

RE: ADVAPI32: service tests

by Rolf Kalbermatter

James Hawkins [mailto:truiken(a)gmail.com] wrote >Have you looked? regedit HKLM\System\CurrentControlSet\Services. >I'm not familiar with spooler, but I assume it's installed by default >on win9x, whereas msi is not. Whichever service you test, though, >you can just skip if the service doesn't exist. Well I have checked and on a clean Wine install from current git there is no service installed at all. I see a VxD/MSTCP entry in the registry but no other settings in there that would be needed for a service to be started nor any other service entry. On that account I wonder what the VxD/MSTCP entry does at all or if it could be removed? >You won't need any of this. Without at least one working service entry (active or not) there won't be many meaningful tests we could do for the service API. >Just check the return value of OpenSCManager; skip the test if they aren't >admin. msdn implies that OpenSCManager will return ERROR_ACCESS_DENIED if >they don't have the correct privileges. It's a trivial issue that most >tests currently don't bother with. I thought skip would be the solution but need to read on that. Last time I did a Wine test skip didn't exist at all. Still on a clean Wine install I don't see how we can currently do many useful service API tests at all. Rolf Kalbermatter

May 20, 2007

Re: msxml3 [1/4]: Add initial implementations of IXMLElement and IXMLElementCollection

by James Hawkins

On 5/18/07, Huw Davies <huw(a)codeweavers.com> wrote: > On Thu, May 17, 2007 at 04:40:06PM -0500, James Hawkins wrote: > > > > Changelog: > > * Add initial implementations of IXMLElement and IXMLElementCollection. > > > I can't help thinking that it would have been cleaner to implement the > IXML stuff using the IXMLDOM interfaces rather than straight on top of > libxml. That way we only get one set of interfaces that depend on > libxml. It may not be possible, but I think it would be worth a look. > I've taken a look, and I don't think it's possible. Here is a 1-to-1 matching of methods in IXMLDocument and IXMLDOMDocument, respectively: xmldoc_get_root => domdoc_documentElement xmldoc_get_fileSize xmldoc_put_fileModifiedDate xmldoc_get_fileUpdatedDate xmldoc_get_URL => domdoc_get_url xmldoc_put_URL => domdoc_load xmldoc_get_mimeType xmldoc_get_readyState => domdoc_get_readyState xmldoc_get_charset xmldoc_put_charset xmldoc_get_version xmldoc_get_doctype => domdoc_get_doctype xmldoc_get_dtdURl xmldoc_createElement => domdoc_createElement The rows with empty second columns have no matching IXMLDOMDocument method, and more precisely, can't be implemented without access to xmlDoc/NodePtr. The file* methods aren't as simple as that, but either way, they don't involve libxml2. Another problem is the discrepancies between the interface implementations. For example, IXMLDocument::get_tagName returns the name of the tag in all upper-case, while IXMLDOMDocument's equivalent method preserves the case of the tag name. The Media Player 9 requires this behavior. I understand your concerns about limiting use of libxml2, but I think that the limitation can only apply to the respective groups of interfaces, e.g., XMLDocument and co. vs. XMLDOMDocument and co. The latest version of each interface implements the interface using libxml2, and each earlier version is implemented on top of the latest version. -- James Hawkins

May 20, 2007

Re: gdi32: check for null-pointer in CreateDIBSection

by Laurent Vromman

Hi, I am not sure at all there a link between what I say and a hiding bug somewhere around this patch, but bug 8088 is due to a problem around DIB section and bitmapinfo too. Maybe a cross analysis between those two bugs could help find this hiding bug. I hope this can help, Laurent Jesse Allen a écrit : > On 5/19/07, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: >> Hi , this fixes bug 8066, >> http://bugs.winehq.org/show_bug.cgi?id=8066 >> >> See the crash log here: >> http://bugs.winehq.org/attachment.cgi?id=5800&action=view , >> CreateDIBSection is called with bitmapinfo = null. >> >> > > > The program should be passing in a correctly initialized BITMAPINFO. > We need to make sure this isn't hiding another bug. Could you provide > a test case? > > >

May 20, 2007

Success: Sim City 4 using DirectX

by Markus

Hello, just wanted to let you know that with Wine 0.9.37, Sim City 4 is running successfully in DirectX mode for the first time in the 3 years I've been playing it under Wine. Previously, to be able to play at all, one had to force the game to use OpenGL calls. The visual artifacts triggered by scrolling the map under that mode are now gone under DirectX as well. So all in all great work :) The only issue remaining seems to be related to the Z-buffer. Cars and pedestrians are always drawn on top of buildings. See http://bugs.winehq.org/show_bug.cgi?id=7260#c3 Regards, -- Markus

May 20, 2007

Re: ADVAPI32: service tests

by James Hawkins

On 5/18/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > While working on some advapi32.service functions I found that having some > tests for those APIs could be very useful. However nbot having added > completely new tests so far there are a few issues I feel intimidated about. > > The actual task of adding a new test file service.c does seem fairly > straightforward to me, considering I can just take some other test file and > copy the framework from it, adding the new service.c to the Makefile.in. > > However there are a few issues I see. First almost any test won't make much > sense without at least one service installed and activated. As it is now > there seem to be no services installed by default in a clean Wine install. > Have you looked? regedit HKLM\System\CurrentControlSet\Services. I'm not familiar with spooler, but I assume it's installed by default on win9x, whereas msi is not. Whichever service you test, though, you can just skip if the service doesn't exist. > So I guess I would also need an extra executable somehow that implements a > basic service that could for instance communicate through a pipe with the > service test. It could be as simple as an executable that implements all the > necessary communication with the service manager and offers some sort of > pipe loopback as main service activity. But how am I going to add such an > extra executable to the make logic of the advapi32 test? > You won't need any of this. > Also under real Windows installing a service will in many cases fail since > that requires administrative privileges for the current process and I'm not > sure we can and want to enforce something like that especially for the > unattended wine test service if that is still working. > Just check the return value of OpenSCManager; skip the test if they aren't admin. msdn implies that OpenSCManager will return ERROR_ACCESS_DENIED if they don't have the correct privileges. It's a trivial issue that most tests currently don't bother with. -- James Hawkins

May 20, 2007

Re: gdi32: check for null-pointer in CreateDIBSection

by Jesse Allen

On 5/19/07, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi , this fixes bug 8066, > http://bugs.winehq.org/show_bug.cgi?id=8066 > > See the crash log here: > http://bugs.winehq.org/attachment.cgi?id=5800&action=view , > CreateDIBSection is called with bitmapinfo = null. > > The program should be passing in a correctly initialized BITMAPINFO. We need to make sure this isn't hiding another bug. Could you provide a test case?

May 19, 2007

Re: Patch [1/4]:Implement D3DRMColorGetRed

by Stefan Dösinger

Am Samstag 19 Mai 2007 22:01 schrieb David.Adam(a)math.cnrs.fr: + color=2949120; + expected=45.0/255.0; Maybe it would be easier to read if you write the color as a hex value(the D3DCOLOR one). Also try to set blue and green to something different than 0.

May 19, 2007

Error compiling wine during git regression test

by Austin English

Howdy, I was attempting to run a regression test, and kept running into errors when trying to compile a bisect between wine 0.9.34 and 0.9.35. After trying all sorts of things to fix it, I tried compiling between wine 0.9.34 and the current git, which worked fine, eventually leading me to the troubled patch. However, building between 0.9.34 and 0.9.35 still does not work. Below is the output from terminal of where it fails, seemingly on the cmd program, and more specifically, in the directory function. make[2]: Entering directory `/home/austin/wine-git/programs/cmd' gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o batch.o batch.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o builtins.o builtins.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o directory.o directory.c directory.c:36: error: expected ) before * token directory.c: In function WCMD_directory: directory.c:409: warning: implicit declaration of function WCMD_list_directory directory.c: At top level: directory.c:443: warning: conflicting types for WCMD_list_directory directory.c:443: error: static declaration of WCMD_list_directory follows non-static declaration directory.c:409: error: previous implicit declaration of WCMD_list_directory was here make[2]: *** [directory.o] Error 1 make[2]: Leaving directory `/home/austin/wine-git/programs/cmd' make[1]: *** [cmd] Error 2 make[1]: Leaving directory `/home/austin/wine-git/programs' make: *** [programs] Error 2 Please CC me in any replies, as I am not subscribed to this mailing list. Austin

May 19, 2007

Re: Small Direct3D milestone

by Stefan Dösinger

> Did you change something affecting D3D multithreaded apps? I am currently working on this. Some fundamental work went into wine somewhen between .33 and .35, but its not active yet. It was just some data structure modifications to handle multiple contexts for one swapchain. Before that the state management rework enabled us to keep track of states for multiple contexts. But right now I am working on making things really thread safe, and after that I can debug some gl crashes with the context selection patches I posted on this list a few months ago so they can go in finally. > Star Trek: > Bridge Commander doesn't start for me (only blank screen) since 0.9.37. > http://appdb.winehq.org/appview.php?iVersionId=4207 (AppDB) > http://www.bridgecommander.com/indepth/bcdemo.htm (downloadable demo) > I'm using the opensource r300 ATI drivers if that matters. No idea about that. If it worked before a regression test will help

May 19, 2007

configure error on OpenBSD

by Vortechz Anderson

I am trying to port wine to OpenBSD, or at least trying to make it build and not segfault upon execution... (This bug is a minor issue compared to some ld.so trouble I have run into. I'd be happy to know about differences between Net/Free/OpenBSD ld.so) configure output: configure: WARNING: sys/sysctl.h: present but cannot be compiled configure: WARNING: sys/sysctl.h: check for missing prerequisite headers? configure: WARNING: sys/sysctl.h: see the Autoconf documentation configure: WARNING: sys/sysctl.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/sysctl.h: proceeding with the preprocessor's result configure: WARNING: sys/sysctl.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Some rows from config.log: In file included from /usr/include/sys/sysctl.h:46, from conftest.c:106: /usr/include/sys/ucred.h:49: error: `NGROUPS' undeclared here (not in a function ) In file included from /usr/include/sys/sysctl.h:47, from conftest.c:106: /usr/include/sys/proc.h:65: error: `MAXLOGNAME' undeclared here (not in a functi on) /usr/include/sys/proc.h:91: error: syntax error before "int" /usr/include/sys/proc.h:215: error: syntax error before "sigset_t" /usr/include/sys/proc.h:230: error: `MAXCOMLEN' undeclared here (not in a function) In file included from conftest.c:106: /usr/include/sys/sysctl.h:327: error: `MAXLOGNAME' undeclared here (not in a function) I managed to get around this by including sys/param.h in the sys/proc.h and sys/ucred.h headers but I'm not sure that's the right approach. Wine developers wouldn't benefit from such patches anyway. I have tried to change configure.ac properly but it seems that I can't get it right... // V.A. P.S. Adding sys/proc and sys/ucred to header list and checking for param.h dependency is not sufficient: AC_CHECK_HEADERS([sys/proc.h],,, [#if HAVE_SYS_PARAM_H # include <sys/param.h> #endif]) AC_CHECK_HEADERS([sys/ucred.h],,, [#if HAVE_SYS_PARAM_H # include <sys/param.h> #endif]) With these addons, both proc and ucred fails. D.S. _________________________________________________________ Flyger tiden iväg? Fånga dagen med Yahoo! Mails inbyggda kalender. Dessutom 250 MB gratis, virusscanning och antispam. Få den på: http://se.mail.yahoo.com _________________________________________________________ Ont om plats? Skaffa gratis Yahoo! Mail med obegränsat, lagringsutrymme, kalender, virusscan och antispamfunktion. http://se.mail.yahoo.com

May 19, 2007

Re: Small Direct3D milestone

by Carl-Daniel Hailfinger

Hi! On 11.05.2007 21:16, Stefan Dösinger wrote: > With Wine 0.9.37 we've archieved something that I allow myself to call a small > milestone - All Direct3D7 Immediate mode SDK demos successfully perform their > intended rendering. Congratulations! > Two major problems are left though, namely windowed opengl rendering(see the > junk where a menu bar should be) and GetDC(there should be a little bit of > text rendered, I disabled render target locking to get proper performance). > > Where to go from here? I am currently fixing the DirectDraw rewrite > regressions I can get hold of, and I am trying to make D3D thread safe > finally. From the application point of view my focus will stay on fixing > older apps first, which somewhat includes getting thread safety, render > target locking and GetDC working properly. Did you change something affecting D3D multithreaded apps? Star Trek: Bridge Commander doesn't start for me (only blank screen) since 0.9.37. http://appdb.winehq.org/appview.php?iVersionId=4207 (AppDB) http://www.bridgecommander.com/indepth/bcdemo.htm (downloadable demo) I'm using the opensource r300 ATI drivers if that matters. Regards, Carl-Daniel

May 19, 2007

Re: Direct3D thread safety review

by H. Verbeet

On 18/05/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > * When a method needs locking, the lock is aquired after printing the trace, > but before checking error conditions(like windows). > * If a method doesn't need locking(e.g. unimplemented, or just a getter for > static info(GetCaps), or QI / AddRef / Release), then the lock is not held > > Since ddraw, d3d8 and d3d9 need their own locking anyway, my plan is to > implement locking in them and assume synchronised calls in wined3d - ie no > wined3d locking. No 2 threads may call wined3d at the same time, and > ddraw/d3d8/d3d9 have to take care of that. That keeps the code simpler. > Makes sense to me.

May 19, 2007

Re: [PATCH] wined3d: IWineD3DDeviceImpl_Clear: list Color parameter in the trace.

by H. Verbeet

On 12/05/07, Erik Inge Bolsø <knan-wine(a)anduin.net> wrote: > - TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Z (%f), Stencil (%d)\n", This, > - Count, pRects, Flags, Z, Stencil); > + TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Color (%f %f %f %f), Z (%f), Stencil (%d)\n", This, > + Count, pRects, Flags, D3DCOLOR_R(Color), D3DCOLOR_G(Color), D3DCOLOR_B(Color), D3DCOLOR_A(Color), Z, Stencil); > Tracing the color is fine, but there's no reason to convert it do individual float components. Printing it as 0x%08x should be fine.

May 19, 2007

Re: [PATCH] wined3d: debug_d3dusage: prettyprint a flag combination

by H. Verbeet

On 12/05/07, Erik Inge Bolsø <knan-wine(a)anduin.net> wrote: > --- > dlls/wined3d/utils.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index c444232..4db0622 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -238,6 +238,7 @@ const char* debug_d3dusage(DWORD usage) { > WINED3DUSAGE_TO_STR(WINED3DUSAGE_SOFTWAREPROCESSING); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_DONOTCLIP); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_POINTS); > + WINED3DUSAGE_TO_STR(WINED3DUSAGE_WRITEONLY|WINED3DUSAGE_POINTS); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_RTPATCHES); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_NPATCHES); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_DYNAMIC); > -- > 1.4.4.2 > That's not a proper fix, debug_d3dusage() should be changed to print all the flags in "usage", not just exact matches.

May 19, 2007

Re: Small Direct3D milestone

by H. Verbeet

On 12/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Am Samstag 12 Mai 2007 00:02 schrieb Raymond Barbiero: > > FYI, I get similar vertex blending errors playing Oblivion. > Oblivion is a direct3d9 game which makes heavy use of vertex shaders. I'd be > really surprised if it uses fixed function vertex blending, so I don't think > the problems in oblivion are related. They may be some rounding/precision > problem in the vertex shaders. > What wine version? There was a rounding issue with mova a couple of versions ago.

May 19, 2007

Re: [PATCH] dlls/wined3d: Implemented converting X1R5G5B5 format to R5G5B5A1 to emulate color-keying.

by Stefan Dösinger

Am Samstag 19 Mai 2007 15:33 schrieb hightower(a)tregt.net: Looks good to me, although I wonder if the maskin in "*Dest = (color & 0x7FFF) << 1" is really needed or if we can just shift out the highest bit.

May 19, 2007

Re: New Gecko package

by Jacek Caban

Luke Bratch wrote: >> I'm interested in >> regressions, so just a simple test if app that >> > worked before still works > >> will be fine. >> > > I've given it a test, and found the following: > > - When setting that URL in HKCU\Software\Wine\MSHTML, > it will download but fail to install. > It's not supposed to work. Package that I've uploaded for testing is in tar.bz2 format while MSHTML Gecko installer expects cab format. > - Extracting it to install it manually works, as do > the scroll bars (which work fine) > - It crashes after submitting more than one form on > websites. For instance searching for something on > Google, then searching again will cause a crash. > Thanks for testing. I've reproduced the crash and I'm trying to fix it. I've found that using older nspr4.dll fixes it so far. Thanks, Jacek

May 19, 2007

Re: shlwapi: stub implementation for SHSetTimerQueueTimer

by Dmitry Timoshkov

"Nigel Liang" <ncliang(a)gmail.com> wrote: > + CreateTimerQueueTimer(phNewTimer, hQueue, pfnCallback, pContext, > + dwDueTime, dwPeriod, dwFlags); > + > + return *phNewTimer; You have to check the return value of CreateTimerQueueTimer before returning a possible garbage. -- Dmitry.

May 19, 2007

Re: RegDeleteTree [6]

by Juan Lang

Hi Stefan, + if (!lpszName) { + ret = ERROR_NOT_ENOUGH_MEMORY; + goto cleanup; + } Now you're mixing tabs and spaces (here and elsewhere.) Please honor the existing formatting. --Juan ____________________________________________________________________________________Yahoo! oneSearch: Finally, mobile search that gives answers, not web links. http://mobile.yahoo.com/mobileweb/onesearch?refer=1ONXIC

May 18, 2007

Re: [PATCH 3/4] msi: automation: Generalize list implementation.

by Andrew Talbot

Misha Koshelev wrote: > So is the general recommendation for wine that we not use Hungarian > notation then? > > Misha IMHO, a prefix is of little value if it merely echos the declared type of the variable it represents, especially in a small-scope situation. To be of value, a prefix needs to convey other information, such as implying the purpose of the variable, or acting as a grouping element for a set of related variables. -- Andy.

May 18, 2007