May 2007 - Wine-Devel - list.winehq.org

Re: problems regression testing/compiling wine

by Michael Stefaniuc

Saulius Krasuckas wrote: > * On Sun, 13 May 2007, Louis Lenders wrote: > >>* EA Durbin <ead1234 <at> hotmail.com> writes: >> >>>No, that doesn't help, i've tried distclean, git clean -x, the usual >>>make clean, and nothing works. Regression testing seems borked passed >>>two bisects. >> >>I know I had the same problem, and somehow i got around it, but i forgot how ;( >>maybe "rm -rf */*/*.def" from wine's source tree. > > > I tend to agree on this guess. But once regression interval starts > occupying Wine versions delta >= 1, usually I do: > > $ rm -rf dlls/; git checkout -f > > after every > > $ git bisect [bad|good] > > and before running ./configure . Cleaner would be to use a separate build directory which you can remove before each $SOURCE_DIR/configure. I use a short script that does all those steps for me. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

May 14, 2007

Re: dinput: Prevent race between destroying the hook window and unloading the dll.

by Alexandre Julliard

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > else ERR("Error creating message window\n"); > > + UnregisterClassW(classW, DINPUT_instance); > return 0; You need to clear the class atom if you unregister the class, otherwise the next window creation will fail. -- Alexandre Julliard julliard(a)winehq.org

May 14, 2007

Re: problems regression testing/compiling wine

by Saulius Krasuckas

* On Sun, 13 May 2007, Louis Lenders wrote: > * EA Durbin <ead1234 <at> hotmail.com> writes: > > > > No, that doesn't help, i've tried distclean, git clean -x, the usual > > make clean, and nothing works. Regression testing seems borked passed > > two bisects. > > I know I had the same problem, and somehow i got around it, but i forgot how ;( > maybe "rm -rf */*/*.def" from wine's source tree. I tend to agree on this guess. But once regression interval starts occupying Wine versions delta >= 1, usually I do: $ rm -rf dlls/; git checkout -f after every $ git bisect [bad|good] and before running ./configure .

May 14, 2007

OpenAL32 dll thunk test

by Chris Robinson

After the previous attempt by Nick Burns was more or less abandoned, I decided to try making an acceptable version myself. This is the current result. I used the original version Nick had and got rid a lot of the macro abuse. It still uses macros to declare/define and load the functions, but it isn't nearly as bad as it was. I know AJ isn't very thrilled with macro use, but I believe the current method is a nice balance between flexibility and clarity. Note that this IS NOT FINISHED. It should be good enough to work, however. The main reason for this is to get some testing to make sure it works as expected on other machines (especially OSX). The things I still need to work on are: a) Skip building the DLL if OpenAL headers aren't found on the system durring ./configure (any autotools experts want to help?) b) Properly handle the autotools stuff (any autotools experts want to help?) c) Fix up extension handling to use al[c]GetProcAddress instead of dlsym (for the sake of being proper; I don't believe this would pose a problem currently) The OpenAL lib is dynamicly loaded, so the lib doesn't need to be present when building. If the lib is not present when the DLL is loaded however, then the DLL will fail to load. Because of this, it might be a good idea to include OpenAL headers with Wine, so they will always be available to build the DLL with (the headers are LGPL licensed, AFAIK). Won't have to worry about skipping building or configure checking that way. On my Linux machine, the OpenAL 1.1 SDK demos work*. I'm curious about how they work for other people on other machines, and for other apps. * Not quite true. EnumerateWin32.exe doesn't wait for a key press before exiting, and OpenALDemo.exe won't wait for key presses when trying to pick a test (it loops endlessly on the "main menu"). These problems are not related to OpenAL. PlayStaticWin32.exe and PlayStreamWin32.exe both work perfectly, and EnumerateWin32.exe does do what it's supposed to, with the exception of the wait-for-key-before-exit problem. Note that if you're using the Sample Implementation, you must get a recent (as in today/yesterday) SVN checkout of it. It was missing a couple somewhat obscure 1.1 functions I sent in a patch for and got applied. After patching, you'll need to run autoconf (or autogen if you use that script) to generate a new configure. Reconfigure, then rebuild Wine. PS. I did get permission from Nick before posting this as I used his "un-licensed" patch as a starting point. It's all okay with him. PPS. I know not everyone likes the idea of this thunk, because the native implementations aren't "up to par" with the Windows version that backends on DSound. However, the only way they'll get better is with use (they've already got several patches from me because of this thunk, with more pending, and more in planning), and if worse comes to worse, you can use a DLL override to use the Windows native OpenAL. Creative is planning on releasing hardware OpenAL Linux drivers for some of their cards later this year, and this would be the best way to take advantage of them.

May 14, 2007

LinuxConf Europe

by Kai Blin

Hi folks, I'm considering to send in a paper proposal for LinuxConf Europe 2007 (http://www.linuxconf.eu/2007/cfp/) talking about (my plans for) Wine / Samba integration. Is there anybody else planning to go there? How about a small meeting there, to practice for WineConf? ;) As far as my plans go, the wiki already lists some of the things, I'm planning to flesh this out a little more. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

May 13, 2007

Re: [PATCH] some alsa midi fixes

by James Hawkins

On 5/13/07, Ralf Beck <musical_snake(a)gmx.de> wrote: > Hello, > this patch fixes: > - Bug 8096 > - incorrect handling of pitchbender on midi-in > - add midi-in midiclock/start/stop/continue/spp/song sel > - make midi-out midiclock/start/stop/continue/spp/song sel handling same > style as on midi-in > One fix per patch please. -- James Hawkins

May 13, 2007

CMD.EXE patchset 1->6

by Ann & Jason Edmeades

Apologies if this set arrives multiple times - I sent it all on Friday, and the mailing list only shows 1,2 and 4. I sent then again tonight separately, and immediately 3 went missing... FYI I had this problem before the last hardware upgrade on winehq, and it appeared fixed since then. I'll start copying a gmail account in future to confirm what I am seeing, but last time some emails got delayed about a month in transit and eventually appeared, but ONLY when winehq was involved, gmail, hotmail, my own email addr etc all got immediate copies... Regards, Jason

May 13, 2007

Re: problems regression testing/compiling wine

by Louis Lenders

EA Durbin <ead1234 <at> hotmail.com> writes: > > No, that doesn't help, i've tried distclean, git clean -x, the usual make > clean, and nothing works. Regression testing seems borked passed two > bisects. > > >From: Louis Lenders <xerox_xerox2000 <at> yahoo.co.uk> > >To: wine-devel <at> winehq.com > >Subject: Re: problems regression testing/compiling wine > >Date: Sun, 13 May 2007 14:05:42 +0000 (UTC) > > I know I had the same problem, and somehow i got around it, but i forgot how ;( maybe "rm -rf */*/*.def" from wine's source tree.

May 13, 2007

Re: problems regression testing/compiling wine

by EA Durbin

No, that doesn't help, i've tried distclean, git clean -x, the usual make clean, and nothing works. Regression testing seems borked passed two bisects. >From: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> >To: wine-devel(a)winehq.com >Subject: Re: problems regression testing/compiling wine >Date: Sun, 13 May 2007 14:05:42 +0000 (UTC) > >E > > winegcc: gcc failed. > > make[2]: *** [winex11.drv.so] Error 2 > > make[2]: Leaving directory `/home/eric/wine/dlls/winex11.drv' > > make[1]: *** [winex11.drv] Error 2 > > make[1]: Leaving directory `/home/eric/wine/dlls' > > make: *** [dlls] Error 2 > > > > _________________________________________________________________ > > More photos, more messages, more storageÂget 2GB with Windows Live >Hotmail. > > >http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati… > > > > > >I think "git clean -x" should work too > > > > > _________________________________________________________________ Like the way Microsoft Office Outlook works? Youll love Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

May 13, 2007

Re: shell32: check result of HeapAlloc(), revised

by hto＠mail.cnt.ru

James Hawkins wrote: > Please don't change the indentation. You have to stick with whatever > indentation exists for the file you're editing. I have changed the indentation of IEnumFORMATETC_Constructor() and IDataObject_Constructor() to be more consistent with the rest of dataobject.c, which uses different indentation style.

May 13, 2007

Re: problems regression testing/compiling wine

by Louis Lenders

E > winegcc: gcc failed. > make[2]: *** [winex11.drv.so] Error 2 > make[2]: Leaving directory `/home/eric/wine/dlls/winex11.drv' > make[1]: *** [winex11.drv] Error 2 > make[1]: Leaving directory `/home/eric/wine/dlls' > make: *** [dlls] Error 2 > > _________________________________________________________________ > More photos, more messages, more storageget 2GB with Windows Live Hotmail. > http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati… > > I think "git clean -x" should work too

May 13, 2007

Re: problems regression testing/compiling wine

by Maarten Lankhorst

EA Durbin schreef: > I'm having problems regression testing between 0.9.15 and 0.9.37. On > 3+ bisects I keep getting the following error and wine won't compile. Most of the time when this happens you forget to do a make distclean first. It is recommended to use ccache and do a 'make distclean' every time time. Maarten

May 13, 2007

Re: shell32: check result of HeapAlloc(), revised

by James Hawkins

On 5/13/07, hto(a)mail.cnt.ru <hto(a)mail.cnt.ru> wrote: > Add an ERR() messages, save an indentation level. > > --- wine-0.9.37-orig/dlls/shell32/dataobject.c 2007-05-13 10:16:18.000000000 +0000 > +++ wine-0.9.37/dlls/shell32/dataobject.c 2007-05-13 10:51:50.000000000 +0000 > @@ -169,27 +169,29 @@ static const IEnumFORMATETCVtbl efvt = > > LPENUMFORMATETC IEnumFORMATETC_Constructor(UINT cfmt, const FORMATETC afmt[]) > { > - IEnumFORMATETCImpl* ef; > - DWORD size=cfmt * sizeof(FORMATETC); > + IEnumFORMATETCImpl* ef; > + DWORD size=cfmt * sizeof(FORMATETC); > Please don't change the indentation. You have to stick with whatever indentation exists for the file you're editing. -- James Hawkins

May 13, 2007

problems regression testing/compiling wine

by EA Durbin

I'm having problems regression testing between 0.9.15 and 0.9.37. On 3+ bisects I keep getting the following error and wine won't compile. /home/eric/wine/dlls/winex11.drv/palette.c:866: undefined reference to `GDI_ReleaseObj' palette.o:/home/eric/wine/dlls/winex11.drv/palette.c:881: more undefined references to `GDI_ReleaseObj' follow palette.o: In function `X11DRV_RealizePalette': /home/eric/wine/dlls/winex11.drv/palette.c:1251: undefined reference to `GDI_GetObjPtr' /home/eric/wine/dlls/winex11.drv/palette.c:1253: undefined reference to `GDI_ReleaseObj' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [winex11.drv.so] Error 2 make[2]: Leaving directory `/home/eric/wine/dlls/winex11.drv' make[1]: *** [winex11.drv] Error 2 make[1]: Leaving directory `/home/eric/wine/dlls' make: *** [dlls] Error 2 _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

May 13, 2007

Re: shell32: check result of HeapAlloc()

by James Hawkins

On 5/13/07, hto(a)mail.cnt.ru <hto(a)mail.cnt.ru> wrote: > James Hawkins wrote: > > On 5/12/07, hto(a)mail.cnt.ru <hto(a)mail.cnt.ru> wrote: > >> > >> --- wine-0.9.37-orig/dlls/shell32/folders.c 2007-05-12 > >> 22:53:06.000000000 +0000 > >> +++ wine-0.9.37/dlls/shell32/folders.c 2007-05-13 00:17:00.000000000 > >> +0000 > >> @@ -81,11 +81,15 @@ IExtractIconW* IExtractIconW_Constructor > >> TRACE("%p\n", pidl); > >> > >> ei = HeapAlloc(GetProcessHeap(),0,sizeof(IExtractIconWImpl)); > >> - ei->ref=1; > >> - ei->lpVtbl = &eivt; > >> - ei->lpvtblPersistFile = &pfvt; > >> - ei->lpvtblExtractIconA = &eiavt; > >> - ei->pidl=ILClone(pidl); > >> + > >> + if (ei) > >> + { > >> + ei->ref=1; > >> + ei->lpVtbl = &eivt; > >> + ei->lpvtblPersistFile = &pfvt; > >> + ei->lpvtblExtractIconA = &eiavt; > >> + ei->pidl=ILClone(pidl); > >> + } > >> > > > > If a HeapAlloc call fails, you need to return with the appropriate error. > > > > It is already done in ISF_ControlPanel_fnGetUIObjectOf(), > IShellFolder_fnGetUIObjectOf(), ISF_Desktop_fnGetUIObjectOf(), > ISF_MyComputer_fnGetUIObjectOf(). > > ... > pObj = (LPUNKNOWN) IExtractIconW_Constructor(pidl); > ... > if (SUCCEEDED(hr) && !pObj) > hr = E_OUTOFMEMORY; > ... > return hr; > Then you need to add an ERR message that the alloc failed, and return immediately. It'll save an indentation level. ei = HeapAlloc(); if (!ei) { ERR("HeapAlloc failed blah blah\n"); return NULL; } -- James Hawkins

May 13, 2007

Re: shell32: check result of HeapAlloc()

by hto＠mail.cnt.ru

James Hawkins wrote: > On 5/12/07, hto(a)mail.cnt.ru <hto(a)mail.cnt.ru> wrote: >> >> --- wine-0.9.37-orig/dlls/shell32/folders.c 2007-05-12 >> 22:53:06.000000000 +0000 >> +++ wine-0.9.37/dlls/shell32/folders.c 2007-05-13 00:17:00.000000000 >> +0000 >> @@ -81,11 +81,15 @@ IExtractIconW* IExtractIconW_Constructor >> TRACE("%p\n", pidl); >> >> ei = HeapAlloc(GetProcessHeap(),0,sizeof(IExtractIconWImpl)); >> - ei->ref=1; >> - ei->lpVtbl = &eivt; >> - ei->lpvtblPersistFile = &pfvt; >> - ei->lpvtblExtractIconA = &eiavt; >> - ei->pidl=ILClone(pidl); >> + >> + if (ei) >> + { >> + ei->ref=1; >> + ei->lpVtbl = &eivt; >> + ei->lpvtblPersistFile = &pfvt; >> + ei->lpvtblExtractIconA = &eiavt; >> + ei->pidl=ILClone(pidl); >> + } >> > > If a HeapAlloc call fails, you need to return with the appropriate error. > It is already done in ISF_ControlPanel_fnGetUIObjectOf(), IShellFolder_fnGetUIObjectOf(), ISF_Desktop_fnGetUIObjectOf(), ISF_MyComputer_fnGetUIObjectOf(). ... pObj = (LPUNKNOWN) IExtractIconW_Constructor(pidl); ... if (SUCCEEDED(hr) && !pObj) hr = E_OUTOFMEMORY; ... return hr;

May 13, 2007

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

by James Hawkins

On 5/12/07, Andrew Riedi <andrewriedi(a)gmail.com> wrote: > Perhaps give an example? > > "Please include a one-liner in your email stating what you did. > Example: changelog: I fixed function X that was causing bug Y. > > Note: There is no need to edit the ChangeLog file itself." > > How is the above? > The only thing about the current documentation that needs to be changed is the word 'email' needs to be added: " Include a ChangeLog entry in the email with your real name, email address and a description of what your patch does." -- James Hawkins

May 12, 2007

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

by Andrew Riedi

Perhaps give an example? "Please include a one-liner in your email stating what you did. Example: changelog: I fixed function X that was causing bug Y. Note: There is no need to edit the ChangeLog file itself." How is the above? -- Andrew Riedi

May 12, 2007

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

by Tony Lambregts

Vincent Fourmond wrote: > Stefan Dösinger wrote: >> also you do not have to >> modify the ChangeLog file, git does that automatically when AJ commits the >> patch. > > I just followed the instructions on > http://winehq.org/site/sending_patches. If they are not correct, please > update this page. > >From that page ----8<--- When submitting patches, please: * Include a ChangeLog entry with your real name, email address and a description of what your patch does. ---->8---- Thats says nothings about a diff of the ChangeLog. I do not know how I would change the wording of that. -- Tony Lambregts

May 12, 2007

Re: shell32: check result of HeapAlloc()

by James Hawkins

On 5/12/07, hto(a)mail.cnt.ru <hto(a)mail.cnt.ru> wrote: > > --- wine-0.9.37-orig/dlls/shell32/folders.c 2007-05-12 22:53:06.000000000 +0000 > +++ wine-0.9.37/dlls/shell32/folders.c 2007-05-13 00:17:00.000000000 +0000 > @@ -81,11 +81,15 @@ IExtractIconW* IExtractIconW_Constructor > TRACE("%p\n", pidl); > > ei = HeapAlloc(GetProcessHeap(),0,sizeof(IExtractIconWImpl)); > - ei->ref=1; > - ei->lpVtbl = &eivt; > - ei->lpvtblPersistFile = &pfvt; > - ei->lpvtblExtractIconA = &eiavt; > - ei->pidl=ILClone(pidl); > + > + if (ei) > + { > + ei->ref=1; > + ei->lpVtbl = &eivt; > + ei->lpvtblPersistFile = &pfvt; > + ei->lpvtblExtractIconA = &eiavt; > + ei->pidl=ILClone(pidl); > + } > If a HeapAlloc call fails, you need to return with the appropriate error. -- James Hawkins

May 12, 2007

Re: msi: undo RegisterProduct/PublishProduct

by Misha Koshelev

On Sat, 2007-05-12 at 16:31 -0500, James Hawkins wrote: > On 5/12/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > > Hi, > > > > I am starting to write some automation conformance tests for things that > > I could check only after a package has been installed (and before it was > > removed) like ProductInfo and RelatedProducts. I've added the install > > functionality into the conformance test, and it works beautifully on > > Windows, cleaning up after itself every time both by deleting all the > > installed files and also doing an > > MsiInstallPackage/Installer::InstallPackage call with REMOVE=ALL options > > which gets rid of all the information published by > > RegisterProduct/PublishProduct, thus allowing the ProductState to go > > back to being INSTALLSTATE_UNKNOWN afterwards. > > > > However, in wine the tests run fine the first time, but then the > > REMOVE=ALL call does not seem to remove the registry data (in fact I'm > > not sure this functionality is present under Wine msi yet). Is there any > > way to properly remove the registry data about the application under > > Wine MSI in my conformance test without just manually clearing out the > > appropriate registry values, and would this be considered to be kosher? > > > > For the time being, using the registry API to delete the keys will be > fine. We do the same thing for the install tests (using DeleteFile to > delete the installed files). Eventually we'll be able to just call > install again wtih REMOVE, but uninstalls is unimplemented in Wine, > and it's a really low priority. > Ok, thanks for the info. Misha

May 12, 2007

Re: Internet explorer not detected

by Tom Spear

On 5/12/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I > > don't really feel sorry for apps that assume everything is running > "Program Files" isn't hardcoded either, like on my German locale > its "Programme". Which would be done as %PROGRAMFILES%, anyways, not %SYSTEMDRIVE%\Program Files -- Thanks Tom

May 12, 2007

Re: msi: undo RegisterProduct/PublishProduct

by James Hawkins

On 5/12/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > Hi, > > I am starting to write some automation conformance tests for things that > I could check only after a package has been installed (and before it was > removed) like ProductInfo and RelatedProducts. I've added the install > functionality into the conformance test, and it works beautifully on > Windows, cleaning up after itself every time both by deleting all the > installed files and also doing an > MsiInstallPackage/Installer::InstallPackage call with REMOVE=ALL options > which gets rid of all the information published by > RegisterProduct/PublishProduct, thus allowing the ProductState to go > back to being INSTALLSTATE_UNKNOWN afterwards. > > However, in wine the tests run fine the first time, but then the > REMOVE=ALL call does not seem to remove the registry data (in fact I'm > not sure this functionality is present under Wine msi yet). Is there any > way to properly remove the registry data about the application under > Wine MSI in my conformance test without just manually clearing out the > appropriate registry values, and would this be considered to be kosher? > For the time being, using the registry API to delete the keys will be fine. We do the same thing for the install tests (using DeleteFile to delete the installed files). Eventually we'll be able to just call install again wtih REMOVE, but uninstalls is unimplemented in Wine, and it's a really low priority. -- James Hawkins

May 12, 2007

msi: undo RegisterProduct/PublishProduct

by Misha Koshelev

Hi, I am starting to write some automation conformance tests for things that I could check only after a package has been installed (and before it was removed) like ProductInfo and RelatedProducts. I've added the install functionality into the conformance test, and it works beautifully on Windows, cleaning up after itself every time both by deleting all the installed files and also doing an MsiInstallPackage/Installer::InstallPackage call with REMOVE=ALL options which gets rid of all the information published by RegisterProduct/PublishProduct, thus allowing the ProductState to go back to being INSTALLSTATE_UNKNOWN afterwards. However, in wine the tests run fine the first time, but then the REMOVE=ALL call does not seem to remove the registry data (in fact I'm not sure this functionality is present under Wine msi yet). Is there any way to properly remove the registry data about the application under Wine MSI in my conformance test without just manually clearing out the appropriate registry values, and would this be considered to be kosher? Thanks Misha

May 12, 2007

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

by Vincent Fourmond

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan Dösinger wrote: > Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond: >> (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup. >> --- >> ChangeLog | 6 ++++++ >> dlls/ddraw/surface.c | 5 +++-- >> 2 files changed, 9 insertions(+), 2 deletions(-) > Now that wined3d stores the clipper, the surface->clipper member should be > removed and GetClipper and SetClipper should use wined3dsurface::getclipper > and Setclipper(like setpalette and getpalette does). I don't really understand what that means: it seems that all of surface.c is using the This->clipper idiom to access to the clipper. I just did add a sanity check to ensure it doesn't get unreferenced when NULL. If there is a transition here to be done however, I'm willing to help (once I understand better the whole scheme). > also you do not have to > modify the ChangeLog file, git does that automatically when AJ commits the > patch. I just followed the instructions on http://winehq.org/site/sending_patches. If they are not correct, please update this page. > Also please stick to the formating of the rest of the file / function. Here > you used tabs instead of spaces for indention. Sorry, I'm not used to paying attention to this kind of conventions; I'll look better next time. Cheers, Vincent Fourmond -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGRhzkx/UhwSKygsoRAvCpAKCRePojVDTlU7gcssclSYAd9HTdWQCePe5s ivOMUm1S0oT8vPFCO0IinwU= =kI5l -----END PGP SIGNATURE-----

May 12, 2007

Re: PATCH - implement LockWorkStation using xdg-screensaver

by Steven Edwards

Hi Hans, On 5/12/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > How about the following patch? I added an option --lock to wineboot > which does an execvp using the Unix search path. LockWorkStation > then calls CreateProcess on "wineboot --lock", analogous to what > ExitWindowsEx does. Thanks a lot. I just checked and LockWorkStation now properly handles the call from ProcessExplorer. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

May 12, 2007

Re: PATCH - implement LockWorkStation using xdg-screensaver

by Steven Edwards

Hi Hans, On 5/12/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > How about the following patch? I added an option --lock to wineboot > which does an execvp using the Unix search path. LockWorkStation > then calls CreateProcess on "wineboot --lock", analogous to what > ExitWindowsEx does. > > When running in a virtual desktop we should probably give precedence > to a Windows screensaver. > > Changelog > Implement LockWorkStation using xdg-screensaver. Your patch seems like a much better method to me. I'll merge in to my tree and test with Process Explorer tonight. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

May 12, 2007

Re: [PATCH] no wined3ddevice - no surface

by Marcus Meissner

On Sat, May 12, 2007 at 06:21:56PM +0200, Stefan Dösinger wrote: > Am Samstag 12 Mai 2007 16:20 schrieb Marcus Meissner: > > Hi, > > > > If wineD3DDevice is not set, than do return > > failure (and do not reference NULL ifaces). > Actually the ddraw object shouldn't be createable in the first place without a > wined3d device object. Or do you want to modify ddraw to do something without > wined3d? No, it somehow got created here. I am not sure why, but I have nvidia GL libraries, but the hardware support is gone due to a too new kernel. Will have too look deeper. Ciao, Marcus

May 12, 2007

Re: Small Direct3D milestone

by Stefan Dösinger

Am Samstag 12 Mai 2007 00:02 schrieb Raymond Barbiero: > > >> continueing work on software or shader emulation of it. I considered > > >> vertex blending a somewhat academic feature. > > FYI, I get similar vertex blending errors playing Oblivion. Oblivion is a direct3d9 game which makes heavy use of vertex shaders. I'd be really surprised if it uses fixed function vertex blending, so I don't think the problems in oblivion are related. They may be some rounding/precision problem in the vertex shaders.

May 12, 2007

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

by Stefan Dösinger

Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond: > (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup. > --- > ChangeLog | 6 ++++++ > dlls/ddraw/surface.c | 5 +++-- > 2 files changed, 9 insertions(+), 2 deletions(-) Now that wined3d stores the clipper, the surface->clipper member should be removed and GetClipper and SetClipper should use wined3dsurface::getclipper and Setclipper(like setpalette and getpalette does). also you do not have to modify the ChangeLog file, git does that automatically when AJ commits the patch. Also please stick to the formating of the rest of the file / function. Here you used tabs instead of spaces for indention.

May 12, 2007

Re: [PATCH] no wined3ddevice - no surface

by Stefan Dösinger

Am Samstag 12 Mai 2007 16:20 schrieb Marcus Meissner: > Hi, > > If wineD3DDevice is not set, than do return > failure (and do not reference NULL ifaces). Actually the ddraw object shouldn't be createable in the first place without a wined3d device object. Or do you want to modify ddraw to do something without wined3d?

May 12, 2007

Re: include: Include local not system sql.h header

by Andrew Talbot

It looks like I needed to tell my linting tool to search the local include directory before searching the system one. -- Andy.

May 12, 2007

Re: PATCH - implement LockWorkStation using xdg-screensaver

by Marcus Meissner

On Sat, May 12, 2007 at 06:13:42AM -0400, Steven Edwards wrote: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashing and still does not properly lock the > workstation. I am not quite sure why. Perhaps someone else is > interested in this to help improve wine usability. Also I guess I > should use HeapAlloc rather than malloc. > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > From 8e7001c9e3309492c881e9c1f717f26e3e379dfb Mon Sep 17 00:00:00 2001 > From: Steven Edwards <winehacker(a)gmail.com> > Date: Sat, 12 May 2007 05:49:52 -0400 > Subject: [PATCH] Implemented LockWorkStation using xdg-screensaver > > + * LockWorkStation (USER32.@) > + */ > +BOOL WINAPI LockWorkStation(void) > +{ > + /* Use xdg-screensaver */ > + static const char screensaver[] = "/usr/bin/xdg-screensaver"; > + static const char lock_command[] = "lock"; > + char **argv; > + > + FILE *f = fopen( screensaver, "r" ); > + if (!f) > + { > + FIXME_(graphics)( "no support for xdg-screensaver detected\n"); > + return 0; > + } You should use either stat/lstat or just check for failure from execve. > + argv = xmalloc(sizeof(lock_command)); > + memcpy( argv[1] , lock_command, sizeof(lock_command)); This is not going to work. char *argv[2]; argv[0] = "/usr/bin/xdg-screensaver"; argv[1] = "lock"; argv[2] = NULL; > + execv( screensaver, argv ); And actually you cannot use execve(), since it replaces the current process with the new one. Use system("/usr/bin/xdg-screensaver lock") or CreateProcess(). Ciao, Marcus

May 12, 2007

Fast events

by Maarten Lankhorst

Hi all, Since I'm trying to improve on winmm's timing scheduling, the best improvement I can find is getting rid of the wineserver calls, they add a huge delay to the timer and that is bad for something that should sleep all the time to get better scheduling. I tried sending in a patch that used linux sockets but it was rejected. Similar patches already do exist: winealsa and wineoss use them, some other sound drivers might use them too. Instead of duplicating that code everywhere I think it's better to add a generic implementation of it that can very easily be changed back to a win32 implementation. What are your thoughts on this? Maarten fevent patch attached. >From 5e5cb0a326f51dc2edef245fcaab4a071f9e0c42 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Sat, 12 May 2007 15:19:45 +0200 Subject: [PATCH] wine headers: introduce fevent interface --- include/wine/fevent.h | 145 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 145 insertions(+), 0 deletions(-) diff --git a/include/wine/fevent.h b/include/wine/fevent.h new file mode 100644 index 0000000..e80391d --- /dev/null +++ b/include/wine/fevent.h @@ -0,0 +1,145 @@ +/* + * Fast event interface + * Use this for when default wineserver calls are extremely bad for time critical usages + * This is also REALLY *ONLY* useful in case of 1 thread doing a 'WaitForSingleObject' + * else weird effects might occur. If someone wants to use this in any other way, results + * are undetermined. + * + * Copyright (C) 2007 Maarten Lankhorst + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef __WINESRC__ +#error This should only be used internally +#endif + +#ifndef __WINE_WINE_FEVENT_H +#define __WINE_WINE_FEVENT_H + +#if (defined(HAVE_POLL_H) || defined(HAVE_SYS_POLL_H)) && !defined(WINE_FEVENT_USE_EVENT) + +#ifdef HAVE_POLL_H +#include <poll.h> +#endif +#ifdef HAVE_SYS_POLL_H +#include <sys/poll.h> +#endif + +#include <errno.h> + +WINE_DECLARE_DEBUG_CHANNEL(fevent); + +struct TAGfevent { + int fd[2]; + DWORD manreset; +}; + +typedef struct TAGfevent *FEVENT; + +static void reset_fd(FEVENT fev) +{ + char readme; + struct pollfd pfd; + pfd.fd = fev->fd[0]; + pfd.events = POLLIN; + while (poll(&pfd, 1, 0) > 0) + read(fev->fd[0], &readme, sizeof(readme)); +} + +static void set_fd(FEVENT fev) +{ + char foo = 'A'; + + write(fev->fd[1], &foo, sizeof(foo)); +} + +static FEVENT create_fd(LPSECURITY_ATTRIBUTES lpEventAttributes, BOOL bManualReset, BOOL bInitialState, LPCWSTR lpName) +{ + FEVENT fev = HeapAlloc(GetProcessHeap(), 0, sizeof(*fev)); + + if (!fev) + goto err; + + if (lpEventAttributes || lpName) + FIXME_(fevent)("FEVENTS are meant to be internal and shouldn't have security attributes or a name\n"); + + if (pipe(fev->fd) < 0) + { + fev->fd[0] = fev->fd[1] = -1; + goto err; + } + fev->manreset = bManualReset; + if (bInitialState) + set_fd(fev); + return fev; + + err: + if (fev) + { + close(fev->fd[0]); + close(fev->fd[1]); + HeapFree(GetProcessHeap(), 0, fev); + } + return NULL; +} + +static void close_fd(FEVENT fev) +{ + close(fev->fd[0]); + close(fev->fd[1]); + fev->fd[0] = fev->fd[1] = -1; + HeapFree(GetProcessHeap(), 0, fev); +} + +static DWORD poll_fd(FEVENT fev, DWORD timeout) +{ + int err; + struct pollfd pfd; + pfd.fd = fev->fd[0]; + pfd.events = POLLIN; + + while ((err = poll(&pfd, 1, (int)timeout)) == -1) + if (errno != EAGAIN && errno != EINTR) + break; + switch (err) + { + case 0: return WAIT_TIMEOUT; + case -1: return WAIT_FAILED; + default: + if (!fev->manreset) + reset_fd(fev); + return WAIT_OBJECT_0; + } +} + +#define RESETEVENT reset_fd +#define SETEVENT set_fd +#define CREATEEVENT create_fd +#define CLOSEEVENT close_fd +#define WAITEVENT poll_fd + +#else + +#define FEVENT HANDLE +#define RESETEVENT ResetEvent +#define SETEVENT SetEvent +#define CREATEEVENT CreateEventW +#define CLOSEEVENT CloseHandle +#define WAITEVENT WaitForSingleObject + +#endif + +#endif /* __WINE_WINE_FEVENT_H */ -- 1.4.4.2

May 12, 2007

include: Include local not system sql.h header

by Andrew Talbot

I have just sent in a patch to use Wine's sql.h instead of the system one, because I noticed that the latter includes <sqltypes.h>, which appears to redefine DWORD as unsigned long, based on its reckoning that the size of a long integer is four bytes on default platforms, whereas - with _MSC_VER undefined - DWORD is an unsigned int. However, I now see that Wine's sql.h includes sqltypes.h, too. So my patch may be unnecessary or wrong, but should odbcinst.h preceed its inclusion of sql.h with some sort of definition of SIZEOF_LONG to prevent this redefinition? Please advise. Thanks, -- Andy.

May 12, 2007

Re: PATCH - implement LockWorkStation using xdg-screensaver

by Stefan Dösinger

Am Samstag 12 Mai 2007 12:13 schrieb Steven Edwards: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashing and still does not properly lock the > workstation. I am not quite sure why. Perhaps someone else is > interested in this to help improve wine usability. Also I guess I > should use HeapAlloc rather than malloc. Yeah, you should use HeapAlloc, and perhaps remove the xmalloc() wrapper :-) . If you test for the existence of xdg-screensaver that way you should close the opened file afterwards. If I remember correctly execvp would check $PATH for the file, so you don't have to hardcode /usr/bin/xdg-screensaver, but I think some "winescreensaver" program simmilar to winebrowser which is configureable via a registry setting would be even better. Also you should return TRUE and FALSE instead of 1 and 0.

May 12, 2007

Re: Small Direct3D milestone

by Vitaly Budovski

Martin Owens wrote: > Woot, thank you so much! > > Stefan D�singer, is this a time to ask you for help getting the really > really easy bug in X11DRV_DIB_MapColor, oh go on pretty please with > sugar on top? > > http://bugs.winehq.org/show_bug.cgi?id=6670 > It looks like a duplicate of http://bugs.winehq.org/show_bug.cgi?id=2666 I sent some patches to the mailing list earlier, so when they are applied it should be fixed. http://www.winehq.org/pipermail/wine-patches/2007-May/039073.html http://www.winehq.org/pipermail/wine-patches/2007-May/039074.html http://www.winehq.org/pipermail/wine-patches/2007-May/039075.html

May 12, 2007

Re: [PATCH] initialize pSurface, since we process it on failure

by Stefan Dösinger

Am Samstag 12 Mai 2007 11:39 schrieb Marcus Meissner: > Hi, > > Not sure if we should perhaps not do the ICOM CAST magic on a failing > CreateSurface call here. > > But initializing pSurface to NULL also helps. The ICOM_CAST thing should set the output to NULL of the surface returned by ddraw7_CreateSurface is NULL, but ddraw7 doesn't always set it to NULL. I wanted to write a test for this because some calls leave the output pointer untouched if they fail and some set it to NULL. AJ also says we should replace transgamings com casting macros with inline functions.

May 12, 2007

Re: Internet explorer not detected

by Stefan Dösinger

> really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I > don't really feel sorry for apps that assume everything is running "Program Files" isn't hardcoded either, like on my German locale its "Programme".

May 12, 2007

Re: Small Direct3D milestone

by Stefan Dösinger

Am Samstag 12 Mai 2007 06:12 schrieb Martin Owens: > Woot, thank you so much! > > Stefan Dösinger, is this a time to ask you for help getting the really > really easy bug in X11DRV_DIB_MapColor, oh go on pretty please with > sugar on top? > > http://bugs.winehq.org/show_bug.cgi?id=6670 I'm sorry, but I don't know that part of the winex11.drv code. It seems to be unrelated to directx.

May 12, 2007

Re: Current behavior of netapi32-access tests on W2K3 and Vista

by Kai Blin

On Friday 11 May 2007 20:08, Paul Vriens wrote: > Hi, > > Not so long ago some tests where added for NetUserAdd and friends. While > browsing I found that I have about 6 testuser home directories on W2K3 and > 4 on Vista (which is the amount of tests I ran on those platforms). Whoops, sorry about that. I didn't have any of those to test before. I'll make sure any additional tests I write in that area will pass on at least win2k3. > Bottom-line is that NetUserDel doesn't delete the home-directory on W2K3 > and Vista (which is a good thing) but has no option to delete it explicitly > (which is a bad thing IMHO). Agreed. :) > Any idea how to cleanup after these tests? Just remove the home directory? I poked around on MSDN a little, but I didn't find anything useful. I'll give this a go with DeleteFile. Thanks for pointing this out. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

May 12, 2007

Re: Small Direct3D milestone

by Martin Owens

Woot, thank you so much! Stefan Dösinger, is this a time to ask you for help getting the really really easy bug in X11DRV_DIB_MapColor, oh go on pretty please with sugar on top? http://bugs.winehq.org/show_bug.cgi?id=6670 On 11/05/07, Raymond Barbiero <EJGYBOGOIPSJ(a)spammotel.com> wrote: > > >> continueing work on software or shader emulation of it. I considered > > >> vertex blending a somewhat academic feature. > > FYI, I get similar vertex blending errors playing Oblivion. > > > >

May 11, 2007

Re: Internet explorer not detected

by James Hawkins

On 5/11/07, richardvoigt(a)gmail.com <richardvoigt(a)gmail.com> wrote: > On 5/11/07, James Hawkins <truiken(a)gmail.com> wrote: > > On 5/11/07, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > > > Hi, i tried help this dude on IRC channel getting an application to run called > > > MegaSpoof. Even after creating fake registry key it kept complaining about > > > missing Internet Explorer. > > > After looking through the +relay log i found this: > > > 000d:Call KERNEL32.CreateProcessW(00000000,0034f428 L"c:\\Program > > > Files\\Internet Explorer\\iexplore.exe -Embedding",0000000 > > > 0,00000000,00000000,00000000,00000000,00000000,0034f7d8,0034f828) ret=77f1d75f > > > 000d:Ret KERNEL32.CreateProcessW() retval=00000000 ret=77f1d75f > > > > > > > > > In current wine a simple "wine "c:\Program Files\Internet > > > Explorer\iexplore.exe"" just fails , because we don't have that directory. After > > > manually creating it , and copy iexplore.exe.so to /Program Files/Internet > > > Explorer/iexplore.exe, the application didn't complain anymore, and got further. > > > > > > Question: do we need to mimic windows behaviour, and create that directory + put > > > wine's iexplore in it, or is the policy that in this case we just have to > > > download MS ie6, and install that (as the application suggested) > > > > > > > c:\Program Files\Internet Explorer is where iexplore.exe is put in XP, > > so I think we should mimic that. It wouldn't be hard to add that to > > wine.inf:[FakeDllsSection]. > > > > really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I > don't really feel sorry for apps that assume everything is running > from C: > Actually, in setupapi it's: DIRID_PROGRAM_FILES,"Internet Explorer",iexplore.exe but I didn't think anyone would nitpick an obvious example, so I didn't spell it out the first time around. -- James Hawkins

May 11, 2007

Re: Internet explorer not detected

by richardvoigt＠gmail.com

On 5/11/07, James Hawkins <truiken(a)gmail.com> wrote: > On 5/11/07, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > > Hi, i tried help this dude on IRC channel getting an application to run called > > MegaSpoof. Even after creating fake registry key it kept complaining about > > missing Internet Explorer. > > After looking through the +relay log i found this: > > 000d:Call KERNEL32.CreateProcessW(00000000,0034f428 L"c:\\Program > > Files\\Internet Explorer\\iexplore.exe -Embedding",0000000 > > 0,00000000,00000000,00000000,00000000,00000000,0034f7d8,0034f828) ret=77f1d75f > > 000d:Ret KERNEL32.CreateProcessW() retval=00000000 ret=77f1d75f > > > > > > In current wine a simple "wine "c:\Program Files\Internet > > Explorer\iexplore.exe"" just fails , because we don't have that directory. After > > manually creating it , and copy iexplore.exe.so to /Program Files/Internet > > Explorer/iexplore.exe, the application didn't complain anymore, and got further. > > > > Question: do we need to mimic windows behaviour, and create that directory + put > > wine's iexplore in it, or is the policy that in this case we just have to > > download MS ie6, and install that (as the application suggested) > > > > c:\Program Files\Internet Explorer is where iexplore.exe is put in XP, > so I think we should mimic that. It wouldn't be hard to add that to > wine.inf:[FakeDllsSection]. > really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I don't really feel sorry for apps that assume everything is running from C: > -- > James Hawkins > > >

May 11, 2007

Re: Small Direct3D milestone

by Chris Morgan

> (*) Alexandre, if you want to freeze now its ok with me :-) The current d3d > code is feature rich enough for 1.0 IMHO, but of course I'll try to get the > fundamentals of more in :-) On that topic, I'd like as much advance notice of a 1.0 release as possible, I'll even swear to silence if a date is suspected but doesn't want to be made public yet. There are several areas of the appdb that should be improved prior to the 1.0 release and while we are making progress it might take a month or so of serious hacking to get things into the kind of shape we'd like to be in for the users that will arrive when 1.0 drops. Chris

May 11, 2007

Re: Small Direct3D milestone

by Stefan Dösinger

Am Freitag 11 Mai 2007 22:54 schrieb H. Verbeet: > On 11/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > Where to go from here? > > D3D8 :-) Yeah, thats the other thing of course :-) But as I said even d3d7 and ddraw had a few biggies I want to fix. Of course I may grab some low hanging fruits like kicking out the fvf code from d3d8 and wined3d :-) Or get the sdk demos going, they should all work now by looking at their names. The plan is still to sort as many biggies out before the 1.0 freeze(*). The sole difference between .36 and .37 from that regard are a few little fixes specific to the d3d7 sdk and bumpenv mapping implemented. Nothing that gets us as far as working multithreaded d3d. Stefan, (*) Alexandre, if you want to freeze now its ok with me :-) The current d3d code is feature rich enough for 1.0 IMHO, but of course I'll try to get the fundamentals of more in :-)

May 11, 2007

Re: Small Direct3D milestone . Thank you - Wine team!

by Thorsten Kani

Fascinating work - please continue it! Please note that i am exited from Wine as a whole - without people doing the 'unsexy' jobs (eg: COM Work...), Wine would never be succesful. ;) so long, Thorsten Stefan Dösinger schrieb: > Hi! > > With Wine 0.9.37 we've archieved something that I allow myself to call a small > milestone - All Direct3D7 Immediate mode SDK demos successfully perform their > intended rendering. I have some screenshots on my university junk server: > > http://stud4.tuwien.ac.at/~e0526822/sdkdemos1.png > http://stud4.tuwien.ac.at/~e0526822/sdkdemos2.png > > Two major problems are left though, namely windowed opengl rendering(see the > junk where a menu bar should be) and GetDC(there should be a little bit of > text rendered, I disabled render target locking to get proper performance). > > Some demos have a few smaller problems too. The bump earth and bump waves need > vendor specific extensions(GL_NV_texture_shader2 / GL_ATI_envmap_bumpmap) and > the bend demo needs GL_ARB_vertex_blend which nvidia does not support. So I > took that screenshot on my mac running linux(ati radeon X1600. The mipmap > demo renders the mipmaped texture garbled, although this works on nvidia > cards. The Z buffer demo says w buffers aren't supported, but the normal z > buffer does what the w buffer is supposed to do. > > What does that mean for gamers? Nothing fancy really, the features used by > games are implemented since a long time, the ones that used to miss(fixed > function bump mapping, vertex blending) aren't really important for games. > Other DirectDraw features like Overlays aren't implemented either, but we are > Direct3D 7 feature complete. > > Where to go from here? I am currently fixing the DirectDraw rewrite > regressions I can get hold of, and I am trying to make D3D thread safe > finally. From the application point of view my focus will stay on fixing > older apps first, which somewhat includes getting thread safety, render > target locking and GetDC working properly. My hope is also to fix the other > related DX7 sdk demos, like the DDraw demos(except overlays, they are highly > tricky with the current wined3d-x11drv integration) and getting native > d3drm.dll working. > > I also want to say thanks to all the small and big helpers who help with > technical advise, debugging and regression testing. Special thanks goes to > Henri without whom I'd be totally lost and who has to be credited for a huge > majority of the shader work in the last half year, and a lot of other things > too. > > Thanks and continue the good work :-) > Stefan > > PS: As for the screenshots, my space on that server is limited, so they will > be gone sooner or later. I didn't want to send huge screenshots as > attachments, not even as jpgs. > > >

May 11, 2007

Re: Internet explorer not detected

by James Hawkins

On 5/11/07, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, i tried help this dude on IRC channel getting an application to run called > MegaSpoof. Even after creating fake registry key it kept complaining about > missing Internet Explorer. > After looking through the +relay log i found this: > 000d:Call KERNEL32.CreateProcessW(00000000,0034f428 L"c:\\Program > Files\\Internet Explorer\\iexplore.exe -Embedding",0000000 > 0,00000000,00000000,00000000,00000000,00000000,0034f7d8,0034f828) ret=77f1d75f > 000d:Ret KERNEL32.CreateProcessW() retval=00000000 ret=77f1d75f > > > In current wine a simple "wine "c:\Program Files\Internet > Explorer\iexplore.exe"" just fails , because we don't have that directory. After > manually creating it , and copy iexplore.exe.so to /Program Files/Internet > Explorer/iexplore.exe, the application didn't complain anymore, and got further. > > Question: do we need to mimic windows behaviour, and create that directory + put > wine's iexplore in it, or is the policy that in this case we just have to > download MS ie6, and install that (as the application suggested) > c:\Program Files\Internet Explorer is where iexplore.exe is put in XP, so I think we should mimic that. It wouldn't be hard to add that to wine.inf:[FakeDllsSection]. -- James Hawkins

May 11, 2007

Internet explorer not detected

by Louis Lenders

Hi, i tried help this dude on IRC channel getting an application to run called MegaSpoof. Even after creating fake registry key it kept complaining about missing Internet Explorer. After looking through the +relay log i found this: 000d:Call KERNEL32.CreateProcessW(00000000,0034f428 L"c:\\Program Files\\Internet Explorer\\iexplore.exe -Embedding",0000000 0,00000000,00000000,00000000,00000000,00000000,0034f7d8,0034f828) ret=77f1d75f 000d:Ret KERNEL32.CreateProcessW() retval=00000000 ret=77f1d75f In current wine a simple "wine "c:\Program Files\Internet Explorer\iexplore.exe"" just fails , because we don't have that directory. After manually creating it , and copy iexplore.exe.so to /Program Files/Internet Explorer/iexplore.exe, the application didn't complain anymore, and got further. Question: do we need to mimic windows behaviour, and create that directory + put wine's iexplore in it, or is the policy that in this case we just have to download MS ie6, and install that (as the application suggested)

May 11, 2007

Re: Small Direct3D milestone

by Raymond Barbiero

> >> continueing work on software or shader emulation of it. I considered > >> vertex blending a somewhat academic feature. FYI, I get similar vertex blending errors playing Oblivion.

May 11, 2007

Re: Small Direct3D milestone

by Mirek

Mirek napsal(a): > Stefan Dösinger napsal(a): >> Am Freitag 11 Mai 2007 22:25 schrieb Mirek: >>> I have one game (Polda 5 Czech version only) which is unplayable without >>> vertex blending, with latest wine and my nvidia card it looks better, >>> but it is still not perfect (I have registry key for software >>> emulation), If you want, I can send you some debuging output, or >>> screenshot. So SDK demos are realy useful to get wine work with more >>> apps. >> I suppose you also have my software vertex emulation patches in, >> right? Screenshots would be good to look at. If there's really a game >> out there that doesn't work without this feature there's a point in >> continueing work on software or shader emulation of it. I considered >> vertex blending a somewhat academic feature. > > Here is log message and some screenshots > http://62.240.181.87/Mirek/wine/Polda%205/ > > Official game site: http://www.polda5.cz/ > > Characters and dynamicaly created objects are broken (but now with > 0.9.37 not unplayable), it is game from year 2005. > I forgot add link to download demo: http://www.polda5.cz/Download/Polda5Demo.exe Mirek

May 11, 2007

Re: Small Direct3D milestone

by Mirek

Stefan Dösinger napsal(a): > Am Freitag 11 Mai 2007 22:25 schrieb Mirek: >> I have one game (Polda 5 Czech version only) which is unplayable without >> vertex blending, with latest wine and my nvidia card it looks better, >> but it is still not perfect (I have registry key for software >> emulation), If you want, I can send you some debuging output, or >> screenshot. So SDK demos are realy useful to get wine work with more apps. > I suppose you also have my software vertex emulation patches in, right? > Screenshots would be good to look at. If there's really a game out there that > doesn't work without this feature there's a point in continueing work on > software or shader emulation of it. I considered vertex blending a somewhat > academic feature. Here is log message and some screenshots http://62.240.181.87/Mirek/wine/Polda%205/ Official game site: http://www.polda5.cz/ Characters and dynamicaly created objects are broken (but now with 0.9.37 not unplayable), it is game from year 2005. Mirek

May 11, 2007

Re: Small Direct3D milestone

by H. Verbeet

On 11/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Where to go from here? D3D8 :-)

May 11, 2007

Re: Small Direct3D milestone

by Stefan Dösinger

Am Freitag 11 Mai 2007 22:25 schrieb Mirek: > I have one game (Polda 5 Czech version only) which is unplayable without > vertex blending, with latest wine and my nvidia card it looks better, > but it is still not perfect (I have registry key for software > emulation), If you want, I can send you some debuging output, or > screenshot. So SDK demos are realy useful to get wine work with more apps. I suppose you also have my software vertex emulation patches in, right? Screenshots would be good to look at. If there's really a game out there that doesn't work without this feature there's a point in continueing work on software or shader emulation of it. I considered vertex blending a somewhat academic feature.

May 11, 2007

Re: Small Direct3D milestone

by Mirek

Coool!! Stefan Dösinger napsal(a): > Hi! > > With Wine 0.9.37 we've archieved something that I allow myself to call a small > milestone - All Direct3D7 Immediate mode SDK demos successfully perform their > intended rendering. I have some screenshots on my university junk server: > > http://stud4.tuwien.ac.at/~e0526822/sdkdemos1.png > http://stud4.tuwien.ac.at/~e0526822/sdkdemos2.png > > Two major problems are left though, namely windowed opengl rendering(see the > junk where a menu bar should be) and GetDC(there should be a little bit of > text rendered, I disabled render target locking to get proper performance). > > Some demos have a few smaller problems too. The bump earth and bump waves need > vendor specific extensions(GL_NV_texture_shader2 / GL_ATI_envmap_bumpmap) and > the bend demo needs GL_ARB_vertex_blend which nvidia does not support. So I > took that screenshot on my mac running linux(ati radeon X1600. The mipmap > demo renders the mipmaped texture garbled, although this works on nvidia > cards. The Z buffer demo says w buffers aren't supported, but the normal z > buffer does what the w buffer is supposed to do. > > What does that mean for gamers? Nothing fancy really, the features used by > games are implemented since a long time, the ones that used to miss(fixed > function bump mapping, vertex blending) aren't really important for games. > Other DirectDraw features like Overlays aren't implemented either, but we are > Direct3D 7 feature complete. I have one game (Polda 5 Czech version only) which is unplayable without vertex blending, with latest wine and my nvidia card it looks better, but it is still not perfect (I have registry key for software emulation), If you want, I can send you some debuging output, or screenshot. So SDK demos are realy useful to get wine work with more apps. > > Where to go from here? I am currently fixing the DirectDraw rewrite > regressions I can get hold of, and I am trying to make D3D thread safe > finally. From the application point of view my focus will stay on fixing > older apps first, which somewhat includes getting thread safety, render > target locking and GetDC working properly. My hope is also to fix the other > related DX7 sdk demos, like the DDraw demos(except overlays, they are highly > tricky with the current wined3d-x11drv integration) and getting native > d3drm.dll working. > > I also want to say thanks to all the small and big helpers who help with > technical advise, debugging and regression testing. Special thanks goes to > Henri without whom I'd be totally lost and who has to be credited for a huge > majority of the shader work in the last half year, and a lot of other things > too. > > Thanks and continue the good work :-) > Stefan > > PS: As for the screenshots, my space on that server is limited, so they will > be gone sooner or later. I didn't want to send huge screenshots as > attachments, not even as jpgs. > Mirek

May 11, 2007

mandriva rpm wine 0.9.37

by marco

As I have still no way to upload the mandriva wine rpm to the official winehq download server. I put it on my own website. So mandriva users you can download the latest wine binaries here: http://www.xs4all.nl/~meijer2/wine/ kind regard, Marco

May 11, 2007

Small Direct3D milestone

by Stefan Dösinger

Hi! With Wine 0.9.37 we've archieved something that I allow myself to call a small milestone - All Direct3D7 Immediate mode SDK demos successfully perform their intended rendering. I have some screenshots on my university junk server: http://stud4.tuwien.ac.at/~e0526822/sdkdemos1.png http://stud4.tuwien.ac.at/~e0526822/sdkdemos2.png Two major problems are left though, namely windowed opengl rendering(see the junk where a menu bar should be) and GetDC(there should be a little bit of text rendered, I disabled render target locking to get proper performance). Some demos have a few smaller problems too. The bump earth and bump waves need vendor specific extensions(GL_NV_texture_shader2 / GL_ATI_envmap_bumpmap) and the bend demo needs GL_ARB_vertex_blend which nvidia does not support. So I took that screenshot on my mac running linux(ati radeon X1600. The mipmap demo renders the mipmaped texture garbled, although this works on nvidia cards. The Z buffer demo says w buffers aren't supported, but the normal z buffer does what the w buffer is supposed to do. What does that mean for gamers? Nothing fancy really, the features used by games are implemented since a long time, the ones that used to miss(fixed function bump mapping, vertex blending) aren't really important for games. Other DirectDraw features like Overlays aren't implemented either, but we are Direct3D 7 feature complete. Where to go from here? I am currently fixing the DirectDraw rewrite regressions I can get hold of, and I am trying to make D3D thread safe finally. From the application point of view my focus will stay on fixing older apps first, which somewhat includes getting thread safety, render target locking and GetDC working properly. My hope is also to fix the other related DX7 sdk demos, like the DDraw demos(except overlays, they are highly tricky with the current wined3d-x11drv integration) and getting native d3drm.dll working. I also want to say thanks to all the small and big helpers who help with technical advise, debugging and regression testing. Special thanks goes to Henri without whom I'd be totally lost and who has to be credited for a huge majority of the shader work in the last half year, and a lot of other things too. Thanks and continue the good work :-) Stefan PS: As for the screenshots, my space on that server is limited, so they will be gone sooner or later. I didn't want to send huge screenshots as attachments, not even as jpgs.

May 11, 2007

Current behavior of netapi32-access tests on W2K3 and Vista

by Paul Vriens

Hi, Not so long ago some tests where added for NetUserAdd and friends. While browsing I found that I have about 6 testuser home directories on W2K3 and 4 on Vista (which is the amount of tests I ran on those platforms). Bottom-line is that NetUserDel doesn't delete the home-directory on W2K3 and Vista (which is a good thing) but has no option to delete it explicitly (which is a bad thing IMHO). Any idea how to cleanup after these tests? Just remove the home directory? Cheers, Paul.

May 11, 2007

Re: posting advertisements

by Tom Spear

On 5/10/07, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > > > It's a gmail account. Does gmail automatically append advertisements? > > > > As far as I know, gmail does not. > This mail will tell us... Like I said I thought I might have spyware, I have since managed to get internet access (as opposed to ethernet only access) for my linux machine here at work, so no more adverts.. Sorry for the spam -- Thanks Tom

May 11, 2007

Re: [d3drm/tests] d3drm is removed from Windows Vista

by Stefan Dösinger

On Friday 11 May 2007 13:52, H. Verbeet wrote: > On 11/05/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > > d3drm is removed from Windows Vista and thus we have to check if it can > > be loaded. > > I suppose that implies that any application using d3drm won't work on > Vista? Yes, I think ms stated that clearly somewhen. No idea why they removed it since it just wraps to directdraw, and native d3drm works on wine(apart of a whole lot of directdraw executebuffer bugs)

May 11, 2007

Re: kernel32: Implement most of CopyFileEx

by Dan Kegel

On 5/10/07, Kevin Koltzau <kevin(a)plop.org> wrote: > On Monday 07 May 2007 11:50 pm, Dan Kegel wrote: > > You don't have a conformance test, nor was there one for CopyFile. > > Maybe you should consider writing one, and making sure it passes > > both on Wine and Windows. > > There is a test for CopyFile in kernel32/tests/file.c Dang, missed that. (I miss a lot of stuff lately.) >if I can find some time > I plan to flesh it out further, but since CopyFile just calls CopyFileEx it > is at least partly testing this code. Yeah, but it doesn't test the feature you needed it for. If Alexandre doesn't accept the patch in a few days, you should probably add a better test, that helps convince him. > > Say, what app is this for? > > Romcenter - http://www.romcenter.com/ I don't see a bug in bugzilla for that, but a problem is mentioned in http://appdb.winehq.org/appview.php?iVersionId=6666 Does your patch fix that problem? Filing a good bug report in bugzilla for the problem your patch solves, and then referring to it from your patch, will also help get your patch accepted. -- Wine for Windows ISVs: http://kegel.com/wine/isv

May 11, 2007

Re: [d3drm/tests] d3drm is removed from Windows Vista

by H. Verbeet

On 11/05/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > d3drm is removed from Windows Vista and thus we have to check if it can be loaded. > I suppose that implies that any application using d3drm won't work on Vista?

May 11, 2007

Re: wined3d: Add hardware cursor support.

by Stefan Dösinger

Am Freitag 11 Mai 2007 02:34 schrieb Andrew Riedi: > I made a test to figure out the exact Windows behavior, and Stefand helped > me out in telling me what to test. This code behaves how it should. I > will send the test in later once I have cleaned it up. > > changelog: wined3d: Add hardware cursor support. > + if (This->hardwareCursor) DestroyCursor(This->hardwareCursor); > + if (This->haveHardwareCursor) This->haveHardwareCursor = FALSE; Is there a specific reason to test if This->haveHardwareCursor is true before setting it to false? Or would a plain This->haveHardwareCursor = FALSE work too? Otherwise looked fine to me

May 11, 2007

Re: [8/8] DDraw: Make IDirectDrawImpl thread safe

by Stefan Dösinger

Am Freitag 11 Mai 2007 11:29 schrieb Alexandre Julliard: > Stefan Dösinger <stefan(a)codeweavers.com> writes: > > @@ -2731,9 +2792,13 @@ IDirectDrawImpl_EnumSurfaces(IDirectDraw7 *iface, > > desc = surf->surface_desc; > > IDirectDrawSurface7_AddRef(ICOM_INTERFACE(surf, > > IDirectDrawSurface7)); if(Callback( ICOM_INTERFACE(surf, > > IDirectDrawSurface7), &desc, Context) != DDENUMRET_OK) + { > > + DDOBJ_UNLOCK(This); > > return DD_OK; > > + } > > It don't think you can call an arbitrary callback function with the > lock held. Makes sense. I'll write a test to see how windows behaves if another thread creates a surface while a thread sleeps in the callback.

May 11, 2007

Re: sprintfW formatting in lib\wine\string.c

by Alexandre Julliard

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > Unfortunately, looking in the code to lib\wine\string.c, it just copies the > field and ignores justification or min/max width precisions for strings, and > as it is used all over the place there's also a concern of what would be > changed by fixing it. There's no reason not to fix it, it hasn't been implemented simply because we haven't needed it yet. -- Alexandre Julliard julliard(a)winehq.org

May 11, 2007

Re: [8/8] DDraw: Make IDirectDrawImpl thread safe

by Alexandre Julliard

Stefan Dösinger <stefan(a)codeweavers.com> writes: > @@ -2731,9 +2792,13 @@ IDirectDrawImpl_EnumSurfaces(IDirectDraw7 *iface, > desc = surf->surface_desc; > IDirectDrawSurface7_AddRef(ICOM_INTERFACE(surf, IDirectDrawSurface7)); > if(Callback( ICOM_INTERFACE(surf, IDirectDrawSurface7), &desc, Context) != DDENUMRET_OK) > + { > + DDOBJ_UNLOCK(This); > return DD_OK; > + } It don't think you can call an arbitrary callback function with the lock held. -- Alexandre Julliard julliard(a)winehq.org

May 11, 2007

Re: Adds NET START to net.exe

by Alexandre Julliard

"Tim Schwartz" <tim(a)sanityinternet.com> writes: > + if(!strcasecmp(argv[1], "start")) > + { > + if(argc < 3) > + { > + printf("Specify service name to start.\n"); > + return TRUE; > + } > + > + if(!net_service(NET_START, argv[2])) > + { > + return TRUE; > + } > + return FALSE; > + } > + > + return FALSE; The previous version was better here, TRUE and FALSE are not appropriate return values for main(), it's supposed to return an error code not a boolean. -- Alexandre Julliard julliard(a)winehq.org

May 11, 2007

Re: crypt32: implement CryptSIPLoad (try 3)

by Paul Vriens

Juan Lang wrote: > - todo_wine > - { > - ok ( ret, "Expected CryptSIPLoad to succeed\n"); > - /* This error will always be there as native searches for the function DllCanUnloadNow > - * in WINTRUST.DLL (in this case). This function is not available in WINTRUST.DLL. > - * For now there's no need to implement this is Wine as I doubt any program will rely on > - * this last error when the call succeeded. > - */ > - ok ( GetLastError() == ERROR_PROC_NOT_FOUND, > - "Expected ERROR_PROC_NOT_FOUND, got 0x%08x\n", GetLastError()); > - ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > - } > + ok ( ret, "Expected CryptSIPLoad to succeed\n"); > + ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > > /* The function addresses returned by CryptSIPLoad are actually the addresses of > * crypt32's own functions. A function calling these addresses will end up first > @@ -348,18 +337,8 @@ static void test_SIPLoad(void) > sdi.cbSize = sizeof(SIP_DISPATCH_INFO); > sdi.pfGet = (pCryptSIPGetSignedDataMsg)0xdeadbeef; > ret = CryptSIPLoad(&unknown2, 0, &sdi); > - todo_wine > - { > - ok ( ret, "Expected CryptSIPLoad to succeed\n"); > - /* This call on it's own would have resulted in a ERROR_PROC_NOT_FOUND, but the previous > - * call to CryptSIPLoad already loaded wintrust.dll. As this information is cached, > - * CryptSIPLoad will not try to search for the already mentioned DllCanUnloadNow. > - */ > - } > - ok ( GetLastError() == 0xdeadbeef, > - "Expected 0xdeadbeef, got 0x%08x\n", GetLastError()); > - todo_wine > - ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > + ok ( ret, "Expected CryptSIPLoad to succeed\n"); > + ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > > /* All OK, but other SIP */ > SetLastError(0xdeadbeef); > > > ------------------------------------------------------------------------ > > Hi Juan, Why did you remove all the comments from the test? It does explain (a little bit) how native does get to this specific lasterror. I agree that the lasterror is not very valuable. I've spent quite some time figuring this stuff out and it seems that (at least to my perception) information gets lost. Cheers, Paul.

May 11, 2007

Re: kernel32: Implement most of CopyFileEx

by Kevin Koltzau

On Monday 07 May 2007 11:50 pm, Dan Kegel wrote: > You don't have a conformance test, nor was there one for CopyFile. > Maybe you should consider writing one, and making sure it passes > both on Wine and Windows. There is a test for CopyFile in kernel32/tests/file.c, if I can find some time I plan to flesh it out further, but since CopyFile just calls CopyFileEx it is at least partly testing this code. > Say, what app is this for? Romcenter - http://www.romcenter.com/

May 10, 2007

Re: posting advertisements

by Mike Schaadt

On 5/10/07, Lei Zhang <thestig(a)google.com> wrote: > On 5/10/07, nicholas.g.lawrence(a)mainroads.qld.gov.au > <nicholas.g.lawrence(a)mainroads.qld.gov.au> wrote: > > > > Check out this new 3D Instant Messenger called IMVU. It's the best I > > > > have seen yet! > > > > > How much time it needs to be asked so that you stopped posting > > advertisements? > > > If you are participating on a developers list behave accordingly. > > > > It's a gmail account. Does gmail automatically append advertisements? > > As far as I know, gmail does not. > > > No, Gmail does not append advertisements(as can be seen by the lack of advertisments on this message.)

May 10, 2007

Re: posting advertisements

by Stefan Dösinger

> > It's a gmail account. Does gmail automatically append advertisements? > > As far as I know, gmail does not. This mail will tell us...

May 10, 2007

Re: posting advertisements

by Lei Zhang

On 5/10/07, nicholas.g.lawrence(a)mainroads.qld.gov.au <nicholas.g.lawrence(a)mainroads.qld.gov.au> wrote: > > > Check out this new 3D Instant Messenger called IMVU. It's the best I > > > have seen yet! > > > How much time it needs to be asked so that you stopped posting > advertisements? > > If you are participating on a developers list behave accordingly. > > It's a gmail account. Does gmail automatically append advertisements? As far as I know, gmail does not.

May 10, 2007

Re: posting advertisements

by Chris Morgan

> ************************************************************ > Opinions contained in this e-mail do not necessarily reflect > the opinions of the Queensland Department of Main Roads, > Queensland Transport or Maritime Safety Queensland, or > endorsed organisations utilising the same infrastructure. > If you have received this electronic mail message in error, > please immediately notify the sender and delete the message > from your computer. > ************************************************************ > > You post complaining about advertising and in your post you include this legal notice of questionable enforceability? hah Chris

May 10, 2007

posting advertisements

by nicholas.g.lawrence＠mainroads.qld.gov.au

> > Check out this new 3D Instant Messenger called IMVU. It's the best I > > have seen yet! > How much time it needs to be asked so that you stopped posting advertisements? > If you are participating on a developers list behave accordingly. It's a gmail account. Does gmail automatically append advertisements? Another option is that it is a virus that is appending the message. The third option is that the poster deliberately put said message in their sig nick ************************************************************ Opinions contained in this e-mail do not necessarily reflect the opinions of the Queensland Department of Main Roads, Queensland Transport or Maritime Safety Queensland, or endorsed organisations utilising the same infrastructure. If you have received this electronic mail message in error, please immediately notify the sender and delete the message from your computer. ************************************************************

May 10, 2007

Re: [4/8] WineD3D: Destroying the resource frees all private data

by Stefan Dösinger

Am Donnerstag 10 Mai 2007 22:33 schrieb H. Verbeet: > On 10/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > - } > > + }; > > Any particular reason for this change? I don't think so. Must have slipped in accidentally. > > + if (Flags & WINED3DSPD_IUNKNOWN) { > > + if(SizeOfData != 4) { > > + WARN("IUnknown data with size %d, returning > > WINED3DERR_INVALIDCALL\n", SizeOfData); + return > > WINED3DERR_INVALIDCALL; > > This looks rather questionable to me. Are you making an assumption > about the size of a pointer here or is 4 some magic constant? Indeed :-/ I just hardcoded 4 as sizeof IUnknown * thoughlessly. We should test that on 64 bit machines, but I guess that sizeof(IUnknown *) is more correct. Does anyone have a 64 bit windows set up to test that?

May 10, 2007

Re: [PATCH 2/2] msi: automation: Implement Installer::RegistryValue.

by Misha Koshelev

On Thu, 2007-05-10 at 12:13 +0200, Alexandre Julliard wrote: > Misha Koshelev <mk144210(a)bcm.edu> writes: > > > + case VT_BSTR: /* Return value of specified key if it exists */ > > + if (ret == ERROR_SUCCESS) > > + { > > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, NULL, NULL, &dwSize); > > + if (ret == ERROR_SUCCESS) > > + { > > + szString = msi_alloc(dwSize); > > + if (szString) > > + { > > + LPWSTR szNewString = NULL; > > + DWORD dwType, dwNewSize = 0; > > + int idx; > > + > > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, &dwType, (LPBYTE)szString, &dwSize); > > + switch (dwType) > > + { > > + /* Registry strings may not be null terminated */ > > + case REG_MULTI_SZ: > > + idx = (dwSize/sizeof(WCHAR))-1; > > + while (idx >= 0 && !szString[idx]) idx--; > > + for (; idx >= 0; idx--) > > + if (!szString[idx]) szString[idx] = '\n'; > > [...] > > This stuff clearly needs to be split out into a few helper functions. > Just sent a new one, mainly with one additional helper function and some if/else condensation. Please let me know if you believe I need to make more helpers. Thank you. Misha

May 10, 2007

Re: [4/8] WineD3D: Destroying the resource frees all private data

by H. Verbeet

On 10/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - } > + }; Any particular reason for this change? > + if (Flags & WINED3DSPD_IUNKNOWN) { > + if(SizeOfData != 4) { > + WARN("IUnknown data with size %d, returning WINED3DERR_INVALIDCALL\n", SizeOfData); > + return WINED3DERR_INVALIDCALL; This looks rather questionable to me. Are you making an assumption about the size of a pointer here or is 4 some magic constant? > - list_add_tail(&This->resource.privateData, &data->entry); > - return WINED3D_OK; > - ... > + list_init(&data->entry); > + list_add_tail(&This->resource.privateData, &data->entry); > > return WINED3D_OK; Is the added list_init() intentional here? Looks redundant to me, if you're doing a list_add_tail() right afterwards anyway.

May 10, 2007

Re: [5/8] WineD3D: Implement DDBLT_DEPTHFILL on the active depth stencil target

by Stefan Dösinger

Am Donnerstag 10 Mai 2007 21:57 schrieb Stefan Dösinger: > WineD3D: Implement DDBLT_DEPTHFILL on the active depth stencil target Ooops

May 10, 2007

[5/8] WineD3D: Implement DDBLT_DEPTHFILL on the active depth stencil target

by Stefan Dösinger

May 10, 2007

sprintfW formatting in lib\wine\string.c

by Ann & Jason Edmeades

Whilst trying to convert cmd to Unicode, I've stumbled across a problem which I either need to work around or fix, and I am not sure which. WCHAR h[] = {'h','e','l','l','o','\0'}; WCHAR fmt[] = {':', '%', '1', '0','s',':','\0'}; char test[255]; WCHAR result[255]; sprintf(test, "'%10s'", "hello"); sprintfW(result, fmt, h); WINE_FIXME("%s vs %s\n", test, wine_dbgstr_w(result)); Gives: fixme:cmd:WCMD_list_directory ' hello' vs L":hello:" ie sprintf of %10s means right justified field of 10 characters sprintfW of %10s gives left justified field of n characters (I haven't tried if the string is > 10, as I don't care...) Basically, the format strings in cmd rely on the padding behaviour. Is this a bug in sprintfW which needs fixing, or should I work around it? Unfortunately, looking in the code to lib\wine\string.c, it just copies the field and ignores justification or min/max width precisions for strings, and as it is used all over the place there's also a concern of what would be changed by fixing it. Any suggestions for a workable alternative? Jason

May 10, 2007

Re: blizzard conference

by Stefan Dösinger

Am Donnerstag 10 Mai 2007 19:13 schrieb Jeremy White: > > Blizzard is at least co-operating with TransGaming on World of Warcraft, > > so they are at least aware that there are Linux users out there. :) > > > > Perhaps someone could act as a representative for CodeWeavers? It might > > make Blizzard more attentive. I can try to get some info from > > TransGaming about the co-operation, if anyone thinks it would be useful. > > We have someone at Blizzard that at least responds to our emails, > although I wouldn't characterize them as especially helpful. > > However, to be honest, I'm not really aware of a lot of issues where > we have a burning need for their help. My understanding is that > it mostly works fairly well. > > Stefan, is that not true? Do we need a lot from them? Nothing huge and important really. They seem to be testing their releases with wine too, some blizzard dev said something like that on the wow forums when asked about a bug in their beta releases. Every now and then I stumble accross some things where I'd ask someone from Blizzard, but in all those cases I could find a solution myself, and most likely quicker than waiting for someone responding, making sure we talk about the same problem and then debugging the things. One thing that would be valueable to us would be to know how the Warden(the anti-cheat system) works, but I don't think Blizzard would tell us. Having someone taking us seriously for sure would be a good thing should we run into a huge problem like a mass ban like Transgaming had, or an update breaking wow in Wine/Crossover completely.

May 10, 2007

Re: blizzard conference

by Stefan Dösinger

> The closest thing I've ever seen was a steam-based hardware survey Valve > released a couple of years ago. Even then, there were tens of thousands > of Wine users playing Steam games. How did you see that? I'm always looking for "Direct3D HAL" 3D cards, but I never saw anything like that there. Though I always paritipate in the survey if steam asks me too to get a few more Direct3D HALs in :-)

May 10, 2007

Re: blizzard conference

by Scott Ritchie

On Thu, 2007-05-10 at 12:05 -0500, Tom Spear wrote: > On 5/10/07, Scott Ritchie <scott(a)open-vote.org> wrote: > > Does anyone have statistics we can present about how many Wine users > > playing Blizzard games there are out there? > > > > The closest thing I've ever seen was a steam-based hardware survey Valve > > released a couple of years ago. Even then, there were tens of thousands > > of Wine users playing Steam games. With Wine more popular now and World > > of Warcraft often working better than in Windows, it seems pretty > > reasonable that there would be even more Wine-based WoW players. > > > > > > Perhaps we could ask Blizzard to just include a simple test for Wine's > > registry key in their software and then keep statistics on it. > > I dont know about every other WoW player, but given Blizzard's history > of phoning home with previous games, I dont know how comfortable I > would be with even a check for a wine registry key that phones home > every time I play WoW. > If you're not comfortable with a Wine registry key being checked for, you definitely should not be playing WoW. The software already checks for a ton of far more personal data. Thanks, Scott Rtichie

May 10, 2007

Re: [5/5] widl: Remove var_t's ptr_level field and start write_pointers

by Dan Hipschman

On Thu, May 10, 2007 at 10:39:31AM -0700, Duane Clark wrote: > Dan Hipschman wrote: > >Well, I sent this quite a while ago and it hasn't shown up on the list yet. > >It's probably too big, so here's a link to the patch instead of inlining > >it. > > > > Patches over 80KB will go to a queue for moderation. I am the only one > moderating, so just be patient. I'll get around to it eventually. OK, I didn't know that and assumed it just got nuked. It appears to have just shown up on the list. :-) Thanks

May 10, 2007

Re: [3/5] widl: Simplify make_safearray

by Dan Hipschman

On Thu, May 10, 2007 at 10:47:26AM +0100, Robert Shearman wrote: > Dan Hipschman wrote: > >This patch just simplifies the make_safearray function. It didn't need > >to be that complicated. I tested the generated headers and typelibs > >with this patch applied (well, I do that with every patch in this series), > >and this doesn't change anything. > > > > Is dlls/oleaut32/tests/tmarshal.tlb identical compared to before this > patch is applied? If not, you won't get test failures in Wine, but you > will when running tests in Windows. Yes, I basically just use find -name '*.tlb' on the wine tree, so I get all the typelibs. Then I use the equivalent of hexdump | diff to check that they don't change (other than the two-byte timestamp).

May 10, 2007

Re: blizzard conference

by Jeremy White

> Blizzard is at least co-operating with TransGaming on World of Warcraft, so > they are at least aware that there are Linux users out there. :) > > Perhaps someone could act as a representative for CodeWeavers? It might make > Blizzard more attentive. I can try to get some info from TransGaming about > the co-operation, if anyone thinks it would be useful. We have someone at Blizzard that at least responds to our emails, although I wouldn't characterize them as especially helpful. However, to be honest, I'm not really aware of a lot of issues where we have a burning need for their help. My understanding is that it mostly works fairly well. Stefan, is that not true? Do we need a lot from them? Cheers, Jeremy

May 10, 2007

Re: blizzard conference

by Alexander Nicolaysen Sørnes

Torsdag 10 mai 2007 18:46, skrev Scott Ritchie: > On Tue, 2007-05-08 at 08:22 +0200, Kai Blin wrote: > > On Tuesday 08 May 2007 05:34, Dan Kegel wrote: > > > Hey, that's only an hour away, maybe I / Lei / Nigel can drop by. > > > > > > But what's the "itchy /etc/hosts bug"? Is that > > > http://bugs.winehq.org/show_bug.cgi?id=7929 ? > > > > I would assume so. I don't know if telling them is going to fix anything, > > though. For new games, I hope they're not using > > gethostbyname(gethostname()) anyway. For the other issues that are > > hitting us with that bug, all seem to be valid winsock programming. I'd > > rather have someone talk to them about better overall wine compatibility. > > Does anyone have statistics we can present about how many Wine users > playing Blizzard games there are out there? > > The closest thing I've ever seen was a steam-based hardware survey Valve > released a couple of years ago. Even then, there were tens of thousands > of Wine users playing Steam games. With Wine more popular now and World > of Warcraft often working better than in Windows, it seems pretty > reasonable that there would be even more Wine-based WoW players. > > > Perhaps we could ask Blizzard to just include a simple test for Wine's > registry key in their software and then keep statistics on it. > Blizzard is at least co-operating with TransGaming on World of Warcraft, so they are at least aware that there are Linux users out there. :) Perhaps someone could act as a representative for CodeWeavers? It might make Blizzard more attentive. I can try to get some info from TransGaming about the co-operation, if anyone thinks it would be useful. Regards, Alexander N. Sørnes > Thanks, > Scott Ritchie

May 10, 2007

Re: blizzard conference

by Tom Spear

On 5/10/07, Scott Ritchie <scott(a)open-vote.org> wrote: > Does anyone have statistics we can present about how many Wine users > playing Blizzard games there are out there? > > The closest thing I've ever seen was a steam-based hardware survey Valve > released a couple of years ago. Even then, there were tens of thousands > of Wine users playing Steam games. With Wine more popular now and World > of Warcraft often working better than in Windows, it seems pretty > reasonable that there would be even more Wine-based WoW players. > > > Perhaps we could ask Blizzard to just include a simple test for Wine's > registry key in their software and then keep statistics on it. I dont know about every other WoW player, but given Blizzard's history of phoning home with previous games, I dont know how comfortable I would be with even a check for a wine registry key that phones home every time I play WoW. -- Thanks Tom

May 10, 2007

Re: blizzard conference

by Scott Ritchie

On Tue, 2007-05-08 at 08:22 +0200, Kai Blin wrote: > On Tuesday 08 May 2007 05:34, Dan Kegel wrote: > > Hey, that's only an hour away, maybe I / Lei / Nigel can drop by. > > > > But what's the "itchy /etc/hosts bug"? Is that > > http://bugs.winehq.org/show_bug.cgi?id=7929 ? > > I would assume so. I don't know if telling them is going to fix anything, > though. For new games, I hope they're not using gethostbyname(gethostname()) > anyway. For the other issues that are hitting us with that bug, all seem to > be valid winsock programming. I'd rather have someone talk to them about > better overall wine compatibility. Does anyone have statistics we can present about how many Wine users playing Blizzard games there are out there? The closest thing I've ever seen was a steam-based hardware survey Valve released a couple of years ago. Even then, there were tens of thousands of Wine users playing Steam games. With Wine more popular now and World of Warcraft often working better than in Windows, it seems pretty reasonable that there would be even more Wine-based WoW players. Perhaps we could ask Blizzard to just include a simple test for Wine's registry key in their software and then keep statistics on it. Thanks, Scott Ritchie

May 10, 2007

Re: [PATCH] Uninstaller: Use a define'd length instead of a magicnumber

by Dmitry Timoshkov

"Tom Spear" <speeddymon(a)gmail.com> wrote: > On 5/10/07, James Hawkins <truiken(a)gmail.com> wrote: >> Yes, you should make a new define. MAX_STRING_LEN is the maximum >> length for a string from the resource file, which is totally unrelated >> to the limit for the length of a subkey name. > Should the new define be put in resource.h, main.c, or somewhere else entirely? It depends in how much source files it actually used. If it's going to be used only in 1 source file then put it in that file only. > Check out this new 3D Instant Messenger called IMVU. It's the best I > have seen yet! How much time it needs to be asked so that you stopped posting advertisements? If you are participating on a developers list behave accordingly. -- Dmitry.

May 10, 2007

Re: [PATCH] Uninstaller: Use a define'd length instead of a magic number

by Tom Spear

On 5/10/07, James Hawkins <truiken(a)gmail.com> wrote: > Yes, you should make a new define. MAX_STRING_LEN is the maximum > length for a string from the resource file, which is totally unrelated > to the limit for the length of a subkey name. Should the new define be put in resource.h, main.c, or somewhere else entirely? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

May 10, 2007

Re: [PATCH] Uninstaller: Use a define'd length instead of a magic number

by James Hawkins

On 5/10/07, Tom Spear <speeddymon(a)gmail.com> wrote: > MAX_STRING_LEN is defined in resource.h at 255. According to > http://msdn2.microsoft.com/en-us/library/ms724872.aspx the limit for > the length of a subkey name is 255. > > >> Please let me know if I should make a new define instead of using > MAX_STRING_LEN. > Yes, you should make a new define. MAX_STRING_LEN is the maximum length for a string from the resource file, which is totally unrelated to the limit for the length of a subkey name. -- James Hawkins

May 10, 2007

Re: Adds NET START to net.exe

by Dmitry Timoshkov

"Tim Schwartz" <tim(a)sanityinternet.com> wrote: > + GetServiceDisplayName(SCManager, service_name, NULL, &buffer_size); > + if(!buffer_size) You need to check the GetServiceDisplayName retrun value, not buffer_size. If GetServiceDisplayName succeeds buffer_size contains valid length. Also please numerate your retries, like "Take 3" or something like that. -- Dmitry.

May 10, 2007

Re: [3 and 4/4] Some console improvements: console codepages - please, comment.

by Alexandre Julliard

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > [move codepages to server side] > http://www.winehq.org/pipermail/wine-patches/2007-May/039093.html > > Please, comment, what I did wrong? Did I miss something important? You didn't send the changes to protocol.def (also your sequence numbering is wrong, if the test requires the patch to succeed then it should come after it). -- Alexandre Julliard julliard(a)winehq.org

May 10, 2007

[3 and 4/4] Some console improvements: console codepages - please, comment.

by Kirill K. Smirnov

Hi, In my serie of four patches the two has not been applied: [kernel32/tests: Add tests for console codepages] http://www.winehq.org/pipermail/wine-patches/2007-May/039092.html [move codepages to server side] http://www.winehq.org/pipermail/wine-patches/2007-May/039093.html Please, comment, what I did wrong? Did I miss something important? Thanks -- Kirill

May 10, 2007

Re: [5/5] widl: Remove var_t's ptr_level field and start write_pointers

by Alexandre Julliard

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > Well, I sent this quite a while ago and it hasn't shown up on the list yet. > It's probably too big, so here's a link to the patch instead of inlining it. Please don't do that. You can gzip the patch if necessary, but please send it by mail. -- Alexandre Julliard julliard(a)winehq.org

May 10, 2007

Re: [PATCH 2/2] msi: automation: Implement Installer::RegistryValue.

by Alexandre Julliard

Misha Koshelev <mk144210(a)bcm.edu> writes: > + case VT_BSTR: /* Return value of specified key if it exists */ > + if (ret == ERROR_SUCCESS) > + { > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, NULL, NULL, &dwSize); > + if (ret == ERROR_SUCCESS) > + { > + szString = msi_alloc(dwSize); > + if (szString) > + { > + LPWSTR szNewString = NULL; > + DWORD dwType, dwNewSize = 0; > + int idx; > + > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, &dwType, (LPBYTE)szString, &dwSize); > + switch (dwType) > + { > + /* Registry strings may not be null terminated */ > + case REG_MULTI_SZ: > + idx = (dwSize/sizeof(WCHAR))-1; > + while (idx >= 0 && !szString[idx]) idx--; > + for (; idx >= 0; idx--) > + if (!szString[idx]) szString[idx] = '\n'; > [...] This stuff clearly needs to be split out into a few helper functions. -- Alexandre Julliard julliard(a)winehq.org

May 10, 2007

Re: [PATCH 02/11] [Kernel32]: ActCtx: Added infrastructure for loading a manifest (app,

by Alexandre Julliard

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > + hFile = CreateFileW(name, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, 0); > + if (hFile != INVALID_HANDLE_VALUE) > + { > + hMap = CreateFileMappingW(hFile, NULL, PAGE_READONLY, 0, 0, NULL); > + if (hMap != INVALID_HANDLE_VALUE) > + { CreateFileMapping returns 0 on error. > + base = MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, 0); > + if (base) > + { > + HANDLE hModule = (HMODULE)(ULONG_PTR)base; > + > + if (RtlImageNtHeader(hModule)) /* we got a PE file */ > + { > + if (first) > + { > + LPWSTR manifestfile; > + > + manifestfile = HeapAlloc(GetProcessHeap(), 0, > + lstrlenW(name) * sizeof(WCHAR) + sizeof(dotManifestW)); > + if (manifestfile) > + { > + strcpyW(manifestfile, name); > + strcatW(manifestfile, dotManifestW); > + ret = get_manifest_in_file(acl, ai, manifestfile, > + resname, FALSE); > + HeapFree(GetProcessHeap(), 0, manifestfile); > + } > + } > + if (ret) ret = get_manifest_in_module(acl, ai, hModule, resname); You cannot pretend that a file mapping is a module and call resource functions on it. You have to use LOAD_LIBRARY_AS_DATAFILE for that. I don't think this patch series is quite ready to go in; this is the third resend and all patches still have obvious bugs. You need to spend more time on it, this is kernel stuff, it needs to be correct. -- Alexandre Julliard julliard(a)winehq.org

May 10, 2007

Re: [PATCH 01/11] [Kernel32]: ActCtx: added basic structures for storing assembly information

by Alexandre Julliard

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > + if (actctx->num_assemblies == actctx->allocated_assemblies) > + { > + if (actctx->allocated_assemblies) > + { > + actctx->allocated_assemblies *= 2; > + actctx->assemblies = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + actctx->assemblies, > + actctx->allocated_assemblies * sizeof(struct assembly)); > + } > + else > + { > + actctx->allocated_assemblies = 1; > + actctx->assemblies = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct assembly)); > + } > + } > + if (!actctx->assemblies) return NULL; You will corrupt the previous state if the realloc fails. This is kernel stuff, please try to be rigorous about error handling. -- Alexandre Julliard julliard(a)winehq.org

May 10, 2007

Re: [3/5] widl: Simplify make_safearray

by Robert Shearman

Dan Hipschman wrote: > This patch just simplifies the make_safearray function. It didn't need > to be that complicated. I tested the generated headers and typelibs > with this patch applied (well, I do that with every patch in this series), > and this doesn't change anything. > Is dlls/oleaut32/tests/tmarshal.tlb identical compared to before this patch is applied? If not, you won't get test failures in Wine, but you will when running tests in Windows. -- Rob Shearman

May 10, 2007