May 2007 - Wine-Devel - list.winehq.org

Re: Call for Ubuntu-wine admin

by Adam Petaccia

On Tue, 2007-05-29 at 01:28 +0200, Tomas.Zijdemans(a)student.uib.no wrote: > If someone is interested in leading the Ubuntu-wine team, please contact me. I was actually looking at how to do that earlier today. I would like to volunteer for the position.

May 30, 2007

Re: Pretty Build System (Take 3)

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Attached is a patch that reduces the verbosity of the build system by > printing the build commands in one of two formats: > COMMAND output_file > or > COMMAND input_file -> output_file > > I hope it meets Alexandre's requirements of not reducing portability > of Wine to other platforms (including Windows). The MAKEFLAGS stuff is still not portable, and I still think this belongs in make itself. Here's a quick proof of concept patch against GNU make. It needs a better algorithm for extracting the command name, and some sort of command-line option; this is left as an exercise for the reader. Index: job.c =================================================================== RCS file: /sources/make/make/job.c,v retrieving revision 1.186 diff -u -p -r1.186 job.c --- job.c 11 May 2007 20:57:21 -0000 1.186 +++ job.c 29 May 2007 21:07:47 -0000 @@ -1079,9 +1079,21 @@ start_job_command (struct child *child) /* Print out the command. If silent, we call `message' with null so it can log the working directory before the command's own error messages appear. */ + { + char *ptr, cmd[128]; - message (0, (just_print_flag || (!(flags & COMMANDS_SILENT) && !silent_flag)) - ? "%s" : (char *) 0, p); + strncpy( cmd, argv[0], sizeof(cmd)-1 ); + cmd[sizeof(cmd)-1] = 0; + if (!strcmp(cmd,"/bin/sh")) + { + if (argv[1] && !strcmp(argv[1],"-c")) strncpy( cmd, argv[2], sizeof(cmd)-1 ); + if ((ptr = strchr( cmd, ' ' ))) *ptr = 0; + } + if ((ptr = strrchr( cmd, '/' ))) memmove( cmd, ptr + 1, strlen(ptr+1) + 1 ); + + message (0, (just_print_flag || (!(flags & COMMANDS_SILENT) && !silent_flag)) + ? "[%s] %s" : (char *) 0, cmd, child->file->name); + } /* Tell update_goal_chain that a command has been started on behalf of this target. It is important that this happens here and not in -- Alexandre Julliard julliard(a)winehq.org

May 29, 2007

Re: Pretty Build System (Take 3)

by Kirill K. Smirnov

You probably forget to run 'autoconf'. I can see nice messages like: $ autoconf ... $ ./configure ... $ make depend ... $ make ... CC extrachunk.o CC factory.o CC getframe.o CC icmstream.o CC regsvr.o CC tmpfile.o >I get the following (on Slackware 11) while running the make depend >portion of ./configure && make depend && make && sudo make install: >make[1]: Entering directory `/home/speeddy/wine-git/tools' >../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 bin2res.c >fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/tools' >make[1]: `makedep' is up to date. >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/dlls' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >../../tools/makedep -C. -S../.. -T../.. main.c >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: MAKERULE_MAKEDEP@: Command not found >make[2]: *** [depend] Error 127 >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[1]: *** [acledit/__depend__] Error 2 >make[1]: Leaving directory `/home/speeddy/wine-git/dlls' >make: *** [dlls/__depend__] Error 2

May 29, 2007

Re: wininet: Add a new NETCON_query_data_available function.

by Stefan Leichter

Am Monday 28 May 2007 12:16 schrieb Robert Shearman: > Use it to implement the behaviour where InternetReadFileExA does a > synchronous request if the data is available and asynchronous otherwise. > --- > configure.ac | 1 + > dlls/wininet/internet.c | 49 > +++++++++++++++++++++++++++-------------- > dlls/wininet/internet.h | 1 + > dlls/wininet/netconnection.c | 35 ++++++++++++++++++++++++++++++ > 4 files changed, 69 insertions(+), 17 deletions(-) Hello, your patch broke the compilation for me. Bye Stefan make[2]: Entering directory `/usr/src/wine/wine-build/dlls/wininet' gcc -c -I../../../wine-git/dlls/wininet -I. -I../../../wine-git/include -I../../include -D__WINESRC__ -D_WINX32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o netconnection.o ../../../wine-git/dlls/wininet/netconnection.c ../../../wine-git/dlls/wininet/netconnection.c: In function ‘NETCON_query_data_available’: ../../../wine-git/dlls/wininet/netconnection.c:585: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_msg’ ../../../wine-git/dlls/wininet/netconnection.c:586: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_len’ make[2]: *** [netconnection.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/wininet'

May 29, 2007

Re: Pretty Build System (Take 3)

by Tom Spear

On 5/29/07, Robert Shearman <rob(a)codeweavers.com> wrote: > Hi, > > Attached is a patch that reduces the verbosity of the build system by > printing the build commands in one of two formats: > COMMAND output_file > or > COMMAND input_file -> output_file > > I hope it meets Alexandre's requirements of not reducing portability of > Wine to other platforms (including Windows). I get the following (on Slackware 11) while running the make depend portion of ./configure && make depend && make && sudo make install: make[1]: Entering directory `/home/speeddy/wine-git/tools' ../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 bin2res.c fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c make[1]: Leaving directory `/home/speeddy/wine-git/tools' make[1]: Entering directory `/home/speeddy/wine-git/tools' make[1]: `makedep' is up to date. make[1]: Leaving directory `/home/speeddy/wine-git/tools' make[1]: Entering directory `/home/speeddy/wine-git/dlls' make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' ../../tools/makedep -C. -S../.. -T../.. main.c make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' make[2]: MAKERULE_MAKEDEP@: Command not found make[2]: *** [depend] Error 127 make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' make[1]: *** [acledit/__depend__] Error 2 make[1]: Leaving directory `/home/speeddy/wine-git/dlls' make: *** [dlls/__depend__] Error 2 -- Thanks Tom

May 29, 2007

Pretty Build System (Take 3)

by Robert Shearman

Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of not reducing portability of Wine to other platforms (including Windows). -- Rob Shearman

May 29, 2007

Re: Call for Ubuntu-wine admin

by Vijay Kiran Kamuju

Hi I will be member, if you ask I may act as a leader. Thanks, VJ On 5/28/07, Tomas.Zijdemans(a)student.uib.no <Tomas.Zijdemans(a)student.uib.no> wrote: > If someone is interested in leading the Ubuntu-wine team, please contact me. > > > >

May 29, 2007

Re: Happy SOC'ing all.

by Jesse Allen

On 5/28/07, Bryan DeGrendel <sirnuke(a)gmail.com> wrote: > > > > I believe most non-bug fix changes will be limited to a small part of the > WINE tree (the mscoree dll), so creating an entire git fork is overkill for On the contrary, I believe that git is ideal for forking (and later merging) like this.

May 29, 2007

Crosscompile (mingw) failure with msxml3 tests

by Paul Vriens

Hi, I just wanted to report the current failures when crosscompiling the msxml3 tests with mingw (and thus no new winetest executable): xmldoc.cross.o:xmldoc.c:(.text+0x1a9): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x1c0): undefined reference to `_CLSID_XMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x149d): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x14b4): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x22): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x39): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1425): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x143c): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1c46): undefined reference to `_IID_IXMLElement' xmlelem.cross.o:xmlelem.c:(.text+0x1f0f): undefined reference to `_IID_IXMLElement' collect2: ld returned 1 exit status make: *** [msxml3_crosstest.exe] Error 1 These started to happen after the addition of some patches made by James Hawkins (Add tests for [IXMLElement|IXMLDocument]) on May 26th. Cheers, Paul.

May 29, 2007

uninstaller: Shorten variable name length.. Whats wrong?

by Tom Spear

Just curious to know if there was something wrong with this patch, or if maybe it wasnt committed due to being a cosmetic change? If it's the latter, I'll just resend the other 2 parts of the patch (2and 3 of 3) against the code the way it is instead of changing the lines.. On 5/23/07, Tom Spear <speeddymon(a)gmail.com> wrote: > This patch shortens the length of some lines in > FetchUninstallInformation, as suggested by Peter Beutner > > -- > Thanks > > Tom > > -- Thanks Tom

May 29, 2007