June 2007 - Wine-Devel - list.winehq.org

Re: Add combobox in winecfg:theme.c

by Vitaly Lipatov

В сообщении от 16 июня 2007 Yaroslav Skorokhodov написал(a): > Changelog > Add combobox for select base font size There was improvement allows select size of the base font (dpi actually) in LogPixel registry entry. It is useful thing (default font size is too small on 17" monitors). What's wrong with the patch? http://www.winehq.org/pipermail/wine-patches/2007-June/040496.html -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

June 29, 2007

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]

by Koshelev, Misha Vladislavo

On 6/27/07, Evan Stade <estade at gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Also, I'd add a PT_MOVETO into your first PolyDraw call so you can tell whether PT_CLOSEFIGURE adds a PT_MOVETO to orig_pos or lastmove, as the current version does not differentiate this. Misha

June 29, 2007

Re: request to change appdb message

by Chris Morgan

On 6/29/07, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Chris Morgan <chmorgan <at> gmail.com> writes: > > > > > > How do you normally judge if the result is valid or not? What if the > > result says that everything works? > > Basically i'm only talking about garbage test results. If the app is > gold/platinum there's of course no need to paste debug output > > >It seems like any result could be faked, and we can't reject a test result > >from > >a user that had problem just because a handful of other users didn't. > > > > Yeah, i agree, there's no way to solve that. > > > > What else can we do with the issue you raised in #1? If users report > > their app doesn't work but don't report the crash data then at least > > we know the app doesn't work and thats valuable data. If it is too > > difficult to report bugs in bugzilla we should see if there are ways > > to assist with this. > > I don't think it's too difficult, most users just don't bother to do this. > > > > > I'm not entirely sure what your point #2 is. You are arguing that we > > want to see crash results in test submissions because then we can > > reply with a suggestion about how to fix the issue? It seems like this > > is exactly the kind of thing we want in bugzilla since it reflects > > issues users have with Wine. > > Unfortunately , if anyone would open a bug with the example > >i gave in issue #2,it would be closed immediately with a comment > "Invalid" -> "Closing". > > > > > > I guess my point about #2 is that assuming the user didn't do > > something really crazy, the issues the user has tend to be > > deficiencies in wine or its documentation and these really are > > legitimate issues that should be addressed. > > Yeah, so maybe we could add a list of "Common failures" to the documention, > with the solution. I can live with that. Then we could point garbage test > submitters to that page. That would be a nice work around. I'll have to > figure out how wiki works, and then i could give it a shot lateron i guess. > > Something like: > > Problem: > err:module:import_dll Library MSVBVM60.DLL (needed by L"C:\\app.exe") > not found > err:module:LdrInitializeThunk Main exe initialization for L"C:\\app.exe" > failed,status c0000135 > > Solution: > winetricks vcrun60 > > or > > Problem: > wine app.exe > err:ole:CoGetClassObject class {00000514-0000-0010-8000-00aa006d2ea4} > not registered > err:ole:create_server class {00000514-0000-0010-8000-00aa006d2ea4} > not registered > err:ole:CoGetClassObject no class object > {00000514-0000-0010-8000-00aa006d2ea4}could be created for > context 0x5 > Unhandled page fault etc......... > > Solution: > winetricks mdac27 > > Would that be something useful? > This sounds like a good idea. What about this nutty implementation. Why not come up with some logic to scan the contents of test results that a user is attempting to submit to the appdb? We could pass them through the scanner and repost the test result with additional comments that would try to address the users issues or at least point them at the faq. This would require a minor amount of php hacking but if you wanted to help out on the php code for the logic and suggestions I could get the architecture in place. The logic portion should be pretty simple, compared to knowing where to integrate things. Also note that we use a test suite with the appdb that can be run from the command line. This would let us save several example pieces of text to test that we respond reasonably to different issues. What do you think? Chris

June 29, 2007

Re: The: "Wine Status - ChangeLog"

by Maarten Lankhorst

Tomas.Zijdemans(a)student.uib.no schreef: > This page has been dead since October 1. > > Since I'm not producing code for the Wine project, this is an area I'd like to > contribute to. (I'm already taking screenshots of the API status page to see > what happens from release to release :)) > > Is there some WineHQ folks here that would be willing to give me accsess? > You can check out the source of the website. Then you just make your changes and submit them to wine-patches(a)winehq.org with [Lostwages] in title. If I'm wrong someone correct me, Maarten

June 29, 2007

Re: Something wrong with my two patches?

by Alexandre Julliard

Markus Gömmel <m.goemmel(a)compulab.de> writes: > On 21 and 22 June I submitted two small patches (for > comctl32/datetime.c and user32/msgbox.c). Both should be ok, but > definitly the first one (datetime.c)... > > Something wrong with them or only some normal delay in putting them > into git? My last small patch went into git within 2 days... Your mails contain two copies of the patch, one of which is mangled, that's a real pain to deal with. Please fix your mail setup and send a single correct version of each patch. -- Alexandre Julliard julliard(a)winehq.org

June 29, 2007

The: "Wine Status - ChangeLog"

by Tomas.Zijdemans＠student.uib.no

This page has been dead since October 1. Since I'm not producing code for the Wine project, this is an area I'd like to contribute to. (I'm already taking screenshots of the API status page to see what happens from release to release :)) Is there some WineHQ folks here that would be willing to give me accsess? Regards.

June 29, 2007

Re: illegal characters in file names

by Hans Leidekker

On Friday 29 June 2007, Alexandre Julliard wrote: > > On Wine the list of characters is: > > > > /:<>| > > Where did you find that list? The "official" list is INVALID_NT_CHARS > in ntdll/directory.c and it should match the NT one. Looks like the list of (printable) characters that shlwapi.PathIsValidChar rejects. -Hans

June 29, 2007

Re: illegal characters in file names

by Alexandre Julliard

"Lei Zhang" <thestig(a)google.com> writes: > On Wine the list of characters is: > > /:<>| Where did you find that list? The "official" list is INVALID_NT_CHARS in ntdll/directory.c and it should match the NT one. -- Alexandre Julliard julliard(a)winehq.org

June 29, 2007

Re: illegal characters in file names

by Hans Leidekker

On Thursday 28 June 2007, Lei Zhang wrote: > On Wine the list of characters is: > > /:<>| > > and on Windows, it is: > > \/:*?"<>| > > Is this intentional or something we should fix? I suspect that the list of invalid characters is filesystem dependent on Windows (e.g. ntfs vs fat32), which may explain why we can allow more characters. Do you have an app that breaks because of this? -Hans

June 29, 2007

Re: make test in winsock segfaulting after patch 4c5b55a0f8...

by Kai Blin

On Friday 29 June 2007 09:21:03 Kai Blin wrote: > commit 4c5b55a0f82e83793814a21eadec8b50d48751f3 > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Jun 4 18:16:48 2007 +0200 > > server: Run async I/O APCs from the SIGUSR1 handler. > > I have attached the backtrace. Looking at bug 8791, I can confirm this only happens with WINEDEBUG=+winsock. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

June 29, 2007