June 2007 - Wine-Devel - list.winehq.org

Re: wincrypt: add missing defines

by Mounir IDRASSI

You forgot the attachement... Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Juan Lang wrote: > --Juan > > > > ____________________________________________________________________________________ > Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool. > http://autos.yahoo.com/carfinder/ > > > > >

June 28, 2007

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.

by Robert Shearman

Jacek Caban wrote: > Robert Shearman wrote: > >> Jacek Caban wrote: >> >>> Hi, >>> >>> I've just sent a test showing that native doesn't implement these >>> interfaces so we shouldn't either. It's strange because IDL declaration >>> says something else. >>> >>> >> All of the interfaces that the patch implements or just IHTMLDOMNode >> that your tests show isn't implemented? >> > > All of these interfaces are not supported by HTMLDocument. I've included > only IHTMLDOMNode in the patch as it's what IDL definition includes. I suspect that you'll get different results when you do the same test on a loaded HTML document, even though this violates COM rules. -- Rob Shearman

June 28, 2007

Re: Direct3D Game test framework

by Stefan Dösinger

Hi, With Francois' help I could build a test package for 3DMark2000 now: http://stud4.tuwien.ac.at/~e0526822/3dmark2000.tar.bz2 It runs two tests, one at 640x480, another one at 1024x768, writes the results to a file and reads the file back. No benchmark results are sent to the server yet(just ok / fail). Steps to run the test: 1) install cxtest from http://www.cxtest.org/download . I recommend installing it with a seperate user account, since the tests scripts mess with files in $HOME. cxtest will download the wine git tree and compile wine, so you need some free space. cxtest installs some sample test packages too(picasa, winzip, pptviewer). It was a bit tricky for me to set cxtest up, since it needs Xvnc, has some problems(non-fatal it seems) with git 1.5, and a problem with the nvidia driver interfered(I couldn't run 2 Wine instances from different user accounts, I got a crash in libglcore). When you try to *record*, not play back a test, make sure to have $DISPLAY unset(vnc is used) 2) Download my test package and unpack it in ~/cxtest/ 3) Run the test WITHOUT using vnc. Obviously you need $DISPLAY set, and 3D acceleration available: ~/cxtest/cxtest_run/bin/run.sh --run 3dmark2000 --verbose --no-user --no-dependency --wine ~/cxtest/wine/wine --no-vnc So whats left? *) Make the Email system send custom test return data, not just success / failure *) extend the server side infrastructure to handle that test data. *) Write tests for more games

June 28, 2007

Something wrong with my two patches?

by Markus Gömmel

On 21 and 22 June I submitted two small patches (for comctl32/datetime.c and user32/msgbox.c). Both should be ok, but definitly the first one (datetime.c)... Something wrong with them or only some normal delay in putting them into git? My last small patch went into git within 2 days... Only a question Thanks and regards Markus Gömmel m.goemmel(a)compulab.de

June 28, 2007

Wine networking broke on Debian Sid

by Ben Hodgetts (Enverex)

Just to make this clear before starting this is a Sid issue (as far as I can tell) not a Wine issue. Anyway, to the point. Networking is broken on Debian Sid and has been for at least a week. I can't find out what has changed in Sid for it to stop working but basically anyone running Wine on Sid wont be able to use any form of network access. Firefox wont work, games wont be able to access servers or anything else, Gecko wont work, etc. This is using GIT, not the distros own packages. I tried using the x86_64 package for Ubuntu 7.04 (because no x86_64 package exists for Debian) and Wine acted exactly the same way with a clean .wine so it's not related to any build time issues. I reset to 0.9.34 in GIT and built that to make sure it wasn't anything that has changed in Wine itself and the issue continued, so it's not something that's changed in Wine. Although using an earlier version of Wine gives a "Winehq.com could not be found, please check the address and try again". Current Wine (or rather Gecko) doesn't bother giving you an error message. Could this be the work of the removal of an unspoken Wine dependency or something more sinister? All native apps still work perfectly which is what makes this such a hard thing to track down. I just thought I'd throw this out there in-case any of you are using Sid and wondering what the the hell happened to Wine. Log attached for completeness. Ben H.

June 28, 2007

Re: cabinent: add a comment about parm passing

by Alexandre Julliard

Jeff L <lats(a)yless4u.com.au> writes: > Mainly because the logic is a bit difficult. It depends on the length > being 0 to terminate the for loop and prevent the null reference. It > is not obvious and easily missed the first time through. Wine has a > number of things like that and more comments would make it quicker and > safer to works with. No, the proper way is to fix the code so that it's understandable. In this specific case you can get rid of the realloc function, it's useless. -- Alexandre Julliard julliard(a)winehq.org

June 28, 2007

Re: request to change appdb message

by Ben Hodgetts (Enverex)

Me and Chris Morgan changed it to this because we were sick of people pasting pages and pages of terminal output into the What works or What doesn't work boxes of the test data which is NOT where it belongs. The information in test data should be written in plain English, not pastes of lots of (mostly useless) terminal output which just looks awful and isn't any use to most users of the AppDB. I agree with point 2 but the problem is most AppDB submitters just... too stupid to be able to use some sense or judgement about what they are asked to actually put in the test reports. What you'd rather change it to would make the previous situation much, much worse so under no circumstances should it be changed to that though. Ben H. Louis. Lenders wrote: > Hi, since a few weeks the following message is displayed when you try > to submit test results into appdb: > > *Please DO NOT include crash or Wine debug output. Instead report the > crash as a bug in the Wine bugzilla at http://bugs.winehq.org > <http://bugs.winehq.org/>. We ask that you use bugzilla because > developers do not monitor the AppDB for bugs. > > I'm not that happy with this message for a few reasons: > > 1. Most testers will not attach this to a bug, either because there > isn't an entry for the app in bugzilla, or they don't bother to do so. > > 2. There are crashes like these that users attach: > wine app.exe > err:module:import_dll Library MSVBVM60.DLL (which is needed by > L"C:\\app.exe") not found > err:module:LdrInitializeThunk Main exe initialization for > L"C:\\app.exe" failed, status c0000135 > > We don't want users to attach these things in bugzilla, we'd rather > point them what to do in the email-field. If users don't attach > crashes anymore to the testresults , i cannot by no means see anymore > if a testresult is valid or not. > > I'd rather see something like: > > **Please DO include crash or Wine debug output here, and **report the > crash as a bug in the Wine bugzilla at http://bugs.winehq.org > <http://bugs.winehq.org/>**. > > Any comments? > * > > ------------------------------------------------------------------------ > Yahoo! Answers - Get better answers from someone who knows. Try it now > <http://uk.answers.yahoo.com/;_ylc=X3oDMTEydmViNG02BF9TAzIxMTQ3MTcxOTAEc2VjA…>. > > ------------------------------------------------------------------------ > > >

June 28, 2007

Re: cabinent: add a comment about parm passing

by Jeff L

James Hawkins wrote: > On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote: >> Coverity CID 43 Forward_Null is false. This adds a comment explaining >> the NULL pass is ok. > Why do we need a comment for that? Mainly because the logic is a bit difficult. It depends on the length being 0 to terminate the for loop and prevent the null reference. It is not obvious and easily missed the first time through. Wine has a number of things like that and more comments would make it quicker and safer to works with.

June 28, 2007

Re: Direct3D Game test framework

by Stefan Dösinger

> > The problem with vnc is recording a cxtest test(ie button clicks, > > keystrokes). That doesn't have to be fast, just beeing able to init glx > > is ok. But I agree on the non-trivial point. So far I've used manually > > coded keystrokes instead of button clicks, and it works, although it a > > bit of pain. > > I see. With eg. 3DMark you'd still have caps issues though. Thats true, but fortunately I don't need the whole set of tests to run while recording. Its enough to get the results dialog to continue recording from there. For that I could fake some caps temporarily in wined3d.

June 28, 2007

Re: Direct3D Game test framework

by H. Verbeet

On 28/06/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Am Donnerstag, 28. Juni 2007 09:09 schrieb H. Verbeet: > > On 28/06/07, Steven Edwards <winehacker(a)gmail.com> wrote: > > > Could we add an extension to vnc to use Mesa? > > > > I suspect it would be non-trivial, but more importantly I think it > > would defeat the purpose of measuring performance on different > > hardware configurations. > The problem with vnc is recording a cxtest test(ie button clicks, keystrokes). > That doesn't have to be fast, just beeing able to init glx is ok. But I agree > on the non-trivial point. So far I've used manually coded keystrokes instead > of button clicks, and it works, although it a bit of pain. > I see. With eg. 3DMark you'd still have caps issues though.

June 28, 2007