July 2007 - Wine-Devel - list.winehq.org

Patch: VarWeekdayName

by Jiří Paleček

Hello, I want to ask, is anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2007-July/041434.html I'm asking because I have other patches, but don't know if it is worthwhile to send them. Regards Jiri Palecek

July 31, 2007

Re: Direct3D Game test framework

by martin pilka

Hello Stefan, link works, I was able to run your test. Installation is ok, however test itself ends with '3DMark Error': '3DMark needs DirectX 7 and proper drivers installed in order to run'. This happens without CxTest as well, with latest WineHq. Note that DirectX7 or newer is correctly detected during installation process. Is it a bug in my configuration, or did I hit some Wine error? Thanks, Martin Stefan Dösinger wrote: > Am Dienstag, 31. Juli 2007 12:28 schrieb martin pilka: >>> With Francois' help I could build a test package for 3DMark2000 now: >>> >>> http://stud4.tuwien.ac.at/~e0526822/3dmark2000.tar.bz2 >>> >>> It runs two tests, one at 640x480, another one at 1024x768, writes the >>> results to a file and reads the file back. No benchmark results are sent >>> to the server yet(just ok / fail). >> Stefan, this link is not valid anymore, could you make the file available >> again? > Oops, I deleted the file accidentally when cleaning up old junk on that > server. I've reuploaded it.

July 31, 2007

Re: wine3d3: Check the destination recangle when for FastBlt().

by Stefan Dösinger

> I have taken another look at it. I still think this specific problem > should be fixed in wined3d. The problem occurs because BltFast (ddraw, > d3d and d3d-gdi) all take two DWORDs as the offset write position, and > then later casts them into a RECT structure which has signed values. > This must for any caller be considered an error. No caller could get > anything useful out of this. > lock_dst.left = dstx; <--- bad cast! > lock_dst.top = dsty; <--- bad cast! > lock_dst.right = dstx + w; <--- bad cast! > lock_dst.bottom = dsty + h; <--- bad cast! > > Why does this not trigger a warning? Not sure. Indeed this does not sound right. The unsigned to signed assignment doesn't look right. However, a problem should only occur if the highest bit of the DWORD is set, in which case this would be a very high value and would exeed the surface dimensions. Such a huge surface can't be created without exceeding the 2 GB userland VM size. Most likely the check in dlls/ddraw/surface.c, line 2067 runs into a signedness issue too.

July 31, 2007

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

by Frank Richter

On 31.07.2007 05:37, Dmitry Timoshkov wrote: > rc doesn't support embedded or escaped quotes at all. So statements like > > LTEXT "String with "quotes"",-1,7,7,120,8 > or > LTEXT "String with \"quotes\"",-1,7,7,120,8 > > don't work. The strings I'm using and that work for me look like: LTEXT "String with ""quotes""",-1,7,7,120,8 > That would create an additional problem for translators IMO. Why? -f.r.

July 31, 2007

Re: user32: erase parent when hiding child

by Alexandre Julliard

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes: > "Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > >> ChangeLog: >> user32: erase parent when hiding child > > As I already pointed out erasing a parent is supposed to be done > in the server. You need to look there why it doesn't happen and add > a fix there. The invalidate and erase part has to happen in the server, and it does, so that part of the patch is redundant. The RDW_ERASENOW part however needs to be done in the client. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2007

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

by Vitaliy Margolen

Peter Dons Tychsen wrote: > On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: >> On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: >>> Peter Dons Tychsen wrote: >>>> OK. Please review this diff: >>>> >>>> I will re-submit it if you like it. >>>> >>>> /Pedro >>> Alright looks good now (you might want to remove the extra white space your >>> patch adds - git complains about those). Just left to make the same change >>> to the other joystick interface :) >>> >>> BTW don't forget to cc: the wine-devel list when you replying. >>> >>> Vitaliy. >> OK. I still feel that trying to sync joystick_linuxinput.c and >> joystick_linux.c is out of scope for this patch. But as my steadiness >> has limits i have done some of it anyway... :). I have kept the changes >> modest. >> >> Please take a look at the new patch. >> >> On another note i will agree with you that it would be practical if the >> two files had similar (or maybe even shared) code. Redundant code is >> never very practical as it always ends up as this very example. The two >> implementations which were supposed to identical always drift apart. If >> things are supposed to do the same, keep them together to begin with. >> >> Thanks, >> > Maybe i would be more successful if i actually attached the > patch.... :-) > > Here it is.... Just few small things left: > -#undef MAX_JOYSTICKS As I mentioned earlier you should move this instead of removing it completely. > static HRESULT joydev_create_deviceW(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEW* pdev) > { > - int i; > - > - find_joydevs(); You removed a really important function call here. > +static HRESULT joydev_create_deviceA(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEA* pdev) > +{ > + unsigned short index; > + > + if ((index = get_joystick_index(rguid)) < MAX_JOYDEV) { > + if ((riid == NULL) || If you reformat the whole function, please make it 4-space indented. Vitaliy.

July 31, 2007

Re: WineD3D: compile against standard GL headers [attempt2]

by H. Verbeet

On 31/07/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > This is the second version of this patch. As Henri suggested extensions are > now defined to 1 and GL_EXT_LEGACY has been set too. > That's better, but you're still missing the functions for GL_ARB_multisample and GL_EXT_vertex_weighting. Since GL_EXT_vertex_weighting can be removed completely that would effectively only be a single function, glSampleCoverageARB.

July 31, 2007

Re: Direct3D Game test framework

by Stefan Dösinger

Am Dienstag, 31. Juli 2007 12:28 schrieb martin pilka: > > With Francois' help I could build a test package for 3DMark2000 now: > > > > http://stud4.tuwien.ac.at/~e0526822/3dmark2000.tar.bz2 > > > > It runs two tests, one at 640x480, another one at 1024x768, writes the > > results to a file and reads the file back. No benchmark results are sent > > to the server yet(just ok / fail). > > Stefan, this link is not valid anymore, could you make the file available > again? Oops, I deleted the file accidentally when cleaning up old junk on that server. I've reuploaded it.

July 31, 2007

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

by Paul Vriens

Alexandre Julliard wrote: > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > >> I'll have a look. >> >> How do yo want to report a missing test? In the normal report file? If >> that's the case we should also change the dissect/gather scripts: > > It has to be part of the report data, so yes the scripts probably need > to be updated. > >> If this thing works out, should we change the old tests back or use >> this new approach only for new (and currently failing) dll's? > > If it simplifies the code we can certainly change the old tests too. > Hi, a patch somewhat like this? diff --git a/programs/winetest/main.c b/programs/winetest/main.c index f743ffc..3c4846d 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -433,6 +433,24 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, LPTSTR lpszName, LONG_PTR lParam) { const char *tempdir = (const char *)lParam; + char dllname[MAX_PATH]; + HMODULE dll; + + /* Check if the main dll is present on this system */ + strcpy(dllname, lpszName); + *strstr(dllname, "_TEST.EXE") = 0; + + dll = LoadLibrary(dllname); + if (!dll) { + /* Here we add some information to the results file + * that indicates that the dll is not present + * on this platform. + */ + report (R_WARNING, "dll : %s is not present", dllname); + return TRUE; + } + FreeLibrary(dll); + get_subtests( tempdir, &wine_tests[nr_of_files], lpszName ); nr_of_tests += wine_tests[nr_of_files].subtest_count; nr_of_files++; Running this on win9x gives me 13 dll's that are not available (the R_WARNING is of course only for testing). Cheers, Paul.

July 31, 2007

Re: Direct3D Game test framework

by martin pilka

> With Francois' help I could build a test package for 3DMark2000 now: > > http://stud4.tuwien.ac.at/~e0526822/3dmark2000.tar.bz2 > > It runs two tests, one at 640x480, another one at 1024x768, writes the results > to a file and reads the file back. No benchmark results are sent to the > server yet(just ok / fail). Stefan, this link is not valid anymore, could you make the file available again? Thanks, Martin

July 31, 2007