August 2007 - Wine-Devel - list.winehq.org

Re: [git] Playing with gitstat (can we change date for the tags?)

by Michael Stefaniuc

Hello, Paul Vriens wrote: > I was just playing with gitstat (http://tree.celinuxforum.org/gitstat/) > to see if it give some nice graphs for Wine as well (on my local box). > > I can see all the tags but for some reason a lot of tags (from > wine-0.0.2 to wine-0.7 and after that wine-940201 to wine-980927, so > basically every tag before Alexandre's "Initial revision") have nearly > the same tagger/author date (around November 30th 2005). This messes up > the ordering of the tags. That's probably when Wine migrated to git and Alexandre imported the history from CVS. A lot of projects will have the same problem if they migrated from something else to git. > Is there something I can do about this? (man git-tag tells me one > shouldn't change tags afterwards). A possible solution would be to have gitstat check the commit referenced by the tag; that one has the right date. E.g "tag wine-0.0.2" references "commit 2c25c3e9442c69bd2402f94f264f0aafa58b00e0" which has as "CommitDate: Tue Jun 29 16:33:12 1993 +0000". > (I've changed the necessary perl-script to only include the tags that > are correct so I do have some output). bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

Aug. 27, 2007

[git] Playing with gitstat (can we change date for the tags?)

by Paul Vriens

Hi, I was just playing with gitstat (http://tree.celinuxforum.org/gitstat/) to see if it give some nice graphs for Wine as well (on my local box). I can see all the tags but for some reason a lot of tags (from wine-0.0.2 to wine-0.7 and after that wine-940201 to wine-980927, so basically every tag before Alexandre's "Initial revision") have nearly the same tagger/author date (around November 30th 2005). This messes up the ordering of the tags. Is there something I can do about this? (man git-tag tells me one shouldn't change tags afterwards). (I've changed the necessary perl-script to only include the tags that are correct so I do have some output). -- Cheers, Paul.

Aug. 27, 2007

Re: Imm32: Update position of default IME window

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > + > + /* make sure we are on the desktop */ > + GetClientRect(GetDesktopWindow(),&desk_rect); You have to use GetMonitorInfo to support multi-monitor setups correctly. -- Alexandre Julliard julliard(a)winehq.org

Aug. 27, 2007

Re: [patch] Garbage code in text string display

by Guan Xin

On 8/24/07, Reece Dunn <msclrhd(a)googlemail.com> wrote: > > You don't need to have a Windows machine to write the tests. You can > write them and build them through the Wine libraries. The reason for > building them on Windows is so that you can verify them against > Windows, but you could always post the tests for other developers to > try. > That's fine! I'll learn some Windows API programming when I have time. Maybe in my next life. I used to program with C++Builder and was very familiar with that tool. Now that I left my previous affiliation and have little opportunity to access Windows. > As well as being run on Wine, they are run on different Windows > versions as well, to verify them on all platforms. No use. You cannot exhaust all possibilities. > A better analogy would be that you have a light switch and a light > bulb. The light switch is your input and the light bulb is the output. > Everything else is unknown (a black box). You don't know how it works. > > You could open the box up and look inside (the equivalent of looking > at the Windows source), but Wine can't do that. Also, if you modify > the Wine code to improve it, you may break something. This would be > like making a short circuit in your example above: the light no longer > works in your replica (i.e. Wine), so any tests will fail on that. > > What you can do instead is say that when the light switch is on the > 'up' position, the light bulb is on and when the switch is on the > 'down' position, the light bulb is off. > > Now say you have two rows of 4 switches and a row of 4 lights, aligned > with each other. What is the behaviour of this system? The only way to > find out (without looking inside) is to devise a set of tests. This > way, you can find out what logic the system is using. For example, if > the system is behaving like a binary adder, you can deduce that from > the tests. That sounds effective if every light is controlled ONLY by the switches nearest to itself, since there are acturally infinite such switches. > The tests in Wine are designed to pass on Windows (and should, in > theory, pass cleanly on that platform). The implementation of Wine is > then written to pass those tests, therefore matching the _behaviour_ > of Windows. > > Specifically, a test would need to be created that highlights the MBCS > program issue you identified, and verify that on Window it is > returning DEFAULT_CHARSET. When this is run on Windows, it will pass, > because it is testing that what is returned is DEFAULT_CHARSET. > However, when this is run on an unpatched Wine, it will fail because > Wine is returning ANSI_CHARSET. Now, running the tests on a patched > version of Wine will cause that test to pass, matching the behaviour > on Windows. I know what you mean. That's fine and clear. I lost my engineer's brain three years before since I changed my profession. No I recalled that technical proofs should never be strict. Best wishes and hope you to progress! Xin

Aug. 27, 2007

[PATCH] Support for animated cursors

by Trent Waddington

Test program at: http://rtfm.insomnia.org/~qg/animatedcursor.exe Probably doesn't support all the possible animated cursors supported under windows, and correct timing of animation hasn't been attempted. Trent

Aug. 27, 2007

[wiki] Useful Registry Keys

by Paul Vriens

Hi, Is "Useful Registry Keys" to show what's in current GIT or should it also help with older versions of Wine? I'm asking because "LogPixels" is currently handled by winecfg and thus could be removed if the page only shows the latest and greatest. Cheers, Paul.

Aug. 27, 2007

Re: cabinet: Add initial tests for FDI

by Paul Vriens

James Hawkins wrote: > Hi, > > Changelog: > * Add initial tests for FDI. > > dlls/cabinet/tests/Makefile.in | 3 +- > dlls/cabinet/tests/fdi.c | 578 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 580 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, Am I correct that you're not deleting the "dest" directory? + CreateDirectoryA("dest", NULL); +} + +static void delete_test_files(void) +{ + DeleteFileA("a.txt"); + DeleteFileA("b.txt"); + DeleteFileA("testdir\\c.txt"); + DeleteFileA("testdir\\d.txt"); + RemoveDirectoryA("testdir"); + + DeleteFileA("extract.cab"); +} (Is "dest" used at all?) -- Cheers, Paul.

Aug. 27, 2007

Re: wine.inf: add Internet Explorer AppPath registry key

by Mikołaj Zalewski

> > Why don't you try it yourself and see if it works? > When I tried it last time it didn't work at all - it wrote it can't find Microsoft servers. But now I gave it another try and it worked with the AppPath (it doesn't work with `winetricks fakeie6` - the Version and VersionVector should not be filled for IE to install). Mikołaj Zalewski

Aug. 27, 2007

[PATCH] Implement ImmReleaseContext.

by Trent Waddington

Ugly stub warning replaced with intuitive implementation. Trent

Aug. 26, 2007

Old versions of Photoshop Elements tryout?

by Dan Kegel

Hi all, I have a copy of Photoshop Elements 1.0, and can easily download a tryout of Photoshop Elements 5, but I don't know where to get trial versions of 2 through 4. Anyone know? Thanks, Dan

Aug. 26, 2007