August 2007 - Wine-Devel - list.winehq.org

Re: Application minimizing resizes it to icon size.

by Stefan Dösinger

Am Donnerstag, 23. August 2007 20:02 schrieb Meelis Mägi: > commands i used to run Ryzom: > 1)wine client_ryzom_rd.exe > 2)wine explorer.exe /desktop=ryzom,1280x1024 client_ryzom_rd.exe > (minimizing Ryzom window inside wine desktop) > > Ryzom hates to be resized to icon mode in both occasions. it detects > the size change and relocates ingame UI accordingly. window in > bottom-left is moved to top-right, bottom-right to top-left etc. its > completely Ryzom's problem that it behaves like that. Ok, in that case I have no idea about the problem. There was a change recently to catch focus losses away from wine correctly, but that patch caused unintuitive behavior in virtual desktops. When the virtual desktop looses the focus now, apps see that they lost the focus and react to it. Especially for games this is strange. I do not know if I should consider that behavior a bug though. It is correct to report the focus loss, since the focus is indeed lost, but apps minimizing in the VD isn't optimal either. But I do not think that this is related to your problem.

Aug. 23, 2007

Re: DIB Driver code available

by Stefan Dösinger

Am Donnerstag, 23. August 2007 18:58 schrieb Jesse Allen: > Hi, > > I have my DIB driver code available on a public git host now: > http://repo.or.cz/w/wine/dibdrv.git > > I'm going to briefly describe it. Is your dib driver an all or nothing replacement of winex11 GDI drawing, or can it be mixed with winex11? How do you deal with BitBlt() or simmilar calls between your driver and winex11?

Aug. 23, 2007

Re: Application minimizing resizes it to icon size.

by Meelis Mägi

2007/8/23, Stefan Dösinger <stefandoesinger(a)gmx.at>: > Am Donnerstag, 23. August 2007 18:56 schrieb Meelis Mägi: > > Hello, i have a silly question. > > > > Why does application resized to icon size when it gets minimized ? > > (also when switching desktops, but thats acts as minimizing i think) > > > > Reason i ask is that, there is MMO Ryzom (ryzom.com) that gets a bit > > confused when minimized and ingame UI gets messed up (only game i know > > that has this problem) > > > > If i comment out SetWindowPos() line in X11DRV_UnmapNotify() function > > (file dlls/winex11.drv/winpos.c), then ingame ui stays ok. > > Does that happen in a virtual desktop, or without it? > commands i used to run Ryzom: 1)wine client_ryzom_rd.exe 2)wine explorer.exe /desktop=ryzom,1280x1024 client_ryzom_rd.exe (minimizing Ryzom window inside wine desktop) Ryzom hates to be resized to icon mode in both occasions. it detects the size change and relocates ingame UI accordingly. window in bottom-left is moved to top-right, bottom-right to top-left etc. its completely Ryzom's problem that it behaves like that. i was just curious why does wine resize application window to icon size when application is minimized (and it's not just in one place, all over the code ;-) thanks.

Aug. 23, 2007

Re: DIB Driver code available

by Alexandre Julliard

"Jesse Allen" <the3dfxdude(a)gmail.com> writes: > Indeed, my tests show that there is a 50 second difference with GDI > Get/SetPixel. If anyone wants to try my app, I'll send it to them :) Note that GetPixel is the worst possible case under X, since it takes a full server roundtrip for each pixel. So yes, a DIB engine will definitely be faster here, the opposite would be very worrying. Testing just SetPixel would be a more meaningful test however. -- Alexandre Julliard julliard(a)winehq.org

Aug. 23, 2007

Re: Application minimizing resizes it to icon size.

by Stefan Dösinger

Am Donnerstag, 23. August 2007 18:56 schrieb Meelis Mägi: > Hello, i have a silly question. > > Why does application resized to icon size when it gets minimized ? > (also when switching desktops, but thats acts as minimizing i think) > > Reason i ask is that, there is MMO Ryzom (ryzom.com) that gets a bit > confused when minimized and ingame UI gets messed up (only game i know > that has this problem) > > If i comment out SetWindowPos() line in X11DRV_UnmapNotify() function > (file dlls/winex11.drv/winpos.c), then ingame ui stays ok. Does that happen in a virtual desktop, or without it?

Aug. 23, 2007

DIB Driver code available

by Jesse Allen

Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. The dib driver (or engine) is a gdi driver. It is loaded into a dc when an application selects a dib, and overrides the existing driver. The magic takes place in SelectBitmap. Safe interaction is provided in gdi32 in four patches. If the winedib.drv.so library is available, then gdi will use the dib driver for drawing into the selected dib. If winedib.drv.so is not available, then gdi will continue using winex11 for example just as before. So these four patches can be safely integrated with the main tree if that is decided to be done. The rest of the code is the driver itself. It can handle all the standard uncompressed dib formats. It can convert between formats, and it can Get/SetDIBits/Blt. Get/SetPixel is implemented too. No other drawing code is done yet, so only simple GDI apps work. I've tested several apps and I'll list my results. notepad -- no regressions found winefile -- visual artifacts, but usable bmp loading -- works fine for what has been tested pixel setting -- works fine for every supported format opengl app -- Tribes 1 -- no regressions found d3d app -- Star Wars Battlefront -- no regressions found ddraw app -- Diablo shareware -- no regressions found ddraw app -- Diablo prerelease -- discovered one visual artifact These are the deficiencies in current code (non-stubs): No RLE support Missing raster operations in *Blt Get/SetDIBits does not conform exactly yet Bottom-up DIB's not tested for (and probably broken) DIB_PAL_COLORS not tested for No stretching No forwarding calls back to original driver* *For forwarding back the calls, what I think can be done is use the hbitmap handle originally given, convert it to a DDB, select it, and make the same gdi call again which will then go to the actual device. I do probably need to make sure the dibdrv's physdev persists and doesn't get deleted during this ;) (probably something in Create/Delete DC) Performance Originally I was going to state not to expect there really to be any performance improvements. I feel that there are optimizations possible that I have not done, but I left room for. My first concern was correct pixel by pixel operation. So I thought not to expect anything but last night I discovered this, so I might as well share. I have written a program that performs Get/SetPixel to test the various formats. There are 13 total tests, and the program produces 52 MB of output. Just for fun I ran my program without the dib driver and found it took a very long time (I was thinking it hung up at first since it took so long!): timed with winex11.drv real 0m53.903s user 0m19.807s sys 0m5.869s So I tried it with my driver: timed with winedib.drv real 0m3.924s user 0m3.537s sys 0m0.191s Indeed, my tests show that there is a 50 second difference with GDI Get/SetPixel. If anyone wants to try my app, I'll send it to them :) Still, I wouldn't expect *your* app to seem much different (or work at all :P) So will all the interested parties take a look at the driver and I'd sure appreciate feedback on the direction this is going, so we move towards finishing this project beyond the summer of code. :) Jesse

Aug. 23, 2007

Application minimizing resizes it to icon size.

by Meelis Mägi

Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask is that, there is MMO Ryzom (ryzom.com) that gets a bit confused when minimized and ingame UI gets messed up (only game i know that has this problem) If i comment out SetWindowPos() line in X11DRV_UnmapNotify() function (file dlls/winex11.drv/winpos.c), then ingame ui stays ok. thanks

Aug. 23, 2007

Re: shlwapi: Fix UrlCombineW for absolute URLs without slashes.

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + process_case = (*base.pszSuffix == L'/') ? 5 : 1; Although using the L prefix is harmless in this case, it's better to avoid it in Wine code IMO. -- Dmitry.

Aug. 23, 2007

Re: [winetest] Use of HeapAlloc and friends

by Dmitry Timoshkov

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? > The rest of our programs do, but winetest uses malloc and realloc. I recall that replacing malloc/realloc by HeapAlloc/HeapReAlloc has fixed user32/tests/msg.c failures under Win95 (that were caused by buggy msvcrt implementations), so if are still aming to run the tests on that platform we should get rid of malloc/realloc. -- Dmitry.

Aug. 23, 2007

Re: [winetest] Use of HeapAlloc and friends

by Ferenc Wagner

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Ferenc Wagner wrote: >> Paul Vriens <paul.vriens.wine(a)gmail.com> writes: >> >>> Is there any particular reason we don't use HeapAlloc/HeapReAlloc in >>> winetest? The rest of our programs do, but winetest uses malloc and >>> realloc. >> >> I can't recall any. I'm more comfortable with the latter, since >> winetest is the only Win32 application I've ever written. > > So when I add functionality should I use malloc or can we use a mix? > Should winetest be changed to use HeapAlloc? That I can't tell. At least I haven't heard a single objection against my style in this respect. Mixing the two doesn't sound like a particularly compelling idea for me. -- Cheers, Feri.

Aug. 23, 2007