August 2007 - Wine-Devel - list.winehq.org

Re: [winetest] Use of HeapAlloc and friends

by Paul Vriens

Ferenc Wagner wrote: > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > >> Is there any particular reason we don't use HeapAlloc/HeapReAlloc in >> winetest? The rest of our programs do, but winetest uses malloc and >> realloc. > > I can't recall any. I'm more comfortable with the latter, since > winetest is the only Win32 application I've ever written. So when I add functionality should I use malloc or can we use a mix? Should winetest be changed to use HeapAlloc? -- Cheers, Paul.

Aug. 23, 2007

Re: [winetest] Use of HeapAlloc and friends

by Ferenc Wagner

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Is there any particular reason we don't use HeapAlloc/HeapReAlloc in > winetest? The rest of our programs do, but winetest uses malloc and > realloc. I can't recall any. I'm more comfortable with the latter, since winetest is the only Win32 application I've ever written. -- Feri.

Aug. 23, 2007

Re: wordpad: Add initial printing support

by Alexander Nicolaysen Sørnes

Torsdag 23 august 2007 12:16, skrev du : > Am Donnerstag, 23. August 2007 01:52 schrieb Alexander Nicolaysen Sørnes: > > wordpad: Add initial printing support > > I usually don't read non-d3d patches, but when I saw the wordpad patches I > decided to see what wordpad looks like today, and I am really impressed :-) > Good work! > Thanks, man! :) There is one backdraw, though: our richedit has a stubbed EM_FORMATRANGE, so without the native dll it won't print anything. > This makes me wonder if Wine does or should register mime types for > wordpad, notepad, regedit, msiexec or .bat files? We really don't have to > be ashamed of our wordpad implementation, it is a nice lightweight editor > for .rtf files. I definitely think we should, both in the Wine environment and the native one. Registering it with icons in WIne is on my to-do list, then I'll see about adding it to the native environment if no one else is planning to. Alexander N. Sørnes

Aug. 23, 2007

[winetest] Use of HeapAlloc and friends

by Paul Vriens

Hi, Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. Cheers, Paul.

Aug. 23, 2007

What the web test reports need.

by Jakob Eriksson

We need a http://test.winehq.org/data/latest/ Which always points to the latest results. Instead of: http://test.winehq.org/data/200708221000/ etc... Who can fix this? regards, Jakob

Aug. 23, 2007

Re: [PATCH try3 5/5] wininet: When sending INTERNET_STATUS_HANDLE_CLOSING make sure the freed handle is not yet available.

by Alexandre Julliard

Misha Koshelev <mk144210(a)bcm.edu> writes: > + /* As on native when the equivalent of WININET_Release is called, the handle > + * is already invalid, but if a new handle is created at this time it does > + * not yet get assigned the freed handle number */ > if( info ) > WININET_Release( info ); > > + EnterCriticalSection( &WININET_cs ); > + > + if( WININET_dwNextHandle > handle ) > + WININET_dwNextHandle = handle; > + > + LeaveCriticalSection( &WININET_cs ); This is wrong, the handle could have been reused by then, you can't assume it is still free. -- Alexandre Julliard julliard(a)winehq.org

Aug. 23, 2007

Re: wordpad: Add initial printing support

by Stefan Dösinger

Am Donnerstag, 23. August 2007 01:52 schrieb Alexander Nicolaysen Sørnes: > wordpad: Add initial printing support I usually don't read non-d3d patches, but when I saw the wordpad patches I decided to see what wordpad looks like today, and I am really impressed :-) Good work! This makes me wonder if Wine does or should register mime types for wordpad, notepad, regedit, msiexec or .bat files? We really don't have to be ashamed of our wordpad implementation, it is a nice lightweight editor for .rtf files.

Aug. 23, 2007

Re: [1/5] WineD3D: Fall back to drawStridedSlow if fog coords are used

by Stefan Dösinger

> This patch is probably fine, but it makes me look into the surrounding > code [ software blending, changing the strided data ], which is still > incredibly misleading. That should go into its own function, with the > FIXVBO macro removed (since all such macros are evil, without > exception), and a big comment should be added that named access to the > strided data is only valid in the fixed function pipeline and will not > work in the shader pipeline. Maybe it makes sense to use two different > structures to make this clearer - not sure. Yes, I think you're right about the macro, a function and a comment. I will make a patch for this. As for the separate structure for named and numbered attribs I am not sure either. We might need extra checks for useVS, but in theory we shouldn't because code that would need them is broken, since it either uses named access with shaders, or numbered access with fixed function. Another thing to consider is getting rid of the strided vertex structure altogether. I am not sure if it will work, or improve things. It may make the code simpler and faster to use the vdecl directory, but otoh there's IDirect3DDevice7::DrawPrimitiveStrided. We could handle that call with a bit of memcpy() calling, this method is hardly used(only one dx sdk sample, and the Ogre based 3D games. Ogre has a gl renderer too).

Aug. 23, 2007

Re: user32: static controls should have a clipping region set whilesending the WM_CTLCOLORSTATIC (with testcase, fixes bug #9195)

by Dmitry Timoshkov

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > Photoshop ImageReady depends on it. You have added an explicit clipping to STATIC_PaintTextfn, but since you are working on it, please test other static styles as well. Btw, if you are keen on writing a test (or making your test generic) for button control, that would help in investigating and fixing the bug 7569 which suffers from the same problem. -- Dmitry.

Aug. 23, 2007

Re: [patch] Garbage code in text string display

by Guan Xin

On 8/23/07, Juan Lang <juan.lang(a)gmail.com> wrote: > You may generally post source to wine-devel if it's short and to the > point. Please don't post a binary. Acturally, this bug is obvious as I have pointed it out. No source is needed for demonstration. Also I always programmed with Borland's AFX when I used Windows. So my source is unlikely to compile under WINE or MSVC. Recently I have no Windows machine and cannot learn Windows API programming to write those tests. > Right to the first point, which is why we write tests that pass on > Windows, and fix Wine to match the tests. This obviates the need to > look at Windows source. You must be mistaken. Tests that fail when WINE is not patched and pass when patched do not prove correctness of the midification. They only increase the possibility of its correctness. I am sorry I never learnt computer science and misunderstood your requisition. Here is an analogy to show what you are doing: in order to find out how to turn off the light, a computer scientist tried to place a piece of wire into the outlet and made a short-circuit. He succeeded. His `test case' never failed as far as he lived. The computer scientist electrocuted himself.

Aug. 23, 2007