August 2007 - Wine-Devel - list.winehq.org

RFC: root cert tool

by Juan Lang

Since there wasn't a clear consensus about how to get CA certificates into the registry, I decided to do what Mono does: punt. So I've written a tool that can load certificates from a file or from a URL and stick them in the registry. By default it assumes you want to download them from Mozilla's CVS front-end, and does so. A patch that adds it is attached. Comments? Thanks, --Juan

Aug. 14, 2007

Re: [2/5] WineD3D: Optimize float constants in stateblocks

by Stefan Dösinger

Am Dienstag, 14. August 2007 20:56 schrieb Alexandre Julliard: > Stefan Dösinger <stefan(a)codeweavers.com> writes: > > From f49fd192ed2747663bdb0445dff9d602519fbc95 Mon Sep 17 00:00:00 2001 > > From: Stefan Doesinger <stefan(a)codeweavers.com> > > Date: Fri, 3 Aug 2007 20:26:29 +0200 > > Subject: [PATCH] WineD3D: Optimize float constants in stateblocks > This one is broken: Actually it is perfectly OK, the previous one isbroken... DWORD contained_transform_states[WINEHIGHEST_RENDER_STATE + 1];

Aug. 14, 2007

Re: Partial phase out of *winehq.com addresses

by Jeremy Newman

On Tue, 2007-08-14 at 13:37 -0700, Duane Clark wrote: > As mentioned about a month ago, we were planning to phase out the > winehq.com email addresses, and use winehq.org exclusively. It looks > like the few holdouts have converted over for awhile now, so I added a > filter to the mailman program to silently drop anything mailed to > winehq.com. > > If Jeremy wants to set the MTA (or whatever) to reject those addresses, > that might be better. Then anyone accidently mailing to the wrong > address would (presumably) get a delivery error message. And it would > take a small portion of the load off mailman. I can configure the mail server to stop accepting winehq.com emails at any time. It is a one line change in the server config. Anyone opposed to this speak up now. I'll give it a few more days of discussion.

Aug. 14, 2007

Partial phase out of *winehq.com addresses

by Duane Clark

As mentioned about a month ago, we were planning to phase out the winehq.com email addresses, and use winehq.org exclusively. It looks like the few holdouts have converted over for awhile now, so I added a filter to the mailman program to silently drop anything mailed to winehq.com. If Jeremy wants to set the MTA (or whatever) to reject those addresses, that might be better. Then anyone accidently mailing to the wrong address would (presumably) get a delivery error message. And it would take a small portion of the load off mailman.

Aug. 14, 2007

Re: [PATCH] Fix Bug in DeadZone calculation

by Artur Szymiec

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Vitaliy Margolen napisał(a): > Artur Szymiec wrote: >> Here is attached patch >> for joystick_linuxinput.c where bug in dead zone >> calculation make joystick unusable. After correction >> tested in two games and works properly. >> >> Best Regards >> Artur Szymiec >> > > Thanks for spotting the problem. Unfortunately your patch has few > problems too. I'll sending a better patch. > > Vitaliy. > Thanks for reviewing the patch. Could you please explain to me what's wrong with this patch. What kind of problems do you mean ? Best Regrads Artur - -- - -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.21-2-k7 i686 AMD Athlon(tm) XP 2800+ Conquer your Desktop! http://www.spreadkde.org/try_kde Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ - -------------------------------------------------------------------------- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGwhHIbB2ld6kq2MsRAg7tAJ43TyR815W4lsJ34Uz3V83fC119rgCg2c/T mt5CxZxrxTcrSe/L/kHBxOM= =8Ue6 -----END PGP SIGNATURE-----

Aug. 14, 2007

Re: Font problem + patch solution

by Alexandre Julliard

"Abel Chiaro" <inckie(a)gmail.com> writes: > At least with those fonts (since I can't test every single font out > there), the patch fixes the issue. And it passes Dmitry's tests. The problem is that looking at differences in the traces is not a good test, since it can't be automated. What is really needed is a test case that succeeds on Windows, fails on current Wine, and succeeds on Wine + your patch. That's also the only way to make sure that the bug doesn't reappear. -- Alexandre Julliard julliard(a)winehq.org

Aug. 14, 2007

Re: Font problem + patch solution

by Abel Chiaro

Alexandre Julliard <julliard(a)winehq.org> wrote: > So does that test behave differently for you with your patch? Does it > show that things are fixed? Which font are you testing with? The patch adds a missing else to the codepage tests in WineEngEnumFonts(), making it handle DEFAULT_CHARSET rather than ignore it. As I pointed out in comment #49 to bug #7571 [1], this eventually revealed that either (a) there's a bug in our font loading functions, or (b) some fonts have some reserved bits set, which strikes me as odd. I have tested the patch with quite a few fonts, including (but not limited to) Apple Garamond, Apple Garamond Light, Arial, Arial Black, Arrus BT, Arrus Blk BT, Calibri, Cambria, Candara, Consolas, Constantia, Corbel, Courier New, Segoe, Segoe Black, Segoe Light, Segoe Condensed, Segoe Print, Segoe UI, Times New Roman, and Trebuchet MS. At least with those fonts (since I can't test every single font out there), the patch fixes the issue. And it passes Dmitry's tests. [1] http://bugs.winehq.org/show_bug.cgi?id=7571#c49

Aug. 14, 2007

Re: Font problem + patch solution

by Alexandre Julliard

"Abel Chiaro" <inckie(a)gmail.com> writes: > Alexandre Julliard wrote: >> You should provide test cases that show that your patch is correct. > > I used Dmitry's tests [1] for this patch. > > [1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html > > Shouldn't that be enough, I'll look into it again. So does that test behave differently for you with your patch? Does it show that things are fixed? Which font are you testing with? -- Alexandre Julliard julliard(a)winehq.org

Aug. 14, 2007

Re: [2/5] WineD3D: Optimize float constants in stateblocks

by Alexandre Julliard

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From f49fd192ed2747663bdb0445dff9d602519fbc95 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 3 Aug 2007 20:26:29 +0200 > Subject: [PATCH] WineD3D: Optimize float constants in stateblocks > > --- > dlls/wined3d/device.c | 24 +++++++++++++- > dlls/wined3d/stateblock.c | 68 +++++++++++++++++++++------------------- > dlls/wined3d/wined3d_private.h | 4 ++ > 3 files changed, 62 insertions(+), 34 deletions(-) This one is broken: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok wine: Unhandled page fault on write access to 0x000000f6 at address 0x61aad11c (thread 0039), starting debugger... WineDbg starting on pid 003a Unhandled exception: page fault on write access to 0x000000f6 in 32-bit code (0x61aad11c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:61aad11c ESP:0033fa90 EBP:0033fac8 EFLAGS:00010202( - 00 - -RI1) EAX:000000f6 EBX:61b3ae04 ECX:00000001 EDX:00000000 ESI:001bd4d0 EDI:001c6f78 Stack dump: 0x0033fa90: 001bd4d0 001bd4e4 00000001 00000000 0x0033faa0: 00000000 00000000 00000000 602d53b1 0x0033fab0: 00000000 00000000 0000002b 617da640 0x0033fac0: 617dad24 001bd4b8 0033faf8 617caebf 0x0033fad0: 00123d30 00000001 001bd4c0 001bd4b8 0x0033fae0: 606e97df 0000005c 617cae3b 60715808 Backtrace: =>1 0x61aad11c IWineD3DDeviceImpl_CreateStateBlock+0x3dc(iface=0x123d30, Type=0x1, ppStateBlock=0x1bd4c0, parent=0x1bd4b8) [/home/julliard/wine/wine/dlls/wined3d/device.c:478] in wined3d (0x0033fac8) 2 0x617caebf IDirect3DDevice8Impl_CreateStateBlock+0x8f(iface=0x121780, Type=0x1, pToken=0x33fe08) [/home/julliard/wine/wine/dlls/d3d8/device.c:1177] in d3d8 (0x0033faf8) 3 0x606e1260 func_device+0x2190() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:528] in d3d8_test (0x0033fe58) 4 0x606e8818 run_test+0x128(name=0x1103c5) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:389] in d3d8_test (0x0033fea8) 5 0x606e8ead main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:437] in d3d8_test (0x0033fed8) 6 0x606e958b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033ff08) 7 0x6041352e start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:820] in kernel32 (0x0033ffe8) 8 0x60027997 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x61aad11c IWineD3DDeviceImpl_CreateStateBlock+0x3dc [/home/julliard/wine/wine/dlls/wined3d/device.c:478] in wined3d: movl %edx,0x0(%eax,%edx,4) 478 object->contained_vs_consts_f[j] = j; -- Alexandre Julliard julliard(a)winehq.org

Aug. 14, 2007

Re: Font problem + patch solution

by Abel Chiaro

Alexandre Julliard wrote: > penna(a)bb.com.br writes: > > > There is a patch proposed at the bug #7571 (http://bugs.winehq.org/show_bug.cgi?id=7571) > > It works very well and I did not experiment any regression. Maybe > > it is not the ideal patch and if it is not, maybe we can provide a fix for > > that. However, at least it fixes the font problem and did not introduce > > any undesirable efects. > > Is that possible to apply that patch at the main tree? Comments > > are also welcome! > > You should provide test cases that show that your patch is correct. I used Dmitry's tests [1] for this patch. [1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html Shouldn't that be enough, I'll look into it again. - Pedro. -- "Caritas omnia vincit."

Aug. 14, 2007