August 2007 - Wine-Devel - list.winehq.org

Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.

by Peter Dons Tychsen

Hello again, 1) Yes i did testing on Windows-XP. I did it by putting together various examples and by checking with InSendMessage() for all cases. This clearly showed that WM_ACTIVATEAPP was always posted and never sent. 2) Yes, i tested with the msg.c test-cases. The patch does "break" some tests in it. Please read note below: However, the test system for msg.c in user32 i severely broken. If i upgrade the test system, it will require lots of more changes to prevent even more test-cases from breaking. The problem is in the ok_sequence_() function of the test system. It is missing a call to: while(PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessage(&msg); This is needed to make sure that all messages are pulled from the queue before it starts comparing with the expected messages (especially for posted message - sent messages are always received). I think is is also the reason why these tast-cases are a bit flaky. On machine the number of passed cases vary allot (because it ends up being timing dependent). If i introduce this in this patch, i will either be flamed for destroying working test cases or for changing too much. The change (which i think needs to be done) breaks around 100 test cases (allot of small changes). Mostly because they now get all the messages which were previously stuck on the queue. I think the missing line should be added in a patch by itself along with a fix for all the broken cases. Trying to blend it in with this patch will end up a mess. /Pedro On Thu, 2007-08-02 at 20:34 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > Hello Wine. > > > > On original Windows, the messages WM_ACTIVATEAPP are sent using > > PostMessage() and not SendMessage() like in the current Wine > > implementation. > > > > I have thoroughly verified that this is the case on Windows-XP (that it > > uses PostMessage()). > > > > This error can lead to fatal focusing problems, as some programs call > > more focus related functions when they receive this message. This leads > > to recursive calls into set_active_calls. It does not crash, but leads > > to unexpected results such as lost focus for mouse and keyboard. > > > > This fixes the focus for the game "Wild Metal" if you switch focus from > > the game to the desktop, and then back again. > > > > http://www.rockstargames.com/classics/ > > > > Cheers, > > > > /Pedro > > > > > > This patch makes 45 msg.c tests in user32 fail for me. Could you double > check your findings? Also when you say "thoroughly verified" have you used > Wine tests or your own program? > > > Vitaliy > >

Aug. 3, 2007

Re: gdi32: don't print fixme more than once

by Robert Shearman

Evan Stade wrote: > diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c > index 9e7684b..2b4d03f 100644 > --- a/dlls/gdi32/enhmetafile.c > +++ b/dlls/gdi32/enhmetafile.c > @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord( > > case EMR_EXTSELECTCLIPRGN: > { > + static int extselectcliprgn_cases; > #if 0 > const EMREXTSELECTCLIPRGN lpRgn = (const EMREXTSELECTCLIPRGN *)mr; > HRGN hRgn = ExtCreateRegion(NULL, lpRgn->cbRgnData, (RGNDATA *)lpRgn->RgnData); > @@ -1180,7 +1181,8 @@ #if 0 > /* ExtSelectClipRgn created a copy of the region */ > DeleteObject(hRgn); > #endif > - FIXME("ExtSelectClipRgn\n"); > + if(!(extselectcliprgn_cases++)) > + FIXME("ExtSelectClipRgn\n"); > break; > } > It would be better to re-enable this code, remove the fixme and fix whatever bug caused it to be disabled in the first place than to not show the fixme as often. -- Rob Shearman

Aug. 3, 2007

Re: Nigel Liang : winecfg: Read/write registry in unicode.

by James Hawkins

On 8/3/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29… > > Author: Nigel Liang <ncliang(a)gmail.com> > Date: Thu Aug 2 16:33:24 2007 -0700 > > winecfg: Read/write registry in unicode. > This patch breaks setting the windows version in winecfg (and I assume everything else that uses the registry): jhawkins(a)sphere2:~$ winecfg wine: Unhandled page fault on read access to 0x00000000 at address 0x7e5859d7 (thread 0010), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e5859d7). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7e5859d7 ESP:0033e2f0 EBP:0033e328 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:7e58d9e4 ECX:ffffffff EDX:00000000 ESI:7e587b60 EDI:00000000 Stack dump: 0x0033e2f0: 00110000 00000000 0000001c 0000000b 0x0033e300: 0016cdf8 0000000b 00000054 001727f8 0x0033e310: 0000001c 00172858 0016cdf8 7e58d9e4 0x0033e320: 7e587b60 7e587ac2 0033efd8 7e578877 0x0033e330: 80000002 7e587b60 7e587ab4 00000000 0x0033e340: 00000001 00000073 0033e398 7e1d19a7 Backtrace: =>1 0x7e5859d7 set_reg_key+0x8f(root=0x80000002, path=0x7e587b60, name=0x7e587ab4, value=0x0) [/home/jhawkins/wine/programs/winecfg/winecfg.c:471] in winecfg (0x0033e328) -- James Hawkins

Aug. 3, 2007

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes

by Stefan Dösinger

Am Freitag, 3. August 2007 18:18 schrieb H. Verbeet: > You are now executing that code multiple times. + This->baseTexture.states[WINED3DTEXSTA_MIPFILTER] = samplerStates[WINED3DSAMP_MIPFILTER]; + This->baseTexture.states[WINED3DTEXSTA_MINFILTER] = samplerStates[WINED3DSAMP_MINFILTER]; + This->baseTexture.states[WINED3DTEXSTA_MAXMIPLEVEL] = samplerStates[WINED3DSAMP_MAXMIPLEVEL]; That, combined with the check before the switch statement, should make sure that the whole block is executed only once. But I just noticed a double break; at the end.

Aug. 3, 2007

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes

by H. Verbeet

You are now executing that code multiple times.

Aug. 3, 2007

Re: [1/5] D3D9: Deal with failing surface creation

by H. Verbeet

On 03/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ok(SUCCEEDED(hr) || hr == D3DERR_INVALIDCALL, "IDirect3DDevice9_CreateTexture: %s\n", DXGetErrorString9(hr)); Same comment as for yesterday's test (even though that one apparently made it in), I don't think that's a useful test. As the patch comment says, the point of the test isn't to test CreateTexture behaviour.

Aug. 3, 2007

Re: Lostwages : contributing.diff

by Jeremy White

Hi Tom, Thanks for thinking of this; I think James would appreciate it if he wasn't listed by name, though. Otherwise, though, it looks great. Cheers, Jeremy Tom Wickline wrote: > Hello, > > I'm CC: Jeremy White in on this patch, if possible I would like to ask > for his approval on the patch before its committed. > > About the patch: > I Changed the mailing address of the WPF to point to the Software > Freedom Conservancy, and added some info about it being a 501(c)(3) > organization. > > Cheers, > > Tom > > Changelog: update WPF information and mailing address > > > ------------------------------------------------------------------------ > > Index: en/contributing.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/contributing.template,v > retrieving revision 1.33 > diff -u -r1.33 contributing.template > --- en/contributing.template 21 Jun 2007 20:21:46 -0000 1.33 > +++ en/contributing.template 31 Jul 2007 02:55:13 -0000 > @@ -363,8 +363,17 @@ > <h3 id="wpf">Wine Party Fund</h3> > > <p>The purpose of the Wine Party Fund is to show appreciation to Wine > - developers by collecting funds for developer meetings, such as future Wine > - Conferences, or in some cases to purchase documentation.</p> > +developers by collecting funds for developer meetings, such as future > +Wine Conferences, or in some cases to purchase documentation.</p> > + > +<p>The organization that currently manages our donations is the > +<a href="http://conservancy.softwarefreedom.org/">Software Freedom > +Conservancy</a>. If you have any questions or are otherwise in need > +of further assistance please visit the SFC site.</p> > + > +<p>The Software Freedom Conservancy is a 501(c)(3) organization, and > +donations made through it are fully tax-deductible to the extent > +permitted by law.</p> > <p><strong>Ways to contribute:</strong></p> > <form action="https://www.paypal.com/cgi-bin/webscr" method="post"> > <div> > @@ -379,13 +388,12 @@ > <p>We also have a SourceForge PayPal account > <a href="http://sourceforge.net/donate/index.php?group_id=6241">sourceforge.net</a></p> > > -<p>You can also send cash, checks or international money order in US funds to:</p> > -<address>The Wine Party Fund > -c/o Jeremy White > -CodeWeavers > -2356 University Ave. West > -Suite 420 > -St. Paul, MN 55114</address> > +<p>You can also send cash, cheque or international money order in US funds to:</p> > +<address>Wine Project > +c/o James Vasille > +Software Freedom Conservancy > +1995 Broadway FL 17 > +New York, NY 10023-5882</address> > <p>Purchase books or music from <a href="http://www.amazon.com/exec/obidos/redirect-home/winehq"> > Amazon.com</a> or <a href="http://www.cdnow.com/from=sr-1093221">CDnow</a> (Use > these specific links only, so that the Wine Party Fund gets the credit.)</p>

Aug. 3, 2007

[Fwd: [winetest] New gather script]

by Paul Vriens

Hi, Forgot to include wine-devel. -------- Original Message -------- Subject: [winetest] New gather script Hi Ferenc, Could you have a look at the new 'gather' script? (you're the original author after all). The new winetest (when committed of course) executable will report when a test is missing because of a failing dll. I've severely changed/mutilated 'gather' so: - it finds these missing dll tests and marks them - doesn't add these to the overall list of tests - goes through the whole list of tests to find out if (and why) tests are missing - it now shows also complete failing tests (for the group) in the group overview - add some extra onMouseOver on both group and single tests. - make sure we always show missing tests in the group overview. The new variables: $test->{dllmissing}->{$dll} (shows if a system/test is missing a dll) $group->{dllmissing}->{$unit} (tells if at least one system in the group is missing this dll, used for having a nice onMouseOver in the Main Summary) $group->{testmissing}->{$testname} (tells if at least one system in the group has a missing test for an unknown reason, needed to cope with the same onMouseOver as mentioned above). I'll split it up in smaller chunks when sent to wine-patches. Cheers, Paul. Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 3 Aug 2007 07:28:36 -0000 @@ -96,9 +96,19 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + # Mark this dll as being missing on one or more systems + + # For this run on this system + $testref->{dllmissing}->{$unit} = "This dll is missing on this system"; + # For the whole group + $group->{dllmissing}->{$unit} = "This dll is missing for some tests"; + } + else { + $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") + unless exists $alltests{$testname}; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; - $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") - unless exists $alltests{$testname}; if ($count ne "failed") { if (defined $group->{extrema}->{$testname}) { my $extrema = $group->{extrema}->{$testname}; @@ -117,6 +127,28 @@ push @{$group->{tests}}, $testref; } +# Find missing tests and/or missing dlls and mark them +foreach my $group (@groups) { + next unless exists $group->{tests}; + foreach my $testname (sort keys %alltests) { + foreach my $test (@{$group->{tests}}) { + if (!exists $test->{results}->{$testname}) { + # The test is missing, try to find the reason + my ($dll,$subtest) = split(/:/, $testname); + if (exists $test->{dllmissing}->{$dll}) { + $test->{results}->{$testname} = [-1, -1, -1, -1]; + $group->{digest}->{$testname} = "differ"; + } + else { + $test->{results}->{$testname} = [-2, -2, -2, -2]; + $group->{digests}->{$testname} = "differ"; + $group->{testmissing}->{$testname} = $testname; + } + } + } + } +} + # Write out the tables my ($header); # same in thead and tfoot @@ -197,28 +229,42 @@ # Output a single cell of a test sub singletest { my ($test, $testname, $groupname) = @_; - - if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my $file = "$test->{dir}/$testname.txt"; + my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; + if ($count eq "failed") { + # test run failed + my $msg = $todo eq "-"?"crash": + $todo == 258?"timeout":"failed"; + my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; + print OUT " <td class=\"note\">$fail</td>\n"; + } elsif ($count == -1) { + # dll missing + my ($dll, $subtest) = split(/:/, $testname); + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $dll.dll is not present on this system" + onMouseOver="No tests run as $dll.dll is not present on this system" + >0</a></td> +EOF + } elsif ($count == -2) { + # test missing + print OUT <<"EOF"; + <td class="skip_fail"><a + title="No tests run for an unknown reason" + onMouseOver="No tests run for an unknown reason" + >0</a></td> +EOF } else { - my $file = "$test->{dir}/$testname.txt"; - my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; - if ($count eq "failed") { - my $msg = $todo eq "-"?"crash": - $todo == 258?"timeout":"failed"; - my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; - print OUT " <td class=\"note\">$fail</td>\n"; - } else { - my $class = $error?"fail":"pass"; - my $skip = $skipped?"skip_":""; - print OUT <<"EOF"; + # test has run + my $class = $error?"fail":"pass"; + my $skip = $skipped?"skip_":""; + print OUT <<"EOF"; <td class="$skip$class"><a href="$file" title="$count tests, $todo TODO, $error errors, $skipped skipped" onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error,$skipped);" >$error</a></td> EOF - } } } @@ -236,6 +282,7 @@ } else { my $href = "href=\"#$group->{name}\""; if (exists $group->{extrema}->{$testname}) { + # At least one system in this group has run this test. my ($min,$max) = @{$group->{extrema}->{$testname}}; my $class = $min==0?($max==0?"pass":"mixed"):"fail"; my $title = $min==0?"":" title=\"Best: $min\""; @@ -246,7 +293,23 @@ >$max</a></td> EOF } else { - print OUT " <td class=\"note\"><a $href>.</a></td>\n"; + my ($dll, $subtest) = split(/:/, $testname); + if ($group->{testmissing}->{$testname}) { + # At least one system in the group has a missing test (but + # not because of a missing dll). + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } elsif (exists $group->{dllmissing}->{$dll}) { + # All systems in the group have a missing dll related to this test. + print OUT <<"EOF"; + <td class="pass"><a $href + title="No tests run as $dll.dll is not present on all $group->{name} systems" + onMouseOver="No tests run as $dll.dll is not present on all $group->{name} systems" + >0</a></td> +EOF + } else { + # All systems in this group failed to correctly run the test. + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } } } }

Aug. 3, 2007

Re: msvcrt40.dll

by Alexandre Julliard

luis.busquets(a)ilidium.com writes: > Nevertheless, msvcirt.dll is not currently one of the files to be ported, > i.e., dlls/msvcirt does not exist. > My questions are: > 1. Can we add the forward to all the rest of the functions in the > msvcrt40.dll spec file to msvcirt.dll? > 2. Should we first add a wine port of msvcirt.dll? Yes, and yes. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2007

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

by Hans Leidekker

On Thursday 02 August 2007, Jacek Caban wrote: > I agree that such a big code duplication is ugly, but that's the > way to go. We may separate the common code to different files in wininet > and keep them in sync with winhttp. This way it shouldn't be too hard to > implement most of the functionality you have implemented. I haven't seen a convincing argument for code duplication yet. We may even be able to achieve 100% by extending wininet a bit. E.g. we could add a Wine internal INTERNET_OPTION_CALLBACK_WINHTTP if we find an app that depends on winhttp specific behavior of callbacks. -Hans

Aug. 3, 2007