August 2007 - Wine-Devel - list.winehq.org

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

by Paul Vriens

Paul Vriens wrote: > Alexandre Julliard wrote: >> Paul Vriens <paul.vriens.wine(a)gmail.com> writes: >> >>> a patch somewhat like this? >> >> Yes; it may be better to do that in extract_test() since we get the >> test name there, it avoids hardcoding _test.exe at two different >> places. But the general principle is fine. >> > It doesn't make the code simpler though. When changing extract_test I > also have to make sure that the tests are not run (--list) in > get_subtests. I still have to get rid of the "_test.exe" in > extract_test. I have to fiddle with test->exename and test->name etc... > > Couldn't I just add a 'static const char testexec[] = "_test.exe" at the > top? > > Cheers, > > Paul. > Hi again, I have got it somewhat working (needs more testing). The attached screenshot shows the output from a win98 system (I only had d3d8 as missing in the report file for testing purposes). When you hover over the test, you will see the text as shown in the screenshot. Cheers, Paul.

Aug. 1, 2007

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

by Paul Vriens

Alexandre Julliard wrote: > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > >> a patch somewhat like this? > > Yes; it may be better to do that in extract_test() since we get the > test name there, it avoids hardcoding _test.exe at two different > places. But the general principle is fine. > It doesn't make the code simpler though. When changing extract_test I also have to make sure that the tests are not run (--list) in get_subtests. I still have to get rid of the "_test.exe" in extract_test. I have to fiddle with test->exename and test->name etc... Couldn't I just add a 'static const char testexec[] = "_test.exe" at the top? Cheers, Paul.

Aug. 1, 2007

Re: 32bit winelib builds in x86_64

by Alexandre Julliard

Michael Ost <most(a)museresearch.com> writes: > Seems I need to use "-m32" for g++, "--32" for as, and "-m elf_i386" > for ld. But with all the nested calls of wineg++ and winebuild I can't > figure out how to get those options passed in everywhere they are > needed. winegcc already takes care of this, except that it doesn't have the right flags for g++, that's a configure bug. I've committed a fix. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2007

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

by Alexandre Julliard

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > a patch somewhat like this? Yes; it may be better to do that in extract_test() since we get the test name there, it avoids hardcoding _test.exe at two different places. But the general principle is fine. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2007

Re: Direct3D Game test framework

by martin pilka

Stefan Dösinger wrote: > Am Dienstag, 31. Juli 2007 16:42 schrieb martin pilka: >> Hello Stefan, >> >> link works, I was able to run your test. Installation is ok, however test >> itself ends with '3DMark Error': '3DMark needs DirectX 7 and proper drivers >> installed in order to run'. This happens without CxTest as well, with >> latest WineHq. Note that DirectX7 or newer is correctly detected during >> installation process. >> >> Is it a bug in my configuration, or did I hit some Wine error? > Are you running on VNC? Do you have opengl support? This error occurs when I > run on a system without opengl support. It is without CxTest and without VNC. I do have HW acceleration and OpenGL (GLX) enabled. Attached is output of xdpyinfo. I am going to try whether 3DMark2001 works. Martin

Aug. 1, 2007

EVE Regression?

by Stephan Rose

Starting with wine 0.9.42 I continuously get the following error trying to start EVE: fixme:d3d_draw:drawPrimitive Using software emulation because not all material properties could be tracked And I just get a black screen for the login screen and it'll just sit there forever like that. The error keeps being reported over and over until I close the window. Everything worked very well with 0.9.41 Any thoughts? Anything I can do? Thanks, Stephan

Aug. 1, 2007

Re: Implement LockWorkstation using xdg-screensaver from explorer

by Steven Edwards

On 7/27/07, Alexandre Julliard <julliard(a)winehq.org> wrote: > Some sort of SendMessage to the desktop window should do the trick. Please ignore my other email to you. So something like this? Thanks for Vitaman on IRC for pointing out that spawnvp killed the calling process. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Aug. 1, 2007

Re: [4/4] winex11.drv: draw custom dashes [try2]

by Evan Stade

On 7/30/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] > * matched braces style of rest of file > * spread code out to make it more readable > * simplified use of gdi_to_x11_dashes > > dlls/winex11.drv/graphics.c | 3 + > dlls/winex11.drv/pen.c | 123 +++++++++++++++++++++++++++++++++++++++++-- > dlls/winex11.drv/x11drv.h | 1 > 3 files changed, 120 insertions(+), 7 deletions(-) > > -- > Evan Stade > > I am not sure how to make this patch more amenable. The gdi_to_x11_dashes function is indeed a bit unwieldy but it doesn't have all that simple a task. Does anyone have some suggestions on how to make it more acceptable? -- Evan Stade

Aug. 1, 2007

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

by Vitaliy Margolen

Peter Dons Tychsen wrote: > On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: >> Peter Dons Tychsen wrote: >>> On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: >>>> On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: >>>>> Peter Dons Tychsen wrote: >>>>>> OK. Please review this diff: >>>>>> >>>>>> I will re-submit it if you like it. >>>>>> >>>>>> /Pedro >>>>> Alright looks good now (you might want to remove the extra white space your >>>>> patch adds - git complains about those). Just left to make the same change >>>>> to the other joystick interface :) >>>>> >>>>> BTW don't forget to cc: the wine-devel list when you replying. >>>>> >>>>> Vitaliy. >>>> OK. I still feel that trying to sync joystick_linuxinput.c and >>>> joystick_linux.c is out of scope for this patch. But as my steadiness >>>> has limits i have done some of it anyway... :). I have kept the changes >>>> modest. >>>> >>>> Please take a look at the new patch. >>>> >>>> On another note i will agree with you that it would be practical if the >>>> two files had similar (or maybe even shared) code. Redundant code is >>>> never very practical as it always ends up as this very example. The two >>>> implementations which were supposed to identical always drift apart. If >>>> things are supposed to do the same, keep them together to begin with. >>>> >>>> Thanks, >>>> >>> Maybe i would be more successful if i actually attached the >>> patch.... :-) >>> >>> Here it is.... >> Just few small things left: >> >>> -#undef MAX_JOYSTICKS >> As I mentioned earlier you should move this instead of removing it completely. >> >> >>> static HRESULT joydev_create_deviceW(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEW* pdev) >>> { >>> - int i; >>> - >>> - find_joydevs(); >> You removed a really important function call here. >> >> >>> +static HRESULT joydev_create_deviceA(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEA* pdev) >>> +{ >>> + unsigned short index; >>> + >>> + if ((index = get_joystick_index(rguid)) < MAX_JOYDEV) { >>> + if ((riid == NULL) || >> If you reformat the whole function, please make it 4-space indented. >> >> Vitaliy. > > OK. Here is the new patch: > Looks good to me. The problem is, it doesn't work for me (USB joystick). I think you forgot to look at how joystick_linuxinput.c handles that data3 field. It's not just 0 based index... Vitaliy.

Aug. 1, 2007