August 2007 - Wine-Devel - list.winehq.org

Re: msvcrt: tests: some values of _mbctype are dependent on the version of Windows

by Alexandre Julliard

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -144,10 +144,18 @@ static int result_cp_949_mbctype[] = { 0 > static int result_cp_950_mbctype[] = { 0x0,65, 0x8,1, 0x18,26, 0x8,6, 0x28,26, 0x8,4, > 0x0,2, 0x4,32, 0xc,94, 0,1 }; > > +/* these characters may differ on different Windows versions */ > +static int fuzzy_cp_1252_mbctype[] = {142, 158, 170, 181, 186, -2}; > +static int fuzzy_cp_1250_mbctype[] = {131, 141, 142, 143, 157, 158, 159, 163, 165, 170, 175, 179, 181, 185, 186, 188, 190, 191, -2}; > +static int fuzzy_cp_932_mbctype[] = { -2 }; > +static int fuzzy_cp_936_mbctype[] = { -2 }; > +static int fuzzy_cp_949_mbctype[] = { -2 }; > +static int fuzzy_cp_950_mbctype[] = { -2 }; What this shows is that the exact values don't matter, and that apps are very unlikely to depend on them. This also means that having slightly different tables in Wine is not a problem, so I'd suggest to not try to test every single char, but just pick a few that are the same on all platforms. -- Alexandre Julliard julliard(a)winehq.org

Aug. 28, 2007

Re: [PATCH] Support for animated cursors

by Trent Waddington

On 8/28/07, H. Verbeet <hverbeet(a)gmail.com> wrote: > http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344… > should be a decent start. heh, making me think this is a well beaten path. > Well, what it comes down to is that you can't change the cursor memory > layout for win16 applications at all, which complicates things a bit. Oh I see, fun. Well, I suppose putting the info after the bitmaps will do it. Trent

Aug. 28, 2007

Re: [PATCH] Support for animated cursors

by H. Verbeet

On 28/08/07, Trent Waddington <trent.waddington(a)gmail.com> wrote: > On 8/28/07, H. Verbeet <hverbeet(a)gmail.com> wrote: > > You should use the timing and frame sequence info from the .ani. > > Also, Xcursor actually supports proper animated cursors, so it would > > be better to handle the animation in winex11.drv > > Can you please direct me to some example code of defining and using an > animated cursor with Xcursor? > http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344… should be a decent start. > > As explained in the comment at the top of cursoricon.c, you can't do > > that, because it will break win16 applications. > > Umm.. what comment would that be? This one: > * Cursors and icons are stored in a global heap block, with the > * following layout: > * > * CURSORICONINFO info; > * BYTE[] ANDbits; > * BYTE[] XORbits; > * > * The bits structures are in the format of a device-dependent bitmap. > * > * This layout is very sub-optimal, as the bitmap bits are stored in > * the X client instead of in the server like other bitmaps; however, > * some programs (notably Paint Brush) expect to be able to manipulate > * the bits directly :-( > Should I replace hNext with a CURSORICONINFO *? This is what I had > initially.. or should I be using something else? Or should I just > make it an BYTE bFrames and append multiple data blocks to the end of > the CURSORICONINFO struct? > Well, what it comes down to is that you can't change the cursor memory layout for win16 applications at all, which complicates things a bit.

Aug. 28, 2007

Re: [PATCH] the function called is cdecl, not WINAPI

by Marcus Meissner

On Mon, Aug 27, 2007 at 02:42:35PM -0700, Juan Lang wrote: > Hi Marcus, > > > the function called is cdecl, not WINAPI > > No it isn't. It's declared that way, but it's wrong. Calling it that > way in Windows crashes. That's why I sent this patch: > http://www.winehq.org/pipermail/wine-cvs/2007-August/035682.html Ah yes, this should fix the warning too (and is probably more correct). Didn't you get a warning during compilation here? Ciao, Marcus

Aug. 28, 2007

re: getting started...

by Dan Kegel

Ed wrote: >I'm brand new to the list and would like to get a Windows application that >I wrote (uCon) to work with wine/winelib. I've submitted it to the application >database. I've tried it on Wine and it *almost* works, so I'd like to pursue >this further by building uCon with Winelib (as is recommended somewhere >in the documentation). Egads. Where does it recommend that? Using winelib is a terrible idea unless you really need it (e.g. on non-x86 platforms, it's your only option). The downside is that your app suddenly becomes very fragile with respect to user updates of wine; they need a synchronized version of your app that matches their version of Wine. I've seen this happen, and it's not pretty. Also, this means double the QA and release trouble. The Right Thing To Do IMHO is just make your app and wine work better together, not use winelib. So your next move is to file bugs in http://bugs.winehq.org describing how your app doesn't work with wine, and work with us to solve them. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Aug. 28, 2007

Re: Old versions of Photoshop Elements tryout?

by Dan Kegel

On 8/27/07, Dan Kegel <dank(a)kegel.com> wrote: > On 8/27/07, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > Or all Trial from one Site: > > > > Photoshop Elements Trial: > > http://ftp.uniroma2.it/Adobe/photoshopelements/win/ Heh. Or ftp://ftp.adobe.com/pub/adobe/photoshopelements/win Sometimes the answer is right there in front of our eyes...

Aug. 28, 2007

Re: Old versions of Photoshop Elements tryout?

by Dan Kegel

On 8/27/07, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > I have a copy of Photoshop Elements 1.0, and can easily > > download a tryout of Photoshop Elements 5, but I don't know > > where to get trial versions of 2 through 4. Anyone know? > > Your SN for V4: > http://www.winehq.org/pipermail/wine-bugs/2006-August/037299.html > > Search for the Filename. > http://www.ntu.edu.sg/cits2/software/download/PSE_40_WWE_TryBuy.zip Ah, good point. I'd forgotten about that. > Or all Trial from one Site: > > Photoshop Elements Trial: > http://ftp.uniroma2.it/Adobe/photoshopelements/win/ Very helpful, thanks! (Now I just need to hope that site stays online long enoug to download them all :-) - Dan

Aug. 27, 2007

Re: 0001-Basic-starting-point-for-implementing-d3dx9_yz.dll.patch

by Detlef Riekenberg

On Mo, 2007-08-27 at 14:13 +0200, Martijn Berger wrote: > > --- > .gitignore | 1 + > Makefile.in | 1 + > configure.ac | 1 + > dlls/Makefile.in | 1 + > dlls/d3dx9/Makefile.in | 15 +++++++++++++++ > 5 files changed, 19 insertions(+), 0 deletions(-) > --- /dev/null > +++ b/dlls/d3dx9/Makefile.in > @@ -0,0 +1,15 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = d3dx9.dll > +IMPORTS = wined3d kernel32 > + > +C_SRCS = \ > + d3dx9_main.c > + > +RC_SRCS = version.rc This will not work: Your Makefile.in referenced "version.rc" and "d3dx9_main.c", but this files are missing in this Patch. You should never autogenerated modifications in any Patch: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… -- By by ... Detlef

Aug. 27, 2007

Re: Old versions of Photoshop Elements tryout?

by Detlef Riekenberg

On So, 2007-08-26 at 13:29 -0700, Dan Kegel wrote: > Hi all, > I have a copy of Photoshop Elements 1.0, and can easily > download a tryout of Photoshop Elements 5, but I don't know > where to get trial versions of 2 through 4. Anyone know? > Thanks, > Dan Google ? Your SN for V4: http://www.winehq.org/pipermail/wine-bugs/2006-August/037299.html Search for the Filename. http://www.ntu.edu.sg/cits2/software/download/PSE_40_WWE_TryBuy.zip Or all Trial from one Site: Photoshop Elements Trial: http://ftp.uniroma2.it/Adobe/photoshopelements/win/ Acrobat Trial: http://ftp.uniroma2.it/Adobe/acrobat/win/ -- By by ... Detlef

Aug. 27, 2007

[PATCH] the function called is cdecl, not WINAPI

by Juan Lang

Hi Marcus, > the function called is cdecl, not WINAPI No it isn't. It's declared that way, but it's wrong. Calling it that way in Windows crashes. That's why I sent this patch: http://www.winehq.org/pipermail/wine-cvs/2007-August/035682.html --Juan

Aug. 27, 2007