January 2008 - Wine-Devel - list.winehq.org

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

by James McKenzie

Jens Nestler wrote: > Am Dienstag, 29. Januar 2008 09:07:16 schrieb Rolf Kalbermatter: > >> Jens Nestler wrote: >> >>> [Patch for Bug 8551] MoveFileWithProgressW >>> unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING >>> >>> http://bugs.winehq.org/show_bug.cgi?id=8551 >>> >>> Hello, >>> >>> please find attached the patch for the bug mentioned above. >>> >> Hi Jens, >> >> Please diff your patches from the top level wine directory itself, as it >> is it's not helpful since the patch utility couldn't even know which of >> the many path.c files in the source tree needs to be patched, and the >> maintainer has a lot more things to do than to search where a patch could >> apply to. >> >> Rolf Kalbermatter >> > > Hi Rolf, > attached you can find the revised path. > Jens > > Please submit a git diff not a UNIX diff. James McKenzie

Jan. 29, 2008

Re: RegOverridePredefKey stub

by Dmitry Timoshkov

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > Sorry, I haven't seen it. > Can you please change it, or should I deliver a changed patch ? Please resend and updated patch with a 'Take 2' in the subject and an explanation in the body what's changed. -- Dmitry.

Jan. 29, 2008

Re: comctl32 failures on Win95, Win98, NT4 asnd Win2K

by Paul Vriens

Reece Dunn wrote: > These tests are all failing consistently with identical failures on > these platforms: > combobox - 21 failures; all identical across the platforms. > datetime - 2 failures; all identical across the platforms. > > The rebar tests have 146 failures on some (Win95 and NT4) and 545 > failures on others (Win98 and Win2K). This looks like it is due to a > different comctl32 version as a result of a different IE version. > > Several of the others have failures on Win95 and Win98 only. > > Is anyone going to look at these? > > - Reece > > > I already had a brief look and it appears that the failures started happening after: commit 7a5497b5c06600dc3b58788d0d6132e9f7cb7b87 Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Dec 10 01:27:50 2007 +0100 comctl32/tests: InitCommonControlsEx() is missing on Windows 95 so call InitCommonControls() instead. I didn't look further yet though. -- Cheers, Paul.

Jan. 29, 2008

Wine BOF at Scale 6X in Los Angeles, Feb 8th

by Dan Kegel

Anyone going to Scale in Los Angeles? I've scheduled a Wine BOF at 7pm on Friday, Feb 8th; see http://www.socallinuxexpo.org/scale6x/conference-info/social-events/birds-o… For those who don't know, SCALE is the brightest spot in Los Angeles' open source / free software scene. They've been going for eight years now. It's where I first saw a Samba developer running Windows in a VM and immediately going from Ethereal traces to implementing new code :-) See you there, I hope! (The BOF is a combined BOF with Zumastor, but don't worry, that just means I'll be talking with two people instead of one :-) - Dan

Jan. 29, 2008

comctl32 failures on Win95, Win98, NT4 asnd Win2K

by Reece Dunn

These tests are all failing consistently with identical failures on these platforms: combobox - 21 failures; all identical across the platforms. datetime - 2 failures; all identical across the platforms. The rebar tests have 146 failures on some (Win95 and NT4) and 545 failures on others (Win98 and Win2K). This looks like it is due to a different comctl32 version as a result of a different IE version. Several of the others have failures on Win95 and Win98 only. Is anyone going to look at these? - Reece

Jan. 29, 2008

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

by Jens Nestler

Am Dienstag, 29. Januar 2008 09:07:16 schrieb Rolf Kalbermatter: > Jens Nestler wrote: > > [Patch for Bug 8551] MoveFileWithProgressW > > unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING > > > > http://bugs.winehq.org/show_bug.cgi?id=8551 > > > > Hello, > > > > please find attached the patch for the bug mentioned above. > > Hi Jens, > > Please diff your patches from the top level wine directory itself, as it > is it's not helpful since the patch utility couldn't even know which of > the many path.c files in the source tree needs to be patched, and the > maintainer has a lot more things to do than to search where a patch could > apply to. > > Rolf Kalbermatter Hi Rolf, attached you can find the revised path. Jens

Jan. 29, 2008

Re: No new winetest?

by Reece Dunn

On 26/01/2008, Francois Gouget <fgouget(a)free.fr> wrote: > On Fri, 25 Jan 2008, Paul Millar wrote: > [...] > > The front-end machine had stopped responding to network traffic. > [...] > > So, sorry, winetest will be off-line until Monday at the earliest. > > Thanks for the status update. Is there any more news on this? - Reece

Jan. 29, 2008

RE: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING

by Rolf Kalbermatter

Jens Nestler wrote: > [Patch for Bug 8551] MoveFileWithProgressW > unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING > > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. Hi Jens, Please diff your patches from the top level wine directory itself, as it is it's not helpful since the patch utility couldn't even know which of the many path.c files in the source tree needs to be patched, and the maintainer has a lot more things to do than to search where a patch could apply to. Rolf Kalbermatter

Jan. 29, 2008

Re: RegOverridePredefKey stub

by Jens Nestler

Am Dienstag, 29. Januar 2008 07:07:26 schrieb Dmitry Timoshkov: > "Jens Nestler" <nessi(a)nessi-online.de> wrote: > > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.000000000 +0100 > > +++ wine-0.9.54/include/winreg.h 2008-01-28 22:07:55.000000000 +0100 > > @@ -131,6 +131,7 @@ > > WINADVAPI LSTATUS WINAPI RegLoadKeyA(HKEY,LPCSTR,LPCSTR); > > WINADVAPI LSTATUS WINAPI RegLoadKeyW(HKEY,LPCWSTR,LPCWSTR); > > #define RegLoadKey WINELIB_NAME_AW(RegLoadKey) > > +WINADVAPI LSTATUS WINAPI RegOverridePredefKey(HKEY,HKEY); > > WINADVAPI LSTATUS WINAPI > > RegLoadMUIStringA(HKEY,LPCSTR,LPSTR,DWORD,LPDWORD,DWORD,LPCSTR); > > WINADVAPI LSTATUS WINAPI > > RegLoadMUIStringW(HKEY,LPCWSTR,LPWSTR,DWORD,LPDWORD,DWORD,LPCWSTR); > > #define RegLoadMUIString > > WINELIB_NAME_AW(RegLoadMUIString) > > Isn't there something that suggests that the entries are alphabetically > sorted? Sorry, I haven't seen it. Can you please change it, or should I deliver a changed patch ? Jens

Jan. 29, 2008

Re: RegOverridePredefKey stub

by Dmitry Timoshkov

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.000000000 +0100 > +++ wine-0.9.54/include/winreg.h 2008-01-28 22:07:55.000000000 +0100 > @@ -131,6 +131,7 @@ > WINADVAPI LSTATUS WINAPI RegLoadKeyA(HKEY,LPCSTR,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadKeyW(HKEY,LPCWSTR,LPCWSTR); > #define RegLoadKey WINELIB_NAME_AW(RegLoadKey) > +WINADVAPI LSTATUS WINAPI RegOverridePredefKey(HKEY,HKEY); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringA(HKEY,LPCSTR,LPSTR,DWORD,LPDWORD,DWORD,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringW(HKEY,LPCWSTR,LPWSTR,DWORD,LPDWORD,DWORD,LPCWSTR); > #define RegLoadMUIString WINELIB_NAME_AW(RegLoadMUIString) Isn't there something that suggests that the entries are alphabetically sorted? -- Dmitry.

Jan. 29, 2008