January 2008 - Wine-Devel - list.winehq.org

Re: Bugzilla: Remove obsolete components

by James Hawkins

On Jan 28, 2008 1:12 PM, Austin English <austinenglish(a)gmail.com> wrote: > Howdy, > > I just finished moving over the last of the obsolete components. > _obsolete_binary, _obsolete_directx, and _obsolete_gui can all be > removed now. > Also, can you please make the following changes: rename: wineps-driver -> wineps.drv winmm&mci -> winmm x11-driver -> winex11.drv add: wintab32 msacm32 wintrust rasapi32 msvfw32 Thanks, James Hawkins

Jan. 29, 2008

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

by James Hawkins

On Jan 28, 2008 4:05 PM, Jens Nestler <nessi(a)nessi-online.de> wrote: > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. > Please submit a test case for this change as well. -- James Hawkins

Jan. 29, 2008

Wine Wiki spam users

by Vitaliy Margolen

Does anyone have a power to block / remove those users that spam Wine wiki? It seems just 2-3 users keep creating more and more spam. Can't we just remove them and permanently block an IP range? Vitaliy.

Jan. 29, 2008

Re: start.exe: Handle the process title argument (try2)

by Dmitry Timoshkov

"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote: > - Use GlobalFree instead of LocalFree According to MSDN LocalFree is the correct one, as I asked before you need to fix Wine implementation of CommandLineToArgvW. -- Dmitry.

Jan. 29, 2008

Re: [PATCH 1/1] winecoreaudio: Make sure Port_SendToMessageThread is non-NULL in CoreAudio_WaveRelease.

by Ken Thomases

On Jan 28, 2008, at 8:06 AM, Misha Koshelev wrote: > I have started playing with wine on MacOS in VMWare. > wineprefixcreate page faults on my > MacOS "system" and I tracked it to Port_SendToMessageThread staying > NULL because of: > err:wave:CoreAudio_WaveInit AudioHardwareGetProperty: > CoreAudio_DefaultDevice.outputDeviceID == kAudioDeviceUnknown > Clearly wineprefixcreate shouldn't be page faulting under any > condition. It seems to me that the driver ought to just fail to load in this case. If you back out your patch and apply the attached patch, does that fix the page fault? -Ken

Jan. 29, 2008

Bugzilla: Remove obsolete components

by Austin English

Howdy, I just finished moving over the last of the obsolete components. _obsolete_binary, _obsolete_directx, and _obsolete_gui can all be removed now. -Austin

Jan. 28, 2008

Re: start.exe: Handle the process title argument

by Detlef Riekenberg

On So, 2008-01-27 at 21:18 +0100, Alexander Nicolaysen Sørnes wrote: > SHELLEXECUTEINFOW sei; > + OSVERSIONINFOW vi; > WCHAR *args = NULL; > - int i; > + int i = 1; > The idention show a mismatch between SPACE and TAB -- By by ... Detlef

Jan. 28, 2008

Re: your winhttp work

by Hans Leidekker

On Sunday 27 January 2008 15:11:23 Hans Leidekker wrote: > I think layering can be done in a relatively clean way by making wininet > handle the superset of wininet and winhttp callbacks and adding callback > filtering as required by winhttp. Old wininet behavior can then be obtained > by an implicit filter on the wininet subset of callbacks. Here's a patch to show how it can be done. -Hans

Jan. 28, 2008

Re: start.exe: Handle the process title argument

by Alexander Nicolaysen Sørnes

On Monday 28 January 2008 04:58:12 you wrote: > "Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote: > > + NOTE: This will only work when run from Wine's cmd, but > > that's ok as start is a builtin + shell command on NT */ > > What's the purpose of the comment above? > Just to be informative to someone working with start.exe. I can remove it. > > + if(argc > 1 && (vi.dwMajorVersion >= 5 || (vi.dwMajorVersion == > > 4 && vi.dwPlatformId == 2))) > > Unless there is an app which would break because of the title set there is > no need to check the version. > I don't have an app handy that relies on the DOS/Win 9x behaviour of start, but commands like start "notepad" a.txt start "C:\Program Files\app.exe" would work with the old behaviour but not with the new one; thus I assumed some apps would break if not checking the Windows version. > > + { > > + int cmdcount; > > + WCHAR* cmdline = GetCommandLineW(); > > + WCHAR** cmdargs = CommandLineToArgvW(cmdline, &cmdcount); > > + WCHAR* pos = cmdline; > > wmain() already has arc/argv pair of parameters, why do you need to parse > command line again? > We need to check for the first parameter beginning with a double quote ("). This is stripped from the argv array. > > + > > + pos += lstrlenW(cmdargs[0]); > > + > > + while(*pos == ' ') > > + pos++; > > + > > + if(*pos == '"') > > + { > > + /* FIXME: Set the process title */ > > + i++; > > + } > > + LocalFree(cmdargs); > > + } > > I assume that you've added LocalFree as MSDN suggests, but > CommandLineToArgvW in Wine uses GlobalAlloc, perhaps you could fix that? Sure. :)

Jan. 28, 2008

Sorry about the extraordinary amount of wine-bugs spam

by Dan Kegel

I've been as annoyed as anybody at the huge churn on wine-bugs lately, it makes it hard to actually read, and the mailing list archive can't really cope. But there seems to be no way around it, so I decided to get a bunch more out of the way in one fell (and I do mean fell) swoop. In particular, I closed over a thousand old RESOLVED FIXED, RESOLVED ABANDONED, RESOLVED WORKSFORME, and RESOLVED INVALID bugs tonight. You can see the effect here: http://bugs.winehq.org/reports.cgi?product=Wine&datasets=RESOLVED%3A&datase… The only real benefit of this is fixed bugs will show up with strikethrough now when referenced in bugzilla, which is actually kind of nice. I'd like to get all the wine-bugs churn out of the way during January, if possible. For reference, the rule of thumb for closing RESOLVED bugs is: FIXED and WORKSFORME: can be closed after two weeks (i.e. after release) ABANDONED: can be closed after three months INVALID: can be closed immediately, but if it's less than a couple months old, check to make sure somebody wasn't just being cranky - Dan

Jan. 28, 2008