October 2008 - Wine-Devel - list.winehq.org

re: patchwatcher problem

by Dan Kegel

Vitaly Perov wrote: >Today I sent the patch "netapi32: add stub for NetShareAdd" > On the old patchwatcher it fails: > winspool.drv:info.c:1281: Test failed: Parameter size wrong! 4 expected got 0 > My patch changes only netapi32. > I have no idea why the winespool.drv test can fail. Sorry, I think that was my fault. I accidentally ran wine on the patchwatcher account by hand around then. - Dan

Oct. 31, 2008

Re: [Re] Vertex pipeline replacement

by Tobias Jakobi

Stefan Dösinger wrote: >> If you know which patch might have broken this, start there. If you do >> not, a normal regression test is a good idea. > It will always be the last patch. This patch does the real thing, the others > are just making the infrastructure more flexible. So a regression test in > this case is mostly useless > > > So what should I do then? What about opening a metabug and adding all apps what break with the new code? Or do you wanna have all this in separate bug reports? Greets, Tobias

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Dan Kegel

On Fri, Oct 31, 2008 at 8:51 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > 2008/10/31 Dan Kegel <dank(a)kegel.com>: >> How would we do this on Windows? (We need the >> winetest results to be reliable, too.) >> That was the main reason I didn't go for LD_PRELOAD... >> I guess we do some sort of DLL injection, but I haven't done >> it personally before. >> > You could patch the IAT, but that's quite a bit less nice than > LD_PRELOAD, of course. The thing is, I want to support running tests on Windows as well. May as well do it the same way everywhere... - Dan

Oct. 31, 2008

Please, look at my patch, I'm not sure it's correct

by Vitaly Perov

Hi, This patch add a stub implementation of IMarshal interface. I have no experience at implementing interfaces, so I'm not sure it's implemented correctly. Please, look at this patch. I'll be grateful for any remarks. Thank you. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

Oct. 31, 2008

Re: malloc to HeapAlloc in dlls/kernel32/process.c

by Michael Stefaniuc

Hello Pete, Pete Myers wrote: > Hi, this is my first ever commit to the Wine project. > > In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch > that changes all malloc calls in ./dlls/kernel32/process.c to HeapAlloc. > > Changelog: > * malloc calls in dlls/kernel32/process.c have been change to HeapAlloc as you might have seen Alexandre removed today those malloc calls himself as those weren't trivial patches. bye michael

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Henri Verbeet

2008/10/31 Dan Kegel <dank(a)kegel.com>: > How would we do this on Windows? (We need the > winetest results to be reliable, too.) > That was the main reason I didn't go for LD_PRELOAD... > I guess we do some sort of DLL injection, but I haven't done > it personally before. > - Dan > You could patch the IAT, but that's quite a bit less nice than LD_PRELOAD, of course.

Oct. 31, 2008

RE: [Re] Vertex pipeline replacement

by Stefan Dösinger

> If you know which patch might have broken this, start there. If you do > not, a normal regression test is a good idea. It will always be the last patch. This patch does the real thing, the others are just making the infrastructure more flexible. So a regression test in this case is mostly useless

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Dan Kegel

On Fri, Oct 31, 2008 at 8:11 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > 2008/10/31 James Mckenzie <jjmckenzie51(a)earthlink.net>: >> This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. >> > I don't see how that's a problem, or how that's different from eg. Linux. > > More on-topic, I don't think it would be hard to do some LD_PRELOAD > hacks on getaddrinfo(), gethostbyname(), and whatever else is > appropriate. How would we do this on Windows? (We need the winetest results to be reliable, too.) That was the main reason I didn't go for LD_PRELOAD... I guess we do some sort of DLL injection, but I haven't done it personally before. - Dan

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Dan Kegel

On Fri, Oct 31, 2008 at 6:15 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Yes, I think this could use a bit of standardization. Perhaps > we could have a scheme like this: > > http.test.winehq.org > ftp.test.winehq.org > ldap.test.winehq.org > pop3.test.winehq.org > ... > > And mandate that networked tests use those. Then you would > have a predictable list of hostnames to redirect. That sounds like a great idea regardless of what else we do. - Dan

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Hans Leidekker

On Friday 31 October 2008 15:52:43 James Mckenzie wrote: > >What happened to your /etc/hosts proposal? It has the > >advantage that we don't need changes to Wine source code. > > > This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. That's true for Unix in general, but I think we require admin rights already because the services need to bind ports below 1024 for example. -Hans

Oct. 31, 2008