October 2008 - Wine-Devel - list.winehq.org

Re: wininet: let automated testers force all DNS lookups to return localhost

by Henri Verbeet

2008/10/31 James Mckenzie <jjmckenzie51(a)earthlink.net>: > This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. > I don't see how that's a problem, or how that's different from eg. Linux. More on-topic, I don't think it would be hard to do some LD_PRELOAD hacks on getaddrinfo(), gethostbyname(), and whatever else is appropriate.

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by James Mckenzie

Hans Leidekker <hans(a)codeweavers.com> at Oct 31, 2008 5:32 AM wrote about Re: wininet: let automated testers force all DNS lookups to return localhost >> Only include this in debugging builds. > >What happened to your /etc/hosts proposal? It has the >advantage that we don't need changes to Wine source code. > This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. James McKenzie

Oct. 31, 2008

Re: [Re] Vertex pipeline replacement

by James Mckenzie

James Hawkins <truiken(a)gmail.com> at Oct 30, 2008 9:22 PM wrote about Re: [Re] Vertex pipeline replacement > >On Thu, Oct 30, 2008 at 10:07 PM, James McKenzie ><jjmckenzie51(a)earthlink.net> wrote: >> Tobias Jakobi wrote: >>> Short feedback: >>> - Max Payne 2: works as expected, I don't see any visual changes >>> - Morrowind: 3D rendering breaks completly, minor (blending?) issues in >>> the menu as well - however ingame scenes are fully black now >>> >>> How should I report this? Open a bug? Should I do any regression testing >>> (since your patchset consists of more than one patch)? >>> >>> >> Do a regression test to locate which patch breaks Morrowmind. >> >> If you know which patch might have broken this, start there. If you do >> not, a normal regression test is a good idea. >> > >Tobias is referring to Stefan's RFC concerning his vertex pipeline >replacement patch. Stefan asked for users to test the patch to see if >any games break. Thank you. This is a 'good thing' to do before sending the patch through to wine-patches. It looks like this patch needs more work. James McKenzie

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Hans Leidekker

On Friday 31 October 2008 13:39:36 Dan Kegel wrote: > On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > What happened to your /etc/hosts proposal? It has the > > advantage that we don't need changes to Wine source code. > > But the disadvantage that we need to know > which servers the test code is going to look up. > I guess I should change my patch to log the actual > name being looked up, then we can get a list. > Do we have any sort of policy about which hostnames > can be used during tests? Yes, I think this could use a bit of standardization. Perhaps we could have a scheme like this: http.test.winehq.org ftp.test.winehq.org ldap.test.winehq.org pop3.test.winehq.org ... And mandate that networked tests use those. Then you would have a predictable list of hostnames to redirect. -Hans

Oct. 31, 2008

patchwatcher problem

by Vitaly Perov

Hi! Today I sent the patch "netapi32: add stub for NetShareAdd" On the old patchwatcher it fails: > winspool.drv:info.c:1281: Test failed: Parameter size wrong! > 4 expected got 0 My patch changes only netapi32. I have no idea why the winespool.drv test can fail. On the new patchwatcher it have passed. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Dan Kegel

On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > What happened to your /etc/hosts proposal? It has the > advantage that we don't need changes to Wine source code. But the disadvantage that we need to know which servers the test code is going to look up. I guess I should change my patch to log the actual name being looked up, then we can get a list. Do we have any sort of policy about which hostnames can be used during tests? > You would need to duplicate this code in every dll that > does networking, if possible. I don't think it will work > for wldap32, where there is no lookup call to hook into. That's ok, I'd happily duplicate it. - Dan

Oct. 31, 2008

Re: wininet: let automated testers force all DNS lookups to return localhost

by Hans Leidekker

On Friday 31 October 2008 12:45:58 Dan Kegel wrote: > The public internet can (and does) go pear-shaped > in the middle of test runs, which means any test > that tries to access the public internet is de facto > flaky, even if it tries to protect itself by skipping > if the internet is down. > > So let's provide a way for automated testers to > force all hostname resolution requests to > return the same result (say, 'localhost' or 'mytestserver'). > Only include this in debugging builds. What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. You would need to duplicate this code in every dll that does networking, if possible. I don't think it will work for wldap32, where there is no lookup call to hook into. -Hans

Oct. 31, 2008

Re: [Re] Vertex pipeline replacement

by Henri Verbeet

2008/10/31 Austin English <austinenglish(a)gmail.com>: > > Apply a single patch at a time until it breaks. > You'll probably just end up with patch 12, which is huge and enables the entire thing.

Oct. 31, 2008

Re: [Re] Vertex pipeline replacement

by Austin English

On Thu, Oct 30, 2008 at 11:22 PM, James Hawkins <truiken(a)gmail.com> wrote: > On Thu, Oct 30, 2008 at 10:07 PM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: >> Tobias Jakobi wrote: >>> Short feedback: >>> - Max Payne 2: works as expected, I don't see any visual changes >>> - Morrowind: 3D rendering breaks completly, minor (blending?) issues in >>> the menu as well - however ingame scenes are fully black now >>> >>> How should I report this? Open a bug? Should I do any regression testing >>> (since your patchset consists of more than one patch)? >>> >>> >> Do a regression test to locate which patch breaks Morrowmind. >> >> If you know which patch might have broken this, start there. If you do >> not, a normal regression test is a good idea. >> > > Tobias is referring to Stefan's RFC concerning his vertex pipeline > replacement patch. Stefan asked for users to test the patch to see if > any games break. > > -- > James Hawkins > > > Apply a single patch at a time until it breaks. -- -Austin

Oct. 31, 2008

Re: [Re] Vertex pipeline replacement

by James Hawkins

On Thu, Oct 30, 2008 at 10:07 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > Tobias Jakobi wrote: >> Short feedback: >> - Max Payne 2: works as expected, I don't see any visual changes >> - Morrowind: 3D rendering breaks completly, minor (blending?) issues in >> the menu as well - however ingame scenes are fully black now >> >> How should I report this? Open a bug? Should I do any regression testing >> (since your patchset consists of more than one patch)? >> >> > Do a regression test to locate which patch breaks Morrowmind. > > If you know which patch might have broken this, start there. If you do > not, a normal regression test is a good idea. > Tobias is referring to Stefan's RFC concerning his vertex pipeline replacement patch. Stefan asked for users to test the patch to see if any games break. -- James Hawkins

Oct. 31, 2008