December 2008 - Wine-Devel - list.winehq.org

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test (try3)

by Paul Vriens

Nikolay Sivov wrote: > Changelog(try3): > - fixed identation in testlist > Changelog(try2): > - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test > - added test for zero dimensions > > P.S. Render with this types spotted in traces of bugs 6799 and 10050 > >>From 3386e8674380390c3b60c6247443c605ffe6ff6a Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 10 Dec 2008 13:41:09 +0300 > Subject: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render > > --- > dlls/oleaut32/olepicture.c | 8 +++++ > dlls/oleaut32/tests/olepicture.c | 64 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 72 insertions(+), 0 deletions(-) > > diff --git a/dlls/oleaut32/olepicture.c b/dlls/oleaut32/olepicture.c > index 498ee53..bdce729 100644 > --- a/dlls/oleaut32/olepicture.c > +++ b/dlls/oleaut32/olepicture.c > @@ -637,6 +637,10 @@ static HRESULT WINAPI OLEPictureImpl_Render(IPicture *iface, HDC hdc, > TRACE("prcWBounds (%d,%d) - (%d,%d)\n", prcWBounds->left, prcWBounds->top, > prcWBounds->right, prcWBounds->bottom); > > + if(cx == 0 || cy == 0 || cxSrc == 0 || cySrc == 0){ > + return CTL_E_INVALIDPROPERTYVALUE; > + } > + > /* > * While the documentation suggests this to be here (or after rendering?) > * it does cause an endless recursion in my sample app. -MM 20010804 > @@ -644,6 +648,10 @@ static HRESULT WINAPI OLEPictureImpl_Render(IPicture *iface, HDC hdc, > */ > > switch(This->desc.picType) { > + case PICTYPE_UNINITIALIZED: > + case PICTYPE_NONE: > + /* nothing to do */ > + return S_OK; > case PICTYPE_BITMAP: > { > HBITMAP hbmpOld; > diff --git a/dlls/oleaut32/tests/olepicture.c b/dlls/oleaut32/tests/olepicture.c > index f81c419..9e33121 100644 > --- a/dlls/oleaut32/tests/olepicture.c > +++ b/dlls/oleaut32/tests/olepicture.c > @@ -25,6 +25,7 @@ > #include <float.h> > > #define COBJMACROS > +#define NONAMELESSUNION > > #include "wine/test.h" > #include <windef.h> > @@ -587,6 +588,68 @@ static void test_enhmetafile(void) > GlobalFree(hglob); > } > > +static void test_Render(void) > +{ > + IPicture *pic; > + HRESULT hres; > + short type; > + PICTDESC desc; > + HDC hdc = GetDC(0); > + > + /* test IPicture::Render return code on uninitialized picture */ > + OleCreatePictureIndirect(NULL, &IID_IPicture, TRUE, (VOID**)&pic); > + hres = IPicture_get_Type(pic, &type); > + ok(hres == S_OK, "IPicture_get_Type does not return S_OK, but 0x%08x\n", hres); > + ok(type == PICTYPE_UNINITIALIZED, "Expected type = PICTYPE_UNINITIALIZED, got = %d\n", type); > + /* zero dimensions */ > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 0, 0, 0, 0, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 10, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 0, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 0, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 10, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 0, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 0, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + /* nonzero dimensions, PICTYPE_UNINITIALIZED */ > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 10, 10, NULL); > + ole_expect(hres, S_OK); > + IPicture_Release(pic); > + > + desc.cbSizeofstruct = sizeof(PICTDESC); > + desc.picType = PICTYPE_ICON; > + desc.u.icon.hicon = LoadIcon(NULL, IDI_APPLICATION); > + if(!desc.u.icon.hicon){ > + win_skip("LoadIcon failed. Skipping...\n"); Shouldn't you also use ReleaseDC() here for consistency sake? > + return; > + } > + > + OleCreatePictureIndirect(&desc, &IID_IPicture, TRUE, (VOID**)&pic); > + /* zero dimensions, PICTYPE_ICON */ > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 0, 0, 0, 0, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 10, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 0, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 10, 0, 0, 0, 0, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 10, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 10, 0, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + hres = IPicture_Render(pic, hdc, 0, 0, 0, 0, 0, 0, 10, 10, NULL); > + ole_expect(hres, CTL_E_INVALIDPROPERTYVALUE); > + IPicture_Release(pic); > + > + ReleaseDC(NULL, hdc); -- Cheers, Paul.

Dec. 10, 2008

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

by Nikolay Sivov

Michael Karcher wrote: > Am Mittwoch, den 10.12.2008, 13:31 +0300 schrieb Nikolay Sivov: > >>>> - remove some tabs from testfile >>>> >>> Please don't change formatting, especially with an incorrect tab size. >>> >> Ok, but I'm using 4 spaces tab size. Is it wrong? >> > > Tab size in wine source code is defined to be 8. Your patch was mixing > tabbed lines with space-indented lines. This causes the code to look > wrong at the standard tab size. > > As a rule of thumb: You should indent you new code with the same > character sequence (spaces/tabs) as the code of the function that > already is there. Your newest iteration still is not OK. The indentation > of the tests in the main test list at the end is (although this is not > nice) partly indented with tabs, partly indented with 8 spaces. You add > a line indented with 4 spaces. > > In the Wine project, whitespace cleanup patches (replacing tabs by > spaces or the other way around) to lines that do not get other changes > are generally frowned upon and usually reject, so don't feel requested > to fix the tab-n-space mix in the test list as well. Just choose one of > the correct variants, that is 8 spaces or one tab. > > Regards, > Michael Karcher > > > Resent. Thank you.

Dec. 10, 2008

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

by Michael Karcher

Am Mittwoch, den 10.12.2008, 13:31 +0300 schrieb Nikolay Sivov: > >> - remove some tabs from testfile > > Please don't change formatting, especially with an incorrect tab size. > Ok, but I'm using 4 spaces tab size. Is it wrong? Tab size in wine source code is defined to be 8. Your patch was mixing tabbed lines with space-indented lines. This causes the code to look wrong at the standard tab size. As a rule of thumb: You should indent you new code with the same character sequence (spaces/tabs) as the code of the function that already is there. Your newest iteration still is not OK. The indentation of the tests in the main test list at the end is (although this is not nice) partly indented with tabs, partly indented with 8 spaces. You add a line indented with 4 spaces. In the Wine project, whitespace cleanup patches (replacing tabs by spaces or the other way around) to lines that do not get other changes are generally frowned upon and usually reject, so don't feel requested to fix the tab-n-space mix in the test list as well. Just choose one of the correct variants, that is 8 spaces or one tab. Regards, Michael Karcher

Dec. 10, 2008

Re: [5/5] winex11.drv: Fix color conversion for 16 bpp cursors.

by Alexandre Julliard

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > case 16: > - /* BGR, 5 red, 6 green, 5 blue */ > - *pixel_ptr = *xor_ptr * 0x1f; > - *pixel_ptr |= (*xor_ptr & 0xe0) << 3; > + /* [gggbbbbb][rrrrrggg] -> [xxxxxxxx][rrrrr000][gggggg00][bbbbb000] */ It seems to me that zero-padding isn't quite right, you should expand the values linearly. -- Alexandre Julliard julliard(a)winehq.org

Dec. 10, 2008

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

by Nikolay Sivov

Alexandre Julliard wrote: > Nikolay Sivov <bunglehead(a)gmail.com> writes: > > >> Changelog: >> - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test >> - added test for zero dimensions >> - remove some tabs from testfile >> > > Please don't change formatting, especially with an incorrect tab size. > > Ok, but I'm using 4 spaces tab size. Is it wrong?

Dec. 10, 2008

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

by Alexandre Julliard

Nikolay Sivov <bunglehead(a)gmail.com> writes: > Changelog: > - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test > - added test for zero dimensions > - remove some tabs from testfile Please don't change formatting, especially with an incorrect tab size. -- Alexandre Julliard julliard(a)winehq.org

Dec. 10, 2008

Re: winetest: fix a compiler warning

by Vincent Povirk

These are addressing some very weird cases. They should be an improvement, but I wonder if we can't do better. > void xprintf (const char *fmt, ...) > { > va_list ap; >- size_t size; >+ size_t size = 0; > DWORD written; It would make more sense, IMO, to update the vstrfmtmake function to also set *lenp to 0, if lenp is set, when it runs out of memory. Winetest uses that function indirectly in other places, and one has a similar problem. (Of course, if we did run out of memory, it's a pretty dismal situation, and the returned string will be NULL, but at least xprintf will silently fail instead of crashing.) > extract_test (struct wine_test *test, const char *dir, LPTSTR res_name) > { > BYTE* code; >- DWORD size; >+ DWORD size = 0; For this to matter, the extract_rcdata call has to fail. This is, again, a pretty dismal situation. In this case, we'll later be writing data starting at NULL, and of an undefined, or with this change 0, length. I don't know if that actually works, and it may be better to give up early. Vincent Povirk

Dec. 10, 2008

Patchwatcher status: offline

by Dan Kegel

My house is being rewired, so Patchwatcher is offline for a day.

Dec. 10, 2008

Re: App hang on creating modal dialog

by Dan Kegel

On Tue, Dec 9, 2008 at 6:48 PM, Jeff Miller <jmiller-wine(a)tanner.com> wrote: >>> http://bugs.winehq.org/show_bug.cgi?id=16346 > > I'm not sure how to create a non-interactive unit test case for this, since > it involves interplay with the window manager and results in a hang. Does it hang all of wine? If not, maybe you could have a second thread doing a timeout. If it *does* hang all of wine, that's an argument for adding timeouts to "make test".

Dec. 10, 2008

Re: App hang on creating modal dialog

by Jeff Miller

Dan Kegel wrote: > Jeff wrote: > >> I'm trying to solve my bug 16346 >> http://bugs.winehq.org/show_bug.cgi?id=16346 >> ... >> I'm trying to figure out where in the wine code I should look for a >> system that might be eating all of the messages intended for my >> application. Can anyone point me in the right direction? >> > > I dunno, but that test case is nice and small. Can you > turn it into a wine conformance test? That will make it > even more likely somebody helps find a solution... > - Dan > I'm not sure how to create a non-interactive unit test case for this, since it involves interplay with the window manager and results in a hang. If someone could point out a similar test case I could pattern mine on, that would be great. On the solution end of things, I have discovered that the following patch resolves the problem. The issue is that the MessageBox is created from within a WM_ACTIVATEAPP message which initiated from the X11 driver. The X11 driver is coded to prevent nested events from being handled. Is there a good reason to prevent nested X11 events from being handled? Jeff From: Jeff Miller <jmiller-wine(a)tanner.com> Date: Tue, 9 Dec 2008 18:33:20 -0800 Subject: Fix bug #16346 by allowing nested X11 events to be handled. --- dlls/winex11.drv/event.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c index 5f7ebef..83a4a82 100644 --- a/dlls/winex11.drv/event.c +++ b/dlls/winex11.drv/event.c @@ -403,8 +403,6 @@ DWORD X11DRV_MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *handles, timeout, flags & MWMO_ALERTABLE ); } - if (data->current_event) mask = 0; /* don't process nested events */ - if (process_events( data->display, filter_event, mask )) ret = count - 1; else if (count || timeout) { -- 1.6.0.3

Dec. 10, 2008

RE: Одговор: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

by Stefan Dösinger

> > Henry, with this patch 'Environment Bump Mapping' test is looking > good, but > > 'fixme:d3d_shader:register_for_arg Unknown source argument 255' is > > still there - continous in many cases, not just in 3DMark2001SE... Is > > this fixme useless, when this works? > > > Stefan has a fix for that. Milan, the arguments that the FIXME warns about are all unused. Known unused arguments are marked with a special value(ARG_UNUSED) to suppress this fixme. A code elsewhere incorrectly sets a different value accidentally, so the FIXME isn't suppressed properly. It is harmless though. The value is indeed unknown, but it isn't used anywhere either.

Dec. 9, 2008

Re: WineHQ redesign

by Vitaliy Margolen

Jeremy Newman wrote: > It is in sync with the rest of the site(s). It is now using 10pt font > instead of 10px. > > Fix it for someone, break it for someone else. > > -Newman > > Vitaliy Margolen wrote: >> Jeremy Newman wrote: >>> I have committed my work for the WineHQ redesign. I've also updated >>> the AppDB and Bugzilla codebases with the new theme. >> >> The font on bugzilla looks 2x bigger then it's used to. The strange part >> it's only the bugzilla part that looks big. Menus are fine. >> >> Vitaliy I don't think so. See attached image. Also see bug 16438: http://bugs.winehq.org/show_bug.cgi?id=16438 Vitaliy.

Dec. 9, 2008

Re: oleaut32: add PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render

by Nikolay Sivov

Jeremy Drake wrote: > On Tue, 9 Dec 2008, Nikolay Sivov wrote: > > >> + case PICTYPE_NONE: >> + case PICTYPE_UNINITIALIZED: >> + /* undocumented code */ >> + return 0x800A017C; >> > > This code looks suspiciously like CTL_E_INVALIDPROPERTYVALUE (from > olectl.h) to me... > > You're right. It returns CTL_E_INVALIDPROPERTYVALUE when at least one of dimensions is zero. I'll update a patch.

Dec. 9, 2008

Re: appdb sidebar has issues

by Alexander Nicolaysen Sørnes

What browser are you using? For me the sidebar text is displayed within the intended confinement, however it is smaller than the rest of the AppDB text and thus a tiny bit harder to read than it should be. Firefox 3 Alexander On Tuesday 09 December 2008 20:47:10 ricardo filipe wrote: > http://img186.imageshack.us/my.php?image=semttulojh9.jpg > > some links do not fit the appdb sidebar and there are blank spaces o.0 > > also, shouldn't the background extend to all site? now it's confined to the > homepage size.... > _________________________________________________________________ > Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! > http://www.amigosdomessenger.com.br/

Dec. 9, 2008

RE: appdb sidebar has issues

by ricardo filipe

i'm on firefox 3 too, but it's fixed now :) thx jeremy.> From: alex(a)thehandofagony.com> To: wine-devel(a)winehq.org; ricardo_barbano(a)hotmail.com> Subject: Re: appdb sidebar has issues> Date: Tue, 9 Dec 2008 21:40:54 +0100> > What browser are you using? For me the sidebar text is displayed within the > intended confinement, however it is smaller than the rest of the AppDB text > and thus a tiny bit harder to read than it should be.> > Firefox 3> > > Alexander> > On Tuesday 09 December 2008 20:47:10 ricardo filipe wrote:> > http://img186.imageshack.us/my.php?image=semttulojh9.jpg> >> > some links do not fit the appdb sidebar and there are blank spaces o.0> >> > also, shouldn't the background extend to all site? now it's confined to the> > homepage size....> > _________________________________________________________________> > Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger!> > http://www.amigosdomessenger.com.br/> > _________________________________________________________________ Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! http://video.msn.com/?mkt=pt-br

Dec. 9, 2008

Re: appdb sidebar has issues

by Jeremy Newman

Fixed the blank spaces thing that logged in users were seeing. Been a looooong time since I played with the appdb codebase. -Newman Alexander Nicolaysen Sørnes wrote: > What browser are you using? For me the sidebar text is displayed within the > intended confinement, however it is smaller than the rest of the AppDB text > and thus a tiny bit harder to read than it should be. > > Firefox 3 > > > Alexander > > On Tuesday 09 December 2008 20:47:10 ricardo filipe wrote: >> http://img186.imageshack.us/my.php?image=semttulojh9.jpg >> >> some links do not fit the appdb sidebar and there are blank spaces o.0 >> >> also, shouldn't the background extend to all site? now it's confined to the >> homepage size.... >> _________________________________________________________________ >> Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! >> http://www.amigosdomessenger.com.br/ > > > >

Dec. 9, 2008

Re: WineHQ redesign

by Jeremy Newman

It is in sync with the rest of the site(s). It is now using 10pt font instead of 10px. Fix it for someone, break it for someone else. -Newman Vitaliy Margolen wrote: > Jeremy Newman wrote: >> I have committed my work for the WineHQ redesign. I've also updated the >> AppDB and Bugzilla codebases with the new theme. > > The font on bugzilla looks 2x bigger then it's used to. The strange part > it's only the bugzilla part that looks big. Menus are fine. > > Vitaliy

Dec. 9, 2008

Re: WineHQ redesign

by Vitaliy Margolen

Jeremy Newman wrote: > I have committed my work for the WineHQ redesign. I've also updated the > AppDB and Bugzilla codebases with the new theme. The font on bugzilla looks 2x bigger then it's used to. The strange part it's only the bugzilla part that looks big. Menus are fine. Vitaliy

Dec. 9, 2008

Re: Одговор: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

by Henri Verbeet

2008/12/9 Milan Kostić <smoki00790(a)gmail.com>: > Henry, with this patch 'Environment Bump Mapping' test is looking good, but > 'fixme:d3d_shader:register_for_arg Unknown source argument 255' is > still there - continous in many cases, not just in 3DMark2001SE... Is > this fixme useless, when this works? > Stefan has a fix for that.

Dec. 9, 2008

appdb sidebar has issues

by ricardo filipe

http://img186.imageshack.us/my.php?image=semttulojh9.jpg some links do not fit the appdb sidebar and there are blank spaces o.0 also, shouldn't the background extend to all site? now it's confined to the homepage size.... _________________________________________________________________ Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! http://www.amigosdomessenger.com.br/

Dec. 9, 2008

Re: defwnd: implement handling of WM_INPUTLANGCHANGE

by Aric Stewart

doh! good catch! thanks, i will correct that and resend. -aric Paul Chitescu wrote: > On Tuesday 09 December 2008 21:17:32 Aric Stewart wrote: > [...] > + while (win_array[count]) > + SendMessageA( win_array[count], WM_INPUTLANGCHANGE, wParam, > lParam); > > Missing a ++ here ? >

Dec. 9, 2008

Re: defwnd: implement handling of WM_INPUTLANGCHANGE

by Paul Chitescu

On Tuesday 09 December 2008 21:17:32 Aric Stewart wrote: [...] + while (win_array[count]) + SendMessageA( win_array[count], WM_INPUTLANGCHANGE, wParam, lParam); Missing a ++ here ?

Dec. 9, 2008

Re: WineHQ redesign

by Paul Chitescu

On Monday 08 December 2008 22:49:15 Jeremy Newman wrote: > I tweaked the font sizes a bit. > > -Newman > > Tijl Coosemans wrote: > > On Monday 08 December 2008 20:42:30 Jeremy Newman wrote: > >> This is because of the "font-size: medium". IE Renders medium text > >> much larger than Gecko and Webkit. I prefer to use "font-size: > >> 12px;", but that disables IEs ability to change the text size via the > >> page drop down. > >> > >> I will revert back to my method as this gives me the fine grain > >> control over font size that I desire. > > > > That makes it unreadable on high DPI screens. What about 10pt or > > something? I have some issues with the side bar of AppDB because the style for mouse hover changes the font weight. This should be avoided on any web site. Depending on browser and settings this can cause insane flickering - changing the layout of the text in frame leaves the mouse pointer outside the text so text changes to non-hover then back to hover ad infinitum. Paul Chitescu

Dec. 9, 2008

Re: new web design takes too much space on left

by Jeremy Newman

I'm done, this design has taken enough of my time. You will need to generate patches for ALL the sites if you want to change it now. -Newman Dan Kegel wrote: > When working on a notebook computer, I find myself > resenting the amount of real estate taken by > the left hand navbar in bugzilla. > > I bet we could shave 20% of that space without > bothering anyone... > >

Dec. 9, 2008

Re: new web design takes too much space on left

by Lei Zhang

On Tue, Dec 9, 2008 at 10:38 AM, Dan Kegel <dank(a)kegel.com> wrote: > When working on a notebook computer, I find myself > resenting the amount of real estate taken by > the left hand navbar in bugzilla. > > I bet we could shave 20% of that space without > bothering anyone... The images in the background are big enough such that if you increase your browser font size up to a certain point, it would still fit. It would be nice if the bg image can extend outwards according to the text size. I've seen it on some sites, but not sure what the css magic is.

Dec. 9, 2008

Re: WineHQ redesign

by Brian Vincent

On Mon, Dec 8, 2008 at 10:40 AM, Jeremy Newman <jnewman(a)codeweavers.com>wrote: > I have committed my work for the WineHQ redesign. I've also updated the > AppDB and Bugzilla codebases with the new theme. > By the way, the new site looks great on a Blackberry using Opera Mini or even the regular Blackberry browser. Great work! -Brian

Dec. 9, 2008

Re: [PATCH] gdi32: Use font substitution for source font when linking fonts.

by Lei Zhang

On Fri, Dec 5, 2008 at 4:46 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is sort of related to bug 16325. I've noticed some applications > use the "MS Shell Dlg" font to display CJK text and fails. > > In HKLM\Software\Microsoft\Windows NT\CurrentVersion\FontSubstitutes, > MS Shell Dlg is set to Tahoma. > > I tried adding a font link for Tahoma in > HKLM\Software\Microsoft\Windows NT\CurrentVersion\FontLink\Systemlink, > but that didn't seem to help. I then tried adding a font link for MS > Shell Dlg, but that didn't have any effect either. > > Taking a closer look, in init_system_links(), both the Tahoma and MS > Shell Dlg entries in Systemlink create a Tahoma entry in memory, due > to the MS Shell Dlg -> Tahoma font substitution. However, in > create_child_font_list(), we check the in-memory list for MS Shell > Dlg, which can never be found. > > With this additional font substitution, create_child_font_list() looks > for Tahoma instead, and the CJK text gets displayed properly. > Anything wrong with this patch?

Dec. 9, 2008

new web design takes too much space on left

by Dan Kegel

When working on a notebook computer, I find myself resenting the amount of real estate taken by the left hand navbar in bugzilla. I bet we could shave 20% of that space without bothering anyone...

Dec. 9, 2008

Re: WineHQ redesign

by Jeremy Newman

Reece Dunn wrote: > Some issues: > 1. The wiki is not using the new layout. Dimi is currently updating the Wiki. > 2. In the forums top-level page, the navigation is displayed in one > big list that pushes the forum content to the bottom of the screen. > 3. The WineHQ link on the forums page links back to the forums page > and not the main website. Side effects of you loading the page while I was still editing it. Should be good now. -Newman

Dec. 9, 2008

Re: WineHQ redesign

by Tomasz Sałaciński

Honestly - I am never using IE, I even don't know how to enable Javascript. I've changed the security level from "Custom" to "Medium" - it fixed the problem. But since the images are not moving, why someone can't draw the correct background onto them, so people in corporate networks when taking decision whatever to use Linux&Wine or not won't have bad "first impression" when looking at WINE's website. These people don't know that IE doesn't support alpha in PNG's. Dnia 2008-12-09, wto o godzinie 11:44 -0600, Jeremy Newman pisze: > Do you have javascript disabled? I have a javascript workaround that > makes PNGs load the alpha correctly under IE6. > > -Newman > > Tomasz Sałaciński wrote: > > Hi, > > > > I've been looking at the new WineHQ webiste and it looks really nice, > > but it doesn't support older browsers. > > > > Today I tried to test it at my computer at work and the website doesn't > > work properly on IE6: > > > > http://alarm-clock.54.pl/winehq.png > > > > IE6 doesn't support transparency in PNG's. > > > > If WINE is to attract Windows users to Linux, it needs to display the > > website properly, or at least show a message to upgrade to a newer > > browser. > > > > Cheers > > > > Dnia 2008-12-09, wto o godzinie 10:08 -0600, Jeremy Newman pisze: > >> It's possible. > >> > >> -Newman > >> > >> Ferenc Wagner wrote: > >>> Jeremy Newman <jnewman(a)codeweavers.com> writes: > >>> > >>>> http://wine.codeweavers.com/winehq_new/ > >>> Is it possible to add some preload magic for the impressed button > >>> images? Otherwise the buttons disappear for a moment when I hover > >>> above them the first time. > >> > >

Dec. 9, 2008

Re: WineHQ redesign

by Reece Dunn

2008/12/9 Reece Dunn <msclrhd(a)googlemail.com>: > Some issues: > 1. The wiki is not using the new layout. > 2. In the forums top-level page, the navigation is displayed in one > big list that pushes the forum content to the bottom of the screen. > 3. The WineHQ link on the forums page links back to the forums page > and not the main website. Other issues: 1. the navigation links at the top produce the rollover hover correctly when the mouse is over the button, but you can only click on the text area; this is confusing, as the whole tab should be the link. 2. the mini-navigation panes -- these also only display the link sections on the text, their hit area does not span the entire width (missing a display: block; ??) and there is no hover colour. Great work, - Reece

Dec. 9, 2008

Re: WineHQ redesign

by Jeremy Newman

Do you have javascript disabled? I have a javascript workaround that makes PNGs load the alpha correctly under IE6. -Newman Tomasz Sałaciński wrote: > Hi, > > I've been looking at the new WineHQ webiste and it looks really nice, > but it doesn't support older browsers. > > Today I tried to test it at my computer at work and the website doesn't > work properly on IE6: > > http://alarm-clock.54.pl/winehq.png > > IE6 doesn't support transparency in PNG's. > > If WINE is to attract Windows users to Linux, it needs to display the > website properly, or at least show a message to upgrade to a newer > browser. > > Cheers > > Dnia 2008-12-09, wto o godzinie 10:08 -0600, Jeremy Newman pisze: >> It's possible. >> >> -Newman >> >> Ferenc Wagner wrote: >>> Jeremy Newman <jnewman(a)codeweavers.com> writes: >>> >>>> http://wine.codeweavers.com/winehq_new/ >>> Is it possible to add some preload magic for the impressed button >>> images? Otherwise the buttons disappear for a moment when I hover >>> above them the first time. >> >

Dec. 9, 2008

Re: WineHQ redesign

by Tomasz Sałaciński

Hi, I've been looking at the new WineHQ webiste and it looks really nice, but it doesn't support older browsers. Today I tried to test it at my computer at work and the website doesn't work properly on IE6: http://alarm-clock.54.pl/winehq.png IE6 doesn't support transparency in PNG's. If WINE is to attract Windows users to Linux, it needs to display the website properly, or at least show a message to upgrade to a newer browser. Cheers Dnia 2008-12-09, wto o godzinie 10:08 -0600, Jeremy Newman pisze: > It's possible. > > -Newman > > Ferenc Wagner wrote: > > Jeremy Newman <jnewman(a)codeweavers.com> writes: > > > >> http://wine.codeweavers.com/winehq_new/ > > > > Is it possible to add some preload magic for the impressed button > > images? Otherwise the buttons disappear for a moment when I hover > > above them the first time. > >

Dec. 9, 2008

Re: WineHQ redesign

by Reece Dunn

Some issues: 1. The wiki is not using the new layout. 2. In the forums top-level page, the navigation is displayed in one big list that pushes the forum content to the bottom of the screen. 3. The WineHQ link on the forums page links back to the forums page and not the main website. Looking good, otherwise. - Reece

Dec. 9, 2008

Re: uxtheme: fix a compiler warning

by Austin English

On Tue, Dec 9, 2008 at 2:35 AM, Michael Karcher <karcher(a)physik.fu-berlin.de> wrote: > Am Dienstag, den 09.12.2008, 00:39 -0600 schrieb Austin English: >> - MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g); >> - if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) { >> + if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &r) && >> + MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g) && >> + MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) { > I would like to see the last two lines indented more than the "if" line. > Take a look at line 748 in msstyles.c to find a precedence case in the > file you are patching. In short, that would mean > > + if(MSSTYLES_GetNextInteger(...) && > + MSSTYLES_GetNextInteger(...) && > + MSSTYLES_GetNextInteger(...)) > + { > > Regards, > Michael Karcher > > > > Patch was already committed. If I fix something else in this file, I'll update this as well. Otherwise, feel free to do so. -- -Austin

Dec. 9, 2008

Re: Alexandre Julliard : include: Added some definitions for x86_64 exception handling.

by Alexandre Julliard

"Steven Edwards" <winehacker(a)gmail.com> writes: > On Tue, Dec 9, 2008 at 7:23 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Author: Alexandre Julliard <julliard(a)winehq.org> >> Date: Mon Dec 8 19:27:59 2008 +0100 >> >> include: Added some definitions for x86_64 exception handling. > > was this a typo? You also added ia64/itanium stuff on this commit. A couple, yes, but I don't have any plans to implement ia64 exception handling if that's what you are wondering... -- Alexandre Julliard julliard(a)winehq.org

Dec. 9, 2008

Re: WineHQ redesign

by Rosanne DiMesio

On Tue, 09 Dec 2008 10:08:56 -0600 The background on the forum is now entirely black. Links are red, but messages are completely unreadable. -- Rosanne DiMesio <dimesio(a)earthlink.net>

Dec. 9, 2008

Re: oleaut32: add PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render

by Jeremy Drake

On Tue, 9 Dec 2008, Nikolay Sivov wrote: > + case PICTYPE_NONE: > + case PICTYPE_UNINITIALIZED: > + /* undocumented code */ > + return 0x800A017C; This code looks suspiciously like CTL_E_INVALIDPROPERTYVALUE (from olectl.h) to me...

Dec. 9, 2008

Re: Alexandre Julliard : include: Added some definitions for x86_64 exception handling.

by Steven Edwards

On Tue, Dec 9, 2008 at 7:23 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Dec 8 19:27:59 2008 +0100 > > include: Added some definitions for x86_64 exception handling. was this a typo? You also added ia64/itanium stuff on this commit. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Dec. 9, 2008

Re: WineHQ redesign

by Jeremy Newman

It's possible. -Newman Ferenc Wagner wrote: > Jeremy Newman <jnewman(a)codeweavers.com> writes: > >> http://wine.codeweavers.com/winehq_new/ > > Is it possible to add some preload magic for the impressed button > images? Otherwise the buttons disappear for a moment when I hover > above them the first time.

Dec. 9, 2008

Re: WineHQ redesign

by Jeremy Newman

I prefer the rounded tabs. -Newman Stephen Gentle wrote: > I still think that the tabs could use a little work - I hacked this > together in Photoshop a little while ago: > http://stephengentle.com/media/images/wine/tabs.png - ignore the lack of > content and most of the layout... > > As for the rest of the site, the main thing I don't like is that > everything is just a little too rounded. Apart from that, it's looking > pretty good. > > Stephen

Dec. 9, 2008

Re: [msi/tests] Run tests again on Win9x and NT4

by Paul Vriens

James Hawkins wrote: > On Tue, Dec 9, 2008 at 9:32 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> Hi, >> >> MsiEnumPatchesExA is not implemented below NT4. >> >> Changelog >> Run tests again on Win9x and NT4 >> > > - r = MsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, > + r = pMsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, > MSIPATCHSTATE_ALL, 0, patchcode, > targetprod, &context, > targetsid, &size); > > Please align the extra parameter lines with the extra character in the > first line. > Sorry, did it again. Will resend. -- Cheers, Paul.

Dec. 9, 2008

Re: [msi/tests] Run tests again on Win9x and NT4

by James Hawkins

On Tue, Dec 9, 2008 at 9:32 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > MsiEnumPatchesExA is not implemented below NT4. > > Changelog > Run tests again on Win9x and NT4 > - r = MsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, + r = pMsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, MSIPATCHSTATE_ALL, 0, patchcode, targetprod, &context, targetsid, &size); Please align the extra parameter lines with the extra character in the first line. -- James Hawkins

Dec. 9, 2008

Re: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

by Henri Verbeet

I've attached a patch to bug 16412 (http://bugs.winehq.org/show_bug.cgi?id=16412) that might help.

Dec. 9, 2008

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > Ok, I'll send in a patch with todo_wine and let you decide. > > My feeling was that without opengl support we should skip the opengl32 > tests, hence the skip in the original patch. The todo_wine was to > flag Wine's ChoosePixelFormat bug. My concern is that my OpenGL setup gets regularly broken by Debian updates, and I notice it when tests start failing. If all the tests just skip, I may end up committing patches that haven't been regression tested. So I'd like to have at least one test failure when OpenGL is compiled in but not working. -- Alexandre Julliard julliard(a)winehq.org

Dec. 9, 2008

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

by Huw Davies

On Mon, Dec 08, 2008 at 01:44:41PM +0100, Alexandre Julliard wrote: > Huw Davies <huw(a)codeweavers.com> writes: > > > Hi Alexandre, > > > > This wasn't what I intended my patch to do. The problem is that > > Wine's ChoosePixelFormat() rets 0 on XServers without glX. The > > win_skip results in a test failure. My patch was intended to mark > > this as a todo_wine. > > We could have a todo_wine around the win_skip, though I'm not quite > convinced that having the opengl32 test succeed without opengl support > is the right thing to do. Ok, I'll send in a patch with todo_wine and let you decide. My feeling was that without opengl support we should skip the opengl32 tests, hence the skip in the original patch. The todo_wine was to flag Wine's ChoosePixelFormat bug. Huw. -- huw(a)codeweavers.com

Dec. 9, 2008

Re: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

by James Mckenzie

Milan Kostić <smoki00790(a)gmail.com> at Dec 9, 2008 7:27 AM (MST) wrote about: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10 > > Console says: > > fixme:d3d_shader:register_for_arg Unknown source argument 255 > > And picture is odd with 1.1.10, in 1.1.9<= it was good i think. I >don't know exactly, but this regression can be due changes in >ati_fragment_shader.c. > > Xorg-1.5.3 > Mesa-7.2 (r200) > ATI 9250 > Can you run a regression test to discover where Wine broke this? James McKenzie

Dec. 9, 2008

Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

by Milan Kostić

Console says: fixme:d3d_shader:register_for_arg Unknown source argument 255 And picture is odd with 1.1.10, in 1.1.9<= it was good i think. I don't know exactly, but this regression can be due changes in ati_fragment_shader.c. http://i263.photobucket.com/albums/ii149/smokidungeon/wine-1110.jpg http://i263.photobucket.com/albums/ii149/smokidungeon/wine-119.jpg Xorg-1.5.3 Mesa-7.2 (r200) ATI 9250

Dec. 9, 2008

Re: WineHQ redesign

by Alexandru Balut

On Mon, Dec 8, 2008 at 6:57 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > http://wine.codeweavers.com/winehq_new/ The images which appear when hovering the main links have some white pixels in the upper left part, between the bright red border and the srinked original image. It would be nice if you could introduce some effect without the shrinking. Thanks, Alex

Dec. 9, 2008

RE: [3/4]

by Stefan Dösinger

> The patch essentially adds a version to the constants and throws them > in a queue. The disadvantage is that setting a constant becomes a bit > more expensive, and cache usage becomes a bit worse if you have to > load constants from deeper in the tree, but it still gives me about 10 > extra fps in the CSS stress test. Whoa, that's an impressive improvement! I didn't see that much room for improvement in the CS:S performance at all. How expensive is a shader_glsl_load_constant call if no constant was changed? I assume that no GL call is made in that case, > I don't see how setting vertex and fragment shaders at the same time > hurts us that much, it just gives the shader backend a certain degree > of freedom. I'd argue that my patch gives the shader backend more freedom. A backend implementation is free to use the same function for vertexshader_select and fragmentshader_select, as we use the same prototype. All it has to do(or better, should do) is checking wether it will be called again via a isStateDirty check. However, this check is done in the current code already, just outside of the shader backend(ie, it is forced onto the backend even if it is not needed) > Please also keep issue 20 from ARB_geometry_shader4 in > mind. While it's possible to do crazy stuff like mixing > ARB_vertex_program with fragment shaders, you can't mix > ARB_vertex_program with a geometry shader. I don't care too much about mixing ARB with GLSL. It might be a neat trick for MacOS, but it doesn't work in the way we need it in the current architecture anyway. To work around those MacOS GLSL bugs we'd have to select the backend based on the concrete shader. Having a ARBvp+GLSLfrag shader backend selected at library load isn't any better than what we have now in terms of MacOS bugdodgeability. > On the other hand, if you > really wanted to do that kind of mixing, you could just create two > backends and always pass FALSE for usePS to one backend, and always > pass FALSE for useVS to the other. It's not impossible, just ugly. > Splitting the shader backend doesn't change anything there. I'll come back to this should I ever send in an ATIfs or NVTS shader backend :-) . That solution is fine with me. > I do have an opinion on how the shader backend should fit in with the > rest of the code. So far, I haven't heard anything that would make me > change that opinion. I think we have a different understanding of what the gobal state table infrastructure is supposed to be. I didn't intend it as a "fixed function" state table, but rather a tool for managing all sorts of states. It includes things like blending, the scissor test or even the index buffer, which are not affected by shaders at all(since they're neither part of the vertex, fragment or geometry pipeline). So I don't think limiting the state table to the fixed function pipeline would be correct, even if shaders sat on top of it. (yes, there are many fixed function states and just a few shader states, but that's due to the nature of the two pipelines) I don't think that the vertex shader bypasses the fixed function vertex pipeline argument works here either. We have such a relationship between states elsewhere, e.g. D3DRS_LIGHTING overrides the lights, D3DRS_ALPHABLENDENABLE overrides various alpha states etc. I'm not convinced that shaders are special in any way. There's also the point about skipping applying fixed function states when the shader is active. I really think this should be up to the fragment pipeline implementation. The ARB fragment pipeline replacement skips the states(because it has to), the fixed function GL pipeline doesn't. Functionally it doesn't make any difference for the ffp pipeline. Performance wise you can argue both. If we apply the states it makes switching the shader on and off cheaper, if we do not apply them it helps broken games.

Dec. 9, 2008