December 2008 - Wine-Devel - list.winehq.org

Re: mscoree: Add a stub for LockClrVersion

by Jeff Zaroyko

On Sat, Dec 20, 2008 at 3:12 PM, Chris Wulff <crwulff(a)rochester.rr.com> wrote: > A stub for LockClrVersion. > > -- Chris Wulff > > Hi Chris You need to set your name and email address in git then regenerate your patches. git repo-config user.name "Your Name" git repo-config user.email "me(a)example.com" -Jeff

Dec. 20, 2008

Re: qedit: tests/mediadet.c test skips sometimes

by Rico Schüller

Austin English schrieb: > On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller <kgbricola(a)web.de> wrote: > >> Hi, >> could anyone try the attached patch for the qedit test on a windows machine? >> It works around bug 16548. But according to the comment in the source I >> think this could be a mistake. I'd like to know if it works without renaming >> the file on windows. On wine it works. >> >> Cheers >> Rico >> >> diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c >> index 2b43124..558ff3a 100644 >> --- a/dlls/qedit/tests/mediadet.c >> +++ b/dlls/qedit/tests/mediadet.c >> @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) >> return FALSE; >> >> DeleteFileW(name); >> +/* >> + Renaming isn't a good way to solve this, see bug 16548. >> lstrcpyW(name + lstrlenW(name) - 3, avi); >> - >> +*/ >> fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, >> FILE_ATTRIBUTE_NORMAL, NULL); >> if (fh == INVALID_HANDLE_VALUE) >> >> >> >> >> > > Tested on my 2k machine, works fine though. That XP machine has always > been a bit buggy, so I wouldn't worry about it too much (times out on > the tests a lot, even though it's got 2 GB ram/dual core CPU). > > Thanks for your test. I think I've found the problem ... it is in UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix, UINT unique, LPWSTR buffer ) in line UINT num = GetTickCount() & 0xffff; . On fast machines GetTickCount has the same value when it is called two times in a short time. Therefore it generates the same time and as a result the same file, which isn't the case on windows. On windows it looks like there is a number increasing each run by one, something like this static UINT num; num = num++ & 0xffff; should be the solution. To make the qedit test happy a Sleep(...) between the two calls should be enough. Cheers Rico

Dec. 19, 2008

Re: jscript: Do not call memcpy() with a NULL pointer argument

by Andrew Talbot

Jacek Caban wrote: > The string was always zero-terminated without your patch. It's fine to > call create_string with NULL str argument as long as len is 0 and > current implementation works fine in this case. > > > Jacek Hi Jacek, Technically, behavior is undefined if the pointers do not each point to an object, even if the size parameter has a value of zero (see http://tinyurl.com/6eqo3n, third post). Though I concede that it would be a rare implementation that touched its pointers (or copies of them) in that case. -- Andy.

Dec. 19, 2008

Re: qedit: tests/mediadet.c test skips sometimes

by Austin English

On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller <kgbricola(a)web.de> wrote: > Hi, > could anyone try the attached patch for the qedit test on a windows machine? > It works around bug 16548. But according to the comment in the source I > think this could be a mistake. I'd like to know if it works without renaming > the file on windows. On wine it works. > > Cheers > Rico > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 2b43124..558ff3a 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) > return FALSE; > > DeleteFileW(name); > +/* > + Renaming isn't a good way to solve this, see bug 16548. > lstrcpyW(name + lstrlenW(name) - 3, avi); > - > +*/ > fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, > FILE_ATTRIBUTE_NORMAL, NULL); > if (fh == INVALID_HANDLE_VALUE) > > > > Tested on my 2k machine, works fine though. That XP machine has always been a bit buggy, so I wouldn't worry about it too much (times out on the tests a lot, even though it's got 2 GB ram/dual core CPU). -- -Austin

Dec. 19, 2008

Re: qedit: tests/mediadet.c test skips sometimes

by Austin English

On Fri, Dec 19, 2008 at 2:32 PM, Rico Schüller <kgbricola(a)web.de> wrote: > Austin English schrieb: >> >> On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller <kgbricola(a)web.de> wrote: >> >>> >>> Hi, >>> could anyone try the attached patch for the qedit test on a windows >>> machine? >>> It works around bug 16548. But according to the comment in the source I >>> think this could be a mistake. I'd like to know if it works without >>> renaming >>> the file on windows. On wine it works. >>> >>> Cheers >>> Rico >>> >>> diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c >>> index 2b43124..558ff3a 100644 >>> --- a/dlls/qedit/tests/mediadet.c >>> +++ b/dlls/qedit/tests/mediadet.c >>> @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR >>> name[MAX_PATH]) >>> return FALSE; >>> >>> DeleteFileW(name); >>> +/* >>> + Renaming isn't a good way to solve this, see bug 16548. >>> lstrcpyW(name + lstrlenW(name) - 3, avi); >>> - >>> +*/ >>> fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, >>> FILE_ATTRIBUTE_NORMAL, NULL); >>> if (fh == INVALID_HANDLE_VALUE) >>> >>> >>> >>> >>> >> >> Tested on XP SP 3: >> >> -Original- >> C:\Documents and Settings\Austin\Desktop>qedit_crosstest.exe >> mediadet: 62 tests executed (0 marked as todo, 0 failures), 0 skipped. >> >> -Your patch- >> C:\Documents and Settings\Austinl\Desktop>qedit_crosstest_new.exe >> mediadet.c:303: Tests skipped: Couldn't initialize tests! >> mediadet: 0 tests executed (0 marked as todo, 0 failures), 1 skipped. >> >> > > Thanks for your test. > I checked this on 3 different XP machines and all run the tests with my > patch fine. I've no glue why it fails for you. > > Probably, could you first verify that there is a bug in wine? If not it's > probably a bug with my machine. A simple example which should trigger the > bug in wine is attached. You could build it with mingw. > Command: "wine main.exe | uniq | wc" > Output on wine: 142 142 4118 > Output on windows: 1000 1000 28000 > Wine used the same unique temp names two times or more in a row, so that the > number is smaller than 1000. This makes it possible to fail the qedit test > on my machine. On windows I get always 1000. > > Cheers > Rico > > #include <stdio.h> > #include <stdlib.h> > #include <windows.h> > > int main() > { > char name[1024]; > int i; > for(i=0;i<1000;i++) > { > GetTempFileName("C:\\windows\\temp\\", "murks", 0, name); > DeleteFile(name); > printf("%s\n", name); > } > return 0; > } > > Windows gets 1000 here as well. Wine gets random numbers, always less than 1000, and usually around 150-190. -- -Austin

Dec. 19, 2008

Re: qedit: tests/mediadet.c test skips sometimes

by Rico Schüller

Austin English schrieb: > On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller <kgbricola(a)web.de> wrote: > >> Hi, >> could anyone try the attached patch for the qedit test on a windows machine? >> It works around bug 16548. But according to the comment in the source I >> think this could be a mistake. I'd like to know if it works without renaming >> the file on windows. On wine it works. >> >> Cheers >> Rico >> >> diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c >> index 2b43124..558ff3a 100644 >> --- a/dlls/qedit/tests/mediadet.c >> +++ b/dlls/qedit/tests/mediadet.c >> @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) >> return FALSE; >> >> DeleteFileW(name); >> +/* >> + Renaming isn't a good way to solve this, see bug 16548. >> lstrcpyW(name + lstrlenW(name) - 3, avi); >> - >> +*/ >> fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, >> FILE_ATTRIBUTE_NORMAL, NULL); >> if (fh == INVALID_HANDLE_VALUE) >> >> >> >> >> > > Tested on XP SP 3: > > -Original- > C:\Documents and Settings\Austin\Desktop>qedit_crosstest.exe > mediadet: 62 tests executed (0 marked as todo, 0 failures), 0 skipped. > > -Your patch- > C:\Documents and Settings\Austinl\Desktop>qedit_crosstest_new.exe > mediadet.c:303: Tests skipped: Couldn't initialize tests! > mediadet: 0 tests executed (0 marked as todo, 0 failures), 1 skipped. > > Thanks for your test. I checked this on 3 different XP machines and all run the tests with my patch fine. I've no glue why it fails for you. Probably, could you first verify that there is a bug in wine? If not it's probably a bug with my machine. A simple example which should trigger the bug in wine is attached. You could build it with mingw. Command: "wine main.exe | uniq | wc" Output on wine: 142 142 4118 Output on windows: 1000 1000 28000 Wine used the same unique temp names two times or more in a row, so that the number is smaller than 1000. This makes it possible to fail the qedit test on my machine. On windows I get always 1000. Cheers Rico #include <stdio.h> #include <stdlib.h> #include <windows.h> int main() { char name[1024]; int i; for(i=0;i<1000;i++) { GetTempFileName("C:\\windows\\temp\\", "murks", 0, name); DeleteFile(name); printf("%s\n", name); } return 0; }

Dec. 19, 2008

Patchwatcher offline?

by IneedAname

Looks like Patchwatcher has being offline from 09-Dec-2008. Did I miss something or did someone trip over the mains cable?

Dec. 19, 2008

Re: [2/5] wined3d: Properly reset the stateblock.

by Alexandre Julliard

Henri Verbeet <hverbeet(a)codeweavers.com> writes: >>From fe7697e20a1316e9bf5dba0469b4d39e5259d07b Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Thu, 18 Dec 2008 17:59:06 +0100 > Subject: wined3d: Properly reset the stateblock. This doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so device.c && touch device.ok device.c:2014: Tests skipped: Display format X1R5G5B5 not supported, skipping device.c:824: Test failed: D3DVIEWPORT->Width = 0 device.c:825: Test failed: D3DVIEWPORT->Height = 0 device.c:827: Test failed: D3DVIEWPORT->MaxZ = 0.000000 device.c:872: Test failed: D3DVIEWPORT->Width = 0 device.c:873: Test failed: D3DVIEWPORT->Height = 0 device.c:875: Test failed: D3DVIEWPORT->MaxZ = 0.000000 make: *** [device.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

Dec. 19, 2008

Re: qedit: tests/mediadet.c test skips sometimes

by Austin English

On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller <kgbricola(a)web.de> wrote: > Hi, > could anyone try the attached patch for the qedit test on a windows machine? > It works around bug 16548. But according to the comment in the source I > think this could be a mistake. I'd like to know if it works without renaming > the file on windows. On wine it works. > > Cheers > Rico > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 2b43124..558ff3a 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) > return FALSE; > > DeleteFileW(name); > +/* > + Renaming isn't a good way to solve this, see bug 16548. > lstrcpyW(name + lstrlenW(name) - 3, avi); > - > +*/ > fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, > FILE_ATTRIBUTE_NORMAL, NULL); > if (fh == INVALID_HANDLE_VALUE) > > > > Tested on XP SP 3: -Original- C:\Documents and Settings\Austin\Desktop>qedit_crosstest.exe mediadet: 62 tests executed (0 marked as todo, 0 failures), 0 skipped. -Your patch- C:\Documents and Settings\Austinl\Desktop>qedit_crosstest_new.exe mediadet.c:303: Tests skipped: Couldn't initialize tests! mediadet: 0 tests executed (0 marked as todo, 0 failures), 1 skipped. -- -Austin

Dec. 19, 2008

Re: user32: set an error in SetParent if parent == hwnd

by Dmitry Timoshkov

Please don't top post, this makes reply following awkward. "Vincent Povirk" <madewokherd+8cd9(a)gmail.com> wrote: > I would, but I can't run the user32:win tests successfully on a > windows machine. I've attached a test program to the bug. > > Vincent Povirk > > > > On Fri, Dec 19, 2008 at 6:41 AM, Dmitry Timoshkov > <dmitry(a)codeweavers.com> wrote: >> "Vincent Povirk" <madewokherd+8cd9(a)gmail.com> wrote: >> >>> fixes bug 16566 >> >> This kind of changes require a test case, adding which is trivial >> in this case. There is no need to run the whole set of user32:win tests, isn't it? All you need is to add an appropriate test to test_parent_owner() and make sure *that* test passes. A test program attached to the bug costs nothing in the sense of Wine regression test suite. If there are problems with the tests - investigate them, and send the patches to fix them. -- Dmitry.

Dec. 19, 2008

Re: Last change to http://wiki.winehq.org/Comctl32

by Austin English

On Fri, Dec 19, 2008 at 8:52 AM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > On Fri, Dec 19, 2008 at 2:41 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> Hi, >> >> I was just wondering if the addition of a link to >> http://www.dll-download-system.com should be in our wiki. Isn't it better to >> point to winetricks for getting riched20? >> > > I'd vote yes, that site seems a bit shady to me. > > --John > > > I changed it. -- -Austin

Dec. 19, 2008

Re: user32: set an error in SetParent if parent == hwnd

by Vincent Povirk

I would, but I can't run the user32:win tests successfully on a windows machine. I've attached a test program to the bug. Vincent Povirk On Fri, Dec 19, 2008 at 6:41 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > "Vincent Povirk" <madewokherd+8cd9(a)gmail.com> wrote: > >> fixes bug 16566 > > This kind of changes require a test case, adding which is trivial > in this case. > > -- > Dmitry. >

Dec. 19, 2008

Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item

by Jacek Caban

HI Konstantin, Konstantin Kondratyuk wrote: > VT_INT type isn't documented in MSDN, but it is supported in Windows > > You're duplicating the code that handles VT_I4 case. Please avoid it. Jacek

Dec. 19, 2008

Re: Patch Feedback

by Jacek Caban

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Is there anything wrong with patches? > > [1/2] mshtml: Implement IHTMLScriptElement get/put event > > [2/2] mshtml: Implement IHTMLScriptElement get/put htmlFor > > First of all, are you trying to fix a real bug? We're starting to handle scripts ourselves, so your implementation is not complete. It would be fine to add such semi-stubs if it fixes a real bug. Otherwise I'd prefer to leave them as stubs so we don't hide bugs. Also, we have NS_FAILED macro that you should use instead of !NS_SUCCEEDED and printing a message on failure would be nice. Jacek

Dec. 19, 2008

Re: Last change to http://wiki.winehq.org/Comctl32

by John Klehm

On Fri, Dec 19, 2008 at 2:41 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > I was just wondering if the addition of a link to > http://www.dll-download-system.com should be in our wiki. Isn't it better to > point to winetricks for getting riched20? > I'd vote yes, that site seems a bit shady to me. --John

Dec. 19, 2008

Re: jscript: Do not call memcpy() with a NULL pointer argument

by Jacek Caban

Andrew Talbot wrote: > On Thu Dec 18 22:41 , 'James Hawkins' <truiken(a)gmail.com> sent: > > >> I didn't write jscript, so I'm not the expert, but create_string is >> internal, so we should probably crash if str is NULL instead of hiding >> the error. What is this patch for? >> >> -- >> James Hawkins >> > > Hi James, > > create_string() is called on line 1323 of this file, with str == NULL and > len = 0. This function always allocates memory for at least one one WCHAR, > so I zero-terminated it. > The string was always zero-terminated without your patch. It's fine to call create_string with NULL str argument as long as len is 0 and current implementation works fine in this case. Jacek

Dec. 19, 2008

Re: jscript: Do not call memcpy() with a NULL pointer argument

by Andrew Talbot

On Thu Dec 18 22:41 , 'James Hawkins' <truiken(a)gmail.com> sent: >I didn't write jscript, so I'm not the expert, but create_string is >internal, so we should probably crash if str is NULL instead of hiding >the error. What is this patch for? > >-- >James Hawkins Hi James, create_string() is called on line 1323 of this file, with str == NULL and len = 0. This function always allocates memory for at least one one WCHAR, so I zero-terminated it. -- Andy.

Dec. 19, 2008

Re: user32: set an error in SetParent if parent == hwnd

by Dmitry Timoshkov

"Vincent Povirk" <madewokherd+8cd9(a)gmail.com> wrote: > fixes bug 16566 This kind of changes require a test case, adding which is trivial in this case. -- Dmitry.

Dec. 19, 2008

Re: Functions that should be static

by Francois Gouget

On Thu, 18 Dec 2008, Christian Costa wrote: [...] > For 1) Why not adding a keyword to mark these functions. Something like > WINAPI which resolve to nothing but that can be tracked by your script. We could potentially go this way if I merge these checks with winapi_check one day. But for now I prefer not to touch Wine's code. Besides there's really only about a handful of these. > I would add another item for more object oriented stuff. Some default > implentations can be written but not always used. > This is sort of templates. This is used in quartz for example. Do you have a specific example of this? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ There are 10 types of people in the world... those who understand binary and those who don't.

Dec. 19, 2008

Re: dmime: Remove unused Wine debug channel

by Francois Gouget

On Thu, 18 Dec 2008, Andrew Talbot wrote: > Changelog: > dmime: Remove unused Wine debug channel. > > diff --git a/dlls/dmime/dmutils.c b/dlls/dmime/dmutils.c > index ad46303..3f25728 100644 > --- a/dlls/dmime/dmutils.c > +++ b/dlls/dmime/dmutils.c > @@ -43,7 +43,6 @@ > > #include "dmutils.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(dmusic); > WINE_DECLARE_DEBUG_CHANNEL(dmfile); It does not seem logical to remove the default debug channel while keeping another channel. So I think that in addition to that you should be making dmfile the default and change the traces accordingly. The same thing applies to your dmstyle patch. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If it stinks, it's chemistry. If it moves, it's biology. If it does not work, It's computer science.

Dec. 19, 2008

strange

by Hervÿffffe9 Chanal

It's rather quickly made but... http://img72.imageshack.us/my.php?image=dessindi7.png

Dec. 19, 2008

Last change to http://wiki.winehq.org/Comctl32

by Paul Vriens

Hi, I was just wondering if the addition of a link to http://www.dll-download-system.com should be in our wiki. Isn't it better to point to winetricks for getting riched20? -- Cheers, Paul.

Dec. 19, 2008

Re: RE: 4/4 WineD3D: add G16R16F / G32R32F support

by Roderick Colenbrander

I don't think we have had issues when we didn't have this format before. Emulation might be tricky it is not as easy as emulating R32F we could just read back using GL_RED but there is no GL_RG without texture_rg. On the Nvidia side ARB_texture_rg is catching up quickly. A stable gl3 driver will be out within a short time. Roderick > I think we should emulate this format like we emulate R32F with ARGB32F if > GL_TEXTURE_RG is not supported. It is a fairly new extension and the > format > is probably rather important. > > (It should not be part of this patch though. Just a general note, the > patch > itself looks ok) > > > > -----Original Message----- > > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > > bounces(a)winehq.org] On Behalf Of Roderick Colenbrander > > Sent: Thursday, December 18, 2008 11:04 PM > > To: wine-patches(a)winehq.org > > Subject: 4/4 WineD3D: add G16R16F / G32R32F support > > > > > > -- > > Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für > > nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a > > -- Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a

Dec. 19, 2008

Re: [3/5] wined3d: Only apply shader constants that changed.

by Henri Verbeet

2008/12/19 Ivan Gyurdiev <ivg231(a)gmail.com>: >> Henri Verbeet wrote: > > This looks like data structure design mixed with GL and shader code. I think > it would be better if the data structure was in its own file, without any GL > or D3D dependencies, and wined3d and other components could use it. > If it was intended to be a generic heap, yes. However, this is intended to be specific to the GLSL shader backend. The main consideration there is that making it more generic would cost us performance which we can't afford, considering constant loading is the main bottleneck in most shader based applications.

Dec. 19, 2008

Re: WCOM

by 田雪锋

Thank you for your advices, I should read the LGPL more again. In WCOM, for performance, only ole32 and rptrt4 was remained and functions should be simplified , so many feature and code should be cutoff. There also is a runnable demo on windows :) BRs faquir Dan Kegel wrote: > faquir wrote: > >> I want support out-of-process COM on a mobile phone platform base on Linux. >> Wine is perfect,but also is too big and too complex to run on the device. >> So,I' going to create a project named WCOM with some code(ole32 and >> rpcrt4) from wine >> > > Say, how about making Wine configurable, like Embedded XP and Linux are? > We already have a configure script. > You could add a --tiny configure option to disable everything but the > tiniest core needed for embedded devices. > > Avoiding a fork might be very good for you business-wise, > because it would mean less maintenance work for you. > > Since Wine is LGPL, you are free to use it in commercial > projects as long as you follow the license's requirements. > Consult a lawyer for details. See also > http://www.softwarefreedom.org/resources/2008/compliance-guide.html > for a guide written by lawyers about how to conform to the GPL, > LGPL, and related licenses. > > BTW, my take on things is: > The intent of the LGPL was something like "allow users > to fix bugs in the code", so in general you should not static link > Wine code directly into your apps, but rather leave Wine as > replaceable dynamic shared libraries. > You must provide the source for the Wine tree you use. > Ideally you'd also provide a way for users to build Wine themselves > and flash the device with their own improved versions of wine. > But I Am Not A Lawyer. > - Dan > >

Dec. 19, 2008

Re: [3/5] wined3d: Only apply shader constants that changed.

by Ivan Gyurdiev

> Henri Verbeet wrote: This looks like data structure design mixed with GL and shader code. I think it would be better if the data structure was in its own file, without any GL or D3D dependencies, and wined3d and other components could use it. - Ivan

Dec. 19, 2008

re: WCOM

by Dan Kegel

faquir wrote: > I want support out-of-process COM on a mobile phone platform base on Linux. > Wine is perfect,but also is too big and too complex to run on the device. > So,I' going to create a project named WCOM with some code(ole32 and > rpcrt4) from wine Say, how about making Wine configurable, like Embedded XP and Linux are? We already have a configure script. You could add a --tiny configure option to disable everything but the tiniest core needed for embedded devices. Avoiding a fork might be very good for you business-wise, because it would mean less maintenance work for you. Since Wine is LGPL, you are free to use it in commercial projects as long as you follow the license's requirements. Consult a lawyer for details. See also http://www.softwarefreedom.org/resources/2008/compliance-guide.html for a guide written by lawyers about how to conform to the GPL, LGPL, and related licenses. BTW, my take on things is: The intent of the LGPL was something like "allow users to fix bugs in the code", so in general you should not static link Wine code directly into your apps, but rather leave Wine as replaceable dynamic shared libraries. You must provide the source for the Wine tree you use. Ideally you'd also provide a way for users to build Wine themselves and flash the device with their own improved versions of wine. But I Am Not A Lawyer. - Dan

Dec. 19, 2008

Re: WCOM

by Juan Lang

> can i use the code from Wine to create WCOM without adding authorization > from Wine or business license ? Yes, but you must provide the source for your modified version of Wine to your customers. Read the LGPL for details. --Juan

Dec. 19, 2008

WCOM

by 田雪锋

Hi,all: I want support out-of-process COM on a mobile phone platform base on Linux. Wine is perfect,but also is too big and too complex to run on the device. So,I' going to create a project named WCOM with some code(ole32 and rpcrt4) from wine,well,WCOM is not need load by wine. I‘m a newbie and have a question: WCOM should be opensource,but the mobile phone platform is a business project, can i use the code from Wine to create WCOM without adding authorization from Wine or business license ? Best Regards faquir

Dec. 19, 2008

Patch Feedback

by Alistair Leslie-Hughes

Hi, Is there anything wrong with patches? [1/2] mshtml: Implement IHTMLScriptElement get/put event [2/2] mshtml: Implement IHTMLScriptElement get/put htmlFor Best Regards Alistair Leslie-Hughes

Dec. 19, 2008

Re: Better user feedback and better user experience (idea)

by Scott Ritchie

Austin English wrote: > On Thu, Dec 18, 2008 at 8:07 AM, Steve Brown <sbrown7(a)umbc.edu> wrote: >> On Wed, 17 Dec 2008, Austin English wrote: >> >>> In a few years when Wine is more developed and has most the API >>> implemented, this may be useful, but there's still a lot to do, and we >>> don't need more reports to tell us this. >> Keep in mind that the Windows API is a moving target. In a few years, the >> API will be no more completely implemented than it is today -- it will just >> be a different set of calls that aren't done than it is today. >> >> Steve Brown >> sbrown7(a)umbc.edu >> > > Of course, didn't meant to imply that it will be complete at that > time, but will be moreso than it is now, especially in regards to > older API functions. > I'm pretty sure we're catching up at this point. Wine development is getting faster, and the Windows API is changing slower - Microsoft does, after all, have to preserve backwards compatibility. So, it's fair to say that even with the release of Windows 7 Wine's implementation of the API will be more complete. Especially the API for running the apps we care about. Thanks, Scott Ritchie

Dec. 19, 2008

RE: 4/4 WineD3D: add G16R16F / G32R32F support

by Stefan Dösinger

I think we should emulate this format like we emulate R32F with ARGB32F if GL_TEXTURE_RG is not supported. It is a fairly new extension and the format is probably rather important. (It should not be part of this patch though. Just a general note, the patch itself looks ok) > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Roderick Colenbrander > Sent: Thursday, December 18, 2008 11:04 PM > To: wine-patches(a)winehq.org > Subject: 4/4 WineD3D: add G16R16F / G32R32F support > > > -- > Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für > nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a

Dec. 19, 2008

RE: [PATCH] Fix ddraw surface version setting

by Stefan Dösinger

The patch looks ok to me

Dec. 19, 2008

RE: [PATCH] wined3d_gl.h minor typo fix

by Stefan Dösinger

> - USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoordvEXT, EXT_FOG_COORD, NULL )\ > + USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoorddvEXT, EXT_FOG_COORD, NULL )\ I think I fixed that one with a patch in my glFogCoord emulation patchset a few days ago. Did you forget to update your git tree, or did I miss something? Other than that, the patch breaks the alignment of the 3rd and 4th column because a 'v' was added to the function name, but no space removed to keep the alignment.

Dec. 19, 2008

Re: implicit declaration of function '_mkdir'

by Austin English

On Sun, Dec 14, 2008 at 5:29 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I am mostly offline (2s ping times) for another two weeks, but noticed > the following starting a couple of days ago on my nightly FreeBSD 6.4 > tester: > > server.c:755: warning: implicit declaration of function '_mkdir' > shellpath.c:2163: warning: implicit declaration of function '_mkdir' > shfldr_unixfs.c:1745: warning: implicit declaration of function '_mkdir' > xdg.c:253: warning: implicit declaration of function '_mkdir' > theme.c:966: warning: implicit declaration of function '_mkdir' > winemenubuilder.c:707: warning: implicit declaration of function '_mkdir' > fd.c:1562: warning: implicit declaration of function '_mkdir' > request.c:530: warning: implicit declaration of function '_mkdir' > > Perhaps one of you has an idea where this might come from and how to > avoid it? > > Gerald > > > http://bugs.winehq.org/show_bug.cgi?id=16561 I started to send a patch, then realized there a lot more occurrences, and didn't have time to fix them all. -- -Austin

Dec. 18, 2008

Re: winecfg volume serial number

by James Hawkins

On Thu, Dec 18, 2008 at 3:07 PM, Michael Ost <most(a)museresearch.com> wrote: > Michael Karcher wrote: >> >> Am Donnerstag, den 18.12.2008, 14:53 -0800 schrieb James Hawkins: >>> >>> I don't understand the problem. If you have the proper permissions, >>> wine should be able to read the volume name and everything should just >>> work. What does volname give you for the network-mounted image? >> >> He is not mounting an image, but a mounted CD-ROM drive. > > Right. > > [most(a)Deceptor ~]$ mount > (snip) > //x.y.z.w/remotex on /home/most/.wine/drive_x type cifs (rw,mand) > > [most(a)Deceptor ~]$ ll ~/.wine/dosdevices/ > total 0 > lrwxrwxrwx 1 most most 10 2008-12-18 11:56 c: -> ../drive_c > lrwxrwxrwx 1 most most 10 2008-12-17 11:34 x: -> ../drive_x > > GetVolumeInformation's CreateFile("\\\\.\\X:") call fails with status > c0000034. So it tries get_filesystem_label, which tries to read > "//x.y.z.w/remotex/.windows-label" via the symlinks. > > I can't write a file there so I can't fake in the label. > > My thought was to store the label in the registry and use that as a fallback > if there is no .windows-label file. I'm all ears for alternate approaches > though.... mo > Have you tried setting the drive type to CD in winecfg? -- James Hawkins

Dec. 18, 2008

Re: ntdll: fix a compiler warning on PC-BSD

by Austin English

2008/12/18 Austin English <austinenglish(a)gmail.com>: > -- > -Austin > Ignore this patch, there are a few more I didn't notice. I'll update and resend. -- -Austin

Dec. 18, 2008

Re: winecfg volume serial number

by James Hawkins

On Thu, Dec 18, 2008 at 2:47 PM, Michael Ost <most(a)museresearch.com> wrote: > James Hawkins wrote: >> >> On Thu, Dec 18, 2008 at 12:31 PM, Michael Ost <most(a)museresearch.com> >> wrote: >>> >>> wine-devel-request(a)winehq.org wrote: >>>> >>>> Date: Tue, 16 Dec 2008 13:52:00 +0100 From: "Hoehle, Joerg-Cyril" >>>> <Joerg-Cyril.Hoehle(a)t-systems.com> Subject: winecfg volume serial >>>> number To: <wine-devel(a)winehq.org> Message-ID: >>>> <47CC5ABB01651443A88DB8EC5B4D657B01C8FD22(a)S4DE8PSAANK.mitte.t-com.de> >>>> Content-Type: text/plain; charset="iso-8859-1" >>>> >>>> Hi, >>>> >>>> I just sent a bug-fix to wine-patches to prevent a crash in winecfg >>>> when editing the volume serial number input field, together with some >>>> unrelated thoughts about winecfg and the device/volume serial number >>>> handling. Then I realized that wine-patches is not a good place for >>>> discussion. So here are the ideas about winecfg's GUI: >>> >>> It doesn't make sense to me to rely on writing to a file to set the >>> windows serial number or label. What about readonly disks? >>> >>> I think those values should be in the registry. Or at least check the >>> registry should be a fallback if .windows-serial or .windows-label does >>> not exist. >>> >>> I am stuck now because an installer program is looking for a CD of a >>> certain label. I can't fudge in the label because it's a CD that I can't >>> write to. >>> >>> Is anyone working on this issue, or agree/disagree? ... mo >>> >> >> The label of the CD is read from the disk. If you're using a mounted >> ISO, you have to fix the access rights of the loopback file >> representing the ISO file. > > Yes, you are right. And this does work. > > In my system I am mounting a remote CD over samba and creating a drive > letter for it in Wine. That's the disc that the installer wants to query. I > was hoping to be able to set the label for the "network" drive to work > around this issue. But the CD is read only so I can't write the file. > > So I am trying to do something tricky, that is probably not even possible in > Windows. And I'll probably just have to my own internal Wine hack to get > this to work. > I don't understand the problem. If you have the proper permissions, wine should be able to read the volume name and everything should just work. What does volname give you for the network-mounted image? -- James Hawkins

Dec. 18, 2008

Re: winecfg volume serial number

by Michael Ost

James Hawkins wrote: > On Thu, Dec 18, 2008 at 12:31 PM, Michael Ost <most(a)museresearch.com> wrote: >> wine-devel-request(a)winehq.org wrote: >>> Date: Tue, 16 Dec 2008 13:52:00 +0100 From: "Hoehle, Joerg-Cyril" >>> <Joerg-Cyril.Hoehle(a)t-systems.com> Subject: winecfg volume serial >>> number To: <wine-devel(a)winehq.org> Message-ID: >>> <47CC5ABB01651443A88DB8EC5B4D657B01C8FD22(a)S4DE8PSAANK.mitte.t-com.de> >>> Content-Type: text/plain; charset="iso-8859-1" >>> >>> Hi, >>> >>> I just sent a bug-fix to wine-patches to prevent a crash in winecfg >>> when editing the volume serial number input field, together with some >>> unrelated thoughts about winecfg and the device/volume serial number >>> handling. Then I realized that wine-patches is not a good place for >>> discussion. So here are the ideas about winecfg's GUI: >> It doesn't make sense to me to rely on writing to a file to set the >> windows serial number or label. What about readonly disks? >> >> I think those values should be in the registry. Or at least check the >> registry should be a fallback if .windows-serial or .windows-label does >> not exist. >> >> I am stuck now because an installer program is looking for a CD of a >> certain label. I can't fudge in the label because it's a CD that I can't >> write to. >> >> Is anyone working on this issue, or agree/disagree? ... mo >> > > The label of the CD is read from the disk. If you're using a mounted > ISO, you have to fix the access rights of the loopback file > representing the ISO file. Yes, you are right. And this does work. In my system I am mounting a remote CD over samba and creating a drive letter for it in Wine. That's the disc that the installer wants to query. I was hoping to be able to set the label for the "network" drive to work around this issue. But the CD is read only so I can't write the file. So I am trying to do something tricky, that is probably not even possible in Windows. And I'll probably just have to my own internal Wine hack to get this to work. - mo

Dec. 18, 2008

Re: jscript: Do not call memcpy() with a NULL pointer argument

by James Hawkins

On Thu, Dec 18, 2008 at 2:21 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > jscript: Do not call memcpy() with NULL pointer argument. > > diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c > index eeceb1f..b49d3b3 100644 > --- a/dlls/jscript/string.c > +++ b/dlls/jscript/string.c > @@ -1395,8 +1395,12 @@ HRESULT create_string(script_ctx_t *ctx, const WCHAR *str, DWORD len, DispatchEx > return E_OUTOFMEMORY; > } > > - memcpy(string->str, str, len*sizeof(WCHAR)); > - string->str[len] = 0; > + if (str) { > + memcpy(string->str, str, len*sizeof(WCHAR)); > + string->str[len] = 0; > + }else { > + string->str[0] = 0; > + } > > *ret = &string->dispex; > return S_OK; > I didn't write jscript, so I'm not the expert, but create_string is internal, so we should probably crash if str is NULL instead of hiding the error. What is this patch for? -- James Hawkins

Dec. 18, 2008

qedit: tests/mediadet.c test skips sometimes

by Rico Schüller

Hi, could anyone try the attached patch for the qedit test on a windows machine? It works around bug 16548. But according to the comment in the source I think this could be a mistake. I'd like to know if it works without renaming the file on windows. On wine it works. Cheers Rico diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index 2b43124..558ff3a 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) return FALSE; DeleteFileW(name); +/* + Renaming isn't a good way to solve this, see bug 16548. lstrcpyW(name + lstrlenW(name) - 3, avi); - +*/ fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL); if (fh == INVALID_HANDLE_VALUE)

Dec. 18, 2008

Re: [msvfw32/tests] Fix a test failure on W2K3

by Christian Costa

Hi Paul, You forgot to update the error messages. Christian Paul Vriens a écrit : > Hi, > > Pick a compressor that's available on all platforms for this > compressor type. > Ideally we would use ICInfo to enumerate and pick one that's available > but I > think that's a bit too much for now. > > (This is the last one to fix the regressions in the > conformance/regressions > tests on my boxes from the last commit round ;) ) > > Changelog > Fix a test failure on W2K3 > > ------------------------------------------------------------------------ > >

Dec. 18, 2008

Re: Functions that should be static

by Christian Costa

Hi Francois, For 1) Why not adding a keyword to mark these functions. Something like WINAPI which resolve to nothing but that can be tracked by your script. I would add another item for more object oriented stuff. Some default implentations can be written but not always used. This is sort of templates. This is used in quartz for example. Christian Francois Gouget a écrit : > I have attached a script that identifies functions that should be made > static (among other things). There are approximately 450 of them, there > should be pretty efw false positives, and I will look into them > eventually. But if someone beats me to it I sure won't complain <g>. > > So if you do try to tackle them you are likely to find that they fall > into one of the following categories: > > 1) Unused debug functions. > For instance for dumping the contents of a structure to stderr. > Although these are unused we probably want to keep them. Let me know > about these and I will put them in an exception list. > > 2) Functions that should be exported by a spec file > It happens. Sometimes the developer implementing a function just > forgets to add it to the spec file! > > 3) Generated functions > This typically happens with widl: it generates a bunch of functions > for the client / server and proxy cases, but these functions may be > unused. I have special code to not warn about these, but there may > be other cases. For instance in the list below you will find a > number of yy*() functions generated by lex. Either we can tell lex > to make them static or to not generate them, or I should make > another special case. If you find some of these, let me know. > > 4) Assembly functions > I believe there should not be any of these in the list below. > So if you find one let me know. > > 5) Functions declared in a private header file but implemented and used > from a single C file. > I'm in favor of removing these functions from the private header and > making them static. > > 6) All the others should be pretty clear-cut. > > > dlls/advapi32/advapi32.dll.so: CRYPT_DESkey8to7 > dlls/browseui/tests/browseui_test.exe.so: strdup_AtoW > dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_AddRef > dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_QueryInterface > dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_Release > dlls/browseui/tests/browseui_test.exe.so: TestACL_AddRef > dlls/browseui/tests/browseui_test.exe.so: TestACL_Clone > dlls/browseui/tests/browseui_test.exe.so: TestACL_Expand > dlls/browseui/tests/browseui_test.exe.so: TestACL_Next > dlls/browseui/tests/browseui_test.exe.so: TestACL_QueryInterface > dlls/browseui/tests/browseui_test.exe.so: TestACL_Release > dlls/browseui/tests/browseui_test.exe.so: TestACL_Reset > dlls/browseui/tests/browseui_test.exe.so: TestACL_Skip > dlls/cabinet/cabinet.dll.so: checksum > dlls/cabinet/cabinet.dll.so: make_decode_table > dlls/cabinet/cabinet.dll.so: QTMupdatemodel > dlls/comctl32/tests/comctl32_test.exe.so: flush_sequence > dlls/comdlg32/comdlg32.dll.so: CC_WMCommand > dlls/crypt32/crypt32.dll.so: ContextList_Empty > dlls/dbghelp/dbghelp.dll.so: hash_table_find > dlls/dbghelp/dbghelp.dll.so: hash_table_hash > dlls/dbghelp/dbghelp.dll.so: module_find_by_name > dlls/dbghelp/dbghelp.dll.so: module_get_container > dlls/dinput/dinput.dll.so: DIEnumDevicesCallbackAtoW > dlls/dmime/dmime.dll.so: DMUSIC_CreateDirectMusicobjImpl > dlls/dmime/dmime.dll.so: DMUSIC_CreateDirectMusicPatternTrackImpl > dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicBufferImpl > dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicDownloadedInstrumentImpl > dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicDownloadImpl > dlls/dnsapi/dnsapi.dll.so: dns_ns_name_pton > dlls/dplayx/dplayx.dll.so: cbDeleteGroupsElem > dlls/dplayx/dplayx.dll.so: cbDeletePlayerElem > dlls/dplayx/dplayx.dll.so: DPLAYX_DestroyLobbyApplication > dlls/dplayx/dplayx.dll.so: DPLAYX_SetLocalSession > dlls/dplayx/dplayx.dll.so: NS_GetOtherMagic > dlls/dplayx/dplayx.dll.so: NS_SetRemoteComputerAsNameServer > dlls/dsound/dsound.dll.so: DirectSoundCaptureDevice_AddRef > dlls/fusion/fusion.dll.so: assembly_get_architecture > dlls/fusion/fusion.dll.so: CompareAssemblyIdentity > dlls/fusion/fusion.dll.so: GetAssemblyIdentityFromFile > dlls/inetcomm/inetcomm.dll.so: InternetTransport_Read > dlls/iphlpapi/iphlpapi.dll.so: getInterfaceEntryByIndex > dlls/iphlpapi/iphlpapi.dll.so: getInterfacePhysicalByName > dlls/itss/itss.dll.so: chm_enumerate > dlls/jscript/jscript.dll.so: jsdisp_call > dlls/jscript/jscript.dll.so: parser_parse > dlls/mountmgr.sys/mountmgr.sys.so: DriverEntry > dlls/msacm32/msacm32.dll.so: MSACM_UnregisterLocalDriver > dlls/mshtml/mshtml.dll.so: HTMLElementCollection_Create > dlls/msi/msi.dll.so: cond_parse > dlls/msi/msi.dll.so: ControlEvent_UnSubscribeToEvent > dlls/msi/msi.dll.so: db_get_raw_stream > dlls/msi/msi.dll.so: encode_streamname > dlls/msi/msi.dll.so: find_published_source > dlls/msi/msi.dll.so: MSI_DatabaseExport > dlls/msi/msi.dll.so: MSI_DatabaseImport > dlls/msi/msi.dll.so: msi_dialog_register_class > dlls/msi/msi.dll.so: MSI_EnableUIPreview > dlls/msi/msi.dll.so: msi_id2stringA > dlls/msi/msi.dll.so: msi_id2stringW > dlls/msi/msi.dll.so: msi_load_media_info > dlls/msi/msi.dll.so: MSI_PreviewDialogW > dlls/msi/msi.dll.so: MSI_RecordDataSize > dlls/msi/msi.dll.so: MSI_RecordSetStream > dlls/msi/msi.dll.so: MSI_RecordSetStringA > dlls/msi/msi.dll.so: MSIREG_OpenInstallerFeaturesKey > dlls/msi/msi.dll.so: msi_strcmp > dlls/msi/msi.dll.so: msi_string2idA > dlls/msi/msi.dll.so: msi_ui_error > dlls/msi/msi.dll.so: msi_version_dword_to_str > dlls/msi/msi.dll.so: reduce_to_shortfilename > dlls/msi/msi.dll.so: sql_parse > dlls/msxml3/msxml3.dll.so: httprequest_Release > dlls/msxml3/msxml3.dll.so: XMLElementCollection_create > dlls/netapi32/netapi32.dll.so: NBNameCacheUpdateNBName > dlls/ole32/ole32.dll.so: IMalloc16_Constructor > dlls/qcap/qcap.dll.so: FreeMediaType > dlls/qcap/qcap.dll.so: IPinImpl_QueryInternalConnections > dlls/quartz/quartz.dll.so: MemInputPin_AddRef > dlls/quartz/quartz.dll.so: MemInputPin_GetAllocator > dlls/quartz/quartz.dll.so: MemInputPin_GetAllocatorRequirements > dlls/quartz/quartz.dll.so: MemInputPin_NotifyAllocator > dlls/quartz/quartz.dll.so: MemInputPin_QueryInterface > dlls/quartz/quartz.dll.so: MemInputPin_Receive > dlls/quartz/quartz.dll.so: MemInputPin_ReceiveCanBlock > dlls/quartz/quartz.dll.so: MemInputPin_ReceiveMultiple > dlls/quartz/quartz.dll.so: MemInputPin_Release > dlls/quartz/quartz.dll.so: OutputPin_DeliverNewSegment > dlls/riched20/riched20.dll.so: ME_ConcatString > dlls/riched20/riched20.dll.so: ME_CopyToCF2W > dlls/riched20/riched20.dll.so: ME_DestroyEditor > dlls/riched20/riched20.dll.so: ME_DITypesEqual > dlls/riched20/riched20.dll.so: ME_DrawParagraph > dlls/riched20/riched20.dll.so: ME_FindItemFwdOrHere > dlls/riched20/riched20.dll.so: ME_FindNextURLCandidate > dlls/riched20/riched20.dll.so: ME_FindRowStart > dlls/riched20/riched20.dll.so: ME_GetOptimalBuffer > dlls/riched20/riched20.dll.so: ME_GetParaFormat > dlls/riched20/riched20.dll.so: ME_GetYScrollVisible > dlls/riched20/riched20.dll.so: ME_InvalidateFromOfs > dlls/riched20/riched20.dll.so: ME_IsCandidateAnURL > dlls/riched20/riched20.dll.so: ME_LinkNotify > dlls/riched20/riched20.dll.so: ME_MakeEditor > dlls/riched20/riched20.dll.so: ME_MakeStringB > dlls/riched20/riched20.dll.so: ME_MarkForWrapping > dlls/riched20/riched20.dll.so: ME_QueueInvalidateFromCursor > dlls/riched20/riched20.dll.so: ME_Scroll > dlls/riched20/riched20.dll.so: ME_SelectByType > dlls/riched20/riched20.dll.so: ME_SetParaFormat > dlls/riched20/riched20.dll.so: ME_ToCFAny > dlls/riched20/riched20.dll.so: ME_UpdateLinkAttribute > dlls/riched20/riched20.dll.so: ME_UpdateSelection > dlls/riched20/riched20.dll.so: ME_UpdateSelectionLinkAttribute > dlls/riched20/riched20.dll.so: REComboWndProc > dlls/riched20/riched20.dll.so: REListWndProc > dlls/riched20/riched20.dll.so: RTFExpandStyle > dlls/riched20/riched20.dll.so: RTFGetClassCallback > dlls/riched20/riched20.dll.so: RTFGetDestinationCallback > dlls/riched20/riched20.dll.so: RTFGetInputName > dlls/riched20/riched20.dll.so: RTFGetOutputName > dlls/riched20/riched20.dll.so: RTFGetReadHook > dlls/riched20/riched20.dll.so: RTFGetStyle > dlls/riched20/riched20.dll.so: RTFHexToChar > dlls/riched20/riched20.dll.so: RTFPeekToken > dlls/riched20/riched20.dll.so: RTFSetClassCallback > dlls/riched20/riched20.dll.so: RTFSetInputName > dlls/riched20/riched20.dll.so: RTFSetOutputName > dlls/riched20/riched20.dll.so: RTFSetToken > dlls/riched20/riched20.dll.so: RTFUngetToken > dlls/rpcrt4/rpcrt4.dll.so: NCA2RPC_STATUS > dlls/rpcrt4/rpcrt4.dll.so: NdrByteCountPointerMemorySize > dlls/rpcrt4/rpcrt4.dll.so: NdrRangeBufferSize > dlls/rpcrt4/rpcrt4.dll.so: NdrRangeFree > dlls/rpcrt4/rpcrt4.dll.so: NdrRangeMarshall > dlls/rpcrt4/rpcrt4.dll.so: NdrRangeMemorySize > dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_receive_fragment > dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_SpawnConnection > dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_ValidateCommonHeader > dlls/rsaenh/rsaenh.dll.so: alloc_handle_table > dlls/rsaenh/rsaenh.dll.so: mp_2expt > dlls/rsaenh/rsaenh.dll.so: mp_abs > dlls/rsaenh/rsaenh.dll.so: mp_add_d > dlls/rsaenh/rsaenh.dll.so: mp_clamp > dlls/rsaenh/rsaenh.dll.so: mp_clear > dlls/rsaenh/rsaenh.dll.so: mp_cmp_mag > dlls/rsaenh/rsaenh.dll.so: mp_cnt_lsb > dlls/rsaenh/rsaenh.dll.so: mp_div > dlls/rsaenh/rsaenh.dll.so: mp_div_2 > dlls/rsaenh/rsaenh.dll.so: mp_div_2d > dlls/rsaenh/rsaenh.dll.so: mp_div_d > dlls/rsaenh/rsaenh.dll.so: mp_dr_reduce > dlls/rsaenh/rsaenh.dll.so: mp_dr_setup > dlls/rsaenh/rsaenh.dll.so: mp_exch > dlls/rsaenh/rsaenh.dll.so: mp_grow > dlls/rsaenh/rsaenh.dll.so: mp_init > dlls/rsaenh/rsaenh.dll.so: mp_init_size > dlls/rsaenh/rsaenh.dll.so: mp_lshd > dlls/rsaenh/rsaenh.dll.so: mp_mod_2d > dlls/rsaenh/rsaenh.dll.so: mp_mod_d > dlls/rsaenh/rsaenh.dll.so: mp_montgomery_calc_normalization > dlls/rsaenh/rsaenh.dll.so: mp_montgomery_reduce > dlls/rsaenh/rsaenh.dll.so: mp_montgomery_setup > dlls/rsaenh/rsaenh.dll.so: mp_mul_2 > dlls/rsaenh/rsaenh.dll.so: mp_mul_2d > dlls/rsaenh/rsaenh.dll.so: mp_mul_d > dlls/rsaenh/rsaenh.dll.so: mp_prime_is_divisible > dlls/rsaenh/rsaenh.dll.so: mp_prime_is_prime > dlls/rsaenh/rsaenh.dll.so: mp_prime_miller_rabin > dlls/rsaenh/rsaenh.dll.so: mp_reduce > dlls/rsaenh/rsaenh.dll.so: mp_reduce_2k > dlls/rsaenh/rsaenh.dll.so: mp_reduce_2k_setup > dlls/rsaenh/rsaenh.dll.so: mp_reduce_setup > dlls/rsaenh/rsaenh.dll.so: mp_rshd > dlls/rsaenh/rsaenh.dll.so: mp_set > dlls/rsaenh/rsaenh.dll.so: mp_signed_bin_size > dlls/rsaenh/rsaenh.dll.so: mp_sqr > dlls/rsaenh/rsaenh.dll.so: mp_sqrmod > dlls/rsaenh/rsaenh.dll.so: mp_zero > dlls/rsaenh/rsaenh.dll.so: release_handle_table > dlls/sane.ds/sane.ds.so: SANE_AutomaticCaptureDirectory > dlls/sane.ds/sane.ds.so: SANE_FileSystemCopy > dlls/sane.ds/sane.ds.so: SANE_PendingXfersStopFeeder > dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Get > dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2GetDefault > dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Reset > dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Set > dlls/secur32/secur32.dll.so: SECUR32_initNegotiateSP > dlls/secur32/secur32.dll.so: SECUR32_strdupW > dlls/setupapi/setupapi.dll.so: PARSER_string_substW > dlls/setupapi/setupapi.dll.so: VcpEnumFiles > dlls/setupapi/setupapi.dll.so: VcpFlush16 > dlls/setupapi/setupapi.dll.so: vsmStringCompare16 > dlls/setupapi/setupapi.dll.so: vsmStringFind16 > dlls/shell32/shell32.dll.so: HCR_GetDefaultIconFromGUIDW > dlls/shell32/shell32.dll.so: ILGetDisplayNameExA > dlls/shell32/shell32.dll.so: _ILGetSTextPointer > dlls/shell32/shell32.dll.so: _ILGetTextPointerW > dlls/shell32/shell32.dll.so: RenderFILECONTENTS > dlls/shell32/shell32.dll.so: RenderFILEDESCRIPTOR > dlls/shell32/shell32.dll.so: RenderPREFEREDDROPEFFECT > dlls/shell32/shell32.dll.so: RenderSHELLIDLISTOFFSET > dlls/shell32/shell32.dll.so: SHILCreateFromPathA > dlls/shell32/shell32.dll.so: TRASH_DisposeElement > dlls/shell32/shell32.dll.so: XDG_GetPath > dlls/user32/user32.dll.so: EditWndProcW > dlls/user32/user32.dll.so: LookupIconIdFromDirectory16 > dlls/uxtheme/uxtheme.dll.so: UXINI_ResetINI > dlls/w32skrnl/w32skrnl.dll.so: _GetThunkBuff > dlls/winealsa.drv/winealsa.drv.so: ALSA_PeekRingMessage > dlls/winealsa.drv/winealsa.drv.so: wodSetVolume > dlls/winedos/winedos.dll.so: DOSDEV_Console > dlls/winedos/winedos.dll.so: DOSDEV_FindCharDevice > dlls/winedos/winedos.dll.so: DOSDEV_IoctlRead > dlls/winedos/winedos.dll.so: DOSDEV_IoctlWrite > dlls/winedos/winedos.dll.so: DOSDEV_Peek > dlls/winedos/winedos.dll.so: DOSDEV_Read > dlls/winedos/winedos.dll.so: DOSDEV_Write > dlls/winedos/winedos.dll.so: DOSVM_AllocCodeUMB > dlls/winedos/winedos.dll.so: DOSVM_AllocUMB > dlls/winedos/winedos.dll.so: DPMI_FreeInternalRMCB > dlls/winedos/winedos.dll.so: VGA_SetQuadPalette > dlls/winedos/winedos.dll.so: VGA_SetTextAttribute > dlls/wineps.drv/wineps.drv.so: PSDRV_CmpColor > dlls/wineps.drv/wineps.drv.so: PSDRV_WriteArrayGet > dlls/wineps.drv/wineps.drv.so: PSDRV_WriteInitClip > dlls/wineps.drv/wineps.drv.so: PSDRV_WriteRRectangle > dlls/winex11.drv/winex11.drv.so: X11DRV_get_client_window > dlls/winex11.drv/winex11.drv.so: X11DRV_SetupGCForPen > dlls/winex11.drv/winex11.drv.so: X11DRV_window_to_X_rect > dlls/winex11.drv/winex11.drv.so: X11DRV_XF86VM_SetExclusiveMode > dlls/winex11.drv/winex11.drv.so: X11DRV_XRandR_Cleanup > dlls/winhttp/winhttp.dll.so: netconn_set_timeout > dlls/wininet/wininet.dll.so: HTTP_FinishedReading > dlls/wininet/wininet.dll.so: HTTP_GetHeader > dlls/wininet/wininet.dll.so: HTTP_HttpOpenRequestW > dlls/wininet/wininet.dll.so: HTTP_HttpSendRequestW > dlls/winmm/winmm.dll.so: MCI_DefYieldProc > dlls/winmm/winmm.dll.so: MCI_GetDriverFromString > dlls/winmm/winmm.dll.so: MCI_SendCommandFrom16 > dlls/winmm/winmm.dll.so: MCI_SendCommandFrom32 > dlls/winmm/winmm.dll.so: MCI_WriteString > dlls/wintrust/wintrust.dll.so: CRYPT_AsnEncodeInt > dlls/wintrust/wintrust.dll.so: WINTRUST_ReAlloc > dlls/wnaspi32/wnaspi32.dll.so: ASPI_SendASPICommand > dlls/wnaspi32/wnaspi32.dll.so: SCSI_GetDeviceName > dlls/wuapi/wuapi.dll.so: AutomaticUpdates_create > programs/cmd/cmd.exe.so: handleExpansion > programs/cmd/cmd.exe.so: WCMD_addCommand > programs/cmd/cmd.exe.so: WCMD_ask_confirm > programs/cmd/cmd.exe.so: WCMD_dir_sort > programs/cmd/cmd.exe.so: WCMD_filesize64 > programs/cmd/cmd.exe.so: WCMD_opt_s_strip_quotes > programs/cmd/cmd.exe.so: WCMD_parse > programs/cmd/cmd.exe.so: WCMD_show_prompt > programs/cmd/cmd.exe.so: WCMD_strrev > programs/cmd/cmd.exe.so: WCMD_strtrim_trailing_spaces > programs/oleview/oleview.exe.so: AddToStrW > programs/oleview/oleview.exe.so: AddToTLDataStrW > programs/oleview/oleview.exe.so: AddToTLDataStrWithTabsW > programs/oleview/oleview.exe.so: CreateInstOnProc > programs/oleview/oleview.exe.so: DetailsProc > programs/oleview/oleview.exe.so: InterfaceViewerProc > programs/oleview/oleview.exe.so: PaneProc > programs/oleview/oleview.exe.so: SysConfProc > programs/oleview/oleview.exe.so: TreeProc > programs/oleview/oleview.exe.so: TypeLibProc > programs/oleview/oleview.exe.so: WndProc > programs/progman/progman.exe.so: DIALOG_Symbol > programs/regedit/regedit.exe.so: GetMultiByteStringN > programs/regedit/regedit.exe.so: GetRootKeyName > programs/regedit/regedit.exe.so: GetWideStringN > programs/regedit/regedit.exe.so: HexEdit_Unregister > programs/regedit/regedit.exe.so: processRegLinesA > programs/regedit/regedit.exe.so: processRegLinesW > programs/taskmgr/taskmgr.exe.so: Draw3dRect > programs/taskmgr/taskmgr.exe.so: Draw3dRect2 > programs/taskmgr/taskmgr.exe.so: FillSolidRect2 > programs/taskmgr/taskmgr.exe.so: GraphCtrl_DrawPoint > programs/taskmgr/taskmgr.exe.so: GraphCtrl_InvalidateCtrl > programs/taskmgr/taskmgr.exe.so: GraphCtrl_Paint > programs/taskmgr/taskmgr.exe.so: GraphCtrl_Resize > programs/taskmgr/taskmgr.exe.so: TrayIcon_GetProcessorUsageIcon > programs/taskmgr/taskmgr.exe.so: UpdateApplicationListControlViewSetting > programs/view/view.exe.so: FileIsPlaceable > programs/view/view.exe.so: GetPlaceableMetaFile > programs/winecfg/winecfg.exe.so: enumerate_valuesW > programs/wineconsole/wineconsole.exe.so: WCUSER_AreFontsEqual > programs/wineconsole/wineconsole.exe.so: WINECON_FetchCells > programs/wineconsole/wineconsole.exe.so: WINECON_GetHistoryMode > programs/wineconsole/wineconsole.exe.so: WINECON_SetHistoryMode > programs/wineconsole/wineconsole.exe.so: WINECON_SetHistorySize > programs/winedbg/winedbg.exe.so: be_cpu_build_addr > programs/winedbg/winedbg.exe.so: be_cpu_linearize > programs/winedbg/winedbg.exe.so: dbg_alloc > programs/winedbg/winedbg.exe.so: dbg__create_buffer > programs/winedbg/winedbg.exe.so: dbg__delete_buffer > programs/winedbg/winedbg.exe.so: dbg__flush_buffer > programs/winedbg/winedbg.exe.so: dbg_free > programs/winedbg/winedbg.exe.so: dbg_get_debug > programs/winedbg/winedbg.exe.so: dbg_get_in > programs/winedbg/winedbg.exe.so: dbg_get_leng > programs/winedbg/winedbg.exe.so: dbg_get_lineno > programs/winedbg/winedbg.exe.so: dbg_get_out > programs/winedbg/winedbg.exe.so: dbg_get_text > programs/winedbg/winedbg.exe.so: dbg_lex_destroy > programs/winedbg/winedbg.exe.so: dbg_outputA > programs/winedbg/winedbg.exe.so: dbg_parse > programs/winedbg/winedbg.exe.so: dbg_pop_buffer_state > programs/winedbg/winedbg.exe.so: dbg_push_buffer_state > programs/winedbg/winedbg.exe.so: dbg_realloc > programs/winedbg/winedbg.exe.so: dbg_restart > programs/winedbg/winedbg.exe.so: dbg__scan_buffer > programs/winedbg/winedbg.exe.so: dbg__scan_bytes > programs/winedbg/winedbg.exe.so: dbg__scan_string > programs/winedbg/winedbg.exe.so: dbg_set_debug > programs/winedbg/winedbg.exe.so: dbg_set_in > programs/winedbg/winedbg.exe.so: dbg_set_lineno > programs/winedbg/winedbg.exe.so: dbg_set_out > programs/winedbg/winedbg.exe.so: dbg__switch_to_buffer > programs/winedbg/winedbg.exe.so: dbg_wrap > programs/winedbg/winedbg.exe.so: expr_alloc_uconstant > programs/winedbg/winedbg.exe.so: lexeme_alloc > programs/winedbg/winedbg.exe.so: parser > programs/winedbg/winedbg.exe.so: validate_file > programs/winemine/winemine.exe.so: AboutDlgProc > programs/winemine/winemine.exe.so: AddFlag > programs/winemine/winemine.exe.so: CompleteBox > programs/winemine/winemine.exe.so: CompleteBoxes > programs/winemine/winemine.exe.so: CreateBoard > programs/winemine/winemine.exe.so: DestroyBoard > programs/winemine/winemine.exe.so: DrawBoard > programs/winemine/winemine.exe.so: DrawFace > programs/winemine/winemine.exe.so: DrawLeds > programs/winemine/winemine.exe.so: DrawMine > programs/winemine/winemine.exe.so: DrawMines > programs/winemine/winemine.exe.so: InitBoard > programs/winemine/winemine.exe.so: LoadBoard > programs/winemine/winemine.exe.so: MainProc > programs/winemine/winemine.exe.so: PlaceMines > programs/winemine/winemine.exe.so: PressBox > programs/winemine/winemine.exe.so: PressBoxes > programs/winemine/winemine.exe.so: SaveBoard > programs/winemine/winemine.exe.so: SetDifficulty > programs/winemine/winemine.exe.so: TestBoard > programs/winemine/winemine.exe.so: TestFace > programs/winemine/winemine.exe.so: TestMines > programs/winemine/winemine.exe.so: UnpressBox > programs/winemine/winemine.exe.so: UnpressBoxes > programs/winhlp32/winhlp32.exe.so: HLPFILE_BPTreeSearch > programs/winhlp32/winhlp32.exe.so: HLPFILE_Contents > programs/winhlp32/winhlp32.exe.so: HLPFILE_HalfPointsToTwips > programs/winhlp32/winhlp32.exe.so: MACRO_AddAccelerator > programs/winhlp32/winhlp32.exe.so: MACRO_ALink > programs/winhlp32/winhlp32.exe.so: MACRO_AppendItem > programs/winhlp32/winhlp32.exe.so: MACRO_Back > programs/winhlp32/winhlp32.exe.so: MACRO_BackFlush > programs/winhlp32/winhlp32.exe.so: MACRO_BookmarkMore > programs/winhlp32/winhlp32.exe.so: MACRO_BrowseButtons > programs/winhlp32/winhlp32.exe.so: MACRO_ChangeButtonBinding > programs/winhlp32/winhlp32.exe.so: MACRO_ChangeEnable > programs/winhlp32/winhlp32.exe.so: MACRO_ChangeItemBinding > programs/winhlp32/winhlp32.exe.so: MACRO_CheckItem > programs/winhlp32/winhlp32.exe.so: MACRO_CloseSecondarys > programs/winhlp32/winhlp32.exe.so: MACRO_CloseWindow > programs/winhlp32/winhlp32.exe.so: MACRO_Compare > programs/winhlp32/winhlp32.exe.so: MACRO_Contents > programs/winhlp32/winhlp32.exe.so: MACRO_ControlPanel > programs/winhlp32/winhlp32.exe.so: MACRO_CopyTopic > programs/winhlp32/winhlp32.exe.so: MACRO_DeleteItem > programs/winhlp32/winhlp32.exe.so: MACRO_DeleteMark > programs/winhlp32/winhlp32.exe.so: MACRO_DestroyButton > programs/winhlp32/winhlp32.exe.so: MACRO_DisableItem > programs/winhlp32/winhlp32.exe.so: MACRO_EnableButton > programs/winhlp32/winhlp32.exe.so: MACRO_EnableItem > programs/winhlp32/winhlp32.exe.so: MACRO_EndMPrint > programs/winhlp32/winhlp32.exe.so: MACRO_ExecFile > programs/winhlp32/winhlp32.exe.so: MACRO_ExecProgram > programs/winhlp32/winhlp32.exe.so: MACRO_ExtAbleItem > programs/winhlp32/winhlp32.exe.so: MACRO_ExtInsertItem > programs/winhlp32/winhlp32.exe.so: MACRO_ExtInsertMenu > programs/winhlp32/winhlp32.exe.so: MACRO_FileExist > programs/winhlp32/winhlp32.exe.so: MACRO_Find > programs/winhlp32/winhlp32.exe.so: MACRO_Finder > programs/winhlp32/winhlp32.exe.so: MACRO_FloatingMenu > programs/winhlp32/winhlp32.exe.so: MACRO_Flush > programs/winhlp32/winhlp32.exe.so: MACRO_FocusWindow > programs/winhlp32/winhlp32.exe.so: MACRO_Generate > programs/winhlp32/winhlp32.exe.so: MACRO_GotoMark > programs/winhlp32/winhlp32.exe.so: MACRO_IfThen > programs/winhlp32/winhlp32.exe.so: MACRO_IfThenElse > programs/winhlp32/winhlp32.exe.so: MACRO_InitMPrint > programs/winhlp32/winhlp32.exe.so: MACRO_InsertItem > programs/winhlp32/winhlp32.exe.so: MACRO_InsertMenu > programs/winhlp32/winhlp32.exe.so: MACRO_IsBook > programs/winhlp32/winhlp32.exe.so: MACRO_IsMark > programs/winhlp32/winhlp32.exe.so: MACRO_IsNotMark > programs/winhlp32/winhlp32.exe.so: MACRO_JumpHelpOn > programs/winhlp32/winhlp32.exe.so: MACRO_JumpID > programs/winhlp32/winhlp32.exe.so: MACRO_JumpKeyword > programs/winhlp32/winhlp32.exe.so: MACRO_KLink > programs/winhlp32/winhlp32.exe.so: MACRO_Menu > programs/winhlp32/winhlp32.exe.so: MACRO_MPrintHash > programs/winhlp32/winhlp32.exe.so: MACRO_MPrintID > programs/winhlp32/winhlp32.exe.so: MACRO_Next > programs/winhlp32/winhlp32.exe.so: MACRO_NoShow > programs/winhlp32/winhlp32.exe.so: MACRO_PopupHash > programs/winhlp32/winhlp32.exe.so: MACRO_PopupId > programs/winhlp32/winhlp32.exe.so: MACRO_PositionWindow > programs/winhlp32/winhlp32.exe.so: MACRO_Prev > programs/winhlp32/winhlp32.exe.so: MACRO_RegisterRoutine > programs/winhlp32/winhlp32.exe.so: MACRO_RemoveAccelerator > programs/winhlp32/winhlp32.exe.so: MACRO_ResetMenu > programs/winhlp32/winhlp32.exe.so: MACRO_SaveMark > programs/winhlp32/winhlp32.exe.so: MACRO_Search > programs/winhlp32/winhlp32.exe.so: MACRO_SetHelpOnFile > programs/winhlp32/winhlp32.exe.so: MACRO_SetPopupColor > programs/winhlp32/winhlp32.exe.so: MACRO_ShellExecute > programs/winhlp32/winhlp32.exe.so: MACRO_ShortCut > programs/winhlp32/winhlp32.exe.so: MACRO_TCard > programs/winhlp32/winhlp32.exe.so: MACRO_Test > programs/winhlp32/winhlp32.exe.so: MACRO_TestALink > programs/winhlp32/winhlp32.exe.so: MACRO_TestKLink > programs/winhlp32/winhlp32.exe.so: MACRO_UncheckItem > programs/winhlp32/winhlp32.exe.so: MACRO_UpdateWindow > programs/winhlp32/winhlp32.exe.so: WINHELP_IndexDlgProc > programs/winhlp32/winhlp32.exe.so: WINHELP_MessageBoxIDS_s > programs/winhlp32/winhlp32.exe.so: WINHELP_SearchDlgProc > programs/winhlp32/winhlp32.exe.so: yyalloc > programs/winhlp32/winhlp32.exe.so: yy_create_buffer > programs/winhlp32/winhlp32.exe.so: yy_delete_buffer > programs/winhlp32/winhlp32.exe.so: yy_flush_buffer > programs/winhlp32/winhlp32.exe.so: yyfree > programs/winhlp32/winhlp32.exe.so: yyget_debug > programs/winhlp32/winhlp32.exe.so: yyget_in > programs/winhlp32/winhlp32.exe.so: yyget_leng > programs/winhlp32/winhlp32.exe.so: yyget_lineno > programs/winhlp32/winhlp32.exe.so: yyget_out > programs/winhlp32/winhlp32.exe.so: yyget_text > programs/winhlp32/winhlp32.exe.so: yylex > programs/winhlp32/winhlp32.exe.so: yylex_destroy > programs/winhlp32/winhlp32.exe.so: yypop_buffer_state > programs/winhlp32/winhlp32.exe.so: yypush_buffer_state > programs/winhlp32/winhlp32.exe.so: yyrealloc > programs/winhlp32/winhlp32.exe.so: yyrestart > programs/winhlp32/winhlp32.exe.so: yy_scan_buffer > programs/winhlp32/winhlp32.exe.so: yy_scan_bytes > programs/winhlp32/winhlp32.exe.so: yy_scan_string > programs/winhlp32/winhlp32.exe.so: yyset_debug > programs/winhlp32/winhlp32.exe.so: yyset_in > programs/winhlp32/winhlp32.exe.so: yyset_lineno > programs/winhlp32/winhlp32.exe.so: yyset_out > programs/winhlp32/winhlp32.exe.so: yy_switch_to_buffer > programs/winhlp32/winhlp32.exe.so: yywrap > > > > ------------------------------------------------------------------------ > >

Dec. 18, 2008

Re: Unused vtables and debug channels

by Christian Costa

Hi, I would suggest to keep the ones in pin.c. The file pin.c is a kind of "template" collection. Christian Maarten Lankhorst a écrit : > Hi Andrew, > > Andrew Talbot schreef: > >> It appears that the following vtables and Wine debug channels are not being used, so I am considering removing them. Please let me know, therefore, if you have plans for any of them and want them kept. >> >> >> Vtables: >> .... >> MemInputPin_Vtbl quartz/nullrenderer.c >> OutputPin_Vtbl* quartz/pin.c >> InputPin_Vtbl* quartz/pin.c >> PullPin_Vtbl* quartz/pin.c >> MemInputPin_Vtbl quartz/transform.c >> MemInputPin_Vtbl quartz/videorenderer.c >> >> > Feel free to remove the quartz ones, it should be harmless. > > Cheers, > Maarten. > >

Dec. 18, 2008

Re: winecfg volume serial number

by James Hawkins

On Thu, Dec 18, 2008 at 12:31 PM, Michael Ost <most(a)museresearch.com> wrote: > wine-devel-request(a)winehq.org wrote: >> Date: Tue, 16 Dec 2008 13:52:00 +0100 From: "Hoehle, Joerg-Cyril" >> <Joerg-Cyril.Hoehle(a)t-systems.com> Subject: winecfg volume serial >> number To: <wine-devel(a)winehq.org> Message-ID: >> <47CC5ABB01651443A88DB8EC5B4D657B01C8FD22(a)S4DE8PSAANK.mitte.t-com.de> >> Content-Type: text/plain; charset="iso-8859-1" >> >> Hi, >> >> I just sent a bug-fix to wine-patches to prevent a crash in winecfg >> when editing the volume serial number input field, together with some >> unrelated thoughts about winecfg and the device/volume serial number >> handling. Then I realized that wine-patches is not a good place for >> discussion. So here are the ideas about winecfg's GUI: > > It doesn't make sense to me to rely on writing to a file to set the > windows serial number or label. What about readonly disks? > > I think those values should be in the registry. Or at least check the > registry should be a fallback if .windows-serial or .windows-label does > not exist. > > I am stuck now because an installer program is looking for a CD of a > certain label. I can't fudge in the label because it's a CD that I can't > write to. > > Is anyone working on this issue, or agree/disagree? ... mo > The label of the CD is read from the disk. If you're using a mounted ISO, you have to fix the access rights of the loopback file representing the ISO file. -- James Hawkins

Dec. 18, 2008

Re: Unused vtables and debug channels

by Christian Costa

Andrew Talbot a écrit : > Christian Costa wrote: > > >> Hi Andrew, >> >> BTW, if the vtable are removed, there may be some unused functions. Will >> they be removed as well ? >> >> Bye, >> Christian >> > > Hi Christian, > > Because I was mindful not to remove such things lightly, that is why I > sought feedback from the community, and I shall respect the views expressed > by some, therefore, to leave the vtables alone. However, I do agree with > Henri's view that it is the keeping of pieces of code needs to be justified, > and so am inclined to remove any genuinely unused Wine debug channels, since > they are comparatively simple items and very easy to resurrect if > eventually required. > > Thanks to everyone, > > Hi Andrew, Cleaning the code is a good thing. If we take the time to do it the right way, that's fine. Christian

Dec. 18, 2008

Re: winecfg volume serial number

by Michael Ost

wine-devel-request(a)winehq.org wrote: > Date: Tue, 16 Dec 2008 13:52:00 +0100 From: "Hoehle, Joerg-Cyril" > <Joerg-Cyril.Hoehle(a)t-systems.com> Subject: winecfg volume serial > number To: <wine-devel(a)winehq.org> Message-ID: > <47CC5ABB01651443A88DB8EC5B4D657B01C8FD22(a)S4DE8PSAANK.mitte.t-com.de> > Content-Type: text/plain; charset="iso-8859-1" > > Hi, > > I just sent a bug-fix to wine-patches to prevent a crash in winecfg > when editing the volume serial number input field, together with some > unrelated thoughts about winecfg and the device/volume serial number > handling. Then I realized that wine-patches is not a good place for > discussion. So here are the ideas about winecfg's GUI: It doesn't make sense to me to rely on writing to a file to set the windows serial number or label. What about readonly disks? I think those values should be in the registry. Or at least check the registry should be a fallback if .windows-serial or .windows-label does not exist. I am stuck now because an installer program is looking for a CD of a certain label. I can't fudge in the label because it's a CD that I can't write to. Is anyone working on this issue, or agree/disagree? ... mo

Dec. 18, 2008

Re: wine-1.2 release criteria?

by Austin English

On Mon, Dec 15, 2008 at 9:24 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Dan Kegel wrote: >> >> - Tests that pass >> We're making progress here, but it's hard to quantify. >> http://test.winehq.org shows some runs still failing >> 20% of the tests, and others failing 0.3%, because >> we don't have a consistent set of machines running the >> tests. I would love to see that site add a feature showing >> the failure history for particular machines. >> > I am doing this locally with my (6) testboxes. This way it's very easy to > spot > differences or even flaky and inconsitent test results (see attached > screenshot). > > This is nice for me as I only have 1 box per OS. Not sure how this will work > out > on test.winehq.org. And I'm not even talking about the extra amount of > diskspace we need for this. Perhaps limit it to developers, or require a registration? -- -Austin

Dec. 18, 2008

Re: implicit declaration of function '_mkdir'

by James Hawkins

On Sun, Dec 14, 2008 at 2:29 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I am mostly offline (2s ping times) for another two weeks, but noticed > the following starting a couple of days ago on my nightly FreeBSD 6.4 > tester: > > server.c:755: warning: implicit declaration of function '_mkdir' > shellpath.c:2163: warning: implicit declaration of function '_mkdir' > shfldr_unixfs.c:1745: warning: implicit declaration of function '_mkdir' > xdg.c:253: warning: implicit declaration of function '_mkdir' > theme.c:966: warning: implicit declaration of function '_mkdir' > winemenubuilder.c:707: warning: implicit declaration of function '_mkdir' > fd.c:1562: warning: implicit declaration of function '_mkdir' > request.c:530: warning: implicit declaration of function '_mkdir' > > Perhaps one of you has an idea where this might come from and how to > avoid it? > You can use git offline to do a regression test. Might give you some better clues. -- James Hawkins

Dec. 18, 2008

Re: RE: WineD3D: add some new GL extensions

by Roderick Colenbrander

Argh .. I already wondered why it wasn't added. Guess I wasn't very awake .. I'll resubmit it later today when I also do something useful with it. Thanks, Roderick > Did you send it to wine-devel intentionally? > > IMHO there's not much use for adding the extensions to the extension list > without making use of them. I think this should be done in one patch. > > > > -----Original Message----- > > From: wine-devel-bounces(a)winehq.org [mailto:wine-devel- > > bounces(a)winehq.org] On Behalf Of Roderick Colenbrander > > Sent: Wednesday, December 17, 2008 11:22 PM > > To: wine-devel(a)winehq.org > > Subject: WineD3D: add some new GL extensions > > > > Hi, > > > > Add some new GL extensions which are needed for better d3d9 floating > > point support for R32F/RG32F and friends. > > > > Roderick > > -- > > Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für > > nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

Dec. 18, 2008