December 2008 - Wine-Devel - list.winehq.org

Re: wined3d: Do not treat oversized textures as failure

by Vincent Pelletier

Le Sunday 28 December 2008 20:20:43 Vincent Pelletier, vous avez écrit : > I discussed with Thunderbird on IRC right after sending last reply. I > noticed that I was not using latest intel driver, so I'm building them atm > to give it a try. (Debian sid is quite outdated these days, because of work > on next stable, I even have to rebuild the kernel) With 2.5.1 version: GL_MAX_TEXTURE_SIZE = 2048 I reverted the patch on my local tree, and the game works fine. Maybe wine should warn for broken drivers when GL_MAX_TEXTURE_SIZE is below 1024 or something... So after all, it seems to be a non-bug. My bad. -- Vincent Pelletier

Dec. 28, 2008

RE: xinput: Add stub XInputEnable

by ricardo filipe

yup, the patches look good on a quick glance. ---------------------------------------- > Date: Mon, 29 Dec 2008 02:30:26 +0700 > From: andrewfenn(a)gmail.com > To: hverbeet(a)gmail.com; wine-devel(a)kievinfo.com; ricardo_barbano(a)hotmail.com > Subject: Re: xinput: Add stub XInputEnable > CC: wine-devel(a)winehq.org > > Sorry guys, that was a really bad patch I submitted much better ones > to wine-patches already. > > [1/2] xinput: Added prototypes to header file > [2/2] xinput: Added stub for XInputEnable >> 2008/12/28 ricardo filipe : >> it's almost that. but it needs some changes. >> first you put the prototypes after the defines and typedefs, they may be needed for the prototypes. >> second you don't put variable names in the protypes, it should be something like: >> DWORD WINAPI XInputGetState(DWORD, XINPUT_STATE*); > No, variable names are optional, but not forbidden. Usually it makesthings more readable to include them. > It's a bit awkward to write "XINPUT_STATE* pState" though, since the *is part of the declarator in C, not part of the base type. i just meant you usually don't put the variable names, as we can see in most other headers in wine. but sure you are right ofc :) _________________________________________________________________ More than messages–check out the rest of the Windows Live™. http://www.microsoft.com/windows/windowslive/

Dec. 28, 2008

Re: xinput: Add stub XInputEnable

by Andrew Fenn

Sorry guys, that was a really bad patch I submitted much better ones to wine-patches already. [1/2] xinput: Added prototypes to header file [2/2] xinput: Added stub for XInputEnable

Dec. 28, 2008

Re: xinput: Add stub XInputEnable

by Henri Verbeet

2008/12/28 Andrew Fenn <andrewfenn(a)gmail.com>: > On Sun, Dec 28, 2008 at 9:39 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: >> Also, don't forget to add the prototype to the header, I noticed they're missing for all the other xinput functions as well. > > I think I have added the prototypes correctly to the header file. > Could you have a quick look at my patch and tell me if I am doing that > right? > Other than the missing semicolon Vitaliy already mentioned, and the types being defined after their first use, I think it's useful to specify C linkage for C++ applications that might include the header. 2008/12/28 ricardo filipe <ricardo_barbano(a)hotmail.com>: > > it's almost that. but it needs some changes. > first you put the prototypes after the defines and typedefs, they may be needed for the prototypes. > second you don't put variable names in the protypes, it should be something like: > > DWORD WINAPI XInputGetState(DWORD, XINPUT_STATE*); > No, variable names are optional, but not forbidden. Usually it makes things more readable to include them. It's a bit awkward to write "XINPUT_STATE* pState" though, since the * is part of the declarator in C, not part of the base type.

Dec. 28, 2008

Re: wined3d: Do not treat oversized textures as failure

by Vincent Pelletier

Le Sunday 28 December 2008 18:11:15, vous avez écrit : > Wow, that is small. Even my pretty old radeon 9000 supports 2048x2048 > textures... > > I recommend to check the max texture size on Windows(does the game work on > this card on Windows?). I'd say there's some driver problem here, 512x512 > sounds way too small for any semi-recent card. I discussed with Thunderbird on IRC right after sending last reply. I noticed that I was not using latest intel driver, so I'm building them atm to give it a try. (Debian sid is quite outdated these days, because of work on next stable, I even have to rebuild the kernel) As for windows, I don't know. I'll certainly try if the rebuild does nothing. -- Vincent Pelletier

Dec. 28, 2008

Re: wined3d: Do not treat oversized textures as failure

by Henri Verbeet

2008/12/28 Stefan Dösinger <stefan(a)codeweavers.com>: >> It tries to create a 1024x1024 texture, and my card (Intel 945GM) is >> limited >> to 512x512: >> >> glxinfo -l | grep GL_MAX_TEXTURE_SIZE >> GL_MAX_TEXTURE_SIZE = 512 > Wow, that is small. Even my pretty old radeon 9000 supports 2048x2048 > textures... > > I recommend to check the max texture size on Windows(does the game work on > this card on Windows?). I'd say there's some driver problem here, 512x512 > sounds way too small for any semi-recent card. > My i915 can certainly do more than 512x512. > That said, we should still fix the memory leak if CreateTexture fails... > Yes, but it's a bit more structural than just CreateTexture(). Most of the create methods in device are flawed in this way.

Dec. 28, 2008

Re: xinput: Add stub XInputEnable

by Vitaliy Margolen

Andrew Fenn wrote: > I think I have added the prototypes correctly to the header file. > Could you have a quick look at my patch and tell me if I am doing that > right? > > + XINPUT_CAPABILITIES* pCapabilities) Missing semicolon. Vitaliy.

Dec. 28, 2008

Re: Implementing dxdiag as student project?

by Roderick Colenbrander

> On Sunday 28 December 2008 07:43:57 am Roderick Colenbrander wrote: > > Native dxdiag is checking the name of the display driver which in our > case > > winex11.drv and I guess this is just the identifier of Winex11.drv. > Inside > > winex11.drv we don't really have the knowledge about the 3d hardware we > are > > emulating. In the end we might need to duplicate some card detection > code > > inside winex11.drv and show a real driver name like the Nvidia or ATI > ones. > > It would be a lot of work and only be worth if apps really need it. > > Are there any X functions that winex11.drv can use to get the strings used > for > a particular screen? Eg. in xorg.conf, I have: > > Section "Device" > ... > Identifier "Card0" > Driver "nvidia" > VendorName "nVidia Corporation" > BoardName "NV80 [GeForce 8600 GT]" > EndSection > > Section "Screen" > Identifier "Screen0" > Device "Card0" > ... > EndSection > > I can't imagine that being inaccessible by X apps.. and I believe I've > seen > some apps report this info. It's something gdi32/user32 can then get for a > particular screen/adapter by calling into winex11.drv (if not also > something > wined3d can use), instead of reporting "X Windows" for the card name. > Those strings were just generated by the tool which created your xorg.conf. These fields are only internal to X. Some of the info can be obtained from X. For instance I requested support for pci id reading in the nvidia drivers and that was added recently. I plan to work on that early next year. Roderick -- Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a

Dec. 28, 2008

RE: xinput: Add stub XInputEnable

by ricardo filipe

it's almost that. but it needs some changes. first you put the prototypes after the defines and typedefs, they may be needed for the prototypes. second you don't put variable names in the protypes, it should be something like: DWORD WINAPI XInputGetState(DWORD, XINPUT_STATE*); see the xinput.h file from the windows SDK for more details. :) btw you could make a patch to include all the prototypes and defines of the header too. regards. ---------------------------------------- > Date: Sun, 28 Dec 2008 23:41:57 +0700 > From: andrewfenn(a)gmail.com > To: wine-devel(a)winehq.org > Subject: Re: xinput: Add stub XInputEnable > > On Sun, Dec 28, 2008 at 9:39 PM, Henri Verbeet wrote: >> Also, don't forget to add the prototype to the header, I noticed they're missing for all the other xinput functions as well. > > I think I have added the prototypes correctly to the header file. > Could you have a quick look at my patch and tell me if I am doing that > right? _________________________________________________________________ Drag n’ drop—Get easy photo sharing with Windows Live™ Photos. http://www.microsoft.com/windows/windowslive/photos.aspx

Dec. 28, 2008

RE: Implementing dxdiag as student project?

by Stefan Dösinger

> I can't imagine that being inaccessible by X apps.. and I believe I've > seen > some apps report this info. It's something gdi32/user32 can then get > for a > particular screen/adapter by calling into winex11.drv (if not also > something > wined3d can use), instead of reporting "X Windows" for the card name. I'm not sure, but I wouldn't expect these settings to be readable via some X11 API. There are X servers without an X config like that, e.g. the MacOS X server, or Windows X servers

Dec. 28, 2008