December 2008 - Wine-Devel - list.winehq.org

Re: patch for gdi32

by Dan Kegel

On Wed, Dec 3, 2008 at 3:38 PM, Xiangrong Fang <xrfang(a)gmail.com> wrote: > It is indeed bug #4065. I read the info there, although I don't fully > understand every bit information there, but that is marked as FIXED > and CLOSED?? As far as I know, this is NOT fixed yet, and it affect a > HUGE amount of Chinese applications, those applications are otherwise > perfectly supported by wine. I think 4065 was closed because we found what seemed to be an acceptable way to get that particular app (Picasa) working. > A very good progress in this area is > that I found Chinese text are more properly auto-wrapped in recent > Wine releases, which is excellent. We are very interested in providing excellent Asian language support. We can use all the help we can get, though, as few Wine developers speak any Asian languages well. > About this issue, shall I submit discussion in #4065 or open a new > bug? (I need to upload some screenshots to illustrate the problem -- > this is NOT a missing font problem as discussed). Please open a new bug. If possible, include source code for a small noninteractive program that demonstrates the problem. e.g. a C program that displays a single character that is wrong in wine but right in windows. > BTW, for these discussions, shall I use wine-devel or wine-patch? All discussions go to wine-devel. When replying to a message on wine-patches, please change the destination to wine-devel. - Dan

Dec. 3, 2008

Re: patch for gdi32

by Xiangrong Fang

Hi Dan, Thank you for your explanations! It is indeed bug #4065. I read the info there, although I don't fully understand every bit information there, but that is marked as FIXED and CLOSED?? As far as I know, this is NOT fixed yet, and it affect a HUGE amount of Chinese applications, those applications are otherwise perfectly supported by wine. A very good progress in this area is that I found Chinese text are more properly auto-wrapped in recent Wine releases, which is excellent. About this issue, shall I submit discussion in #4065 or open a new bug? (I need to upload some screenshots to illustrate the problem -- this is NOT a missing font problem as discussed). BTW, for these discussions, shall I use wine-devel or wine-patch? Please advise. Thank you! Sincerely, Shannon 2008/12/4 Dan Kegel <dank(a)kegel.com>: > On Wed, Dec 3, 2008 at 1:24 PM, Dan Kegel <dank(a)kegel.com> wrote: >> Hi Xiangrong, >> you forgot to attach the patch, I think. > > Aha. You attached the wrong format. We want a plain text file, > i.e. not .odt, but .txt. The nice description in your .odt/.pdf > belongs in a bug report in http://bugs.winehq.org. > (And, as somebody mentioned, there may be related bugs already, > e.g. http://bugs.winehq.org/show_bug.cgi?id=4065 ) > > If you don't want to use "git diff" to generate the patch, use 'diff -u'. See > http://kegel.com/academy/opensource.html#patches > > Good luck, and welcome to Wine development! > - Dan >

Dec. 3, 2008

Re: Wine t-shirts?

by Ismael Barros²

Hum, that would be cool, I'll ask the boss but it's probably in. Does anyone have a higher resolution version? On Wed, Dec 3, 2008 at 4:29 PM, Steven Edwards <sedwards(a)bordeauxgroup.com> wrote: > On Wed, Dec 3, 2008 at 9:50 AM, Ismael Barros² <razielmine(a)gmail.com> wrote: >> I already asked julliard about permissions and donations (winehq is >> getting 3€ for each sold T-shirt), and now I should determine the >> T-shirt design itself. We'll probably start off with the classical >> wine logo, but we're not sure about the composition, any ideas? The >> website logo looks fine (without the shades, we're limited to 4 >> colours), but the "hq" is probably unnecessary for a T-shirt. > > +1 on the teeshirts if you can use the drunk Penguin on some of them > now that CodeWeavers is not using it for products. > > http://www.ixsoft.de/software/products/CWTSHIRTDP-L.html > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo >

Dec. 3, 2008

Re: patch for gdi32

by Dan Kegel

On Wed, Dec 3, 2008 at 1:24 PM, Dan Kegel <dank(a)kegel.com> wrote: > Hi Xiangrong, > you forgot to attach the patch, I think. Aha. You attached the wrong format. We want a plain text file, i.e. not .odt, but .txt. The nice description in your .odt/.pdf belongs in a bug report in http://bugs.winehq.org. (And, as somebody mentioned, there may be related bugs already, e.g. http://bugs.winehq.org/show_bug.cgi?id=4065 ) If you don't want to use "git diff" to generate the patch, use 'diff -u'. See http://kegel.com/academy/opensource.html#patches Good luck, and welcome to Wine development! - Dan

Dec. 3, 2008

Re: patch for gdi32

by Henri Verbeet

Isn't this the same issue a bug 4065? (http://bugs.winehq.org/show_bug.cgi?id=4065)

Dec. 3, 2008

Re: Mono integration to Wine

by Scott Ritchie

Kornél Pál wrote: > Hi, > > I would like to receive comments on mixed-mode assembly support of Mono > on Wine and if there are people willing to update the Loader to call > _CorValidateImage, _CorExeMain (real entry point is not called for EXEs) > and _CorImageUnloading for managed images. > What is the current status of running a mixed-mode assembly app with Wine after doing something like winetricks mono2? I'm very interested in this question, especially in finding a good sample application out there. Thanks, Scott Ritchie

Dec. 3, 2008

Re: [2/2] gdiplus: fix a warning in GdipMultiplyTextureTransform

by Henri Verbeet

2008/12/3 Nikolay Sivov <bunglehead(a)gmail.com>: > Our prototypes should match MS', shouldn't they?. In this case I don't see > another way to silent this warning > which means nothing (you've already named the reason why). Up to a point. Personally I'd say the PSDK headers are broken here since they're inconsistent with themselves.

Dec. 3, 2008

Re: [2/2] gdiplus: fix a warning in GdipMultiplyTextureTransform

by Nikolay Sivov

Henri Verbeet wrote: > 2008/12/3 Nikolay Sivov <bunglehead(a)gmail.com>: > >> - return GdipMultiplyMatrix(brush->transform, matrix, order); >> + return GdipMultiplyMatrix(brush->transform, (GpMatrix*)matrix, order); >> > > I don't think casting const away makes it much better. Considering > what the function does, and the fact that the matrix *is* const in the > prototype for Matrix::Multiply(), I'd say it would be better to just > change the prototype for GdipMultiplyMatrix. MS doesn't seem to care a > whole lot about their plain C interfaces these days. > Our prototypes should match MS', shouldn't they?. In this case I don't see another way to silent this warning which means nothing (you've already named the reason why). > Slightly OT, the code in matrix_multiply() isn't quite the most > efficient way to multiply two 2x3 matrices, although if you're lucky > the compiler will unroll the loop for you and fold the constants. > Of course you're right here.

Dec. 3, 2008

IServiceProvider::QueryService tests

by Konstantin Kondratyuk

In dlls/mshtml/tests/htmldoc.c there is a comment: /* * Services used by HTMLDocument: * * IOleUndoManager * IInternetSecurityManager * ITargetFrame * {D5F78C80-5252-11CF-90FA-00AA0042106E} * HTMLFrameBase * IShellObject * {3050F312-98B5-11CF-BB82-00AA00BDCE0B} * {53A2D5B1-D2FC-11D0-84E0-006097C9987D} * {AD7F6C62-F6BD-11D2-959B-006097C553C8} * DefView (?) * {6D12FE80-7911-11CF-9534-0000C05BAE0B} * IElementBehaviorFactory * {3050F429-98B5-11CF-BB82-00AA00BDCE0B} * STopLevelBrowser * IHTMLWindow2 * IInternetProtocol * IWebBrowserApp * UrlHostory * IHTMLEditHost * IHlinkFrame */ It is confirmed by tests? I have not found. It seems to me, also there should be IHTMLEditServices interface support. How it is correct to add the test on IServiceProvider::QueryService? Thanks. -- Best regards, Konstantin Kondratyuk.

Dec. 3, 2008

Re: Alexandre Julliard : ole32: Register interfaces through dlldata. c as far as possible.

by Alexandre Julliard

"Rob Shearman" <robertshearman(a)gmail.com> writes: > 2008/12/3 Alexandre Julliard <julliard(a)winehq.org>: >> /* from dlldata.c */ >> +extern HINSTANCE hProxyDll DECLSPEC_HIDDEN; >> +extern BOOL WINAPI OLE32_DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID fImpLoad) DECLSPEC_HIDDEN; > > Why declare OLE32_DllMain when it isn't used? No reason, I just declared all the functions that could be useful, but DllMain turned out to be not so useful in the end. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2008