December 2008 - Wine-Devel - list.winehq.org

Re: [2/2] gdiplus: fix a warning in GdipMultiplyTextureTransform

by Henri Verbeet

2008/12/3 Nikolay Sivov <bunglehead(a)gmail.com>: > - return GdipMultiplyMatrix(brush->transform, matrix, order); > + return GdipMultiplyMatrix(brush->transform, (GpMatrix*)matrix, order); I don't think casting const away makes it much better. Considering what the function does, and the fact that the matrix *is* const in the prototype for Matrix::Multiply(), I'd say it would be better to just change the prototype for GdipMultiplyMatrix. MS doesn't seem to care a whole lot about their plain C interfaces these days. Slightly OT, the code in matrix_multiply() isn't quite the most efficient way to multiply two 2x3 matrices, although if you're lucky the compiler will unroll the loop for you and fold the constants.

Dec. 3, 2008

Re: Wine t-shirts?

by Steven Edwards

On Wed, Dec 3, 2008 at 9:50 AM, Ismael Barros² <razielmine(a)gmail.com> wrote: > I already asked julliard about permissions and donations (winehq is > getting 3€ for each sold T-shirt), and now I should determine the > T-shirt design itself. We'll probably start off with the classical > wine logo, but we're not sure about the composition, any ideas? The > website logo looks fine (without the shades, we're limited to 4 > colours), but the "hq" is probably unnecessary for a T-shirt. +1 on the teeshirts if you can use the drunk Penguin on some of them now that CodeWeavers is not using it for products. http://www.ixsoft.de/software/products/CWTSHIRTDP-L.html -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Dec. 3, 2008

Re: Wine t-shirts?

by Ismael Barros²

On Thu, May 8, 2008 at 10:32 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > 2008/5/8 Maarten Lankhorst <m.b.lankhorst(a)gmail.com>: >> 2008/5/8 Jon Parshall <jparshall(a)codeweavers.com>: >>> I've messed around with Wine Bottles for our installer artwork, and I have this version that I could gussy up for the shirts if you'd like. >> I like the most left bottle, can you make one in the reddish color >> wine uses? And put the label I created on it and get it roughly in the >> same size? It would be perfect for the t-shirt. > Uncorked, since wine will be released. :D > Hi all I'm setting up a T-shirt store specialized in free software, www.freewear.org (work still in progress, but if everything goes well it should be running in one or two weeks), and obviously want Wine T-shirts in :) I already asked julliard about permissions and donations (winehq is getting 3€ for each sold T-shirt), and now I should determine the T-shirt design itself. We'll probably start off with the classical wine logo, but we're not sure about the composition, any ideas? The website logo looks fine (without the shades, we're limited to 4 colours), but the "hq" is probably unnecessary for a T-shirt. Anyway, if you guys want come up with a nicer design/logo, or want to order T-shirts for some Wine/FOSS event, we're open for business. Cheers Ismael Barros

Dec. 3, 2008

Re: Alexandre Julliard : ole32: Register interfaces through dlldata. c as far as possible.

by Rob Shearman

2008/12/3 Alexandre Julliard <julliard(a)winehq.org>: > /* from dlldata.c */ > +extern HINSTANCE hProxyDll DECLSPEC_HIDDEN; > +extern BOOL WINAPI OLE32_DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID fImpLoad) DECLSPEC_HIDDEN; Why declare OLE32_DllMain when it isn't used? > extern HRESULT WINAPI OLE32_DllGetClassObject(REFCLSID rclsid, REFIID iid,LPVOID *ppv) DECLSPEC_HIDDEN; > +extern HRESULT WINAPI OLE32_DllRegisterServer(void) DECLSPEC_HIDDEN; > +extern HRESULT WINAPI OLE32_DllUnregisterServer(void) DECLSPEC_HIDDEN; -- Rob Shearman

Dec. 3, 2008

Re: cryptdlg: Implement FormatVerisignExtension (resend)

by Alexandre Julliard

"Juan Lang" <juan.lang(a)gmail.com> writes: > Aside from the size, is there anything wrong with this one? You are still wasting lots of space by storing copies of string resources. There's no need to do that. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2008

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

by Alexandre Julliard

"Henri Verbeet" <hverbeet(a)gmail.com> writes: > 2008/12/3 Juan Lang <juan.lang(a)gmail.com>: >>> Why is this a good thing - this just artificially caps your constants at >>> 32. If I remember correctly I had to change shaders to do the exact >>> opposite change, because newer versions introduced more than 32 constants. >> >> I agree with you, this is a questionable change. The benefit in >> reduced data results in a gain of code size and runtime cost. >> --Juan >> > Perhaps setting constants becomes slightly more expensive this way, > but I'm not convinced it's very significant. The more performance > critical code that applies the constants becomes significantly cheaper > though. I expect most operations will become faster, because the data is more likely to be kept in cache and in registers. It could probably be made even more efficient by getting rid of most of the remaining loops. I think it's a very reasonable change, using array of BOOLs is really wasteful. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2008

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

by Henri Verbeet

2008/12/3 Juan Lang <juan.lang(a)gmail.com>: >> Why is this a good thing - this just artificially caps your constants at >> 32. If I remember correctly I had to change shaders to do the exact >> opposite change, because newer versions introduced more than 32 constants. > > I agree with you, this is a questionable change. The benefit in > reduced data results in a gain of code size and runtime cost. > --Juan > Perhaps setting constants becomes slightly more expensive this way, but I'm not convinced it's very significant. The more performance critical code that applies the constants becomes significantly cheaper though.

Dec. 3, 2008

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

by Henri Verbeet

2008/12/3 Ivan Gyurdiev <ivg231(a)gmail.com>: >> Re: [4/5] wined3d: Use a bitmask to store which bool and int constants >> are set. > > Why is this a good thing - this just artificially caps your constants at 32. > If I remember correctly I had to change shaders to do the exact opposite > change, because newer versions introduced more than 32 constants. > > Ivan > We could always extend the number of possible constants by using an array. However, when we need more constants we'll probably need a scheme more like what's used for float constants anyway. The reduced memory usage is significant, not so much because we can't spare the memory, but because it allows the compiler to just keep the entire thing in a register. Perhaps even more importantly, when an application starts using constants from zero and goes up from there (which is not an unreasonable thing to do), we only have to go through the loop the amount of times as there are constants set. If the application doesn't use int or bool constants at all, we don't have to go through the loop at all either.

Dec. 3, 2008

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

by Juan Lang

> Why is this a good thing - this just artificially caps your constants at > 32. If I remember correctly I had to change shaders to do the exact > opposite change, because newer versions introduced more than 32 constants. I agree with you, this is a questionable change. The benefit in reduced data results in a gain of code size and runtime cost. --Juan

Dec. 3, 2008

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

by Ivan Gyurdiev

> Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set. Why is this a good thing - this just artificially caps your constants at 32. If I remember correctly I had to change shaders to do the exact opposite change, because newer versions introduced more than 32 constants. Ivan

Dec. 3, 2008