February 2008 - Wine-Devel - list.winehq.org

Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]

by H. Verbeet

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(LPD3DXRENDERTOSURFACE iface, REFIID riid, LPVOID *object) > +{ > + ID3DXRenderToSurfaceImpl *This=(ID3DXRenderToSurfaceImpl*)iface; > + > + if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ID3DXRenderToSurface)) { > + TRACE("(%p): QueryInterface from %sn", This, debugstr_guid(riid)); > + IUnknown_AddRef(iface); > + *object=This; > + return S_OK; > + } > + WARN("(%p)->(%s, %p): not foundn", iface, debugstr_guid(riid), object); > + object=NULL; > + return E_NOINTERFACE; > +} > + Setting object to NULL here doesn't do a whole lot, you should set *object to NULL (also goes for the other QueryInterface implementations). Also, you'll probably want to put the TRACE before the if block.

Feb. 24, 2008

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9]

by H. Verbeet

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > + TRACE("stubn"); Shouldn't that be a \n (here and in the other patches)?

Feb. 24, 2008

Re: gdiplus: Implement GdipLoadImageFromFile

by Dmitry Timoshkov

"Nathan Beckmann" <nathan.beckmann(a)gmail.com> wrote: > stat = GdipCreateBitmapFromStream(stream, bitmap); > > - if(!stat) > + if(stream) > IStream_Release(stream); The 'if' check above is not needed, GdipCreateStreamOnFile returns a status which is already checked. > + stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > + > + if (stat != Ok) > + return stat; > + > + stat = GdipLoadImageFromStream(stream, image); > + > + if (stream) > + IStream_Release(stream); Same thing here. -- Dmitry.

Feb. 24, 2008

Re: gdiplus: Implement GdipLoadImageFromFile

by James Hawkins

On Sat, Feb 23, 2008 at 11:00 PM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Hi. My name is Nathan Beckmann. I'm working on GDI+ for a class > project at UCLA (sponsored by Google). > > This patch implements GdipLoadImageFromFile. > > It includes basic tests for invalid parameters, all of which pass on > Windows. I'm working on this in order to get ConvertImage.exe > (http://bugs.winehq.org/show_bug.cgi?id=10980) to work. Now I'm > working on image encoders/decoders. > > Implemented GdipLoadImageFromFile using > GdipLoadImageFromStream. Implementation based on > GdipCreateBitmapFromFile. > > Changed GdipCreateBitmapFromFile to properly release the Stream COM > object. > > Added tests for CreateBitmapFromFile and LoadImageFromFile when passed > with invalid parameters. One fix per patch. http://winehq.org/site/sending_patches -- James Hawkins

Feb. 24, 2008

re: Sending updates to wine developers guide

by Dan Kegel

> I can't find the documentation so I can edit it. Look at the bottom of http://winehq.org/site/git The command to load it into a local git repository is git cvsimport -v -k -d :pserver:anonymous(a)wine.cvs.sourceforge.net:/cvsroot/wine docs You can then send in patches.

Feb. 24, 2008

Sending updates to wine developers guide

by Austin English

I was looking at the website.git online, I can't find the documentation so I can edit it. http://source.winehq.org/git/website.git/?a=blob;f=templates/en/documentati… references /docs/, but that doesn't exist on git. I'm sure a lot of the info is outdated, but I was mostly looking to fix the regression testing guides, which still reference CVS, and are horribly outdated. Any possibility of adding /docs/ to website.git? -Austin

Feb. 24, 2008

Re: Bugs fixed in 0.9.56

by Dan Kegel

On Sat, Feb 23, 2008 at 5:04 PM, Ivan Gyurdiev <ivg231(a)gmail.com> wrote: > Dan Kegel wrote: > > Here are the bugs marked fixed during the 0.9.56 cycle. > > (A few of them were fixed earlier, but not marked as such before.) > > It might be nice if the "Lots of bugfixes" line in each release ANNOUNCE > file would link to a list like this one. > Proof there were lots of bugfixes... Alexandre told me he's thinking of doing that from now on. I guess seeing that list made it pretty obvious we should do it! - Dan

Feb. 24, 2008

Re: Bugs fixed in 0.9.56

by Ivan Gyurdiev

Dan Kegel wrote: > Here are the bugs marked fixed during the 0.9.56 cycle. > (A few of them were fixed earlier, but not marked as such before.) > It might be nice if the "Lots of bugfixes" line in each release ANNOUNCE file would link to a list like this one. Proof there were lots of bugfixes... Ivan

Feb. 24, 2008

Re: wined3d: ActivateContext: try to fix wrong parameter?

by Rico Schüller

I refer to the last attachment to the bug (and the patch which was sent in the initial mail http://www.winehq.org/pipermail/wine-devel/2008-February/062835.html - it's the same). I just want to say if my patch is wrong and the other way is wrong (see bug http://bugs.winehq.org/show_bug.cgi?id=11584 ) then the real issue must be somewhere else! To find that my knowledge isn't good enough yet. So I just want to have some help/hints to find the real source of the bug ;-) Cheers Rico Stefan Dösinger wrote: > Am Freitag, 22. Februar 2008 22:45:23 schrieb Rico Schüller: >> I didn't step deep into this problem. So if I could help with some logs >> or other things, please let me know. Properly, the real bug is somewhere >> else? > Did you intend to attach a file to the mail, or did you refer to the last > attachment to the bug? >

Feb. 23, 2008

Re: Do we need a forum?

by L. Rahyen

On Thursday February 21 2008 16:37:15 Tom Wickline wrote: > On Mon, Feb 18, 2008 at 8:19 PM, L. Rahyen <research(a)science.su> wrote: > > > Tom is committed to doing this with > > > wine-forum. If there is something you don't like, such as the > > > registration, advertisements, etc I am sure he is willing to adjust > > > the user experience. > > > > OK, then if he is reading this list hopefully he will consider my > > words as feature request. If he really will fix these issues that would > > be great. Thanks. > > Sorry for the late reply, ive caught the flu bug and ive been sick for > the past week. > > I have yet to receive the first email of complaint about the > advertisements on the forum. > I know the Kontera adverts are considered by some as nag, pop-up > advertising but ive yet to receive a message or email asking me to remove > them. Well, personally I don't care about ads. I simply don't see them in most cases anyway. I use complex custom filters on all web-pages - and auto-removing of ads is just of one their features. In fact, I even didn't know about existence of ads on wine-forum (and many other sites)! BTW, I never mentioned ads in my messages as a problem... > As for registration, every forum ive ever visited asked for registration, > sorry but I don't understand what your asking for? > > Tom Well, there is some forums which provides "quick reply" form at the bottom of the thread (on any of its pages). If you are logged in, you can type text there and then submit it as usually. If you are not logged in, you will be able to enter your nickname, protection code and text with your reply. Protection code is intended as protection from "spam bots". Usually, protection code provided as somewhat noisy image with few digits and user should recognize them and enter correctly in the "protection code" field. Sometimes additional optional fields with password is provided so user can login and send an answer simultaneously. If he/she leave password field blank then reply is posted anyway with provided nickname but with "guest" settings (such as default avatar for all guests or not avatar at all, etc.) and guest privileges. Sometimes nickname collisions are allowed, sometimes not. Typically it is good idea to make "guest" settings in the way that clearly marks all guest posts as such. However, depending on the code base of a forum, it may be simple to integrate such a feature, or hard. But registration is one-time problem, especially for people who just want to ask one question or answer to some topic (that was found using Google for example) and don't plan to use the forum frequently. And many people can consider this as "minor" issue. More important problem is lack of ability to subscribe for all messages from the forum as as well as inability to answer via standard mail client. These problems are most important. wine-forum.org doesn't provide such functionality. It would be great if this is fixed. *At least* there should be possibility to subscribe to all messages from the forum and possibility to answer by clicking on the link (to the reply form on the forum) in each e-mail message from the forum (direct processing of the e-mail answers is even better but can be harder to implement). It is also important that after you logged in you don't need to login every time again and there is no short timeout (use of cookies is necessary for this to work). But I have no idea how hard/easy will be to implement these features on wine-forum.org because I know very little about vBulletin used by wine-forum. I think that recently created http://forum.winehq.org/ seems to be the best solution. Registration there isn't a problem because anyone can write a message directly to the mailing list without registration on the forum. This is exactly what I imagine as a perfect solution suitable for all users: everyone can post answers without logging in (via the mailing list), everybody can use forum or mailing list (depending on personal choice), and it is possible to receive and answer using any e-mail client you like. So I think winehq.org now have very good forum with nice sync with wine-users mailing list! I really like it. In fact it solves all major problems that I mentioned in my previous messages!

Feb. 23, 2008