February 2008 - Wine-Devel - list.winehq.org

Re: dmband: Indirection levels fix

by Robert Shearman

Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ftDate = pDesc->ftDate; > if (pDesc->dwValidData & DMUS_OBJ_MEMORY) { > This->pDesc->llMemLength = pDesc->llMemLength; > - memcpy (This->pDesc->pbMemData, pDesc->pbMemData, sizeof (pDesc->pbMemData)); > + memcpy (&This->pDesc->pbMemData, &pDesc->pbMemData, sizeof (pDesc->pbMemData)); > } > if (pDesc->dwValidData & DMUS_OBJ_STREAM) { > /* according to MSDN, we copy the stream */ This isn't correct. Judging by the surrounding code, this should be allocating a block of memory of This->pDesc->pbMemData and then passing pDesc->llMemLength into memcpy, possibly validating that pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. -- Rob Shearman

Feb. 21, 2008

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.

by Detlef Riekenberg

On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c… > > Author: James Hawkins <jhawkins(a)codeweavers.com> > Date: Fri Feb 15 17:39:46 2008 -0600 > > itircl: Add a stub implementation of itircl.dll. Hi James. While adding your Patch to http://wiki.winehq.org/Developers-Hints , I found this Page: http://www.helpware.net/aphelp/info.htm itircl.dll: HTML Help 1 (found on w2k and xp) itircl52.dll: MS Help 2 apircl.dll: Assistance Platform 1.0 (Vista) -- By by ... Detlef

Feb. 21, 2008

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

by Francois Gouget

On Thu, 21 Feb 2008, Jeff Zaroyko wrote: [...] > I think this looks good, http://jeffz.name/tmp/suggestion3.png > > Do you still think we need to change the green Francois? I prefer to have the text in the colored bar because that way it matches the title at the top (Known bugs in suggestion.png). So here's my proposal with a slightly lighter green and white text. http://fgouget.free.fr/tmp/newfg.png But I don't have a strong opinion on this, so do as you think is best. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

Feb. 21, 2008

Re: slc: Added stub for SLGetWindowsInformationDWORD

by Alistair Leslie-Hughes

Gee, you guys are quick. Submitted again without the comments. Best Regards Alistair Leslie-Hughes

Feb. 21, 2008

Re: slc: Added stub for SLGetWindowsInformationDWORD

by James Hawkins

On Thu, Feb 21, 2008 at 3:38 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > > On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes > <leslie_alistair(a)hotmail.com> wrote: > > Hi, > > > > Changelog: > > slc: Added stub for SLGetWindowsInformationDWORD > > > > Best Regards > > Alistair Leslie-Hughes > > > Hi Alistair, > > I know that function descriptions should always be your own words but > I guess this is also true for header files. > > The comments in slerror.h are exactly like the comments on MSDN: > http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx > And on top of that, you really shouldn't be adding those types of comments to the headers anyway (commenting a define). -- James Hawkins

Feb. 21, 2008

Re: slc: Added stub for SLGetWindowsInformationDWORD

by Paul Vriens

On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I guess this is also true for header files. The comments in slerror.h are exactly like the comments on MSDN: http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx Cheers, Paul.

Feb. 21, 2008

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

by Jeff Zaroyko

On Thu, Feb 21, 2008 at 1:24 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > On Thu, Feb 21, 2008 at 12:45 PM, Chris Morgan <chmorgan(a)gmail.com> wrote: > > > > > > On Wed, Feb 20, 2008 at 8:36 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > > > > > On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > > > > > > > The default colours for warnings and notes on the appdb pages feel > > > > rather strong, this patch changes the red and blue to be a bit softer. > > > > > > > > I think this makes it more readable. A comparison can be seen here: > > > > http://jeffz.name/tmp/ > > > > > > In new.png the green looks darker than the others. Maybe it should be > > > lightened up a bit too. > > > > > > > > > -- > > > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > > > In a world without fences who needs Gates? > > > > > > > > > > > > We might also consider inverting the color of the text to increase the > > contrast since it seems difficult to read. > > > > Chris > > > > > > how about moving the title to the row below? removes the contrasting > text problem > > http://jeffz.name/tmp/suggestion.png > I think this looks good, http://jeffz.name/tmp/suggestion3.png Do you still think we need to change the green Francois?

Feb. 21, 2008

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

by Jeff Zaroyko

On Thu, Feb 21, 2008 at 12:45 PM, Chris Morgan <chmorgan(a)gmail.com> wrote: > > On Wed, Feb 20, 2008 at 8:36 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > > > On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > > > > > The default colours for warnings and notes on the appdb pages feel > > > rather strong, this patch changes the red and blue to be a bit softer. > > > > > > I think this makes it more readable. A comparison can be seen here: > > > http://jeffz.name/tmp/ > > > > In new.png the green looks darker than the others. Maybe it should be > > lightened up a bit too. > > > > > > -- > > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > > In a world without fences who needs Gates? > > > > > > > We might also consider inverting the color of the text to increase the > contrast since it seems difficult to read. > > Chris > how about moving the title to the row below? removes the contrasting text problem http://jeffz.name/tmp/suggestion.png

Feb. 21, 2008

Re: Adding devices in setupapi

by Erich Hoover

> > I think it probably does something similar to: > http://www.codeproject.com/KB/system/RemoveDriveByLetter.aspx > > Except instead of mapping a drive to usb device, it does it the other > way around. > > After looking more into it it really looks like this is the thing it > does. (I need a bunch of hacks for it to work, but alas.) However it > doesn't get me much further since our IOCTL_STORAGE_GET_DEVICE_NUMBER > ioctl is a stub. I would need something that can at least guarantee > uniqueness per volume for it, perhaps a conversion of drive letter to > integer. Now I just need to figure that one out. > > Cheers, > Maarten. > > I do not believe the device number matching is the problem, I have been exploring this problem a little with RemoveDriveByLetter and I believe that it is not working because the SymbolicLink entry is not added as a "real" thing in Wine. Performing an experiment with accessing the same drive letter in three different ways (results below, last parameter is "hDrive") I see that only the call with the registry-returned value for the drive fails (even if it is added to "HKLM/System/MountedDevices"). I believe that a call to IoCreateSymbolicLink must be made in order for the name returned by the registry to be recognized as an alias for the drive. I think iTunes is probably going through the device tree looking for its vendor and product code. It should get this back from CM_Get_Device_ID, but I do not have Windows so I cannot fake iTunes out to confirm this. SetupDiGetDeviceInterfaceDetail '\\?\USBSTOR#Disk&Ven_Apple&Prod_iPod&Rev_1.62#000A27001420C124&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}': -1 SetupDiGetDeviceInterfaceDetail '\\?\Volume{00000000-0000-0000-0000-000000000048}': 60 SetupDiGetDeviceInterfaceDetail '\\.\H:': 64 Device number comparison: 1 1

Feb. 21, 2008

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

by Chris Morgan

On Wed, Feb 20, 2008 at 8:36 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > > > The default colours for warnings and notes on the appdb pages feel > > rather strong, this patch changes the red and blue to be a bit softer. > > > > I think this makes it more readable. A comparison can be seen here: > > http://jeffz.name/tmp/ > > In new.png the green looks darker than the others. Maybe it should be > lightened up a bit too. > > > -- > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > In a world without fences who needs Gates? > > We might also consider inverting the color of the text to increase the contrast since it seems difficult to read. Chris

Feb. 21, 2008