February 2008 - Wine-Devel - list.winehq.org

Re: [advapi32/tests #2] Don't set last error to 0 so we can check if it has changed

by Paul Vriens

On Feb 18, 2008 2:17 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > > > We test for a last error of 0, so we shouldn't set it to 0 before the > > function is called. This however introduces a todo_wine. > > Is there any reason to believe that last error should be 0 on success? > This looks more like a broken test to me. > Well no. I agree it looks more like a broken test me as well. That's why I said I didn't see any of the tests enter this 'if' statement. This if statement was introduced by Rob Shearman: http://source.winehq.org/git/wine.git/?a=commit;h=1731df4ca0460c3ef15b27450… I have no clue what the test does and what's wrong with it so can we leave it like this? Or should we ask Rob to go way back in his memory (June 2005) ;-) Cheers, Paul.

Feb. 18, 2008

Re: programs: add winestartfile for starting files from the unix path (for file managers)

by Vincent Povirk

The odd thing about wine's explorer is that it doesn't seem to copy any UI that's handled by explorer on windows. It seems to be some sort of service and have something to do with HAL (and controlling virtual desktops for some reason). I must admit I don't understand the reasoning behind any of the current things that are or are not handled by explorer, but I think this is probably not the right place. The reason for trying to emulate explorer functionality is that some apps depend on being called exactly the way they would be called by explorer. AFAIK they do not care if they're called by explorer.exe or some other program. I imagine this wouldn't be too difficult to add, but I'd have to make explorer depend on shell32 (and possibly shlwapi). I'm also not sure how this would interact with /desktop functionality (come to think of it, explorer would read any path starting in a / as a command-line switch..). On Feb 18, 2008 5:07 AM, Steven Edwards <winehacker(a)gmail.com> wrote: > As explorer.exe is always running could you do something like extend > it so that that KFM and friends could call 'explorer.exe filename' > directly? It seems redundant to add another winelib application when > you are trying to emulate explorer functionality anyway and explorer > is always running. You could extend it to use messaging to connect to > an existing explorer.exe process also. > > Thanks > Steven > > > > On 2/17/08, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > > This is now attempt 4, not that anyone's counting. > > > > Adding winelib programs is a bit involved, and I imagine I've screwed > > something up along the way. If you know how to add them properly, > > please say something, even if it's to tell me I did it right. > > > > This patch adds a winelib program called winestartfile for starting > > files given the unix path. It attempts to mimic what windows explorer > > does to start files and provide some visible (gui) feedback when it > > doesn't work. The idea is that wine.desktop can then be modified to > > use winestartfile instead of wine, solving the following problems when > > starting exe files from file managers: > > * File managers typically do not set the working directory to the > > directory that contains an exe when they start it. Setting the working > > directory is the default behavior for windows explorer, and many > > windows programs rely on it. > > * File managers naturally use the unix path to start files, and the > > wine binary passes the unix path along to the exe it starts, rather > > than translating it to a windows path (this can and probably should > > also be fixed somewhere else). > > * Windows explorer always starts exe files with quotes around the path > > in the command-line, even if the path does not contain spaces. The > > wine binary does not (and probably should not) add quotes in this > > situation. A few apps rely on the quotes. See > > http://bugs.winehq.org/show_bug.cgi?id=5224#c14 > > > > -- > > Vincent Povirk > > > > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > -- Vincent Povirk

Feb. 18, 2008

Re: Usable Wine interface

by Christian Authmann

Edward Savage wrote: > I would very much like to see a --spawn-new trigger that can be added > to a command to start a new virtual desktop. wine explorer.exe /desktop=Name,800x600 myapp.exe a hint about that command-line trick could be added to winecfg though, as it seems to be quite unknown.

Feb. 18, 2008

Re: iTunes

by Robert Shearman

Maarten Lankhorst wrote: > On a slightly related note: Do you know if the hardware drivers are > installed somewhere? I would be interested in getting iTunes syncing > to my ipod touch (similar to iphone). I didn't see anything in my > wineprefix after installation. I don't know about the iPod Touch and iPhone, but iPods are USB mass storage devices in Windows and so don't require any device drivers. iTunes 4.x communicated with an iPod using DeviceIoControl(..., IOCTL_SCSI_PASS_THROUGH, ...) and DeviceIoControl(..., IOCTL_SCSI_PASS_THROUGH_DIRECT, ...), but only after doing a whole bunch of low-level calls using setupapi and other ioctls to find the device. The 4.x versions of iTunes did install a driver for the CD burning functionality, however. Good luck, but bear in mind that any hard work done on iTunes may need to re-done in 3-6 months time when the next version of iTunes comes out. -- Rob Shearman

Feb. 18, 2008

Re: [advapi32/tests #2] Don't set last error to 0 so we can check if it has changed

by Alexandre Julliard

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > We test for a last error of 0, so we shouldn't set it to 0 before the > function is called. This however introduces a todo_wine. Is there any reason to believe that last error should be 0 on success? This looks more like a broken test to me. -- Alexandre Julliard julliard(a)winehq.org

Feb. 18, 2008

Re: inetcomm: Fix compilation on systems that don't support nameless unions.

by Marcus Meissner

On Mon, Feb 18, 2008 at 11:54:22AM +0100, Francois Gouget wrote: > --- > dlls/inetcomm/mimeole.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c > index a0da6b9..e986e7f 100644 > --- a/dlls/inetcomm/mimeole.c > +++ b/dlls/inetcomm/mimeole.c > @@ -1257,7 +1257,7 @@ static HRESULT WINAPI sub_stream_CopyTo( > ULARGE_INTEGER totalBytesRead; > ULARGE_INTEGER totalBytesWritten; > > - TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.LowPart, pcbRead, pcbWritten); > + TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.u.LowPart, pcbRead, pcbWritten); > > totalBytesRead.QuadPart = 0; > totalBytesWritten.QuadPart = 0; > @@ -1525,7 +1525,7 @@ static HRESULT create_body_offset_list(IStream *stm, const char *boundary, struc > > zero.QuadPart = 0; > hr = IStream_Seek(stm, zero, STREAM_SEEK_CUR, &cur); > - start = cur.LowPart; > + start = cur.u.LowPart; > > do { > hr = IStream_Read(stm, overlap, PARSER_BUF_SIZE, &read); > @@ -1599,7 +1599,7 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IMimeBody_Load(mime_body, pStm); > zero.QuadPart = 0; > hr = IStream_Seek(pStm, zero, STREAM_SEEK_CUR, &cur); > - offset->cbBodyStart = cur.LowPart + offset->cbHeaderStart; > + offset->cbBodyStart = cur.u.LowPart + offset->cbHeaderStart; > if(parent) MimeBody_set_offsets(impl_from_IMimeBody(mime_body), offset); > IMimeBody_SetData(mime_body, IET_BINARY, NULL, NULL, &IID_IStream, pStm); > body = new_body_entry(mime_body, msg->next_hbody, parent); > @@ -1629,8 +1629,8 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IStream *sub_stream; > ULARGE_INTEGER start, length; > > - start.LowPart = cur->offsets.cbHeaderStart; > - length.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > + start.u.LowPart = cur->offsets.cbHeaderStart; > + length.u.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > create_sub_stream(pStm, start, length, &sub_stream); > sub_body = create_sub_body(msg, sub_stream, &cur->offsets, body); > IStream_Release(sub_stream); > @@ -1674,7 +1674,7 @@ static HRESULT WINAPI MimeMessage_Load( > > zero.QuadPart = 0; > IStream_Seek(pStm, zero, STREAM_SEEK_END, &cur); > - offsets.cbBodyEnd = cur.LowPart; > + offsets.cbBodyEnd = cur.u.LowPart; > MimeBody_set_offsets(impl_from_IMimeBody(root_body->mime_body), &offsets); > > list_add_head(&This->body_tree, &root_body->entry); > There seems to be damage in here, both ^M and lose 0s. Ciao, Marcus

Feb. 18, 2008

Re: iTunes

by Maarten Lankhorst

Hi James, 2008/2/17, James Hawkins <truiken(a)gmail.com>: > On Feb 17, 2008 11:39 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > > > > Hi James, > > > > 2008/2/17, James Hawkins <truiken(a)gmail.com>: > > > On Feb 17, 2008 11:16 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > > > > Hi James, > > > > > > > > > > > > 2008/2/17, James Hawkins <truiken(a)gmail.com>: > > > > > On Feb 17, 2008 11:07 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > > > > > > 2008/2/17, James Hawkins <truiken(a)gmail.com>: > > > > > > > > > > > > > On Feb 17, 2008 9:42 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > > > > > > > > Hi Christopher, > > > > > > > > > > > > > > > > Christopher Harvey wrote: > > > > > > > > > What needs to get done for iTunes to work? > > > > > > > > > > > > > > > > v7.6 basically works if you set windows version to windows vista, and > > > > > > > > find out why the installer fails to create the 'Bonjour service' > > > > > > > > registry stuff properly. > > > > > > > > > > > > > > > > I submitted 8 or so stub dll's to wine-patches that make iTunes v7.6 > > > > > > > > actually start after installation. It checks for the dll's and > > > > > > > > silently fails if they don't exist. > > > > > > > > > > > > > > > > I haven't done any further testing yet though, but it looks like it is > > > > > > > > probably a small installer bug that prevents itunes v7.6 from > > > > > > > > installing without first manually creating those registry keys. > > > > > > > > > > > > > > > > > > > > > > The Bonjour service depends on the tcpip service. As far as I know, > > > > > > > we don't provide that service. What registry keys are you referring > > > > > > > to? > > > > > > Keys like: > > > > > > In HKLM\SYSTEM\CurrentControlSet\Services\Bonjour Service: > > > > > > ImagePath="C:\...." > > > > > > Start=0x00000002 > > > > > > Description="....." > > > > > > > > > > > > Those are not created during install. If I manually add them the > > > > > > 'bonjour service' will report success on start, but actually crash > > > > > > right after. However it is enough to satisfy the itunes installer. > > > > > > Without those it will report failure without even attempting to start > > > > > > the service. :-) > > > > > > > > > > > > > > > > hmm according to the logs, the service is installed just fine. You'd > > > > > get an err otherwise. The dependencies aren't listed, but since we > > > > > don't have the tcpip service anyway, it won't make a difference > > > > > (though that might be why it crashes when you get the service to > > > > > start.) > > > > There is a big difference. Without it it will abort installation > > > > because the bonjour service fails to start. With it it will start but > > > > immediately crash, however that happens after start so installation > > > > happily continues. The effect is that installer will continue. I don't > > > > see how it can be fine if it fails to create the appropiate registry > > > > keys. > > > > > > > > > > I'm not saying it's not. I'm saying that the call to CreateService > > > doesn't fail, or you'd get an err, like I said before. > > > > > > service = CreateServiceW(hscm, name, disp, GENERIC_ALL, serv_type, > > > start_type, err_control, file->TargetPath, > > > load_order, NULL, NULL, serv_name, pass); > > > if (!service) > > > { > > > if (GetLastError() != ERROR_SERVICE_EXISTS) > > > ERR("Failed to create service %s: %d\n", debugstr_w(name), > > > GetLastError()); > > > } > > > > > > I'm not saying there's not a bug in CreateServiceW, but as it stands, > > > we don't get a failure. > > You can try for yourself at the following link: > > http://www.apple.com/downloads/macosx/apple/windows/bonjourforwindows.html > > > > Or try iTunes v7.6 directly. > > > > It could also be that it never calls CreateService for some reason, > > I'm not 100% sure. > > > > I already have tried it; that's how I know the call doesn't fail. Yes > it does call CreateService. All the error paths in > ITERATE_InstallService have ERRs, so you'd see it if it did fail. It could be that it fails with a parameter error and then exits silently, those paths are not covered. On a slightly related note: Do you know if the hardware drivers are installed somewhere? I would be interested in getting iTunes syncing to my ipod touch (similar to iphone). I didn't see anything in my wineprefix after installation. Cheers, Maarten.

Feb. 18, 2008

Re: [1/16] msxml3: Support functions for typelib

by Alistair Leslie-Hughes

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:878x1lc5ds.fsf(a)wine.dyndns.org... >> + *typeinfo = typeinfos[tid]; >> + return S_OK; > > You should increment the ref count when you are returning a pointer, > even if it's also stored in a global variable. Hi, After reviewing the changes I need to an AddRef to typeinfo, it doesnt make sense. In each GetTypeInfo function we do an AddRef since the user gets a pointer pack to the typinfo pointer. Where as, in GetIDsOfNames and Invoke functions we use the get_typeinfo function to retreive the pointer and in this case we dont want to increment the pointer. What is the best course of actions? 1. AddRef in get_typeinfo and therefore Release in GetIDsOfNames and Invoke or 2. AddRef in GetTypeInfo, and nothing else has to be changed. Best Regards Alistair Leslie-Hughes

Feb. 18, 2008

Re: [PATCH] Environment variable to specify X11 window for desktop

by Dmitry Timoshkov

"Steven Edwards" <winehacker(a)gmail.com> wrote: > As detlef pointed out about the screensavers, there does seem to be a > few valid cases for this. Maybe support for embedding could be put > inside of the existing explorer? I'd like to add support for Windows > screensavers. A while back I submitted a patch that needs some rework > for xdg-screensavers but I expect users will want to also be able to > use the native ones. Windows screen-savers already support drawing in a window without external ugly hacks. -- Dmitry.

Feb. 18, 2008

Re: [PATCH] Environment variable to specify X11 window for desktop

by Roderick Colenbrander

Hi, I'm just bumping into this discussion. From what I read the reason you need such functionality is for a mozilla powerpoint plugin. Have you figured out how this embedding is done on Windows? I don't know much about it but I think embedding works using COM and perhaps almost the same as e.g. Flash. For example codeweavers has a plugin to embed IE plugins in mozilla, the same for the KDE reaktivate project which did something similar for Konqueror (although it can be used on mozilla too as they put it all in a library). Likely IE plugins work differently but I think the same embedding mechanism could be used, so you won't need such an X11 hack. Regards, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

Feb. 18, 2008