February 2008 - Wine-Devel - list.winehq.org

Re: dlls/shell32/pidl.c -- adjust to unsignedness of a type

by Gerald Pfeifer

On Sat, 16 Feb 2008, Alexandre Julliard wrote: > The test should probably be removed completely since there's already a > default for it in the switch() that follows. I was thinking of this, but wanted to go for the smaller patch initially, but your wish is my command ;-). Updated patch below. Nearly everything here is whitespace changes; the second hunk only removes "if (type >= 0 && type <= 2) {" and "}". Gerald ChangeLog: Adjust a format specifier and remove a redundant range check in ILGetDisplayNameExW(). Index: pidl.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/pidl.c,v retrieving revision 1.159 diff -u -3 -p -r1.159 pidl.c --- pidl.c 16 Feb 2008 15:58:53 -0000 1.159 +++ pidl.c 17 Feb 2008 18:44:54 -0000 @@ -97,7 +97,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF STRRET strret; DWORD flag; - TRACE("%p %p %p %d\n", psf, pidl, path, type); + TRACE("%p %p %p %x\n", psf, pidl, path, type); if (!pidl || !path) return FALSE; @@ -109,46 +109,44 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF return FALSE; } - if (type >= 0 && type <= 2) + switch (type) { - switch (type) + case ILGDN_FORPARSING: + flag = SHGDN_FORPARSING | SHGDN_FORADDRESSBAR; + break; + case ILGDN_NORMAL: + flag = SHGDN_NORMAL; + break; + case ILGDN_INFOLDER: + flag = SHGDN_INFOLDER; + break; + default: + FIXME("Unknown type parameter = %x\n", type); + flag = SHGDN_FORPARSING | SHGDN_FORADDRESSBAR; + break; + } + + if (!*(const WORD*)pidl || type == ILGDN_FORPARSING) + { + ret = IShellFolder_GetDisplayNameOf(lsf, pidl, flag, &strret); + if (SUCCEEDED(ret)) { - case ILGDN_FORPARSING: - flag = SHGDN_FORPARSING | SHGDN_FORADDRESSBAR; - break; - case ILGDN_NORMAL: - flag = SHGDN_NORMAL; - break; - case ILGDN_INFOLDER: - flag = SHGDN_INFOLDER; - break; - default: - FIXME("Unknown type parameter = %x\n", type); - flag = SHGDN_FORPARSING | SHGDN_FORADDRESSBAR; - break; + if(!StrRetToStrNW(path, MAX_PATH, &strret, pidl)) + ret = E_FAIL; } - if (!*(const WORD*)pidl || type == ILGDN_FORPARSING) + } + else + { + ret = SHBindToParent(pidl, &IID_IShellFolder, (LPVOID*)&psfParent, &pidllast); + if (SUCCEEDED(ret)) { - ret = IShellFolder_GetDisplayNameOf(lsf, pidl, flag, &strret); + ret = IShellFolder_GetDisplayNameOf(psfParent, pidllast, flag, &strret); if (SUCCEEDED(ret)) { - if(!StrRetToStrNW(path, MAX_PATH, &strret, pidl)) + if(!StrRetToStrNW(path, MAX_PATH, &strret, pidllast)) ret = E_FAIL; } - } - else - { - ret = SHBindToParent(pidl, &IID_IShellFolder, (LPVOID*)&psfParent, &pidllast); - if (SUCCEEDED(ret)) - { - ret = IShellFolder_GetDisplayNameOf(psfParent, pidllast, flag, &strret); - if (SUCCEEDED(ret)) - { - if(!StrRetToStrNW(path, MAX_PATH, &strret, pidllast)) - ret = E_FAIL; - } - IShellFolder_Release(psfParent); - } + IShellFolder_Release(psfParent); } }

Feb. 17, 2008

Re: Next big app(s) to try?

by Dan Kegel

Edward Savage wrote: > CS3 photoshop, illustrator, flash, and aftereffects so I can drag my > girlfriend to linux. OK, just for you I created http://wiki.winehq.org/AdobeAfterEffects with download links, etc. There's one common bug stopping all CS3 installs, I think, but in my experience bugs in the earlier versions also show up in later versions, and the earlier versions have easier to work on. So if you want us to work on After Effects, please start testing all the trial versions before CS3 and filing bugs. That will get the app ready for when we fix that common CS3 bug. - Dan

Feb. 17, 2008

Re: include: Add support for executing finally code for exceptions without using a separate function.

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > The first goal is accomplished by changing the previous two-state > variable of __first into a three-state variable where the third state > is the state in which the finally code is executed in the normal > case. The second goal is accomplished by calling sigsetjmp in > __wine_finally_handler to give the finally code a place to jump back > to after it has finished executing. That can't work, once you longjmp into the finally block you can't longjmp back, since you are no longer inside the function that did the setjmp. -- Alexandre Julliard julliard(a)winehq.org

Feb. 17, 2008

Re: [1/6] ddraw: fix executebuffer branching with non-zero offset

by Stefan Dösinger

Am Montag, 18. Februar 2008 02:36:35 schrieb Alexander Dorofeyev: > Fixes a crash in Moto Racer 2. > --- > dlls/ddraw/executebuffer.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) The patches look good to me

Feb. 17, 2008

Re: [6/6] wined3d: take alpha from device palette entry for d3d 8 and later

by Stefan Dösinger

Am Montag, 18. Februar 2008 02:37:00 schrieb Alexander Dorofeyev: >/*can ddraw and d3d < 8 surfaces use device's palette (d3d >= 8 feature)?*/ No, they can't, there is no API to access them

Feb. 17, 2008

Re: Next big app(s) to try?

by Nemes Ioan Sorin

Can I add here Corel Draw suite ? I've managed to start and work with Corel Draw 12 (with Wine Doors I add VB common controls) but after wine 0.9.45 Corel stop working. Also Corel Draw is widely used in DTP industry. Finally imagine AVID* working better and faster under WINE, ..stop I walk in a dream now, sorry for that ;) Edward Savage wrote: > CS3 photoshop, illustrator, flash, and aftereffects so I can drag my > girlfriend to linux. > > Thanks :D > > (Sorry for the dupe Jaap, hit the wrong reply button.) > > On Feb 17, 2008 10:07 PM, Jaap Stolk <jwstolk(a)gmail.com > <mailto:jwstolk(a)gmail.com>> wrote: > > On Feb 17, 2008 11:57 AM, Pau Garcia i Quiles <pgquiles(a)elpauer.org > <mailto:pgquiles(a)elpauer.org>> wrote: > > > > AutoCAD, please > > > > I spend a lot of time trying to get autocad (2004) to run on Wine. > There where some small problems like registry things and with Internet > Explorer dependencies, but those where easy to solve. The big problem > is that the copy protection (and the anti-debugging tricks in it) run > as a couple of windows drivers and do things that are far from > "normal" in Windows. It is also very picky about almost everything, > and does not generate any timely or useful error messages. (it just > exits at the very end, without any clue about what went wrong.) > Without the copy protection I'm sure autocad would run just fine with > Wine. Newer autocad versions use .NET as well, which could be more > complicated. (And no, "p2p" versions still have all the copy > protection and anti-debugging tricks. ) > > Personally (as a programmer), I think my time would be better spend on > many of the open-source CAD programs. > (Or ask rhino3d very nicely if they want to make a Linux version. > please. :-) > > jaap. > > > > > ------------------------------------------------------------------------ > >

Feb. 17, 2008

Re: dlls/msi/streams.c type fixes

by James Hawkins

On Feb 17, 2008 6:23 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This patch contains one or two items from my November patch the core > of which was independently recreated by Marcus and accepted and one > or two additional changes. It addresses the following warnings: > > streams.c: In function 'streams_set_table_size': > streams.c:59: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_delete': > streams.c:379: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_find_matching_rows': > streams.c:404: warning: comparison between signed and unsigned > > Gerald > > ChangeLog: > Adjust the signedness of three variables and add a comment for > add_streams_to_table(). > > Index: streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.11 > diff -u -3 -p -r1.11 streams.c > --- streams.c 16 Feb 2008 15:59:26 -0000 1.11 > +++ streams.c 17 Feb 2008 12:17:50 -0000 > @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msidb); > > typedef struct tabSTREAM > { > - int str_index; > + UINT str_index; > LPWSTR name; > IStream *stream; > } STREAM; > @@ -54,7 +54,7 @@ typedef struct tagMSISTREAMSVIEW > UINT row_size; > } MSISTREAMSVIEW; > > -static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) > +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, UINT size) > { > if (size >= sv->max_streams) > { > @@ -372,7 +372,7 @@ static UINT STREAMS_modify(struct tagMSI > static UINT STREAMS_delete(struct tagMSIVIEW *view) > { > MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; > - int i; > + UINT i; > > TRACE("(%p)\n", view); > > @@ -440,6 +440,7 @@ static const MSIVIEWOPS streams_ops = > }; > > static INT add_streams_to_table(MSISTREAMSVIEW *sv) > + /* Return -1 in case of error. */ > { > IEnumSTATSTG *stgenum = NULL; > STATSTG stat; > Don't add random comments like this. -- James Hawkins

Feb. 17, 2008

appdb feature request: hide the ugly urls

by Dan Kegel

How hard would it be for the appdb to support more readable URLs for vendors and applications? e.g. Adobe Premiere is currently at http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 but it'd be so slick to see instead http://appdb.winehq.org/adobe/premiere Believe it or not, that little change would make the appdb less scary for newcomers. - Dan

Feb. 17, 2008

bugzilla on the fritz again

by Dan Kegel

Just started getting this: Software error: Can't connect to the database. Error: Too many connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig?

Feb. 17, 2008

Re: Next big app(s) to try?

by Dan Kegel

On Feb 17, 2008 4:02 AM, L. Rahyen <research(a)science.su> wrote: > What about support for Autodesk products (such as AutoCAD and 3ds max)? As > far as I know there is two group of problems preventing them from working: > copy-protection related and .NET related. ... > However for not-so-new versions there is no .NET issues (just copy-protection > problems).... > This is true for AutoCAD too (as far as I know AutoCAD and 3ds max are using > same protection called C-Dilla). Yeah, getting .net working would be great, and we seem to be making some progress there. And getting the copy protection used by these apps would be great. Googling around, I see that C-Dilla has sometimes been called Safecast, which is related to Safedisc, so I took the liberty of updating http://wiki.winehq.org/SafeDisc with a link to the Autocad 2000 bug, http://bugs.winehq.org/show_bug.cgi?id=8466. That one looks like it's waiting for some action - James pointed out a simple-looking problem, but nobody's tackled it yet. I'm torn between tackling hard problems and just going for the low-hanging fruit. I think the upshot is: I'm going to push hard on the low-hanging fruit, and let the hard problems sort themselves out in their own time, since pushing on them usually tends to involve a lot of wheel spinning. - Dan

Feb. 17, 2008