February 2008 - Wine-Devel - list.winehq.org

Re: Autoplay considered harmful

by Evil Jay

The purist in me says that WINE should not improve on Windows - it should behave the same way, warts and all. If I had a vote, I'd vote to enable it by default, but give the user an easy way to disable it in winecfg. (And I'd immediately disable it the first time I ran Winecfg!) But, whatever you guys decide to do is cool - as long as you keep cranking out this great package! :) -Jesse Steven Edwards wrote: > On Feb 16, 2008 8:58 AM, Dan Kegel <dank(a)kegel.com> wrote: > >> http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… >> says that USB devices are being sold with infected >> autorun apps. "If you plug in, you're already infected," >> >> I'd say that's a pretty good argument for not supporting autoplay... >> > > I was actually thinking about this today. The right method would be to > use HAL notification events to prompt the user if they want to autorun > when sticking a new cdrom in. There could even be warning text in the > dialog so that if it pops up with other device insertion, the user > would know that it could be a virus. > >

Feb. 16, 2008

Re: X developer's conference, April 16-18

by Roderick Colenbrander

> http://www.x.org/wiki/Events/XDC2008 > > Seems like Wine might want a representative. > What issues would we want to bring up there? > - relative mouse motion events > ...? > > - Dan > Perhaps X developers should be aware about the way we implement windowed opengl rendering (bug 2398) using Composite. Basically we use an 'offscreen' window as a buffer and so now and then we copy this data over. Not all drivers support this properly yet (yes, they are working on features like this) but I don't think most are aware of the way Wine uses them (there is more than compiz). Roderick -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

Feb. 16, 2008

Re: Autoplay considered harmful

by Steven Edwards

On Feb 16, 2008 8:58 AM, Dan Kegel <dank(a)kegel.com> wrote: > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > says that USB devices are being sold with infected > autorun apps. "If you plug in, you're already infected," > > I'd say that's a pretty good argument for not supporting autoplay... I was actually thinking about this today. The right method would be to use HAL notification events to prompt the user if they want to autorun when sticking a new cdrom in. There could even be warning text in the dialog so that if it pops up with other device insertion, the user would know that it could be a virus. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 16, 2008

Re: Autoplay considered harmful

by Dan Kegel

On Feb 16, 2008 7:08 AM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > > Dan Kegel wrote: > > > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > > > says that USB devices are being sold with infected > > > autorun apps. "If you plug in, you're already infected," > > > > > > I'd say that's a pretty good argument for not supporting autoplay... > > Completely not supported or disabled by default? By default, I guess. Some customers might know their cd-rom's are safe, and we should let them enable it via a control panel, I guess. But autoplay support is kind of a distro packaging thing, I think, so we probably have to discuss this with whoever builds the packages...?

Feb. 16, 2008

Re: Autoplay considered harmful

by Robert Lövlie

John Klehm wrote: >> Dan Kegel wrote: >> >>> http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… >>> says that USB devices are being sold with infected >>> autorun apps. "If you plug in, you're already infected," >>> >>> I'd say that's a pretty good argument for not supporting autoplay... >>> >>> > > Completely not supported or disabled by default? > > --John Klehm > The autorun.inf files are simple enough to support with a simple script, and they usually launch a windows program. This can be implementet in an end system with minimum effort and no changes to the wine codebase. I'm firmly opposed to wine polling disk drives for new mediums and autoplaying them by default. -- Robert Lövlie topace(a)oijk.net

Feb. 16, 2008

Re: Autoplay considered harmful

by John Klehm

> Dan Kegel wrote: > > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > > says that USB devices are being sold with infected > > autorun apps. "If you plug in, you're already infected," > > > > I'd say that's a pretty good argument for not supporting autoplay... > > Completely not supported or disabled by default? --John Klehm

Feb. 16, 2008

Re: dlls/shell32/pidl.c -- adjust to unsignedness of a type

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF > return FALSE; > } > > - if (type >= 0 && type <= 2) > + if (type <= 2) > { > switch (type) > { The test should probably be removed completely since there's already a default for it in the switch() that follows. -- Alexandre Julliard julliard(a)winehq.org

Feb. 16, 2008

Re: [1/16] msxml3: Support functions for typelib

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; You should increment the ref count when you are returning a pointer, even if it's also stored in a global variable. -- Alexandre Julliard julliard(a)winehq.org

Feb. 16, 2008

Re: Autoplay considered harmful

by James McKenzie

Dan Kegel wrote: > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > says that USB devices are being sold with infected > autorun apps. "If you plug in, you're already infected," > > I'd say that's a pretty good argument for not supporting autoplay... > > > +1 Let's not forget the infected CDs as well. James McKenzie

Feb. 16, 2008

Re: wined3d: Fix bug in swapchain release which causes incorrect display mode changes.

by Chris Robinson

On Saturday 16 February 2008 06:01:48 am Peter Dons Tychsen wrote: > Fixed bug in wined3d swapchain, which caused the release of the > swap-chain to mess around with the display-modes set by ddraw. Also > added test-case for this scenario. Reworked test code minimally, to > re-use existing test code. You may want to test D3D8 and D3D9 too, to see what they do when presented by the situation (since the code is shared). Also I don't think you should make those 2-space indents just to avoid changing those few lines.

Feb. 16, 2008