February 2008 - Wine-Devel - list.winehq.org

Re: [RFC] winecfg enhancements

by Steven Edwards

On Feb 13, 2008 2:29 PM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > And the other proposed improvements? Those were mentioned and can be > commented on. I've skimmed the discussion and while its important to me it bears much too verbose. Can we just get some mockup images of that the proposed changes would look like? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 14, 2008

ddraw / wined3d fighting over the resolution!

by Peter Dons Tychsen

Hi Stefan/Devs. The funny old game "Insane" has a resolution bug when it exits. I am not sure exactly how to fix this. 1) It call SetDisplayMode() - switches from 1280 x 1024 -> 640 x 480. OK. 2) It creates a 3D surface which starts the SwapChain - swapchain saves current resolution. 3) Exit. It calls RestoreDisplayMode() - switches back to 1280 x 1024. OK. 4) SwapChain is destroyed. Switches "back" to 640 x 480 ! BAD! I presume the code guesses that the caller does this in another sequence (and it does work fine in other sequences). Why does the SwapChain-destroy function play around with the resolution at all. Is that really necessary? I think it should not do it if the caller is ddraw at least. How do i fix this? Thanks, /pedro

Feb. 14, 2008

Weird failure in kernel32 volume test

by Maarten Lankhorst

Hi all, The latest update of trying to be the second person for which all tests succeed. I sent a bunch of patches that make some tests pass. At the moment I have 3 failures on a clean wineprefix, with no icons on my desktop, and with wine in native window mode on kde 3.5.x: user32: 'msg' test fails. The famous 'win' test passes. kernel32: I get a very weird bug on the 'volume' test. It only occurs when I run my mini script for running the tests. I have absolutely no idea why I get ERROR_FILE_NOT_FOUND on FindFirstVolumeA on the first time I run the whole testsuite, and not successive runs. Anyone has experienced the same, or have an idea what is going on? msi: multi-sz failure in msi install, I did a todo_wine on it so it doesn't stop the build. It seems to be a recent failure though because I know that it didn't bomb out on install a few days ago. Anyone else has some tests that consistently fail on make test? Cheers, Maarten.

Feb. 14, 2008

Almost done...

by Maarten Lankhorst

Hi all, Right now I got down to only the user32 msg test failing (minus the todo's). I solved the user32 win test with a very high-tech solution: Remove all icons from my desktop, which prevents the stupid file description popup from failing the user32 win test. The other way would be to run it in a wine desktop which would also prevent this (I got no failures on runtest, except the todo's). The msg tests are more difficult. For some reason I accidentally passed them once, when I had the debug scrolling on. But after that there were always failures on my pc. Is there any way to sync those so that it is less prone to timing issues? Cheers, Maarten.

Feb. 14, 2008

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests

by Peter Dons Tychsen

OK. I still think he should put a FIXME remark in the test-case, and document why Sleep() is needed. Someone might fix the driver someday. The only reason i yelled "alert!", is that i have seen so much bad code which has come to a state where the are Sleep(143) here and Sleep(1332) there, where nobody can remember why they are there and what the Sleep count represents (most of the time no-one ever knew! :-)). In the mean time, the real bugs just getter harder to find, as they are covered by all the messy Sleeps(). I see allot of this kind of yap in telecom embedded software (mobile phones etc.). In this case Maarten probably knows what he is doing (he usually does). But thanks for the follow up! And now i will go to Sleep(). Thanks, /p On Wed, 2008-02-13 at 11:28 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 03:11:24 schrieb Peter Dons Tychsen: > > Eh, this does not seem like a proper way to get a unit test to pass. > > > > Sleep()... that leads to the dark side! :-) > I talked to Maarten on IRC about this. The problem seems to be that his > monitor takes ages to mode switch, but ChangeDisplaySettings returns before > this modeswitch is done. Also the opengl driver attempts to draw before the > setup is ready, which fails and causes the test failures. > > So it sounds like a driver bug which will only affect the tests(since games > draw repeatedly and do not care if the first few frames do not render > properly)

Feb. 13, 2008

Re: [PATCH] include: add ISampleGrabber interface

by Lei Zhang

On Feb 13, 2008 3:03 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This patch adds the ISampleGrabber interface, also needed by IMediaDet. > Bah, let me try again. Just realized I forgot to pass -n to git format-patch as well.

Feb. 13, 2008

Re: Fixing the last failing tests

by Dan Kegel

Dmitry wrote: >> An example is IsWindowUnicode. It always returns TRUE on XP, > >That's not true. The test you submitted that checks this, http://www.winehq.org/pipermail/wine-patches/2005-July/018839.html must have passed once on Windows, but it seems to be failing now; see e.g. http://test.winehq.org/data/200802131000/xp_rs-winxp-sp2/user32:win.txt which is full of lines like win.c:3656: Test failed: IsWindowUnicode expected to return FALSE Do you have a Windows system where that test passes currently? - Dan

Feb. 13, 2008

Re: gecko download not robust?

by Steven Edwards

On Feb 10, 2008 10:11 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Compiling the package is quite tricky. I've compiled it on Windows XP > using MSVC. There is no other way ATM, so I think that my Gecko package > should be included as is in Linux packages. Where is the source package? Is it just from the normal firefox source tree with certain configuration options? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 13, 2008

Re: gecko download not robust?

by Austin English

You could make it a suggested package, a la wine-dev. Including is also a possibility, but keep in mind that's several megabytes that don't change with each release (or that often) that have to be redownloaded each time. I've got high bandwith, so doesn't bother me, but a lot of people don't... -Austin On Feb 13, 2008 3:24 PM, marco <marco(a)mandrivaclub.nl> wrote: > > > Austin English wrote: > > On Feb 9, 2008 5:17 PM, marco <marco(a)mandrivaclub.nl> wrote: > > > >>> Hmm. gecko download hung for me once. I saw > >>> fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 > >>> in the log, which makes me wonder if our download code > >>> doesn't handle transient network errors well. > >>> > >>> Time to get rid of the download, and just bundle gecko outright, I say... > >>> > >> I make the mandriva rpms for wine. > >> This would make the rpms 30% bigger. > >> And you would download the same gecko binary over and over again with > >> every new version. > >> > >> But if that is not a problem than it can be easily done. > >> > >> > >> > > > > Why not have package maintainers package gecko like most do > > development files. So you could have for example on ubuntu: > > $ sudo apt-get install wine wine-dev wine-gecko > > > > Where wine-gecko wouldn't have to be upgraded very often. > > > > -Austin > > > > > > I looked into it. > And there are some options. > > I can make a separate package of gecko that I can make it a > dependencie of wine. > Problem is people have to know where to find it or the get stuck. > > I can also make the package and make it not a dependencie on wine but > the the people don't know it exist. > > And I can just put it in the wine package. > > I think this is the best option in this case. Its the easiest option > because people only have to download en install one package. > > marco > > > > > > > > > > > > >

Feb. 13, 2008

Re: gecko download not robust?

by marco

Austin English wrote: > On Feb 9, 2008 5:17 PM, marco <marco(a)mandrivaclub.nl> wrote: > >>> Hmm. gecko download hung for me once. I saw >>> fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 >>> in the log, which makes me wonder if our download code >>> doesn't handle transient network errors well. >>> >>> Time to get rid of the download, and just bundle gecko outright, I say... >>> >> I make the mandriva rpms for wine. >> This would make the rpms 30% bigger. >> And you would download the same gecko binary over and over again with >> every new version. >> >> But if that is not a problem than it can be easily done. >> >> >> > > Why not have package maintainers package gecko like most do > development files. So you could have for example on ubuntu: > $ sudo apt-get install wine wine-dev wine-gecko > > Where wine-gecko wouldn't have to be upgraded very often. > > -Austin > > I looked into it. And there are some options. I can make a separate package of gecko that I can make it a dependencie of wine. Problem is people have to know where to find it or the get stuck. I can also make the package and make it not a dependencie on wine but the the people don't know it exist. And I can just put it in the wine package. I think this is the best option in this case. Its the easiest option because people only have to download en install one package. marco

Feb. 13, 2008