February 2008 - Wine-Devel - list.winehq.org

Re: Fixing the last failing tests

by James Hawkins

On Feb 12, 2008 8:16 PM, Peter Dons Tychsen <donpedro(a)tdcadsl.dk> wrote: > Hello M. > > What is wrong with detecting the version, and branching the test code > accordingly? Other tests do that IIRC. I think that is a better > solution, if the version selector in winecfg is still going to be > meaningful (registry). > The only time the tests should check for the windows version is if we know an app does the same thing, which is hardly ever. P.S. Please bottom-post on this mailing list. -- James Hawkins

Feb. 13, 2008

re: Fixing the last failing tests

by Dan Kegel

Maarten wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 without MSLU */ ok(!IsWindowUnicode()); } else { /* win95 with MSLU, or something with native unicode support */ ok(IsWindowUnicode()); }

Feb. 13, 2008

Re: Fixing the last failing tests

by Peter Dons Tychsen

Hello M. What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry). How about fixing the functions as well (like IsWindowUnicode), so it returns the correct data according to the version in winecfg (registry). However, i do like the irony in your example :-) /pedro On Tue, 2008-02-12 at 18:09 -0800, Maarten Lankhorst wrote: > Hi all, > > I'm very close to passing the whole wine conformance suite on my pc. > The only tests failing are in user32. These tests are failing in any > version of windows though. How do I make them pass on at least 1 > version of windows and wine? Would patches to make it run on xp and > wine be accepted? > > And if I can succeed with that, how do I make it work with other > versions of windows as well. > > Cheers, > Maarten. > > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); > >

Feb. 13, 2008

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests

by Peter Dons Tychsen

Eh, this does not seem like a proper way to get a unit test to pass. Sleep()... that leads to the dark side! :-) Why does it need a Sleep()? If its failing on Wine, then shouldn't it be fixed in the libs? And if its on orig-winxp-vista then there must be a better way to wait? Or no? The string "This makes the tests pass on my pc" isn't very good either. What system? In general, introducing magic Sleep() values in code is not a good idea. If the test system is stressed, you will start getting failures again = bad idea. /p On Wed, 2008-02-13 at 02:26 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > > This makes the tests pass on my pc. > > d3d8 might need it as well > >

Feb. 13, 2008

Fixing the last failing tests

by Maarten Lankhorst

Hi all, I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted? And if I can succeed with that, how do I make it work with other versions of windows as well. Cheers, Maarten. An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");

Feb. 13, 2008

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests

by Stefan Dösinger

Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > This makes the tests pass on my pc. d3d8 might need it as well

Feb. 13, 2008

Alsa spitting out warnings every time Wine runs.

by Peter Dons Tychsen

Hi Maarten & Devs. Great to see that audio is so much better in Wine now. But.... On fedora core 6 and 8 i get this every time i start Wine: ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 I think its harmless, but what do you it means? How do i stop it? Should i fix it in Wine or Alsa? /p

Feb. 13, 2008

[PATCH] Environment variable to specify X11 window for desktop

by Timothy Lee

Dear all, The attached patch allows the WINE desktop to be embedded within an existing X11 window, and is similar to the windowed mode in WINE. I've tested this feature using MS PowerPoint Viewer 2007, so that a fullscreen slideshow can be fitted inside any X11 window. Regards, Timothy Lee

Feb. 13, 2008

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

by Peter Dons Tychsen

Hi Stefan. OK thanks for the fast, precise and well-cut review (and probably correct). I will fix the 3 issues and re-submit. /p On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > > Hi Devs. > > > > I had this patch silently rejected. > > Can anybody spot what is wrong with this patch? > My first thought was that filtering the modes like this is kinda ugly, but > given that ddraw uses wined3d and wined3d uses the d3d9 interface this is the > only way. (I don't think adding an extra flag to wined3d is cleaner, > considering that ddraw can sort this out on its own). > > However, I think you shouldn't clone the application's bug you're trying to > work around and deal with the "out of mode buffer" case. you can e.g. use > HeapReAlloc to increase the buffer without loosing the content. > > Another minor thing is the if(buffer) HeapFree(buffer) code. HeapFree checks > against NULL, so the extra check isn't needed, and it is sorta a policy not > to have redundant checks before HeapFree >

Feb. 13, 2008

How is the testsuite built for windows

by Maarten Lankhorst

Hi all, I'm trying to get the tests to run in windows, but I'm not sure how to build them. Any attempt to do mingw cross compiling fails badly. Who managed to compile all wine tests for windows, and how is it done? Cheers, Maarten.

Feb. 12, 2008