February 2008 - Wine-Devel - list.winehq.org

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

by Stefan Dösinger

Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > Hi Devs. > > I had this patch silently rejected. > Can anybody spot what is wrong with this patch? My first thought was that filtering the modes like this is kinda ugly, but given that ddraw uses wined3d and wined3d uses the d3d9 interface this is the only way. (I don't think adding an extra flag to wined3d is cleaner, considering that ddraw can sort this out on its own). However, I think you shouldn't clone the application's bug you're trying to work around and deal with the "out of mode buffer" case. you can e.g. use HeapReAlloc to increase the buffer without loosing the content. Another minor thing is the if(buffer) HeapFree(buffer) code. HeapFree checks against NULL, so the extra check isn't needed, and it is sorta a policy not to have redundant checks before HeapFree

Feb. 12, 2008

ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

by Peter Dons Tychsen

Hi Devs. I had this patch silently rejected. Can anybody spot what is wrong with this patch? It is really needed for some older games like Grand Theft Auto, and other oldies (but goodies!). /pedro

Feb. 12, 2008

Re: dbghelp/dwarf.c: new valgrind warnings?

by Eric Pouech

Dan Kegel a écrit : > I'm now seeing some new valgrind warnings when > wine is doing stack dumps after crashes: > > + Conditional jump or move depends on uninitialised value(s) > + at dwarf2_load_one_entry (dwarf.c:983) > + by dwarf2_lookup_type (dwarf.c:858) > + by dwarf2_load_one_entry (dwarf.c:1020) > + by dwarf2_parse (dwarf.c:2060) > + by elf_load_debug_info (elf_module.c:1085) > + by module_get_debug (module.c:303) > + by SymFromAddr (symbol.c:1071) > + by stack_get_current_symbol (stack.c:143) > + by display_print (display.c:174) > + by wait_exception (tgt_active.c:178) > + by dbg_active_auto (tgt_active.c:951) > + by main (winedbg.c:544) > > I don't know when this started, but maybe it's related > to recent changes by Eric Pouech? > my bad patch sent to wine-patched thx for spotting it A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Feb. 12, 2008

Re: [winetest] Would it be worthwhile to send zipped version of the reports?

by Paul Vriens

Reece Dunn wrote: > On 12/02/2008, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> Hi, >> >> As more and more tests are developed I think it could make sense to zip the >> report files before sending. >> >> It will of course put a small extra burden on the winehq server but as the >> reports are text only we gain a 90% or so per report. >> >> Thoughts? > > This is a good idea, although gzip or bzip2 would be better, and they > can be embedded into the winetest application. > > It would also mean that we can finally get a full run of the Vista > tests, as they will then be under the 1.5MB file limit! > > - Reece > Hi, Well I should have said 'compressed' cause I'm not in favor of any compression currently as long as the files get smaller. -- Cheers, Paul.

Feb. 12, 2008

Re: [advapi32/tests] Only use functions if they are implemented

by Paul Vriens

James Hawkins wrote: > On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> Hi, >> >> Added some verbosity to the GetProcAddress stuff. The skips prevent the >> crash(es) I'm seeing on win95. >> > > What is the point of this 'verbosity'? You already add the skips, so > if a function isn't available for a test, you're going to see it twice > now. Also, it adds to the code size. > I did the 'verbosity' to find out the missing functions before I did the skips in the first place. As a lot of the tests are still not running on all platforms I've added these extra trace. If needed I'll sent a patch with just the skips. There are a lot of tests already with these extra traces (and yes I'm guilty). Maybe we should have a janitorial task once we have a green testpage. -- Cheers, Paul.

Feb. 12, 2008

Re: [winetest] Would it be worthwhile to send zipped version of the reports?

by Reece Dunn

On 12/02/2008, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > As more and more tests are developed I think it could make sense to zip the > report files before sending. > > It will of course put a small extra burden on the winehq server but as the > reports are text only we gain a 90% or so per report. > > Thoughts? This is a good idea, although gzip or bzip2 would be better, and they can be embedded into the winetest application. It would also mean that we can finally get a full run of the Vista tests, as they will then be under the 1.5MB file limit! - Reece

Feb. 12, 2008

Re: [advapi32/tests] Only use functions if they are implemented

by James Hawkins

On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Added some verbosity to the GetProcAddress stuff. The skips prevent the > crash(es) I'm seeing on win95. > What is the point of this 'verbosity'? You already add the skips, so if a function isn't available for a test, you're going to see it twice now. Also, it adds to the code size. -- James Hawkins

Feb. 12, 2008

[winetest] Would it be worthwhile to send zipped version of the reports?

by Paul Vriens

Hi, As more and more tests are developed I think it could make sense to zip the report files before sending. It will of course put a small extra burden on the winehq server but as the reports are text only we gain a 90% or so per report. Thoughts? -- Cheers, Paul.

Feb. 12, 2008

Re: browseui: Add undocumented Component Category Cache Daemon class

by Dmitry Timoshkov

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > --- /dev/null > +++ b/dlls/browseui/compcatcachedaemon.c > @@ -0,0 +1,159 @@ > +/* > + * Progress dialog > + * > + * Copyright 2007 Mikolaj Zalewski Is the above information correct? -- Dmitry.

Feb. 12, 2008

Re: Oleview: Added Dutch translations

by Dmitry Timoshkov

"Frans Kool" <frans.kool(a)gmail.com> wrote: > From 2e5bda68273038f924f8f0d1b325a2a4c71f17ae Mon Sep 17 00:00:00 2001 > From: Frans Kool <Frans.Kool(a)gmail.com> > Date: Tue, 12 Feb 2008 12:04:56 +0100 > Subject: Oleview: Added Dutch translations This your patch as well as a previous one are wrapped. -- Dmitry.

Feb. 12, 2008