February 2008 - Wine-Devel - list.winehq.org

Re: Gdiplus: conformance test for GdipDrawLineI in graphics.c

by James Hawkins

On Feb 10, 2008 3:46 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added conformance test mainly checking for input parameters > You forgot the patch again. -- James Hawkins

Feb. 10, 2008

Re: Gdiplus: GdipDrawArc in graphics.c does not return InvalidParameter for bad values of height and width

by James Hawkins

On Feb 10, 2008 3:19 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added two checks for non-positive values of width and height > -added a conformance test for invalid parameters > You forgot the patch. -- James Hawkins

Feb. 10, 2008

winecfg improvements

by Reece Dunn

Hi, I have just submitted 4 patches that make it possible to import a colour theme from winecfg and have it correctly apply the colours. One example is the Ubuntu Human theme (see attachment), adapted from http://tombuntu.com/wp-content/uploads/2008/01/winehumancolours.txt. Enjoy, - Reece

Feb. 10, 2008

Re: dlls/gdi32/font.c warning removal (RESEND)

by Gerald Pfeifer

On Wed, 6 Feb 2008, Alexandre Julliard wrote: >> The reason is that we have >> >> #define HDPTOLP(y) ((y<0)? \ >> (-abs(INTERNAL_YDSTOWS(dc, (y)))): \ >> (abs(INTERNAL_YDSTOWS(dc, (y))))) >> >> which is overly complicated for unsigned types. We can avoid these >> warnings by using plain INTERNAL_YDSTOWS instead of HDPTOLP here. > No, you still need the abs(). You're right. That was a stupid thinko on my side. Please find below an updated patch. Gerald ChangeLog: For unsigned types, directly use INTERNAL_YDS Index: font.c =================================================================== RCS file: /home/wine/wine/dlls/gdi32/font.c,v retrieving revision 1.39 diff -u -3 -p -r1.39 font.c --- font.c 6 Feb 2008 13:28:51 -0000 1.39 +++ font.c 10 Feb 2008 21:26:59 -0000 @@ -1690,16 +1690,16 @@ UINT WINAPI GetOutlineTextMetricsW( output->otmTextMetrics.tmOverhang = WDPTOLP(output->otmTextMetrics.tmOverhang); output->otmAscent = HDPTOLP(output->otmAscent); output->otmDescent = HDPTOLP(output->otmDescent); - output->otmLineGap = HDPTOLP(output->otmLineGap); - output->otmsCapEmHeight = HDPTOLP(output->otmsCapEmHeight); - output->otmsXHeight = HDPTOLP(output->otmsXHeight); + output->otmLineGap = abs(INTERNAL_YDSTOWS(dc,output->otmLineGap)); + output->otmsCapEmHeight = abs(INTERNAL_YDSTOWS(dc,output->otmsCapEmHeight)); + output->otmsXHeight = abs(INTERNAL_YDSTOWS(dc,output->otmsXHeight)); output->otmrcFontBox.top = HDPTOLP(output->otmrcFontBox.top); output->otmrcFontBox.bottom = HDPTOLP(output->otmrcFontBox.bottom); output->otmrcFontBox.left = WDPTOLP(output->otmrcFontBox.left); output->otmrcFontBox.right = WDPTOLP(output->otmrcFontBox.right); output->otmMacAscent = HDPTOLP(output->otmMacAscent); output->otmMacDescent = HDPTOLP(output->otmMacDescent); - output->otmMacLineGap = HDPTOLP(output->otmMacLineGap); + output->otmMacLineGap = abs(INTERNAL_YDSTOWS(dc,output->otmMacLineGap)); output->otmptSubscriptSize.x = WDPTOLP(output->otmptSubscriptSize.x); output->otmptSubscriptSize.y = HDPTOLP(output->otmptSubscriptSize.y); output->otmptSubscriptOffset.x = WDPTOLP(output->otmptSubscriptOffset.x); @@ -1708,7 +1708,7 @@ UINT WINAPI GetOutlineTextMetricsW( output->otmptSuperscriptSize.y = HDPTOLP(output->otmptSuperscriptSize.y); output->otmptSuperscriptOffset.x = WDPTOLP(output->otmptSuperscriptOffset.x); output->otmptSuperscriptOffset.y = HDPTOLP(output->otmptSuperscriptOffset.y); - output->otmsStrikeoutSize = HDPTOLP(output->otmsStrikeoutSize); + output->otmsStrikeoutSize = abs(INTERNAL_YDSTOWS(dc,output->otmsStrikeoutSize)); output->otmsStrikeoutPosition = HDPTOLP(output->otmsStrikeoutPosition); output->otmsUnderscoreSize = HDPTOLP(output->otmsUnderscoreSize); output->otmsUnderscorePosition = HDPTOLP(output->otmsUnderscorePosition);

Feb. 10, 2008

WineD3D: split framebuffer -> texture path from LoadLocation [attempt 2]

by Roderick Colenbrander

Hi, This is a resubmit from the previous patch without messed up indent. Regards, Roderick Colenbrander -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

Feb. 10, 2008

Re: Implemented a stub for MsiSetExternalUIRecord in msi.dll

by James Hawkins

On Feb 10, 2008 1:11 PM, Luke Benstead <kazade(a)gmail.com> wrote: > This unimplemented function causes the .NET framework 3.0 installer to fail > (and also Visual C++ express 8.0) with this patch the installer continues > further before crashing. This is my first ever patch on Wine (and working > with GIT) so I'm sure I've done something wrong, if so I apologize in > advance :) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 643f9cc..9fb6906 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -992,6 +992,7 @@ end: > return state; > } > > + > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > { > INSTALLUILEVEL old = gUILevel; Random whitespace change -> bad. > @@ -1008,6 +1009,18 @@ INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > return old; > } > > +/*********************************************************************** > + * MsiSetExternalUIRecord [MSI.@] > + */ > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER puiHandler, > + DWORD dwMessageFilter, LPVOID pvContext, > + PINSTALLUI_RECORD_HANDLER ppuiPrevHandler ) > +{ > + FIXME("%p %08x %p %p", > + puiHandler, dwMessageFilter, pvContext, ppuiPrevHandler); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > INSTALLUI_HANDLERA WINAPI MsiSetExternalUIA(INSTALLUI_HANDLERA puiHandler, > DWORD dwMessageFilter, LPVOID pvContext) > { Used tabs -> bad. > @@ -2452,3 +2465,5 @@ UINT WINAPI MsiAdvertiseScriptA( LPCSTR szScriptFile, DWORD dwFlags, > debugstr_a( szScriptFile ), dwFlags, phRegData, fRemoveItems ); > return ERROR_CALL_NOT_IMPLEMENTED; > } > + > + More random whitespace changes. > @@ -573,6 +576,7 @@ UINT WINAPI MsiAdvertiseScriptW(LPCWSTR, DWORD, PHKEY, BOOL); > UINT WINAPI MsiCloseHandle(MSIHANDLE); > UINT WINAPI MsiCloseAllHandles(void); > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL, HWND*); > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER, DWORD, LPVOID, PINSTALLUI_RECORD_HANDLER); Inconsistent whitespace. The rest of the file does not have spaces after parentheses. -- James Hawkins

Feb. 10, 2008

Re: WineD3D: split framebuffer -> texture path from LoadLocation

by Roderick Colenbrander

> > Hi, > > > > This patch puts the framebuffer -> texture from LoadLocation in a > separate > > function in a similar way to read_from_framebuffer. It borrows some code > > from LoadLocation and read_from_framebuffer. > > > > Regards, > > Roderick Colenbrander > You're mixing tabs and spaces in this patch > I already feared so. For some reason Kate from KDE 4.0.0/4.0.1 doesn't show tabulators for me which makes this a hell. I'll see what I can do about it. Roderick -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

Feb. 10, 2008

re: Is there a Git Repositories for Unaccept Patches or (work in Progress)?

by Dan Kegel

Joeseph wrote: > Is there a Git Repositories for Unaccept Patches or (work in Progress)? Not really, but people often attach patches to bugzilla entries if they're not quite good enough to submit. And if anybody wants to start such a git repository, more power to them. >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, > but it still hasn't been accepted. The article you read is out of date; ntoskrnl.exe is now part of wine. > Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. As I said above, developers are free to attach patches to bug reports. What you're really trying to get at is: sometimes developers get discouraged at how hard it is to get patches into Wine. But no mechanical aid will really help there. The only cure is persistance on the part of the developer, and assistance (chiefly good feedback) from other Wine developers. After a developer gets a few patches committed, the wine process starts to feel a lot smoother. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Feb. 10, 2008

Re: gecko download not robust?

by Jacek Caban

Dan Kegel wrote: > Hmm. gecko download hung for me once. I saw > fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 > in the log, which makes me wonder if our download code > doesn't handle transient network errors well. > It looks like urlmon bug. Our Gecko downloader is also not really finished yet as its developing process stopped when it started to work. BTW, as a side effect, my current work on urlmon will allow us to improve the Gecko downloader a bit. > Time to get rid of the download, and just bundle gecko outright, I say... > I'd agree, but we need Gecko packages. AFAIK only Gentoo supports it ATM. Thanks, Jacek

Feb. 10, 2008

Re: pdh[3:3]: remove unnecessary tests done in PdhLookupPerfNameByIndexW

by Jeff Latimer

Dmitry Timoshkov wrote: > "Jeff Latimer" <lats(a)yless4u.com.au> wrote: > >> --- a/dlls/pdh/pdh_main.c >> +++ b/dlls/pdh/pdh_main.c >> @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( >> LPCSTR machine, DWORD index, LPSTR >> >> TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size); >> >> - if (machine) >> - { >> - FIXME("remote machine not supported\n"); >> - return PDH_CSTATUS_NO_MACHINE; >> - } >> - >> if (!buffer || !size) return PDH_INVALID_ARGUMENT; >> - if (!index) return ERROR_SUCCESS; > > Changelog mentions PdhLookupPerfNameByIndexW by the change is in > PdhLookupPerfNameByIndexA. > Why are you removing the checks in one place by leave the same in > other one? Why the tests > are unnecessary? > The parameters, bufferW and sizeW passed by PdhLookupPerfNameByIndexA to PdhLookupPerfNameByIndexW are local to PdhLookupPerfNameByIndexA. The test is needed still in PdhLookupPerfNameByIndexA because the size and buffer are not passed but still need to be checked. Jeff

Feb. 10, 2008