February 2008 - Wine-Devel - list.winehq.org

New winetricks: msxml6, riched30

by Dan Kegel

Johan Dahlin sent in a patch to add msxml6, and said "It's enough to make msi2xml.exe to at least start-up (before failing in msi later)." Tom Wickline some time ago sent in a suggestion for adding riched30. I didn't know any apps it helped, but apparantly Novell thinks it helps Groupwise a bit. So it's in now. Caution, it doesn't update riched32, no idea what happens if apps try to use it after this... As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/

Feb. 6, 2008

Re: Building tests with Visual Studio 2005 Express

by Dan Kegel

On Feb 5, 2008 11:28 PM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > Do you know where the Express download is for this, as I can only find > VS 2008 Express? Nope. I just happen to have an old copy.

Feb. 6, 2008

Re: regression in worms2

by José Salavert Torres

Happens the same in "Warcraft 3 : The Frozen Throne", you have to start the application directly from "war3.exe", "Frozen\ Throne.exe" ceased to work. El mar, 05-02-2008 a las 22:14 +0100, Olaf Leidinger escribió: > Hello! > > I noticed that the game "worms 2" broke between wine-0.9.53 and wine-0.9.54. A git-bisect revealed the guilty patches. > > The game includes a frontend.exe which starts game.exe and controls the settings of the game (the map and teams etc.). Running game.exe directly works but you can't alter the settings. When running game.exe via frontend the game doesn't show up but hangs after changing resolution. Before the following commit the game starts and is playable: > > 2921f5c156b368b4ce6e615eb61dad5c5f423bf8 is first bad commit > commit 2921f5c156b368b4ce6e615eb61dad5c5f423bf8 > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Jan 22 20:06:35 2008 +0100 > > server: Invalidate the correct region when custom valid rects are specified. > > :040000 040000 1385d5899b5b6affd5da84328e1bc15985406976 5c8756013a67c0402f3bb5fb9f3ee7b4a50e124a M server > > And this one makes worms2 hang after exiting the game: > > c19af910ebafa9b1928b0f67bee68f6b0b237e8e is first bad commit > commit c19af910ebafa9b1928b0f67bee68f6b0b237e8e > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Jan 17 19:53:59 2008 +0100 > > winex11.drv: Don't create a win_data structure for the desktop window, except in the process that owns it. > > Handle desktop size changes by sending a message to the desktop owner. > > :040000 040000 b7c030353fe92121bb999481724a3689429b2e8a 80fd2c5f4ace2707abb01648bd61663a6c9d7626 M dlls > > Thanks for your attention! > > Ciao, > Olaf -- José Salavert Torres <josator(a)fiv.upv.es> Estudiante UPV

Feb. 6, 2008

Re: Building tests with Visual Studio 2005 Express

by Reece Dunn

On 06/02/2008, Dan Kegel <dank(a)kegel.com> wrote: > After giving up for the moment on building with Visual C 6, > I tried Visual Studio 2005. Do you know where the Express download is for this, as I can only find VS 2008 Express? These links (as well as the Platform SDK stuff) would be useful adding to the building test documentation. > First hitch: > Boy, does it spew out lots of warnings about deprecated functions! This is the same for 2008. > Seventy-seventh hitch: > gdiplus/tests/brush.c includes Microsoft's gdiplus.h, but that's not > safe to include from C, so you get an error on the namespace. It looks as if those tests need to be set to compile with C++ for the SDK tests asnd add a "using namespace GdiPlus;" to them. Alternatively, disable them for the SDK headers and use the Wine ones. > Golly. I guess I won't be building the tests with any flavor of > microsoft C any time soon! I have managed to get most of the tests building. When I get the chance, I'll look at geetting msvcmaker to generate the VC project files, but these keep changing and are incompatible with each other! To do it properly, VC 2002, VC 2003, VC 2005 and VC 2008 project files need to be supported. I don't currently have access to the 2002 (7.0) tools, but the format should be close to 2003 after the version number differences. - Reece

Feb. 6, 2008

Re: RegOverridePredefKey stub - Take 2

by Dmitry Timoshkov

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > Stub implementation for RegOverridePredefKey. > The added prototype in the winreg.h is now in alphabetical order. Patches should be sent to wine-patches. -- Dmitry.

Feb. 6, 2008

Re: Building tests with Visual Studio 2005 Express

by Francois Gouget

On Tue, 5 Feb 2008, Dan Kegel wrote: > After giving up for the moment on building with Visual C 6, > I tried Visual Studio 2005. > > First hitch: > Boy, does it spew out lots of warnings about deprecated functions! > http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=87401&SiteID=1 > talks about this a bit; defining _CRT_SECURE_NO_DEPRECATE > and _CRT_NONSTDC_NO_DEPRECATE suppresses the warnings. commit aba98c62b4d44aae5d3e199acc6d7efceb7be417 Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Feb 2 16:26:36 2007 +0100 msvcmaker: Add _CRT macros to avoid being flooded with Visual Studio 2005 warnings. diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index 50644ac..2176a9e 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -642,6 +642,8 @@ sub _generate_dsp($$) { push @includes, $wine_include_dir; } } + # Add these _CRT macros to avoid warnings with Visual Studio 2005 + push @defines2, "_CRT_NONSTDC_NO_DEPRECATE", "_CRT_SECURE_NO_DEPRECATE"; if($wine) { foreach my $include (@includes) { But this patch is no good because we should really only set these when generating project files in the new format. [...] > Third hitch: > error C2065: 'PFORM_INFO_2A': undeclared identifier > See http://msdn2.microsoft.com/en-us/library/aa383745(VS.85).aspx > and http://blogs.msdn.com/oldnewthing/archive/2007/04/11/2079137.aspx > winspool.h only defines the new symbol if NTDDI_VERSION is NTDDI_LONGHORN > or higher. NTDDI_LONGHORN is 0x06000000. > Fix: > add /D _WIN32_WINNT=0x0600 to that list of changes to all the .dsp > files in hitch #1 above. Well, usually these are defined at the start of the relevant conformance test files. See dlls/shell32/tests/shlexec.c for instance. [...] > Fifth hitch: > generated.c refers to CS_STUB_INFO, which is not defined in > Microsoft's rpcndr.h. > ?? It used to be there but has apparently been removed in the latest SDKs. The problem is the generated.c files are not being regenerated very often. It probably also means we should update our rpcndr.h to match the latest PSDK. > Sixth hitch: > it can't find server.h > Seventh hitch: > can't find tmarshal.h > Fix: > Not sure, but maybe these files need to be generated by midl, and msvcmaker > doesn't know about that yet? See > http://www.mail-archive.com/wine-devel(a)winehq.org/msg37442.html Yes. > Eighth hitch: > riched20/tests/editor.c fails to compile because in GETTEXTEX, the > field is named lpUsedDefChar, not lpUsedDefaultChar > Fix: > fix our richedit.h? Sent a patch. This is why it's useful to compile the conformance tests with the PSDK headers. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

Feb. 6, 2008

Re: Building tests with MSVC 6 broken?

by Francois Gouget

On Tue, 5 Feb 2008, Dan Kegel wrote: > On Feb 5, 2008 5:01 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > The solution is to use Visual Studio 2005 which is a free download. > > There's still some hitches there: > > * it does not use .dsp files anymore but can convert them to the new > > XML build files. > > * in the process it loses some dll imports so you'll have to add them > > back manually, for each test. So it's feasible to compile individual > > tests but compiling all of them is a real pain. > > * you'd better add _CRT_NONSTDC_NO_DEPRECATE and _CRT_SECURE_NO_DEPRECATE > > otherwise you'll get a ton of warnings. > > I gathered that, but check out my next post, there are other > roadblocks. Maybe if I use the right Windows SDK (as pointed out by John Klehm) > some of these will go away. I remember that when I was still using VC6 I regularly had to update the PSDK in order to make the conformance tests happy (but note that I had a bias towards using the PSDK headers). But at some point I became stuck because I couldn't get the new PSDKs to work with VC6. That's when I got forced to switch to VC2005. So I'm not sure there exists a PSDK that's both recent enough for the conformance tests and compatible with VC6. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

Feb. 6, 2008

Re: Building tests with MSVC 6 broken?

by Dan Kegel

On Feb 5, 2008 5:01 PM, Francois Gouget <fgouget(a)free.fr> wrote: > The solution is to use Visual Studio 2005 which is a free download. > There's still some hitches there: > * it does not use .dsp files anymore but can convert them to the new > XML build files. > * in the process it loses some dll imports so you'll have to add them > back manually, for each test. So it's feasible to compile individual > tests but compiling all of them is a real pain. > * you'd better add _CRT_NONSTDC_NO_DEPRECATE and _CRT_SECURE_NO_DEPRECATE > otherwise you'll get a ton of warnings. I gathered that, but check out my next post, there are other roadblocks. Maybe if I use the right Windows SDK (as pointed out by John Klehm) some of these will go away. > What this means is that msvcmaker needs to be updated to generate the > new XML build files directly, all with the right settings. Yep.

Feb. 6, 2008

Re: Building tests with MSVC 6 broken?

by Dan Kegel

On Feb 5, 2008 5:24 PM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > > crypt32/tests/cert.c: error C2081: 'HCRYPTPROV_OR_NCRYPT_KEY_HANDLE': > > name in formal parameter list illegal > > Turns out that identifier was introduced in Vista, and added to Wine here: > > http://www.winehq.org/pipermail/wine-patches/2007-August/042250.html > > Fix: > > Uninstall the platform SDK and install the Windows SDK! > > http://www.microsoft.com/downloads/details.aspx?familyid=c2b1e300-f358-4523… > > I don't know if this will help with compiling the tests. but I have > fought with that many headed SDK nonsense too. Yeah, I saw your post about make crosstest dependencies, too, thanks. > Sorry Dan you still don't have the latest SDK =P (assuming you used > the one with the link you gave). > > You have linked to the one published 2006-11-07: > "Microsoft(R) Windows(R) Software Development Kit for Windows Vista™ > and .NET Framework 3.0 Runtime Components" > > Trickily enough the latest SDK is actually published on 2007-03-22: > "Microsoft(R) Windows(R) Software Development Kit Update for Windows Vista™" > http://www.microsoft.com/downloads/details.aspx?FamilyID=4377F86D-C913-4B5C… Thanks for the tip! - Dan

Feb. 6, 2008

Building tests with Visual Studio 2005 Express

by Dan Kegel

After giving up for the moment on building with Visual C 6, I tried Visual Studio 2005. First hitch: Boy, does it spew out lots of warnings about deprecated functions! http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=87401&SiteID=1 talks about this a bit; defining _CRT_SECURE_NO_DEPRECATE and _CRT_NONSTDC_NO_DEPRECATE suppresses the warnings. Fix: You can't set them via corewin_express.vsprops because our project is converted from an older visual studio version, so you have to add those two defines to all the .dsp files, e.g. perl -p -i -e 's,/D "WIN32",/D "WIN32" /D "_CRT_NONSTDC_NO_DEPRECATE" /D "_CRT_SECURE_NO_DEPRECATE",' `find . -iname '*.dsp'` Second hitch: For some reason, the imported projects lose their list of .lib files to link against. Fix: As suggested at http://msdn2.microsoft.com/en-us/express/aa700755.aspx add user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib to the "Additional Dependencies" setting in the file corewin_express.vsprops. Third hitch: error C2065: 'PFORM_INFO_2A': undeclared identifier See http://msdn2.microsoft.com/en-us/library/aa383745(VS.85).aspx and http://blogs.msdn.com/oldnewthing/archive/2007/04/11/2079137.aspx winspool.h only defines the new symbol if NTDDI_VERSION is NTDDI_LONGHORN or higher. NTDDI_LONGHORN is 0x06000000. Fix: add /D _WIN32_WINNT=0x0600 to that list of changes to all the .dsp files in hitch #1 above. Fourth hitch: urlmon_test.exe refers to CLSID_IdentityUnmarshal, but that symbol is not defined. ?? Fifth hitch: generated.c refers to CS_STUB_INFO, which is not defined in Microsoft's rpcndr.h. ?? Sixth hitch: it can't find server.h Seventh hitch: can't find tmarshal.h Fix: Not sure, but maybe these files need to be generated by midl, and msvcmaker doesn't know about that yet? See http://www.mail-archive.com/wine-devel(a)winehq.org/msg37442.html Eighth hitch: riched20/tests/editor.c fails to compile because in GETTEXTEX, the field is named lpUsedDefChar, not lpUsedDefaultChar Fix: fix our richedit.h? ... Seventy-seventh hitch: gdiplus/tests/brush.c includes Microsoft's gdiplus.h, but that's not safe to include from C, so you get an error on the namespace. Golly. I guess I won't be building the tests with any flavor of microsoft C any time soon! - Dan

Feb. 6, 2008