February 2008 - Wine-Devel - list.winehq.org

Re: New winetricks 20080226: adds dotnet11 verb

by bill lam

Dan Kegel wrote: > What app is this, and what is it about Wine's gdiplus that > makes you need to override it? Does the app crash, > or does it just look bad? If it crashes, what's the crash log? > The app is a package called 'platimg' of J language. I had reported this and I believed that it is the negative stride that caused the problem. NB. load and decode a jpeg file into 2D integer matrix with each integer NB. for one pixel element. readimg1 'picture.jpg' where definition of readimg1 is as follows readimg1=: 3 : 0 GdiplusStartup (TOK=.,_1);GdiplusStartupInput;0 GdipCreateBitmapFromFile y;BMP=.,_1 z=. bmpARGB {.BMP GdiplusShutdown {.TOK z ) bmpARGB=: 3 : 0 DATA=. i.4%~#BitmapData GdipBitmapLockBits y;0;ImageLockModeRead;PixelFormat32bppARGB;DATA 'w h s f p r'=. DATA z=. (h,w)$memr p,0,(w*h),JINT GdipBitmapUnLockBits y;DATA GdipDisposeImage y z ) Here GdipBitmapLockBits has 2 issues, 1. GdipBitmapLockBits accept a null for rect (the second argument) to stands for the entire region. I can workaround this by calling GdipGetImageWidth and GdipGetImageHeight to construct the rect. However 2. the data returned GdipBitmapLockBits does not point a valid bitmap data, so the when trying memory read in the following z=. (h,w)$memr p,0,(w*h),JINT J gives raise a domain error. (but no crash, so that no crash log) Scripts of J can be difficult to understand, but since this example calls gdiplus api so that you can follow it without much difficulty and write an equivalent c program to test it. current version of J can be downloaded here. http://www.jsoftware.com/beta.htm after installation, run package manager that comes with J to install the platimg addon. regards,

Feb. 27, 2008

Re: New winetricks 20080226: adds dotnet11 verb

by Dan Kegel

On Wed, Feb 27, 2008 at 7:00 AM, bill lam <cbill.lam(a)gmail.com> wrote: > In current wine version *.55, the built-in version of comctl32 does work for my > app so that I do not need the native comctl32 anymore. Now only odbc and gdiplus > need to be overrided. What app is this, and what is it about Wine's gdiplus that makes you need to override it? Does the app crash, or does it just look bad? If it crashes, what's the crash log?

Feb. 27, 2008

Re: Bug for icons in toolbar (and how to deal with this in bugzilla)

by Juan Lang

Hi Paul, > This is about 'autoruns' from SysInternals (Microsoft) > > The icons on the first row of buttons look fine. All other rows however show the > icons below the position they should actually be. > > I've looked at our bugzilla and found two bugs that look the same: > > http://bugs.winehq.org/show_bug.cgi?id=6948 > http://bugs.winehq.org/show_bug.cgi?id=8813 > > Both are for different applications. > > Should I open a new one for 'autoruns' or use one of the existing ones? Open a new bug. If all three bugs can be shown to be caused by the same defect, they can be closed together. Since they're in different apps, the bugs should be different. --Juan

Feb. 27, 2008

Bug for icons in toolbar (and how to deal with this in bugzilla)

by Paul Vriens

Hi, This is about 'autoruns' from SysInternals (Microsoft) The icons on the first row of buttons look fine. All other rows however show the icons below the position they should actually be. I've looked at our bugzilla and found two bugs that look the same: http://bugs.winehq.org/show_bug.cgi?id=6948 http://bugs.winehq.org/show_bug.cgi?id=8813 Both are for different applications. Should I open a new one for 'autoruns' or use one of the existing ones? -- Cheers, Paul.

Feb. 27, 2008

Re: New winetricks 20080226: adds dotnet11 verb

by bill lam

Dan Kegel wrote: > Which apps? > What version of comctl32 and gdiplus do they require? I check version of gdiplus from pp viewer 2003 (winetricks) and that from win-xp, they are the same version. I must had use my old version from win-me that caused problem. Sorry for the noise. In current wine version *.55, the built-in version of comctl32 does work for my app so that I do not need the native comctl32 anymore. Now only odbc and gdiplus need to be overrided. Thank you to all wine developers. regards,

Feb. 27, 2008

Re: Wineserver crash in inotify code

by Alexandre Julliard

"Dan Kegel" <dank(a)kegel.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=11746 > may explain a few mysterious wineserver crashes > I saw a few weeks ago. > > Anyone feel like diving in to this one? It's probably > a rat's nest of twisty linked lists, and a node isn't > getting removed properly from all the lists > it's in when it's freed, or something. Please give this a try: diff --git a/server/change.c b/server/change.c index 590a1cb..2266621 100644 --- a/server/change.c +++ b/server/change.c @@ -438,6 +438,7 @@ static void inode_set_name( struct inode *inode, const char *name ) static void free_inode( struct inode *inode ) { int subtree = 0, watches = 0; + struct inode *tmp, *next; struct dir *dir; LIST_FOR_EACH_ENTRY( dir, &inode->dirs, struct dir, in_entry ) @@ -448,7 +449,6 @@ static void free_inode( struct inode *inode ) if (!subtree && !inode->parent) { - struct inode *tmp, *next; LIST_FOR_EACH_ENTRY_SAFE( tmp, next, &inode->children, struct inode, ch_entry ) { @@ -464,6 +464,13 @@ static void free_inode( struct inode *inode ) if (inode->parent) list_remove( &inode->ch_entry ); + /* disconnect remaining children from the parent */ + LIST_FOR_EACH_ENTRY_SAFE( tmp, next, &inode->children, struct inode, ch_entry ) + { + list_remove( &tmp->ch_entry ); + tmp->parent = NULL; + } + if (inode->wd != -1) { inotify_remove_watch( get_unix_fd( inotify_fd ), inode->wd ); -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2008

Re: msxml3:Implement wcscpy_s (try 4)

by Huw Davies

On Wed, Feb 27, 2008 at 09:11:17PM +1100, Alistair Leslie-Hughes wrote: > Hi, > Corrected the spec file. > > Changelog: > msxml3: Implement wcscpy_s > > Best Regards > Alistair Leslie-Hughes > > From 5438165a1a5b3a2683948b93e34e9017f4958e61 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 27 Feb 2008 19:58:04 +1100 > Subject: [PATCH] Implement wcscpy_s > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+), 0 deletions(-) Note that the subject line should be 'msvcrt:...'. I guess Alexandre will fix this. Huw. -- Huw Davies huw(a)codeweavers.com

Feb. 27, 2008

Re: More ops for(#winehq (was Re: Wine hostmask for Freenode IRC)

by Travis Watkins

On Mon, Feb 25, 2008 at 10:09 AM, Jeremy White <jwhite(a)winehq.org> wrote: > Hey Ben, > > > > I submitted one ages ago and it was approved. Sorry that I've not been > > in IRC for ages, just lots to deal with outside of computer-land these > > days. For the record it took about a year and a half for the group > > registration to go through. AFAIK I now have overriding rights and > > control of the channels (although it's not shown in access). > > > > If anyone needs anything added or changed (including hostmasks) just > > email me. > > > > Ah, great! Could I ask you to arrange to transfer that to the > Software Freedom Conservancy? (That's our 'official' holder for things > like this). > > And I think we need to get a raft of folks up to level 30 on #winehackers, > starting with kai, and I'd appreciate it if you'd make > me and julliard level 40 on both. > > Cheers, > > Jeremy > > > You probably have to file a new one to change the owner. If so, well, I've been waiting for one for Compiz for well over a year... -- Travis Watkins http://www.realistanew.com

Feb. 27, 2008

Re: X developer's conference, April 16-18

by Travis Watkins

On Tue, Feb 26, 2008 at 7:41 AM, Tijl Coosemans <tijl(a)ulyssis.org> wrote: > On Monday 25 February 2008 17:49:42 Stefan Dösinger wrote: > > * Other things? > > Display settings at the window manager level: > > http://bugs.winehq.org/show_bug.cgi?id=3230 > http://bugs.winehq.org/show_bug.cgi?id=10115 > http://bugs.winehq.org/show_bug.cgi?id=10841 > > > The right thing to do here is to create a specification for how this would work and bring it to wm-spec-list. Then you can at least count on metacity to add support for it, if wm-spec-list approves it. Then again, they might just tell you WINE is broken. -- Travis Watkins http://www.realistanew.com

Feb. 27, 2008

Re: msxml3: Implemented wcscpy_s (try 3)

by Alistair Leslie-Hughes

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote in message news:02e801c87920$02228430$a600fea9(a)DMITRY... > "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > >> Corrected comparisons, and error message in test. > > >> diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec >> index d6cffcb..ebd718c 100644 >> --- a/dlls/msvcrt/msvcrt.spec >> +++ b/dlls/msvcrt/msvcrt.spec >> @@ -761,6 +761,7 @@ >> @ cdecl wcscmp(wstr wstr) ntdll.wcscmp >> @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll >> @ cdecl wcscpy(ptr wstr) ntdll.wcscpy >> +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s > > What's happened to the spec entry fix? I use an old patch after I reset my tree, Ill correct it again. Thanks Alistair Leslie-Hughes

Feb. 27, 2008