February 2008 - Wine-Devel - list.winehq.org

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [2/2]

by James Hawkins

On Fri, Feb 29, 2008 at 1:17 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > > On Thu, Feb 28, 2008 at 11:44 PM, James Hawkins <truiken(a)gmail.com> wrote: > > > > On Fri, Feb 29, 2008 at 12:29 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > > > Patch Originally From: > > > Louis Lenders > > > Description: > > > This patch adds conformance tests for WritePrivateProfileString sharing > > > problems. The patch was created by Louis Lenders and extensively tested, > > > but never submitted (see Bug #5024). Please note that a couple of the tests > > > now fail because cached profile information is returned, resolving that > > > problem is outside the scope of these patches. > > > Changelog: > > > kernel32: Test for WritePrivateProfileString Sharing Permissions > > > > > > > If a test fails, it has to be wrapped in todo_wine, else make test will fail. > > > > -- > > James Hawkins > > > > I would argue that make test should fail for regressions, though I > don't know when exactly this particular problem surfaced. Re-ording > the tests can actually mask the problem as well as inserting > todo_wine, which would be preferred? > Um make test does fail for regressions. make test fails if an ok call fails and is not covered by todo_wine, and it also fails when a test in a todo_wine block succeeds. That's how we keep track of the tests. If reordering the tests masks the problem, what's the point of the tests? -- James Hawkins

Feb. 29, 2008

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [2/2]

by Erich Hoover

On Thu, Feb 28, 2008 at 11:44 PM, James Hawkins <truiken(a)gmail.com> wrote: > > On Fri, Feb 29, 2008 at 12:29 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > > Patch Originally From: > > Louis Lenders > > Description: > > This patch adds conformance tests for WritePrivateProfileString sharing > > problems. The patch was created by Louis Lenders and extensively tested, > > but never submitted (see Bug #5024). Please note that a couple of the tests > > now fail because cached profile information is returned, resolving that > > problem is outside the scope of these patches. > > Changelog: > > kernel32: Test for WritePrivateProfileString Sharing Permissions > > > > If a test fails, it has to be wrapped in todo_wine, else make test will fail. > > -- > James Hawkins > I would argue that make test should fail for regressions, though I don't know when exactly this particular problem surfaced. Re-ording the tests can actually mask the problem as well as inserting todo_wine, which would be preferred? Erich Hoover ehoover(a)mines.edu

Feb. 29, 2008

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [2/2]

by James Hawkins

On Fri, Feb 29, 2008 at 12:29 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > Patch Originally From: > Louis Lenders > Description: > This patch adds conformance tests for WritePrivateProfileString sharing > problems. The patch was created by Louis Lenders and extensively tested, > but never submitted (see Bug #5024). Please note that a couple of the tests > now fail because cached profile information is returned, resolving that > problem is outside the scope of these patches. > Changelog: > kernel32: Test for WritePrivateProfileString Sharing Permissions > If a test fails, it has to be wrapped in todo_wine, else make test will fail. -- James Hawkins

Feb. 29, 2008

Re: New winetricks 20080226: adds dotnet11 verb

by James Hawkins

On Thu, Feb 28, 2008 at 10:07 PM, bill lam <cbill.lam(a)gmail.com> wrote: > I patched platimg to work with negative stride and now it works with wine > built-in gdiplus. > > FYI, native gdiplus gives a top-down bitmap but wine's gdiplus gives a > bottom-up. It is not a bug in wine's but might causes compatibility problem. > How is it not a bug? -- James Hawkins

Feb. 29, 2008

Re: New winetricks 20080226: adds dotnet11 verb

by bill lam

I patched platimg to work with negative stride and now it works with wine built-in gdiplus. FYI, native gdiplus gives a top-down bitmap but wine's gdiplus gives a bottom-up. It is not a bug in wine's but might causes compatibility problem.

Feb. 29, 2008

Re: GSoC project ideas

by Steven Edwards

On Thu, Feb 28, 2008 at 7:29 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > That would be a great SoC project IMO. I'd be even more interested in > correct architecture than in implementing whole GUI. By architecture I > mean mainly plug-in API (project like "Get Google toolbar working with > Wine IE"?). Whats your estimate on how long it should take to implement enough of the plug-in API to do this? My thinking was to break the Internet Explorer project down in to deliverables with the structure and at least a good chunk of the API being a requirement along with the GUI. Most of the resources/dialogs would be of use one the full plug-in API was implemented I would think. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 29, 2008

Re: GSoC project ideas

by Steven Edwards

On Thu, Feb 28, 2008 at 7:28 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > AFAICT Mozilla support for mingw32 is not really good (I've tried it and > decided to go back to MSVC) and it's even worse if you try to compile it > from Linux. I would very appreciate if someone would fix that. Even > better if it was a Winelib port. From my experience their makefiles are, > hmmm, not really nice to work with. Anyway, that would be my favorite > SOC project. If we want to make this a SoC project, I can help mentor it a bit unless someone else wants to step up. I was thinking about giving this another shot myself using Han's mingw rpms he supports for CrossTesting. I've got quite a bit of experience on the mingw side from my ReactOS days and have followed the Mozilla/Firefox mingw progress since the start of time so I think I could help a student get started. I don't have much spare time to actually work on it so having a student do with with some monetary motivation would be a good thing. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 29, 2008

Re: GSoC project ideas

by Jacek Caban

Kai Blin wrote: > On Monday 25 February 2008 09:24:10 Kai Blin wrote: > > >> Feel free to add your own project ideas, maybe elaborate a bit on the >> deliverables of the idea. >> > > How about a project to implement a real interface for Wine's built-in > iexplore.exe? Ideally, this would not only give a menu and toolbar but also > be compatible with third-party addons. > That would be a great SoC project IMO. I'd be even more interested in correct architecture than in implementing whole GUI. By architecture I mean mainly plug-in API (project like "Get Google toolbar working with Wine IE"?). Thanks, Jacek

Feb. 29, 2008

Re: GSoC project ideas

by Jacek Caban

Kai Blin wrote: > On Monday 25 February 2008 09:24:10 Kai Blin wrote: > >> * Improving our HTML/Win32 Help viewers. >> > > What needs to be done here? Did last year's CHM compiler project produce any > results? Jacek, you mentored this, comments? > What I've mentored was something else - it was a chm compiler that would allow us to make use of HTML help in Wine (eg. winecfg help) and winelib apps. HTML help is almost at the same state as it was year ago. I've improved it then to be able to use some simple chm files, but much more is needed. Most functionality is not implemented (just run hh.exe and look...) and API is almost totally not implemented. Also current implementation can't handle many chm files. I think project that would improve things would be good. >> * Complete the Wine Web browser (aka. Internet Explorer) ie. frame >> controls, toolbar, status bar >> > > Steven Edwards suggested some work on that recently. Is there enough work left > to make this a full SoC project? > Yes, definitely there is and it would be a great project IMO. It would be even netter if UI was designed to be compatible with IE. It means implementing plug-in support. >> * Full URLMoniker implementation. (IE working with builtin urlmon.dll) >> > > That one's for Jacek to comment. :) > urlmon.dll is much improved since then. Although there is still a lot to do, even more than a complete SoC project, someone interested in it would have to find other goal than working IE IMO. >> * Get Mozilla compiling as a Winelib application >> (http://www.winehq.org/site/winelib#mozilla) >> > > Looks like Mozilla builds in mingw32 now, so maybe that webpage should be > updated. I'm not sure how much effort this project actually would be. > Comments, anyone? > AFAICT Mozilla support for mingw32 is not really good (I've tried it and decided to go back to MSVC) and it's even worse if you try to compile it from Linux. I would very appreciate if someone would fix that. Even better if it was a Winelib port. From my experience their makefiles are, hmmm, not really nice to work with. Anyway, that would be my favorite SOC project. Thanks, Jacek

Feb. 29, 2008

Re: GSoC project ideas

by Kai Blin

On Monday 25 February 2008 09:24:10 Kai Blin wrote: > Feel free to add your own project ideas, maybe elaborate a bit on the > deliverables of the idea. How about a project to implement a real interface for Wine's built-in iexplore.exe? Ideally, this would not only give a menu and toolbar but also be compatible with third-party addons. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

Feb. 28, 2008