February 2008 - Wine-Devel - list.winehq.org

Re: winehq.org down?

by Reece Dunn

On 03/02/2008, James Hawkins <truiken(a)gmail.com> wrote: > Hey guys, > > I'm having problems connecting to the winehq.org server. Is this a known issue? It's working my side. Is there a problem with your connection? Do other sites work? - Reece

Feb. 3, 2008

Re: winehq.org down?

by Jeremy White

James Hawkins wrote: > Hey guys, > > I'm having problems connecting to the winehq.org server. Is this a known issue? > The server has been getting locked up lately. Jeremy Newman thinks it's related to MySQL, as he's seen it running amok in conjunction with the crashes; he fears that recent changes to the appdb code may have triggered this, but that's mostly speculation. At this point, there is little hard data; there haven't been console or other obvious log messages that would point at a source of the problem. We do now have a mysql log file, perhaps that will shed some light. It's definitely increasing in frequency, though, as it's happened both days this weekend. Cheers, Jeremy

Feb. 3, 2008

Re: winehq.org down?

by Austin English

On Feb 3, 2008 1:47 PM, James Hawkins <truiken(a)gmail.com> wrote: > Hey guys, > > I'm having problems connecting to the winehq.org server. Is this a known issue? > > -- > James Hawkins > Appdb/bugzilla/wiki/winehq.org are all fine here. -Austin

Feb. 3, 2008

winehq.org down?

by James Hawkins

Hey guys, I'm having problems connecting to the winehq.org server. Is this a known issue? -- James Hawkins

Feb. 3, 2008

Re: cabinet: Include wine/port.h for strcasecmp().

by Dmitry Timoshkov

"Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: >>The rules are as follows: > >> * For case insensitive comparisons of 'windows strings', a Windows >> function must be used (stricmp() or similar). > > and > >>In this case, KERNEL32 lstrcmpiA() would be more appropriate. In >>general, using stricmp() in Win32 code should be discouraged since it >>may cause unnecessary dependency on MSVCRT. > > Wine lstrcmpi is broken (bug #10767). There are cases GLIBC strcasecmp and > Windows lstrcmpi handle correctly but wine not. Should we fix this first? The bug 10767 is a corner case, and nothing prevents using kernel32 APIs to perform string comparisons in Wine (which we do). I don't think that you want to use glibc string comparison functions to compare for instance cyrillic strings in CP1251 (Wine) and UTF-8 (Linux) encodings. Still, the bug 10767 has an explanation for an incompatibility, so the problem should be either solved on unicode.org side, or by patching libs/wine/cpmap.pl. -- Dmitry.

Feb. 3, 2008

cabinet: Include wine/port.h for strcasecmp().

by Kirill K. Smirnov

>The rules are as follows: > * For case insensitive comparisons of 'windows strings', a Windows > function must be used (stricmp() or similar). and >In this case, KERNEL32 lstrcmpiA() would be more appropriate. In >general, using stricmp() in Win32 code should be discouraged since it >may cause unnecessary dependency on MSVCRT. Wine lstrcmpi is broken (bug #10767). There are cases GLIBC strcasecmp and Windows lstrcmpi handle correctly but wine not. Should we fix this first? -- Kirill

Feb. 3, 2008

Re: Resend patch from Norbert

by Vitaliy Margolen

Rico Schüller wrote: > Hi, > > I only resend a patch because it isn't in the todays git and the author > didn't answer for a while. > > Cheers > Rico > > > ------------------------------------------------------------------------ > > > - memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(pRect)); > + memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(RECT)); To avoid such problems in the future one should use something like: *pRect = This->updateStateBlock->scissorRect; Doing a quick search through wined3d I've found number of places with memcpy instead of simple assignment of one struct to another struct. This is a good janitorial task to get rid of memcpy where simple assignment will work. Vitaliy.

Feb. 2, 2008

Re: winex11.drv: Use bitwise NOT not logical NOT

by Andrew Talbot

Vitaliy Margolen wrote: > Marcus Meissner wrote: >> On Sat, Feb 02, 2008 at 05:43:27PM +0000, Andrew Talbot wrote: > Correct. What all that meant, is if app asks for something, but the value > is > 0, switch to default mode. > Yes. I wrongly mistook it to be a case of setting one group of flags in accordance with another. I should have looked more carefully. > Also Andrew, have you actually ran tests to check of they still pass? Of > course you need to run them in interactive mode: > export WINETEST_INTERACTIVE=1 > No, I'm guilty again. Thanks for the advice. -- Andy.

Feb. 2, 2008

Re: winex11.drv: Use bitwise NOT not logical NOT

by Andrew Talbot

Marcus Meissner wrote: > I do not think this is right, def_mode is a boolean and we actually check > for not-0-being of various struct members. > > Ciao, Marcus Hi Marcus, You are correct. I should have studied the code more carefully. Thanks, -- Andy.

Feb. 2, 2008

Re: winex11.drv: Use bitwise NOT not logical NOT

by Vitaliy Margolen

Marcus Meissner wrote: > On Sat, Feb 02, 2008 at 05:43:27PM +0000, Andrew Talbot wrote: >> Changelog: >> winex11.drv: Use bitwise NOT not logical NOT. >> >> diff --git a/dlls/winex11.drv/settings.c b/dlls/winex11.drv/settings.c >> index d68b674..2cd36c7 100644 >> --- a/dlls/winex11.drv/settings.c >> +++ b/dlls/winex11.drv/settings.c >> @@ -369,10 +369,10 @@ LONG X11DRV_ChangeDisplaySettingsEx( LPCWSTR devname, LPDEVMODEW devmode, >> devmode->dmBitsPerPel,devmode->dmDisplayFrequency, handler_name); >> >> dwBpp = devmode->dmBitsPerPel; >> - if (devmode->dmFields & DM_BITSPERPEL) def_mode &= !dwBpp; >> - if (devmode->dmFields & DM_PELSWIDTH) def_mode &= !devmode->dmPelsWidth; >> - if (devmode->dmFields & DM_PELSHEIGHT) def_mode &= !devmode->dmPelsHeight; >> - if (devmode->dmFields & DM_DISPLAYFREQUENCY) def_mode &= !devmode->dmDisplayFrequency; >> + if (devmode->dmFields & DM_BITSPERPEL) def_mode &= ~dwBpp; >> + if (devmode->dmFields & DM_PELSWIDTH) def_mode &= ~devmode->dmPelsWidth; >> + if (devmode->dmFields & DM_PELSHEIGHT) def_mode &= ~devmode->dmPelsHeight; >> + if (devmode->dmFields & DM_DISPLAYFREQUENCY) def_mode &= ~devmode->dmDisplayFrequency; > > I do not think this is right, def_mode is a boolean and we actually check for > not-0-being of various struct members. > Correct. What all that meant, is if app asks for something, but the value is 0, switch to default mode. Also Andrew, have you actually ran tests to check of they still pass? Of course you need to run them in interactive mode: export WINETEST_INTERACTIVE=1 Vitaliy.

Feb. 2, 2008