March 2008 - Wine-Devel - list.winehq.org

Re: winmm/tests: Don't use 0x55 to avoid any confusion when running with+heap.

by Dmitry Timoshkov

"Francois Gouget" <fgouget(a)free.fr> wrote: > mmioSeek(hmmio, 0, SEEK_SET); > - memset(&ck, 0x55, sizeof(ck)); > + memset(&ck, 0x66, sizeof(ck)); > ret = mmioDescend(hmmio, &ck, NULL, MMIO_FINDCHUNK); > ok(ret == MMIOERR_CHUNKNOTFOUND || > ret == MMIOERR_INVALIDFILE, "mmioDescend returned %u\n", ret); > @@ -162,7 +162,7 @@ static void test_mmioDescend(void) > ok(ck.dwDataOffset != 0x55555555, "wrong dwDataOffset: %04x\n", ck.dwDataOffset); The 'ok' above (and 2 tests before it) will fail with your changes. -- Dmitry.

March 2, 2008

Re: Any graphics card y'all like to see tests run on?

by Austin English

On Wed, Feb 27, 2008 at 9:36 PM, James McKenzie <jjmckenzie51(a)sprintpcs.com> wrote: > > Stefan Dösinger wrote: > > Am Mittwoch, 27. Februar 2008 05:49:57 schrieb Austin English: > > > >> Thanks Carl, and to the rest of the list, sorry for the noise/false > >> hope to d3d/ddraw guys. > >> > > Just to answer your previous questions if someone else wonders the same: Some > > ATI card would be useful. I have an X1600 and a radeon mobility 9000 myself, > > but other cards would be good to test as well. In the codeweavers office we > > have a few other cards too(older radeons and a bunch of macs) > > > > > Testing on Macs, especially the newer laptops would be nice :) > > I have a MacBookPro and a MacBook here (the latter is the other person > who lives here's.) > > James > > > > My roommate has a MacBook pro, so if testing anything specific is needed, drop me a line. -Austin

March 2, 2008

Re: iPod synced with iTunes v7.6!

by Juan Lang

> I got an ipod I borrowed to sync: http://www.astro.rug.nl/~lankhorst/ipod.png W00t! Well done, Maarten! --Juan

March 2, 2008

Re: msi: ACTION_RegisterProduct store all InstallProperties

by James Hawkins

On Sat, Mar 1, 2008 at 4:33 PM, Adam Strzelecki <ono(a)java.pl> wrote: > > Which is wrong, which you'll see when I submit my next patch which > > tests your theory. > > I don't mind you pointing me out my mistakes. So I kindly waiting for > your patch. However right now I presented my arguments quoting Wine > sources, but you just respond that I'm wrong without presenting yours. > > All I can say, I was testing this is MSXML 6.0 + Visual Studio 2005 > installer, and current Wine trunk causes VS2005 installer think that > MSXML 6.0 is regardless of anything, just because VerionMajor & > VersionMinor fails on MsiGetProductInfo. > Have some patience...I *just* wrote the tests, and I'm doing this on a Saturday. You'll see them soon enough. -- James Hawkins

March 1, 2008

Re: msi: ACTION_RegisterProduct store all InstallProperties

by Adam Strzelecki

> Which is wrong, which you'll see when I submit my next patch which > tests your theory. I don't mind you pointing me out my mistakes. So I kindly waiting for your patch. However right now I presented my arguments quoting Wine sources, but you just respond that I'm wrong without presenting yours. All I can say, I was testing this is MSXML 6.0 + Visual Studio 2005 installer, and current Wine trunk causes VS2005 installer think that MSXML 6.0 is regardless of anything, just because VerionMajor & VersionMinor fails on MsiGetProductInfo. -- Adam Strzelecki |: nanoant.com :|

March 1, 2008

Re: msi: ACTION_RegisterProduct store all InstallProperties

by James Hawkins

On Sat, Mar 1, 2008 at 4:02 PM, Adam Strzelecki <ono(a)java.pl> wrote: > Hello, > > > > I think you need to read through the implementation of > > MSI_GetProductInfo more closely and also read the MsiGetProductInfo > > tests in tests/msi.c and the test_publish:RegisterProduct tests in > > tests/install.c. > > I think I did, and looking at the tests I see they are testing > properties only at Uninstall key, and I think this is wrong, or at > least incomplete, as quoted below: > > > res = RegOpenKeyA(uninstall, prodcode, &prodkey); > > ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); > > > > CHECK_REG_DWORD(prodkey, "Version", 0x1010001); > > CHECK_REG_DWORD(prodkey, "VersionMajor", 1); > > CHECK_REG_DWORD(prodkey, "VersionMinor", 1); > > CHECK_REG_DWORD(prodkey, "WindowsInstaller", 1); > > > While MSI_GetProductInfo is reading VersionMajor, VersionMinor, ... > etc from InstallProperties key (from szInstallProperties_fmt or > szInstaller_LocalSystemProductCodes_fmt), but NOT from Uninstall key > as quotes below: > > > if (classes) > > MSIREG_OpenLocalSystemProductKey(szProduct, &userdata, FALSE); > > else > > MSIREG_OpenInstallPropertiesKey(szProduct, &userdata, FALSE); > > > > if (!lstrcmpW(szAttribute, INSTALLPROPERTY_HELPLINKW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_HELPTELEPHONEW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLDATEW) || > > !lstrcmpW(szAttribute, > > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLLOCATIONW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLSOURCEW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_LOCALPACKAGEW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_PUBLISHERW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLINFOABOUTW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLUPDATEINFOW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMINORW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMAJORW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONSTRINGW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_PRODUCTIDW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGCOMPANYW) || > > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGOWNERW)) > > { > > if (!prodkey) > > { > > r = ERROR_UNKNOWN_PRODUCT; > > goto done; > > } > > > > if (!userdata) > > return ERROR_UNKNOWN_PROPERTY; > > > > if (!lstrcmpW(szAttribute, > > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW)) > > szAttribute = display_name; > > else if (!lstrcmpW(szAttribute, > > INSTALLPROPERTY_VERSIONSTRINGW)) > > szAttribute = display_version; > > > > val = msi_reg_get_value(userdata, szAttribute, &type); > > if (!val) > > val = empty; > > } > > > So it does not find any of those properties in the registry, because > they're not written there by ACTION_RegisterProduct. > And fixing this is the intention of my patch. > Which is wrong, which you'll see when I submit my next patch which tests your theory. -- James Hawkins

March 1, 2008

Re: msi: ACTION_RegisterProduct store all InstallProperties

by Adam Strzelecki

Hello, > I think you need to read through the implementation of > MSI_GetProductInfo more closely and also read the MsiGetProductInfo > tests in tests/msi.c and the test_publish:RegisterProduct tests in > tests/install.c. I think I did, and looking at the tests I see they are testing properties only at Uninstall key, and I think this is wrong, or at least incomplete, as quoted below: > res = RegOpenKeyA(uninstall, prodcode, &prodkey); > ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); > > CHECK_REG_DWORD(prodkey, "Version", 0x1010001); > CHECK_REG_DWORD(prodkey, "VersionMajor", 1); > CHECK_REG_DWORD(prodkey, "VersionMinor", 1); > CHECK_REG_DWORD(prodkey, "WindowsInstaller", 1); While MSI_GetProductInfo is reading VersionMajor, VersionMinor, ... etc from InstallProperties key (from szInstallProperties_fmt or szInstaller_LocalSystemProductCodes_fmt), but NOT from Uninstall key as quotes below: > if (classes) > MSIREG_OpenLocalSystemProductKey(szProduct, &userdata, FALSE); > else > MSIREG_OpenInstallPropertiesKey(szProduct, &userdata, FALSE); > > if (!lstrcmpW(szAttribute, INSTALLPROPERTY_HELPLINKW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_HELPTELEPHONEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLDATEW) || > !lstrcmpW(szAttribute, > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLLOCATIONW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLSOURCEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_LOCALPACKAGEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_PUBLISHERW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLINFOABOUTW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLUPDATEINFOW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMINORW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMAJORW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONSTRINGW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_PRODUCTIDW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGCOMPANYW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGOWNERW)) > { > if (!prodkey) > { > r = ERROR_UNKNOWN_PRODUCT; > goto done; > } > > if (!userdata) > return ERROR_UNKNOWN_PROPERTY; > > if (!lstrcmpW(szAttribute, > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW)) > szAttribute = display_name; > else if (!lstrcmpW(szAttribute, > INSTALLPROPERTY_VERSIONSTRINGW)) > szAttribute = display_version; > > val = msi_reg_get_value(userdata, szAttribute, &type); > if (!val) > val = empty; > } So it does not find any of those properties in the registry, because they're not written there by ACTION_RegisterProduct. And fixing this is the intention of my patch. Regards, -- Adam Strzelecki |: nanoant.com :|

March 1, 2008

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

by Steven Edwards

On Sat, Mar 1, 2008 at 10:55 AM, Adam Strzelecki <ono(a)java.pl> wrote: > > No, we may not have a look! And we sure as hell can't > > post copyrighted Microsoft source code on this mailing list! > Argh... I meant you may have a look if you have Visual Studio > installed, I don't intend to post any copyrighted code there, but I > just post header copyright information from this file to prove that it > does exist:) > However you can find with Google + "strlen.asm - contains strlen() > routine" on M$ forums some ppl that wisely did post full source ;P Wine kind of work on the honor system here. If you've looked at the CRT sources even though they come with the PSDK and MSVC please don't start implementing those functions. Ditto for ATL. MSVC ships with the source code for it also but the developers that work on the ATL don't go digging in to those sources. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

March 1, 2008

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

by Adam Strzelecki

> No, we may not have a look! And we sure as hell can't > post copyrighted Microsoft source code on this mailing list! Argh... I meant you may have a look if you have Visual Studio installed, I don't intend to post any copyrighted code there, but I just post header copyright information from this file to prove that it does exist:) However you can find with Google + "strlen.asm - contains strlen() routine" on M$ forums some ppl that wisely did post full source ;P Regards, -- Adam Strzelecki |: nanoant.com :|

March 1, 2008

re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

by Dan Kegel

Adam Strzelecki wrote: > Visual Studio is shipping with complete sources of C CRT so you may have a look. > ;*** > ;strlen.asm - contains strlen() routine > ; > ; Copyright (c) Microsoft Corporation. All rights reserved. No, we may not have a look! And we sure as hell can't post copyrighted Microsoft source code on this mailing list! - Dan

March 1, 2008