May 2008 - Wine-Devel - list.winehq.org

Re: Search for leftovers after running winetest

by Paul Vriens

Kai Blin wrote: > On Friday 30 May 2008 09:44:16 Paul Vriens wrote: >> Hi, >> >> (Sorry, first one went to the wrong list) >> >> I just had a look at some of the stuff that's still around after running >> winetest a few months now on my W2K3 box (some of the regkeys are linked of >> course): > > [...] > >> Filesystem >> ========== >> C:\Documents and Settings\testuser >> (basically a testuser for each winetest run on xp+ systems) > > This one's mine, created by dlls/netapi32/tests/access.c > However, at least when I wrote it I couldn't reproduce your findings on my XP > box. I do have access to a win2k3 box now, so I'll look into this again. I > just don't really have time for this right now. Could you please file a bug > for that and cc me on it so it won't get lost? > > Cheers, > Kai > > > > ------------------------------------------------------------------------ > > I'll create a bug report for this. Btw, the user acount information is nicely removed, it's just that the user-directory isn't removed starting as of XP. -- Cheers, Paul.

May 30, 2008

Re: Search for leftovers after running winetest

by Kai Blin

On Friday 30 May 2008 09:44:16 Paul Vriens wrote: > Hi, > > (Sorry, first one went to the wrong list) > > I just had a look at some of the stuff that's still around after running > winetest a few months now on my W2K3 box (some of the regkeys are linked of > course): [...] > Filesystem > ========== > C:\Documents and Settings\testuser > (basically a testuser for each winetest run on xp+ systems) This one's mine, created by dlls/netapi32/tests/access.c However, at least when I wrote it I couldn't reproduce your findings on my XP box. I do have access to a win2k3 box now, so I'll look into this again. I just don't really have time for this right now. Could you please file a bug for that and cc me on it so it won't get lost? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

May 30, 2008

Search for leftovers after running winetest

by Paul Vriens

Hi, (Sorry, first one went to the wrong list) I just had a look at some of the stuff that's still around after running winetest a few months now on my W2K3 box (some of the regkeys are linked of course): Registry ======== HKEY_CLASSES_ROOT\Applications\shell32_test.exe HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Applications\shell32_test.exe HKEY_CLASSES_ROOT\TypeLib\{D96D8A3E-78B6-4C8D-8F27-059DB959BE8A} HKEY_LOCAL_MACHINE\SOFTWARE\Classes\TypeLib\{D96D8A3E-78B6-4C8D-8F27-059DB959BE8A} (includes a reference to oleaut32_test.exe) HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.shlexec\OpenWithList (reference to shell32_test.exe) HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug (contains 'Debugger' which points to kernel32_test.exe) HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\StillImage\Debug\mscms_test.exe HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\BOGUS HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Enum\USB\BOGUS HKEY_LOCAL_MACHINE\SYSTEM\ControlSet002\Enum\USB\BOGUS HKEY_CURRENT_USER\Software\Wine HKEY_LOCAL_MACHINE\SOFTWARE\Wine\msitest Filesystem ========== C:\Config.Msi C:\Documents and Settings\testuser (basically a testuser for each winetest run on xp+ systems) (Any maybe more) I'm wondering how this effects tests? Any ideas? Do other see the same leftovers? I also think we should remove all leftovers after the tests if possible. Nice janitorial task or important enough to be tackled quicker? -- Cheers, Paul.

May 30, 2008

Re: dxdiagn: PhysicalMemory parameter is a string not long long

by Alexandre Julliard

Vitaliy Margolen <wine-devel(a)kievinfo.com> writes: > Well it really should be "%llu" but Wine doesn't support that. "%lu" > is used btw at least in one place in the code: > http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746 It's the correct format for a ULONG_PTR. > What should it be then? The same as wine_dbgstr_longlong? I doubt you want it to be in hex. You should use something like VariantChangeType. -- Alexandre Julliard julliard(a)winehq.org

May 30, 2008

Double free in direct sound capture

by Michael Karcher

Hello developers I was running the testcases with warn+heap, and noted some warnings from dsound:capture. They are caused by double free calls, and only happen with winealsa.drv, not with wineoss.drv. The following patch happens to makes the messages disappear. Could somebody with some knowledge about wine's DirectSound implementation please look into this issue and find a proper fix? Regards, Michael Karcher

May 30, 2008

Re: dxdiagn: PhysicalMemory parameter is a string not long long

by Vitaliy Margolen

Alexandre Julliard wrote: > Vitaliy Margolen <wine-devel(a)kievinfo.com> writes: > >> Was anything wrong with this patch? I've used a simple utility >> DxDiagOutput.exe from DXSDK to find and test this. > > The printf format is wrong. > Well it really should be "%llu" but Wine doesn't support that. "%lu" is used btw at least in one place in the code: http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746 What should it be then? The same as wine_dbgstr_longlong? Vitaliy.

May 30, 2008

Recent change causes registry creation to fail

by Benjamin M. Schwartz

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I am trying to write a scripted wine installation in a nonstandard directory. As part of this procedure, I set $WINEPREFIX and then run wineprefixcreate. This worked perfectly in 0.9.59, but in 0.9.60+ it fails with wineserver: chdir to config dir : Not a directory wine: for some mysterious reason, the wine server failed to run "regedit" fails with the same error. Wine does run, but its registry appears to be screwy. For example, the DOS environment variables like %PROGRAMFILES% and %PATH% are not set at all. I have traced the error to a change made by Alexandre Julliard to registry.c in mid-April [1]. Why might that change have this effect? What should I do to avoid this problem? Thank you, Ben Schwartz OLPC volunteer [1] http://source.winehq.org/git/wine.git/?a=blobdiff;f=server/registry.c;h=d2c… -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkg/g8wACgkQUJT6e6HFtqTgdwCeM7S/HVIS8LU82qVQ5R3cs0Yt HGAAn3cQhdG4VR5H/2jbIbU7SS/uDRX4 =5Bd7 -----END PGP SIGNATURE-----

May 30, 2008

Re: advpack: don't close a handle if it wasn't opened

by James Hawkins

On Thu, May 29, 2008 at 10:34 PM, Dan Kegel <dank(a)kegel.com> wrote: > Avoids referencing an undefined variable. > The right way to fix this is to set subkey to NULL in the beginning. -- James Hawkins

May 30, 2008

Re: user32: Allow a NULL foreground window in the tests

by Dmitry Timoshkov

"James Hawkins" <truiken(a)gmail.com> wrote: > Passing 0 for the foreground window essentially disables the test, > whereas allowing a NULL window is testing another variation of what > can happen with the foreground window, just like if a last error is, > e.g., ERROR_FILE_NOT_FOUND on one platform instead of > ERROR_PATH_NOT_FOUND. Your method disables the test completely. Yes, passing foreground == 0 disables the foreground window test. That should be done very carefully for the tests that always fail. I'd expect for instance test_SetActiveWindow() and test_SetForegroundWindow() not need to disable it. -- Dmitry.

May 30, 2008

[website] Re: wine site: Translate sendind_patches to Spanish in web.site.git

by Ángel Guzmán Maeso

> OK. Patches are complete. The majority of the website can be translated > now. O_O XLNT!!!!!! > What still needs to be done is to allow translation of the sidebar nav. My > plan is to move that out of the config.php file and into a separate file, > possibly in XML. Well, sound good for me. People who want to send translations of the news and wwn will probably need > to subscribe to wine-cvs and watch for commits from me for the files in the > "en" dirs to keep the turn around time on translations shorter. Yeah, I am already subscribed to ALL lists of wine, so it's no problem (wine-cvs, wine-devel, wine-bugs...wine-santa, wine-bogeyman...). At the very least, the website will always fall back to the english version > of the template. Ok > Yeah, I'm working on a patch now to enable translations of all the content. > Someone will have fun jobs of sending in translations of all the WWN > content, but if they are up to the challenge. > > Hold off on your updates until I'm done. Well, Still not begin to translate part of WWN, but translates other templates. FYI, your templates will need to be in UTF-8 encoded text files. Make sure > your text editor is set to output that. Your original patch was not UTF-8. Sorry, I used Geany, Gedit and other and they are in conflict of encode. For Your Information: Not translate NEVER with google translator or other "translators" because they are machines and they translate as if they were wild Indians or master yoda. If you use your translators, at least you know enough language to translate that, because if not the translation will be very very bad, for example, in /template/es/404.template I send a patch with translations for many templates and 404.template (in UTF-8 believe) and a small improve in a function of file site. This improvement use array_ramdom instead of rand+count but the bound is not clear for me, so you should review

May 30, 2008