June 2008 - Wine-Devel - list.winehq.org

Re: Some conformance tests a bit slow under Valgrind

by Dylan Smith

On Fri, Jun 27, 2008 at 12:43 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > Rather than using one URL for all the messages, you could also cycle through > URL after testing them initially. It would have the same performance of > using the same valid URL, but keeps the variety in the test. I ended up looking at the test more to fix a valgrind error, and noticed that my patch should probably only cycle over valid urls instead of all of them. The valid urls could be moved to the front of the urls array, and then index can be use the number of valid urls to mod by, rather than the total number of urls. > I am attaching a rough patch to show what I mean, and so I can give everyone > an idea of the impact this type of change makes. The following are times > from calling runtest for the editor tests of riched20.dll before and after > the patch. > > Before: > real 1m6.924s > user 0m42.067s > sys 0m7.148s > > After: > real 0m11.539s > user 0m3.876s > sys 0m0.956s Dan, was this enough of a difference for the time the tests take to run?

June 30, 2008

Re: programs: add rudimentary dxdiag

by Austin English

On Mon, Jun 30, 2008 at 9:50 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, any comments on this one? > btw, is there a reason i never ever receive any comments on my patches when > they are rejected? If so, please tell me, that'll save me a lot of time of > sending them in... > > ----- Forwarded Message ---- > From: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> > To: wine-patches(a)winehq.org > Sent: Thursday, 26 June, 2008 3:20:04 AM > Subject: Re: programs: add rudimentary dxdiag > > Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for > dxdiag.exe, and give an error if it's not found, so wine needs its own. > Instead of simple stub, this patch also adds the (simplified) d3d test > like seen in native dxdiag, so users can test if their d3d is setup > correctly. Screenshot can be seen here: > http://bugs.winehq.org/attachment.cgi?id=14342 > > A few remarks: > > -patch contains binary code for a bitmap, so to apply again i had to do > git apply dx.patch > git add programs/dxdiag/ > tools/make_makefiles > autoconf > > maybe there's a simpler way, but i dunno > > - code for spinning cube was partially based on spinning cube code > scattered all over the internet > -rest was ripped of winecfg > - There' s a problem while minizing the d3d-window, but running it in > wine-0.9.22 it all goes fine, so this must be a regression somewhere, and > not a bug in the attached code. I'll go after that later. > - Hopefully you're not to picky on this patch, it 's quite some line's of > code,and i'm sure things need to be improved, but this does not affect > wine's core code but os rather an enhancement, and it 's not really possible > to send it in in small chuncks. > > > > > ________________________________ > Not happy with your email address? > Get the one you really want - millions of new email addresses available now > at Yahoo! > ________________________________ > Not happy with your email address? > Get the one you really want - millions of new email addresses available now > at Yahoo! > > > Like I said in the bug, you should add dxdiag to configure.ac/Makefile.in/etc. -Austin

June 30, 2008

Re: programs: add rudimentary dxdiag

by Juan Lang

> Hi, any comments on this one? > btw, is there a reason i never ever receive any comments on my patches when > they are rejected? If so, please tell me, that'll save me a lot of time of > sending them in... I'll bite. One comment for both questions: it's too big. No comment from AJ usually means either, "this is too big, I'll look at it later," or "I think there's something wrong with it, but I don't know what yet, I'll look at it later." Of course new patches come along, and you eventually get dropped from the queue. You can split this up. Try adding a stub program with one patch then adding a bit at a time. --Juan

June 30, 2008

programs: add rudimentary dxdiag

by Louis. Lenders

Hi, any comments on this one? btw, is there a reason i never ever receive any comments on my patches when they are rejected? If so, please tell me, that'll save me a lot of time of sending them in... ----- Forwarded Message ---- From: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> To: wine-patches(a)winehq.org Sent: Thursday, 26 June, 2008 3:20:04 AM Subject: Re: programs: add rudimentary dxdiag Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for dxdiag.exe, and give an error if it's not found, so wine needs its own. Instead of simple stub, this patch also adds the (simplified) d3d test like seen in native dxdiag, so users can test if their d3d is setup correctly. Screenshot can be seen here: http://bugs.winehq.org/attachment.cgi?id=14342 A few remarks: -patch contains binary code for a bitmap, so to apply again i had to do git apply dx.patch git add programs/dxdiag/ tools/make_makefiles autoconf maybe there's a simpler way, but i dunno - code for spinning cube was partially based on spinning cube code scattered all over the internet -rest was ripped of winecfg - There' s a problem while minizing the d3d-window, but running it in wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not a bug in the attached code. I'll go after that later. - Hopefully you're not to picky on this patch, it 's quite some line's of code,and i'm sure things need to be improved, but this does not affect wine's core code but os rather an enhancement, and it 's not really possible to send it in in small chuncks. ________________________________ Not happy with your email address? Get the one you really want - millions of new email addresses available now at Yahoo! __________________________________________________________ Not happy with your email address?. Get the one you really want - millions of new email addresses available now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html

June 30, 2008

Re: Bugzilla search

by Vitaliy Margolen

Jeremy Newman wrote: > Try it now. > Much better, thanks. Vitaliy.

June 30, 2008

Re: Bugzilla search

by Jeremy Newman

Try it now. Vitaliy Margolen wrote: > Any time I'm trying to search for bugs with anything more then just a simple > string in the subject I'm getting a blank page. This didn't happen before. > > This makes searching for bugs impossible. Can some one look into this? > > Vitaliy. > >

June 30, 2008

UUID lookup utility

by Mikołaj Zalewski

To be able to check quickly what a UUID in Bugzilla means, I wrote a script to show some information about them. It uses data retrieved from Windows and Wine include files and registries (it finds information about more than 32000 different UUIDs). If someone is interested in it, I have put to on http://pf128.krakow.sdi.tpnet.pl/uuid.tgz . It's written in JavaScript and works under Firefox 1.5+ (it would require some small modifications to work on IE). Mikołaj Zalewski

June 30, 2008

Re: cryptui(2/3): Document definitions missing from public header

by Alexandre Julliard

"Juan Lang" <juan.lang(a)gmail.com> writes: > +/* These definitions probably belong in cryptuiapi.h, but the PSDK doesn't have > + * them, so define them here. > + */ The latest version of the PSDK does have them AFAICS. -- Alexandre Julliard julliard(a)winehq.org

June 30, 2008

Re: [06/12] gdi32: Perform the world transform separately from font scaling

by Michael Karcher

Am Dienstag, den 24.06.2008, 16:11 +0900 schrieb Dmitry Timoshkov: > + /* World transform */ > + if (!is_identity_FMAT2(&font->font_desc.matrix)) > + { > + FT_Matrix worldMat; > + worldMat.xx = FT_FixedFromFloat(font->font_desc.matrix.eM11); > + worldMat.xy = FT_FixedFromFloat(font->font_desc.matrix.eM21); > + worldMat.yx = FT_FixedFromFloat(font->font_desc.matrix.eM12); > + worldMat.yy = FT_FixedFromFloat(font->font_desc.matrix.eM22); > + pFT_Matrix_Multiply(&worldMat, &transMat); > + needsTransform = TRUE; > + } > + This causes a regression in the German computer-aided tax form printing program "Elster-Formular". Previously, font scaling worked like in the GM_COMPATIBLE graphics mode (set via SetGraphicsMode on the DC), that is, mainly abs(yy) is used as scaling factor, and that's it. This change introduces something like the GM_ADVANCED graphics mode, but does it wrong (for example, the origin for reflections should be the point specified in TextOut, currently, reflections are done relative to the base line of the character; also the background is not reflected at all). I have attached a simple test program to show what happens in wine with a scaling that inverts the y axis (as the German tax program uses). Its expected output would be to characters looking the same at the same Y position, which is what I get in windows, and also with Wine 1.0. If the GM_ADVANCED line is activated, expected output would be the first "F" as is, and the second "F" upside down above the line, with the lowest part of the white box touching the black line. No Wine version does handle this case correctly. Regards, Michael Karcher

June 30, 2008

Re: winebrowser: make dde works right when version > NT

by Hans Leidekker

On Monday 30 June 2008 09:05:42 Ivan Sinitsin wrote: > Fix propblem with command `wine start http://<something>` when version of > windows > NT. > When version > NT we have WCHAR and don`t need to transform char to WCHAR. I believe it's not the windows version that determines whether the data retrieved is a Unicode string but rather the iCodePage field in the CONVCONTEXT structure supplied to DdeInitialize by the client. The patch I attached to http://bugs.winehq.org/show_bug.cgi?id=13891 makes use of that information but it will only work when the client thread is in the same process. This is because cross process querying of DDE conversation info is currently not implemented. -Hans

June 30, 2008