January 2009 - Wine-Devel - list.winehq.org

Re: http://wiki.winehq.org/NamedPipes

by Kai Blin

On Friday 30 January 2009 19:38:20 Luke Kenneth Casson Leighton wrote: > samba having "break-out" for named pipes traffic is one of those > absolutely _essential_ things that should have fucking well gone into > the samba source code a _long_ time ago. around 1998 would have been > good. Funny enough, the Samba project codenamed "franky" (http://wiki.samba.org/index.php/Franky) will be doing all of this. It's not quite there yet, but after some nice work done in the Samba3 smbd by Volker Lendecke and some more work in the Samba4 "samba" daemon by Stefan Metzmacher, Jelmer Vernooij and some overall effort by other folks from the Samba Team, franky is coming along quite well. Just a heads up, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

Jan. 31, 2009

RE: gdi32: Remove unneeded check. (Coverity)

by EA Durbin

> From: kai.blin(a)gmail.com > To: robertshearman(a)gmail.com > Subject: Re: gdi32: Remove unneeded check. (Coverity) > Date: Wed, 28 Jan 2009 10:32:40 +0100 > CC: wine-devel(a)winehq.org > > On Tuesday 27 January 2009 18:29:10 Rob Shearman wrote: > > > It doesn't make much sense to leave the lcdfilter variable in the > > function if you're going to remove the if condition depending on it, > > since it only has one other use. > > However, It might have been the intention of the author of this code > > that this is setting to be changed at compile time (or runtime through > > a registry tweak) and have the code do the appropriate thing - in that > > case it would have been better to put the variable at the top of the > > file. > > I actually have no idea. This was the smallest possible fix that addressed the > coverity issue, but I agree that we need to do something with the lcdfilter > variable. > > Looking at the commits responsible for the lcdfilter assignment (028617b9) and > the if check (45a081f1), I don't see anything that hints at why there's an if > check with lcdfilter hardcoded. CCing the original author. > > Cheers, > Kai > > -- > Kai Blin > WorldForge developer http://www.worldforge.org/ > Wine developer http://wiki.winehq.org/KaiBlin > Samba team member http://www.samba.org/samba/team/ > -- > Will code for cotton. _________________________________________________________________ Hotmail® goes where you go. On a PC, on the Web, on your phone. http://www.windowslive-hotmail.com/learnmore/versatility.aspx#mobile?ocid=T…

Jan. 31, 2009

Re: msadp32.acm : block align and adpcm extra data

by Vincent Pelletier

Le Thursday 22 January 2009 16:25:42 Stefano Guidoni, vous avez écrit : > This patch solves bug 7385: > Function ADPCM_StreamSize must return a > buffer size, which is a multiple of block align. > This buffer size is > calculated taking into account input-blockalign, output-blockalign and > adpcm-samplesperblock. Hi. Excuse me for contacting you directly, but that patch didn't enter the source tree, because of the "while" loops. I've been trying for hours to guess by trial and (tons of) error the right formula not involving any "magic" number (besides 7, which is the number of bytes per channel in adpcm block header afaik), but I could not reach the right result: after ~ten seconds, the result of my computation diverges from yours, and audio starts repeating/skipping. Probably operation rounding errors. and/or integer overflows. Could you explain me how you reached that formula ? Mainly, I don't understand why there is no trace of the number of samples per seconds, nor why you multiply a plock align with another block align in the denominator of source size computation when source is adpcm. By advance, many thanks for enlightening me. -- Vincent Pelletier

Jan. 30, 2009

Re: request for windows test: GetPrivateProfileSectionNamesA

by Austin English

On Fri, Jan 30, 2009 at 1:37 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > Could someone please test those, I want to see if > the second or third crash on Windows to handle those > borderline cases. > > Ciao & Thanks, Marcus > > > --- > dlls/kernel32/tests/profile.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c > index 5292c33..feeb7b2 100644 > --- a/dlls/kernel32/tests/profile.c > +++ b/dlls/kernel32/tests/profile.c > @@ -214,6 +214,13 @@ static void test_profile_sections_names(void) > WriteFile( h, content, sizeof(content), &count, NULL); > CloseHandle( h); > > + ret = GetPrivateProfileSectionNamesA( NULL, 0, testfile3 ); > + ok (ret == 0, "GetPrivateProfileSectionNamesA(NULL,0) returned %d instead of 0\n", ret); > + ret = GetPrivateProfileSectionNamesA( buf, 0, testfile3 ); > + ok (ret == 0, "GetPrivateProfileSectionNamesA(buf,0) returned %d instead of 0\n", ret); > + ret = GetPrivateProfileSectionNamesA( NULL, 1, testfile3 ); > + ok (ret == 0, "GetPrivateProfileSectionNamesA(NULL,1) returned %d instead of 0\n", ret); > + > /* Test with sufficiently large buffer */ > memset(buf, 0xc, sizeof(buf)); > ret = GetPrivateProfileSectionNamesA( buf, 29, testfile3 ); > -- > 1.5.6 > > > > Third crashes on 2k SP4 and XP SP3. First and second are okay. -- -Austin

Jan. 30, 2009

Re: [2/13]msctf: implement SetFocus and GetFocus

by Aric Stewart

Humm, I thought so at first also, but then when I was testing with word 2007 (which is the only program I have found so far that uses this) I found that if i released here then the DocumentMgr was prematurely destroyed and caused Word to crash. With not releasing then everything lined up. There is also a note in msdn about AssociateFocus which states that it does not increment the lock possibly in contrast to SetFocus. The documentation on these interfaces is very very sparse. -aric Jacek Caban wrote: > Hi Aric, > > Aric Stewart wrote: >> --- >> dlls/msctf/threadmgr.c | 28 ++++++++++++++++++++++++---- >> 1 files changed, 24 insertions(+), 4 deletions(-) >> > > + if (!pdimFocus || FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check))) > + return E_INVALIDARG; > + > + This->focus = check; > > > Shouldn't This->focus be released if it's already set? > > > Jacek > > > >

Jan. 30, 2009

Re: [2/13]msctf: implement SetFocus and GetFocus

by Jacek Caban

Hi Aric, Aric Stewart wrote: > --- > dlls/msctf/threadmgr.c | 28 ++++++++++++++++++++++++---- > 1 files changed, 24 insertions(+), 4 deletions(-) > + if (!pdimFocus || FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check))) + return E_INVALIDARG; + + This->focus = check; Shouldn't This->focus be released if it's already set? Jacek

Jan. 30, 2009

Re: Highest commits per month (ever)

by Paul Vriens

Paul Vriens wrote: > Hi, > > This month we hit the highest number of commits per month ever : 1307. > > It's a shame there is weekend coming ;) > Should be "Highest number of commits per month (ever)" and "It's a shame there is a weekend coming". Shouldn't be writing emails at the end of a working week. -- Cheers, Paul.

Jan. 30, 2009

Highest commits per month (ever)

by Paul Vriens

Hi, This month we hit the highest number of commits per month ever : 1307. It's a shame there is weekend coming ;) -- Cheers, Paul.

Jan. 30, 2009

request for windows test: GetPrivateProfileSectionNamesA

by Marcus Meissner

Hi, Could someone please test those, I want to see if the second or third crash on Windows to handle those borderline cases. Ciao & Thanks, Marcus --- dlls/kernel32/tests/profile.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index 5292c33..feeb7b2 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -214,6 +214,13 @@ static void test_profile_sections_names(void) WriteFile( h, content, sizeof(content), &count, NULL); CloseHandle( h); + ret = GetPrivateProfileSectionNamesA( NULL, 0, testfile3 ); + ok (ret == 0, "GetPrivateProfileSectionNamesA(NULL,0) returned %d instead of 0\n", ret); + ret = GetPrivateProfileSectionNamesA( buf, 0, testfile3 ); + ok (ret == 0, "GetPrivateProfileSectionNamesA(buf,0) returned %d instead of 0\n", ret); + ret = GetPrivateProfileSectionNamesA( NULL, 1, testfile3 ); + ok (ret == 0, "GetPrivateProfileSectionNamesA(NULL,1) returned %d instead of 0\n", ret); + /* Test with sufficiently large buffer */ memset(buf, 0xc, sizeof(buf)); ret = GetPrivateProfileSectionNamesA( buf, 29, testfile3 ); -- 1.5.6

Jan. 30, 2009

Re: Reliable Datagram / Stream behaviour of NT Pipes

by Luke Kenneth Casson Leighton

On Fri, Jan 30, 2009 at 6:41 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > Hi Luke, hi juan :) >> the issue with the implementation of nt named pipes on top of _just_ >> streams (unix sockets) is this: two packets sent get blatted into one >> read. > > You are correct. We've known about that bug for ages, but never got > around to fixing it. See e.g. Mike McCormack's interview and his > comments on message mode: > http://www.winehq.org/interview/7 ohhhh - message mode _that's_ what it's called :) dang, that got dragged out of long-term storage. i remember seeing that in smb packets. >> ... i'm veery tempted to say "can i have a go at implementing this?" >> but... i know it'll be ... how-to-say... eeenteresting :) >> >> should i try? > > Yes, by all means. this'll be interesting ha ha >> would an extra server message need to be added (for read), so that the >> server can keep track of how much data has been read back (of the >> current datagram)? > > Possibly. This is tricky too, because a named pipe handle can be > shared across processes. eek. > You really want named pipe reads to block > until a complete datagram is available. What to do with short reads > is something you'd have to figure out too. yep. > Some nice C test cases > would go a long way toward a correct implementation. ok, then that's where i'll start. i've got a qemu'd xp so i can actually test that they work properly on nt. i've just dragged the tng source code out of cvs, first time in ages, so there's plenty there to work from, really quite quickly. yaay! :)

Jan. 30, 2009