October 2009 - Wine-Devel - list.winehq.org

Re: Image List tests for comctl32 v6

by Nikolay Sivov

Joel Holdsworth wrote: > Hi All, > > I'm working on some tests to demonstrate some alpha-channel behaviour in > comctl32 ImageLists. The problem is that this behaviour is only present > in comctl32 v6, which of course you usually activate with an xml > manifest. For the wine test suite we have a helper function, > load_v6_module, that dynamically creates a manifest resource entry in > the module, which seems to activate v6 behaviour. However, while this > seems to activate v6 behaviour for controls, it seems not to for image > lists - my tests work if I link a manifest into the test suite, but > don't work via load_v6_module. > > Does anyone have any thoughts about what might be going on here, and > what I should do with my tests? > > Thanks > Joel > Hi, Joel. It works for precreated manifest as a separate file (not compiled in), isn't it? If so you could do a trick that I spotted here http://www.winehq.org/pipermail/wine-patches/2009-September/078869.html for a first time - here another process is created after main test binary loaded, it's created for exactly the same binary but with a manifest created first (command line parameter passed to jump to V6 tests). Hope this helps.

Oct. 1, 2009

Re: Image List tests for comctl32 v6

by Owen Rudge

Hi Joel, > I'm working on some tests to demonstrate some alpha-channel behaviour in > comctl32 ImageLists. The problem is that this behaviour is only present > in comctl32 v6, which of course you usually activate with an xml > manifest. For the wine test suite we have a helper function, > load_v6_module, that dynamically creates a manifest resource entry in > the module, which seems to activate v6 behaviour. However, while this > seems to activate v6 behaviour for controls, it seems not to for image > lists - my tests work if I link a manifest into the test suite, but > don't work via load_v6_module. Do you mean that the tests pass on Windows but not Wine when using load_v6_module, or that they don't pass on either platform? I used load_v6_module for some v6 imagelist tests (which may not yet be merged into Wine actually; I should probably check that and resubmit) and they worked fine. You may want to look at http://tinyurl.com/ybo28lt for instance. If the tests are working on Windows but not on Wine, the obvious reason for your tests failing would be that the required alpha channel support is not implemented. Cheers, -- Owen Rudge http://www.owenrudge.net/

Oct. 1, 2009

Image List tests for comctl32 v6

by Joel Holdsworth

Hi All, I'm working on some tests to demonstrate some alpha-channel behaviour in comctl32 ImageLists. The problem is that this behaviour is only present in comctl32 v6, which of course you usually activate with an xml manifest. For the wine test suite we have a helper function, load_v6_module, that dynamically creates a manifest resource entry in the module, which seems to activate v6 behaviour. However, while this seems to activate v6 behaviour for controls, it seems not to for image lists - my tests work if I link a manifest into the test suite, but don't work via load_v6_module. Does anyone have any thoughts about what might be going on here, and what I should do with my tests? Thanks Joel

Oct. 1, 2009

Re: [4/4] msi: Test installing over in-use files.

by Hans Leidekker

On Thursday 01 October 2009 08:46:13 pm Paul Vriens wrote: > > + RegOpenKeyExA(HKEY_LOCAL_MACHINE, key, 0, KEY_ALL_ACCESS,&hkey); > > + if (!RegQueryValueExA(hkey, value, NULL, NULL, NULL,&size)) > > + { > > + skip("Pending file rename operations, skipping test\n"); > > + return; > > Hi Hans, > > (In response to this and the previous patch concerning pending renames). > > Win9x and WinMe act differently on pending renames (as usual :( ). > Instead of using the registry some entries are written into > %windir%\WinInit.ini. > > Is it worthwhile to have the tests cope with this or should we just skip > them on Win9x/WinMe? I don't think it's worthwhile, lets just skip them on 9x. -Hans

Oct. 1, 2009

Re: Wine and Intel 3D

by Roderick Colenbrander

When the Xserver crashes the bug in question is a bug in the display drivers. Wine itself or any other X app won't bring the Xserver down (they can't). Though knowing what changes in Wine triggered this (probably glsl / fbo stuff) could help the intel developers fixing the issue but as I said the issue is in the intel drivers. Roderick On Thu, Oct 1, 2009 at 8:47 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > On Thu, Oct 1, 2009 at 12:30 PM, MD.IMAM HOSSAIN <imamdxl8805(a)gmail.com> > wrote: >> >> Dear Developers, >> >> Latest wine is having problems with Intel UXA 2D driver. >> Many games cause X server to restart. >> >> My system is UBUNTU 9.04. >> Tested with Intel 2.8 graphics driver, 2.6.30 rc-4 linux kernel, Mesa >> 7.5.2. >> >> WINE 1.1.29 = prolem >> WINE 1.1.18 = NO problem >> >> All Linux native games works wonderfully by this latest Intel driver. >> >> Best regards, >> MD. IMAM HOSSAIN > > The instructions for performing a regression test will assist you in > narrowing down the problem: > http://wiki.winehq.org/RegressionTesting > > Erich Hoover > ehoover(a)mines.edu > > > >

Oct. 1, 2009

Re: Wine and Intel 3D

by Erich Hoover

On Thu, Oct 1, 2009 at 12:30 PM, MD.IMAM HOSSAIN <imamdxl8805(a)gmail.com>wrote: > Dear Developers, > > Latest wine is having problems with Intel UXA 2D driver. > Many games cause X server to restart. > > My system is UBUNTU 9.04. > Tested with Intel 2.8 graphics driver, 2.6.30 rc-4 linux kernel, Mesa > 7.5.2. > > WINE 1.1.29 = prolem > WINE 1.1.18 = NO problem > > All Linux native games works wonderfully by this latest Intel driver. > > Best regards, > MD. IMAM HOSSAIN > The instructions for performing a regression test will assist you in narrowing down the problem: http://wiki.winehq.org/RegressionTesting Erich Hoover ehoover(a)mines.edu

Oct. 1, 2009

Re: [4/4] msi: Test installing over in-use files.

by Paul Vriens

On 09/29/2009 02:57 PM, Hans Leidekker wrote: > > + static char key[] = "System\\CurrentControlSet\\Control\\Session Manager"; > + static char value[] = "PendingFileRenameOperations"; > + > + RegOpenKeyExA(HKEY_LOCAL_MACHINE, key, 0, KEY_ALL_ACCESS,&hkey); > + if (!RegQueryValueExA(hkey, value, NULL, NULL, NULL,&size)) > + { > + skip("Pending file rename operations, skipping test\n"); > + return; Hi Hans, (In response to this and the previous patch concerning pending renames). Win9x and WinMe act differently on pending renames (as usual :( ). Instead of using the registry some entries are written into %windir%\WinInit.ini. Is it worthwhile to have the tests cope with this or should we just skip them on Win9x/WinMe? -- Cheers, Paul.

Oct. 1, 2009

Wine and Intel 3D

by MD.IMAM HOSSAIN

Dear Developers, Latest wine is having problems with Intel UXA 2D driver. Many games cause X server to restart. My system is UBUNTU 9.04. Tested with Intel 2.8 graphics driver, 2.6.30 rc-4 linux kernel, Mesa 7.5.2. WINE 1.1.29 = prolem WINE 1.1.18 = NO problem All Linux native games works wonderfully by this latest Intel driver. Best regards, MD. IMAM HOSSAIN

Oct. 1, 2009

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

by Alexandre Julliard

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes: > "Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > >> The TRY 5 of tests had beent sent. Is it correct or my test so bad >> that nobody doesn't like to answer? :) > > Try 5 looks good to me (therefore the lack of the comment), not sure > why it wasn't committed. It's still using W functions, it's leaking an hdc, and it cannot possibly pass on Wine. Not to mention that it would be more convincing if it showed some successful sequences as well. -- Alexandre Julliard julliard(a)winehq.org

Oct. 1, 2009

Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

by Hans Leidekker

Hi Nate, Your patch applies with offsets, please rebase to current git. And get rid of this warning: db.c: In function ‘test_where_not_in_selected’: db.c:1576: warning: unused variable ‘count’ > + query = /*"Select IESTable.Action, IESTable.Condition from CATable, IESTable where "*/ > + "Select IESTable.Condition from CATable, IESTable where " > + //"CATable.Action = IESTable.Action and (CATable.Type = 51 or CATable.Type = 32) " > + "CATable.Action = IESTable.Action and CATable.Type = 32 " > + /*"order by IESTable.Sequence"*/; Please remove the commented strings. > static UINT ALTER_get_column_info( struct tagMSIVIEW *view, > - UINT n, LPWSTR *name, UINT *type, BOOL *temporary ) > + UINT n, LPWSTR *name, UINT *type, BOOL *temporary, > + LPWSTR *tableName) 'table_name' or just 'table' would be more in keeping with the existing style. > + printf("Returned entry: %s\n", buf); trace() is usually used for debug printing but you might want to turn this into a test instead, or just leave it out. And you should split off the tests to keep the patch size down. -Hans

Oct. 1, 2009