October 2009 - Wine-Devel - list.winehq.org

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

by Dmitry Timoshkov

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > The TRY 5 of tests had beent sent. Is it correct or my test so bad that nobody > doesn't like to answer? :) Try 5 looks good to me (therefore the lack of the comment), not sure why it wasn't committed. -- Dmitry.

Oct. 1, 2009

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

by Ilya Shpigor

On Tuesday 29 September 2009 10:57:45 you wrote: > You should use SendMessageA instead of SendMessageW to make the test run > under Win9x as well. Testing the return value of SendMessage would be also > helpful. Hi, The TRY 5 of tests had beent sent. Is it correct or my test so bad that nobody doesn't like to answer? :) -- Best regards, Ilya Shpigor.

Oct. 1, 2009

Re: Owen Rudge : comctl32: Implement highlighting (marquee) selection support in listview.

by Owen Rudge

Hi Nikolay, > Didn't test it much yet, but few issues from a start: I'll look into these issues and try to submit a fix as soon as possible. Cheers, -- Owen Rudge http://www.owenrudge.net/

Oct. 1, 2009

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

by Nikolay Sivov

Paul Vriens wrote: > On 10/01/2009 09:58 AM, Nikolay Sivov wrote: >> >> P.S. how could I change a locale on my Debian system for particular Wine >> run? Could you help me with that? > > What I usually do is something like > > LC_ALL=nl_NL.UTF-8 wine .... > or > LC_ALL=nl_NL.UTF-8 make monthcal.ok > > More lang references can be found at > http://wiki.winehq.org/TestingLanguages > Strange it doesn't work for me. Both LC_ALL and LANG don't change anything. Maybe I've got a wrong configuration on my system, how could I reset it to default or reinitialize in some way?

Oct. 1, 2009

Re: Owen Rudge : comctl32: Implement highlighting (marquee) selection support in listview.

by Nikolay Sivov

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 69b76a18fb19bd4a6c83f4f05eb942513af970fd > URL: http://source.winehq.org/git/wine.git/?a=commit;h=69b76a18fb19bd4a6c83f4f05… > > Author: Owen Rudge <orudge(a)codeweavers.com> > Date: Wed Sep 30 16:41:23 2009 +0100 > > comctl32: Implement highlighting (marquee) selection support in listview. > > --- > Hi, Owen. Didn't test it much yet, but few issues from a start: - when control doesn't have focus rectangle is visible, but it doesn't select anything; - during resizing rectangle and moving pointer outside client area rectangle gets stuck, on native it still moves; - after mouse released outside client area rectangle should be cleared, now it stays as it is. Do you plan to work on this?

Oct. 1, 2009

Re: Peter Dons Tychsen : user32: Add exception handling for timer callbacks.

by Peter Dons Tychsen

On Thu, 2009-10-01 at 12:33 +0200, Alexandre Julliard wrote: > Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > > > Just out of interest: You changed this to a write. Fine. > > But why the volatile? Can GCC assume predetermined results when writing > > to NULL? I don't see any reason to use volatile unless someone else is > > also read/writing from NULL (which is impossible). It might just > > generate more code in some cases. > > It's just to make sure no compiler tries to be too smart. For a single > access it probably doesn't make a difference; it could change if for > instance we try to trigger a second crash and the compiler optimizes out > the first write. > Ah,OK. Thanks for the info. /pedro

Oct. 1, 2009

Re: [comctl32/tests] Fix some test failures

by Paul Vriens

On 10/01/2009 03:28 PM, Nikolay Sivov wrote: > Paul Vriens wrote: >> On 10/01/2009 02:58 PM, Nikolay Sivov wrote: >>> Yes, please. If a problem is only in rectangle orders it's very simple >>> to fix (test for yyyy in returned locale data). I suggest not to drop >>> tests yet, we'll probably want to drop them later when trying probable >>> dpi-dependent failures. >> >> Well I need to test for all possible occurrences of month and year. So >> something like: >> >> /* Get the format of the title */ >> len = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, NULL, 0); >> yearmonth = HeapAlloc(GetProcessHeap(), 0, len); >> GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, yearmonth, len); >> /* Find out the order */ >> year = strstr(yearmonth, "y"); >> month = strstr(yearmonth, "M"); >> >> if (month < year) trace("Month before year\n"); >> else trace("Year before month\n"); >> HeapFree(GetProcessHeap(), 0, yearmonth); > Yes, not all possible actually, only month < year condition matters. > It's better to use yyyy pattern cause some locales add > extra words in this format string. Also a static char[80] buffer should > be used to simplify things (btw, MSDN says about 80 character length for Yeah, but as I didn't find a nice constant for this I opted for the dynamic one. The problem with the 'yyyy' pattern is that this is not the only pattern. year : "yyyyy", "yyyy", "yy", "y" month : "MMMM", "MMM", "MM", "M" This for example "yyyy maybe MMMM" produces "2007 may7be April" in the title. (There is a limit to what can be used for LOCALE_SYEARMONTH though.) > all locale data, but we currently use much shorter in some cases - about > 10, 30 or so. Unfortunately there's no way to check this max length > value, cause it's more like a max resource length. Anyway I'm going to > use this value in next patch set maybe cause it's documented at least > and isn't so magic like ours). >> >> The 3 tests I removed with the first patch can be removed safely as >> all should be tested in the loop. >> >> Now I need to change the way we test to cope with: >> - order of year/month > Ok. >> - text right after the prev button or right before the next button > Not sure what you mean here. Isn't it the same as order? If you change the regional settings to Portuguese (on a Windows box) you see what I mean. There is no room between the buttons and the text. -- Cheers, Paul.

Oct. 1, 2009

Re: [comctl32/tests] Fix some test failures

by Nikolay Sivov

Paul Vriens wrote: > On 10/01/2009 03:12 PM, Paul Vriens wrote: >> On 10/01/2009 02:58 PM, Nikolay Sivov wrote: >>> Yes, please. If a problem is only in rectangle orders it's very simple >>> to fix (test for yyyy in returned locale data). I suggest not to drop >>> tests yet, we'll probably want to drop them later when trying probable >>> dpi-dependent failures. >> >> Well I need to test for all possible occurrences of month and year. So >> something like: >> >> /* Get the format of the title */ >> len = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, NULL, 0); >> yearmonth = HeapAlloc(GetProcessHeap(), 0, len); >> GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, yearmonth, len); >> /* Find out the order */ >> year = strstr(yearmonth, "y"); >> month = strstr(yearmonth, "M"); >> >> if (month < year) trace("Month before year\n"); >> else trace("Year before month\n"); >> HeapFree(GetProcessHeap(), 0, yearmonth); >> >> The 3 tests I removed with the first patch can be removed safely as all >> should be tested in the loop. >> >> Now I need to change the way we test to cope with: >> - order of year/month >> - text right after the prev button or right before the next button >> > > Oh and it's also possible to not have any room between year and month: > > SetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, "yyyyMMMM"); Yes, but this is a system wide setting, I don't know is it ok to do such things in tests.

Oct. 1, 2009

Re: [comctl32/tests] Fix some test failures

by Nikolay Sivov

Paul Vriens wrote: > On 10/01/2009 02:58 PM, Nikolay Sivov wrote: >> Yes, please. If a problem is only in rectangle orders it's very simple >> to fix (test for yyyy in returned locale data). I suggest not to drop >> tests yet, we'll probably want to drop them later when trying probable >> dpi-dependent failures. > > Well I need to test for all possible occurrences of month and year. So > something like: > > /* Get the format of the title */ > len = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, NULL, 0); > yearmonth = HeapAlloc(GetProcessHeap(), 0, len); > GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, yearmonth, len); > /* Find out the order */ > year = strstr(yearmonth, "y"); > month = strstr(yearmonth, "M"); > > if (month < year) trace("Month before year\n"); > else trace("Year before month\n"); > HeapFree(GetProcessHeap(), 0, yearmonth); Yes, not all possible actually, only month < year condition matters. It's better to use yyyy pattern cause some locales add extra words in this format string. Also a static char[80] buffer should be used to simplify things (btw, MSDN says about 80 character length for all locale data, but we currently use much shorter in some cases - about 10, 30 or so. Unfortunately there's no way to check this max length value, cause it's more like a max resource length. Anyway I'm going to use this value in next patch set maybe cause it's documented at least and isn't so magic like ours). > > The 3 tests I removed with the first patch can be removed safely as > all should be tested in the loop. > > Now I need to change the way we test to cope with: > - order of year/month Ok. > - text right after the prev button or right before the next button Not sure what you mean here. Isn't it the same as order?

Oct. 1, 2009

Re: [comctl32/tests] Fix some test failures

by Paul Vriens

On 10/01/2009 03:12 PM, Paul Vriens wrote: > On 10/01/2009 02:58 PM, Nikolay Sivov wrote: >> Yes, please. If a problem is only in rectangle orders it's very simple >> to fix (test for yyyy in returned locale data). I suggest not to drop >> tests yet, we'll probably want to drop them later when trying probable >> dpi-dependent failures. > > Well I need to test for all possible occurrences of month and year. So > something like: > > /* Get the format of the title */ > len = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, NULL, 0); > yearmonth = HeapAlloc(GetProcessHeap(), 0, len); > GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, yearmonth, len); > /* Find out the order */ > year = strstr(yearmonth, "y"); > month = strstr(yearmonth, "M"); > > if (month < year) trace("Month before year\n"); > else trace("Year before month\n"); > HeapFree(GetProcessHeap(), 0, yearmonth); > > The 3 tests I removed with the first patch can be removed safely as all > should be tested in the loop. > > Now I need to change the way we test to cope with: > - order of year/month > - text right after the prev button or right before the next button > Oh and it's also possible to not have any room between year and month: SetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_SYEARMONTH, "yyyyMMMM"); -- Cheers, Paul.

Oct. 1, 2009