October 2009 - Wine-Devel - list.winehq.org

Re: [comctl32/tests] Fix some test failures

by Paul Vriens

On 10/01/2009 12:29 PM, Paul Vriens wrote: > Hi, > > Instead of checking fixed points in the title we now check for the order > of items only. > > I didn't cater for locale differences on Windows (as I don't have a way > to test), so I'm going to rely on test.winehq.org after this patch has > been applied (if, of course). > > The test could be easily extended if we know for a fact that items > should be at a fixed place (or by calculating text width, button width > an such). > > Changelog > Fix some test failures > FWIW, changing the regional settings on a Windows box does change the title of the calendar. Setting it to Portuguese shows that the name of the month is longer than expected and hence the hittests don't work as it was before. This patch also succeeds on the Portuguese settings (tested on W2K3). -- Cheers, Paul.

Oct. 1, 2009

Re: dwmapi: Add a stub for DwmGetGraphicsStreamTransformHint.

by Alexandre Julliard

Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> writes: > --- > dlls/dwmapi/dwmapi.spec | 2 +- > dlls/dwmapi/dwmapi_main.c | 9 +++++++++ > 2 files changed, 10 insertions(+), 1 deletions(-) Please build a proper numbered series, where each patch is relative to the previous one. -- Alexandre Julliard julliard(a)winehq.org

Oct. 1, 2009

Re: tools/winebuild: add FreeBSD support (1/2) (RESEND) (fwd)

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ I'd like to ping this after three weeks. This fixes a real bug > that has reported by a user. Any chance to get it in, or do you > need to see this changed somehow? ] Looks ok but the patch doesn't apply. When resubmitting a patch you have to rebase on current git first. -- Alexandre Julliard julliard(a)winehq.org

Oct. 1, 2009

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

by Paul Vriens

On 10/01/2009 09:58 AM, Nikolay Sivov wrote: > Paul Vriens wrote: >> On 09/30/2009 12:10 PM, Nikolay Sivov wrote: >>> Paul Vriens wrote: >>>> On 09/29/2009 12:36 PM, Nikolay Sivov wrote: >>>>> Changelog: >>>>> - be sure we have a single view calendar for hittesting >>>>> >>>>> >>>>> ------------------------------------------------------------------------ >>>>> >>>>> >>>>> >>>> Hi Nikolay, >>>> >>>> This one introduces a test failure on several platforms: >>>> >>>> monthcal.c:1002: Test failed: Expected 10000, got 10002 >>>> >>>> I fixed it on my NT4 box by checking the point more to the left (see >>>> attached). >>>> >>>> I somehow doubt it's the correct fix though. Aren't these tests with >>>> more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? >>>> >>> Hi, Paul. >>> >>> I certainly noticed that. A problem for me is that it doesn't fail on >>> mine XP. Could you please send me (offlist) a crossbuilt binary with >>> this patch - I'm not able to built it myself at the moment. >>> >>> About fragility of these test - it was a reason why I use dynamic point >>> calculation here, it was fixed before. So now it should be less dpi/font >>> dependent I hope. It isn't affected by locale too much I think. >>> >> >> Doing a little bit of testing (doing a hittest on the full range) >> shows subtle differences between for example my NT4 and W2K3 box. The >> W2K3 calendar shows "April, 2009" where NT4 shows "April 2009". >> >> Looking at >> http://test.winehq.org/data/3fe20bdc7ea59b3e5711bed26d86c433109b21e7/xp_af-… >> >> even seems to indicate that with this locale the year is shown before >> the month? >> >> I'm wondering what a good test would be (that covers all cases) or >> whether most of these tests should be dropped? >> >> A normal order should be for "April 2009": >> >> - MCHT_TITLE >> - MCHT_TITLEBTNPREV >> - MCHT_TITLE >> - MCHT_TITLEMONTH >> - MCHT_TITLE >> - MCHT_TITLEYEAR >> - MCHT_TITLE >> - MCHT_TITLEBTNNEXT >> - MCHT_TITLE >> >> (That box mentioned would have MCHT_TITLEMONTH and MCHT_TITLEYEAR the >> other way around). >> >> Maybe testing the order (both variations) would be fine enough? >> >> Any thoughts? >> > If some locales do this rectangles permutation it's another bug in Wine > code, we currently don't depend on locale at this point. > > Maybe you're right and we should add alternate hittesting codes for a > test results structure and make it differ on month/year cases. > When Wine got support for this it will fail without such changes on it > as well. So patch it please if you have time now. I'll see what I can come up with, although probably later today. > > P.S. how could I change a locale on my Debian system for particular Wine > run? Could you help me with that? What I usually do is something like LC_ALL=nl_NL.UTF-8 wine .... or LC_ALL=nl_NL.UTF-8 make monthcal.ok More lang references can be found at http://wiki.winehq.org/TestingLanguages -- Cheers, Paul.

Oct. 1, 2009

Re: sti: add stubs for the IStillImageW interface (try 2)

by Henri Verbeet

2009/9/30 Damjan Jovanovic <damjan.jov(a)gmail.com>: > Changelog: > * sti: add stubs for the IStillImageW interface (try 2) > This leaks, you need to return the internal IUnknown to the caller somehow. I think an explicit QueryInterface for IUnknown is supposed to return lpInternalUnkVtbl, and StiCreateInstanceW() probably as well when the object is being aggregated.

Oct. 1, 2009

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

by Nikolay Sivov

Paul Vriens wrote: > On 09/30/2009 12:10 PM, Nikolay Sivov wrote: >> Paul Vriens wrote: >>> On 09/29/2009 12:36 PM, Nikolay Sivov wrote: >>>> Changelog: >>>> - be sure we have a single view calendar for hittesting >>>> >>>> >>>> ------------------------------------------------------------------------ >>>> >>>> >>>> >>> Hi Nikolay, >>> >>> This one introduces a test failure on several platforms: >>> >>> monthcal.c:1002: Test failed: Expected 10000, got 10002 >>> >>> I fixed it on my NT4 box by checking the point more to the left (see >>> attached). >>> >>> I somehow doubt it's the correct fix though. Aren't these tests with >>> more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? >>> >> Hi, Paul. >> >> I certainly noticed that. A problem for me is that it doesn't fail on >> mine XP. Could you please send me (offlist) a crossbuilt binary with >> this patch - I'm not able to built it myself at the moment. >> >> About fragility of these test - it was a reason why I use dynamic point >> calculation here, it was fixed before. So now it should be less dpi/font >> dependent I hope. It isn't affected by locale too much I think. >> > > Doing a little bit of testing (doing a hittest on the full range) > shows subtle differences between for example my NT4 and W2K3 box. The > W2K3 calendar shows "April, 2009" where NT4 shows "April 2009". > > Looking at > http://test.winehq.org/data/3fe20bdc7ea59b3e5711bed26d86c433109b21e7/xp_af-… > > even seems to indicate that with this locale the year is shown before > the month? > > I'm wondering what a good test would be (that covers all cases) or > whether most of these tests should be dropped? > > A normal order should be for "April 2009": > > - MCHT_TITLE > - MCHT_TITLEBTNPREV > - MCHT_TITLE > - MCHT_TITLEMONTH > - MCHT_TITLE > - MCHT_TITLEYEAR > - MCHT_TITLE > - MCHT_TITLEBTNNEXT > - MCHT_TITLE > > (That box mentioned would have MCHT_TITLEMONTH and MCHT_TITLEYEAR the > other way around). > > Maybe testing the order (both variations) would be fine enough? > > Any thoughts? > If some locales do this rectangles permutation it's another bug in Wine code, we currently don't depend on locale at this point. Maybe you're right and we should add alternate hittesting codes for a test results structure and make it differ on month/year cases. When Wine got support for this it will fail without such changes on it as well. So patch it please if you have time now. P.S. how could I change a locale on my Debian system for particular Wine run? Could you help me with that?

Oct. 1, 2009

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

by Paul Vriens

On 09/30/2009 12:10 PM, Nikolay Sivov wrote: > Paul Vriens wrote: >> On 09/29/2009 12:36 PM, Nikolay Sivov wrote: >>> Changelog: >>> - be sure we have a single view calendar for hittesting >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >> Hi Nikolay, >> >> This one introduces a test failure on several platforms: >> >> monthcal.c:1002: Test failed: Expected 10000, got 10002 >> >> I fixed it on my NT4 box by checking the point more to the left (see >> attached). >> >> I somehow doubt it's the correct fix though. Aren't these tests with >> more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? >> > Hi, Paul. > > I certainly noticed that. A problem for me is that it doesn't fail on > mine XP. Could you please send me (offlist) a crossbuilt binary with > this patch - I'm not able to built it myself at the moment. > > About fragility of these test - it was a reason why I use dynamic point > calculation here, it was fixed before. So now it should be less dpi/font > dependent I hope. It isn't affected by locale too much I think. > Doing a little bit of testing (doing a hittest on the full range) shows subtle differences between for example my NT4 and W2K3 box. The W2K3 calendar shows "April, 2009" where NT4 shows "April 2009". Looking at http://test.winehq.org/data/3fe20bdc7ea59b3e5711bed26d86c433109b21e7/xp_af-… even seems to indicate that with this locale the year is shown before the month? I'm wondering what a good test would be (that covers all cases) or whether most of these tests should be dropped? A normal order should be for "April 2009": - MCHT_TITLE - MCHT_TITLEBTNPREV - MCHT_TITLE - MCHT_TITLEMONTH - MCHT_TITLE - MCHT_TITLEYEAR - MCHT_TITLE - MCHT_TITLEBTNNEXT - MCHT_TITLE (That box mentioned would have MCHT_TITLEMONTH and MCHT_TITLEYEAR the other way around). Maybe testing the order (both variations) would be fine enough? Any thoughts? -- Cheers, Paul.

Oct. 1, 2009