November 2009 - Wine-Devel - list.winehq.org

Re: Link to Test Runs

by Nate Gallaher

Tests can be found at test.winehq.org Mike wrote: > Ok, I found this once before but I can't find it again. Where is the link to the test runs for different platforms, etc. I wanted to see if my tests passed Win 95. > > Sorry for asking questions that should probably be obvious, but we all start ignorant and some of us more ignorant and naive than others. > > Thanks, > Mikey > > > > > >

Nov. 6, 2009

Link to Test Runs

by Mike

Ok, I found this once before but I can't find it again. Where is the link to the test runs for different platforms, etc. I wanted to see if my tests passed Win 95. Sorry for asking questions that should probably be obvious, but we all start ignorant and some of us more ignorant and naive than others. Thanks, Mikey

Nov. 6, 2009

Re: shell32/tests: Add Program Manager DDE Conformance Tests (try 2)

by Mike

Didn't copy first response to the devel list. Took an initial look and I think I know what is going on. I will try and get a patch finished by the end of the weekend to correct these. --- On Fri, 11/6/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: shell32/tests: Add Program Manager DDE Conformance Tests (try 2) > To: "Mikey Alexander" <firesword14(a)yahoo.com> > Cc: wine-devel(a)winehq.org > Date: Friday, November 6, 2009, 12:43 AM > On 11/03/2009 04:32 AM, Mike wrote: > > These conformance tests are for the program manager > dde. Basic operations are tested. The current > wine implementation (shell32/dde.c) of the Program Manager > DDE is stubbed. This conformance tests were run and > passed on Win 98 SE and Win XP SP2. Related Bug #9159 > > > > > > --- > > dlls/shell32/tests/Makefile.in | > 1 + > > dlls/shell32/tests/progman_dde.c > | 551 ++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 552 insertions(+), 0 > deletions(-) > > create mode 100644 > dlls/shell32/tests/progman_dde.c > > > > > > Hi Mikey, > > These new tests introduce test failures on different > platforms: > > http://test.winehq.org/data/tests/shell32:progman_dde.html > > Could you have a look? > > -- > Cheers, > > Paul. >

Nov. 6, 2009

To error out or to skip tests?

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, I apologize for the numerous occurrances of red color on test.winehq due to my new winmm MCI tests. That was not expected. However, turning something green is not a goal in itself. For some time now I wanted to query wine-devel about this topic, independently of my patches, so here it goes. An analysis reveals that my tests implement a detector of vmware (virtualbox etc.) default installs, i.e. MS-Windows systems that have not been configured with sound. No real user's machines would be like that (except for a w95 box I tried with a broken soundcard). The revealing line is > Tests skipped: Please install audio driver. Tests will fail (18 errors) This goes hand in hand with "5 tests, 0 errors, 1 skip" in winmm:wave. Exactly those systems skipping the wave tests produce 18-19 MCI errors. Failure to flag an error in such cases has known drawbacks: - For several month, Austin did not notice that his BSD boxes had lost sound. wave.ok simply reports "5 tests ok, 1 skipped" in joyfull green, whereas it executed many tests half a year ago. - All those vmware boxes configured without sound and thus skipping all but 5 wave.ok tests have for monthes *not* provided valuable feedback to Wine. So they were actually *not* executing tests, when they could have. It's only when Paul tested one of my tests that he realized that sound was not configured on one of his vmware boxes, promptly configured the sound device, and the tests passed. The picture on test.winehq.org is a disaster: None of the w95, w98, nt4, 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests! They all have no sound configured. Mostly useless. Therefore, I believe it's sometimes better to flag an error than to calmly skip something. Last year already, submitting the ICCVID patches, I was thinking: "iccvid.dll may not part of every installation, but we want feedback so we should compare behaviour with MS-Windows systems equipped with that library and ask people to install it if not present". Likewise, Wine should compare with systems similarly equipped: d3d8, d3d9, dplay, dmusic etc. Perhaps an easy change on test.winehq would be to augment the blue color indicator of skipped tests to the full rectangle surface instead of the current green? Of course, I'll change my tests to flag a single error on systems without sound. -- Or no error at all, if that's wine-devel consensus. What do you think? Jörg Höhle. There's only few real MCI test errors I saw on test.winehq: the system "fg_winxp-ie8" that yields 1 error instead of 18: mci.c:391: Test failed: not enough time elapsed 80ms -- a flakey test. And on the ME systems: mci.c:603: Test failed: mci re-auto-open status mode returned error: 275 mci.c:612: Test failed: mci auto-open pause returned error: 275 Luckily, there are a few machines that pass all tests.

Nov. 6, 2009

Re: winmm/tests: Add MCI waveaudio tests.

by Paul Vriens

On 11/05/2009 02:35 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > this is the same as yesterday's patch except that I replaced the > ad-hoc skip auto-open test with one that specifically detects Wine's > missing auto-open functionality instead of another thing missing in Wine. > You will prefer that version; sorry for the quick-shot. > > Regards, > Jörg Höhle. > Hi Jörg, This one introduces several test failures: http://test.winehq.org/data/tests/winmm:mci.html I guess you already noticed, but could you have a look? -- Cheers, Paul.

Nov. 6, 2009

Re: shell32/tests: Add Program Manager DDE Conformance Tests (try 2)

by Paul Vriens

On 11/03/2009 04:32 AM, Mike wrote: > These conformance tests are for the program manager dde. Basic operations are tested. The current wine implementation (shell32/dde.c) of the Program Manager DDE is stubbed. This conformance tests were run and passed on Win 98 SE and Win XP SP2. Related Bug #9159 > > > --- > dlls/shell32/tests/Makefile.in | 1 + > dlls/shell32/tests/progman_dde.c | 551 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 552 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/progman_dde.c > > Hi Mikey, These new tests introduce test failures on different platforms: http://test.winehq.org/data/tests/shell32:progman_dde.html Could you have a look? -- Cheers, Paul.

Nov. 6, 2009

Re: had trouble compiling today

by Susan Cragin

>Looks like a gcc compiler bug, so you will need to report it there >and/or to the Ubuntu bug tracker. > >Out of interest: > a/ did this work when you were running karmic? Yes. Worked always with Karmic. Worked yesterday with Lucid. But downloaded new gcc today, and new git. So it's one or the other. > b/ what does "gcc --version" produce? gcc (Ubuntu 4.4.2-1ubuntu3) 4.4.2 > c/ is this an incremental build from a previous build on karmic? Yes. (In fact, it's pre-alpha lucid.) It may well be that there is a new gcc that depends on a new something else that hasn't been released yet. > d/ what happens if you clean out all build files (running "git >clean -fxd" in ~/wine will do this if ~/wine is a clone of the wine >git repository) and do a build -- does that resolve the issue? Oh, that's a nice command. I'll have to remember that one. Nothing happens. >NOTE: You should still report this to gcc/Ubuntu. Noted. Reported. Bug filed. >- Reece As I was getting ready to send this I noted another gcc floating by aptitude, so I gave that one a spin. No luck. The problem persists, but I bet the developers know about it.

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by David Laight

On Thu, Nov 05, 2009 at 02:21:47PM +0100, Yann Droneaud wrote: > And OpenBSD won't allow page 0 mapping for security reasons (and > performance reasons). > > Since Wine seems to be working on other *BSD and derivative systems, > is this a problem ? NetBSD is likely to disable user space mapping of address 0 some time in the near future - it does have problems with the compatibility code for other unix system binariess though (I can't remember which ones, compat-ultrix might be the one). David -- David Laight: david(a)l8s.co.uk

Nov. 5, 2009

Re: had trouble compiling today

by Reece Dunn

2009/11/5 Susan Cragin <susancragin(a)earthlink.net>: > It may be me. I've upgraded to Lucid Lynx. > My compile failed. > > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o int21.o int21.c > int21.c: In function ‘INT21_GetDriveAllocInfo’: > int21.c:3556: internal compiler error: in int_cst_value, at tree.c:8305 > Please submit a full bug report, > with preprocessed source if appropriate. > See <file:///usr/share/doc/gcc-4.4/README.Bugs> for instructions. Looks like a gcc compiler bug, so you will need to report it there and/or to the Ubuntu bug tracker. Out of interest: a/ did this work when you were running karmic? b/ what does "gcc --version" produce? c/ is this an incremental build from a previous build on karmic? d/ what happens if you clean out all build files (running "git clean -fxd" in ~/wine will do this if ~/wine is a clone of the wine git repository) and do a build -- does that resolve the issue? NOTE: You should still report this to gcc/Ubuntu. - Reece

Nov. 5, 2009

had trouble compiling today

by Susan Cragin

It may be me. I've upgraded to Lucid Lynx. My compile failed. gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o int21.o int21.c int21.c: In function ‘INT21_GetDriveAllocInfo’: int21.c:3556: internal compiler error: in int_cst_value, at tree.c:8305 Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.4/README.Bugs> for instructions. make[2]: *** [int21.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/winedos' make[1]: *** [winedos] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls] Error 2 susan(a)ubuntu:~/wine$

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by Mihai Donțu

On Thursday 05 November 2009 19:44:47 David Gerard wrote: > 2009/11/5 Mihai Donțu <mihai.dontu(a)gmail.com>: > > I've never been able to run a dos program in Wine, but I've never asked > > myself why because I always had an alternative. > > DOSbox is a much better DOS than Wine is ever likely to be. > > Do Win32 console apps run okay in Wine without the page 0 mapping? I > I use wine to run the Microsoft Visual Studio Express compiler (cl.exe). So far I hadn't had any problems. > ask because in my last job, we actually used Wine to run a Win32 > console app on RHEL4 to save installing another Windows box. Never let > anyone tell you Wine isn't ready for the enterprise ;-) > -- Mihai Donțu

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by David Gerard

2009/11/5 Mihai Donțu <mihai.dontu(a)gmail.com>: > I've never been able to run a dos program in Wine, but I've never asked myself > why because I always had an alternative. DOSbox is a much better DOS than Wine is ever likely to be. Do Win32 console apps run okay in Wine without the page 0 mapping? I ask because in my last job, we actually used Wine to run a Win32 console app on RHEL4 to save installing another Windows box. Never let anyone tell you Wine isn't ready for the enterprise ;-) - d.

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by Mihai Donțu

On Thursday 05 November 2009 18:31:52 Yann Droneaud wrote: > Le jeudi 05 novembre 2009 à 17:01 +0100, Marcus Meissner a écrit : > > On Thu, Nov 05, 2009 at 02:21:47PM +0100, Yann Droneaud wrote: > > > Hi, > > > > > > In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt > > > is criticising Linux page 0 handling. > > > He argue that Linux allows page 0 mapping only for Wine. > > > And OpenBSD won't allow page 0 mapping for security reasons (and > > > performance reasons). > > > > > > Since Wine seems to be working on other *BSD and derivative systems, > > > is this a problem ? > > > > > > Could someone comment on this issue. I don't find anything related on > > > <http://wiki.winehq.org/OpenBSD> > > > > Its actually not a real problem for Wine, last years code works without > > NULL pages. > > It seems many people thinks Wine needs to mmap the page 0 to run common > application. > > Does Wine 1.0 need it ? > > If not, it's really a myth. > # sysctl vm.mmap_min_addr vm.mmap_min_addr = 4096 and wine works like a charm. > > Our DOS emulator requires it, as vm86() mode uses 0 based mapping, > > so DOS programs won't work afterwards. But otherwise I see no dependency. > > (Perhaps Win16, but I dont think so.) > I've never been able to run a dos program in Wine, but I've never asked myself why because I always had an alternative. > According to this post from Alexandre Julliard, win16 don't need it. > > http://old.nabble.com/Re%3A-vm86-mode-is-not-supported-p23884662.html > > Perhaps it could be good point if there's a way to disable DOS emulator > at build time ? > -- Mihai Donțu

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by Marcus Meissner

On Thu, Nov 05, 2009 at 05:31:52PM +0100, Yann Droneaud wrote: > Le jeudi 05 novembre 2009 à 17:01 +0100, Marcus Meissner a écrit : > > On Thu, Nov 05, 2009 at 02:21:47PM +0100, Yann Droneaud wrote: > > > Hi, > > > > > > In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt is > > > criticising Linux page 0 handling. > > > He argue that Linux allows page 0 mapping only for Wine. > > > And OpenBSD won't allow page 0 mapping for security reasons (and > > > performance reasons). > > > > > > Since Wine seems to be working on other *BSD and derivative systems, > > > is this a problem ? > > > > > > Could someone comment on this issue. I don't find anything related on > > > <http://wiki.winehq.org/OpenBSD> > > > > Its actually not a real problem for Wine, last years code works without > > NULL pages. > > > > It seems many people thinks Wine needs to mmap the page 0 to run common > application. > > Does Wine 1.0 need it ? > > If not, it's really a myth. I installed 1.0.1 , enabled mmap_min_addr protectionm ... Testcase: Firefox 3.5.4 ... installs and runs nicely. (OK, I had some crashes after Flash Player installation for youtube, but youtube plays). > According to this post from Alexandre Julliard, win16 don't need it. > > http://old.nabble.com/Re%3A-vm86-mode-is-not-supported-p23884662.html > > Perhaps it could be good point if there's a way to disable DOS emulator o> at build time ? You do not know that at build time. My WINE rpms build for i586 can be run on i586 and x86_64 machines. Ciao, Marcus

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by Yann Droneaud

Le jeudi 05 novembre 2009 à 17:01 +0100, Marcus Meissner a écrit : > On Thu, Nov 05, 2009 at 02:21:47PM +0100, Yann Droneaud wrote: > > Hi, > > > > In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt is > > criticising Linux page 0 handling. > > He argue that Linux allows page 0 mapping only for Wine. > > And OpenBSD won't allow page 0 mapping for security reasons (and > > performance reasons). > > > > Since Wine seems to be working on other *BSD and derivative systems, > > is this a problem ? > > > > Could someone comment on this issue. I don't find anything related on > > <http://wiki.winehq.org/OpenBSD> > > Its actually not a real problem for Wine, last years code works without > NULL pages. > It seems many people thinks Wine needs to mmap the page 0 to run common application. Does Wine 1.0 need it ? If not, it's really a myth. > > Our DOS emulator requires it, as vm86() mode uses 0 based mapping, > so DOS programs won't work afterwards. But otherwise I see no dependency. > (Perhaps Win16, but I dont think so.) > According to this post from Alexandre Julliard, win16 don't need it. http://old.nabble.com/Re%3A-vm86-mode-is-not-supported-p23884662.html Perhaps it could be good point if there's a way to disable DOS emulator at build time ? Regards -- Yann Droneaud

Nov. 5, 2009

Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

by Juan Lang

> Checking the return value of CryptAcquireContextW() is also possible but I > took the path of minimal change in the source. The change I suggest would be small too. > Besides, I consider passing pointers to uninitialized variables a bad > programming practice. Not when they're out pointers. --Juan

Nov. 5, 2009

Re: Wine on OpenBSD, Theo de Raadt

by Marcus Meissner

On Thu, Nov 05, 2009 at 02:21:47PM +0100, Yann Droneaud wrote: > Hi, > > In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt is > criticising Linux page 0 handling. > He argue that Linux allows page 0 mapping only for Wine. > And OpenBSD won't allow page 0 mapping for security reasons (and > performance reasons). > > Since Wine seems to be working on other *BSD and derivative systems, > is this a problem ? > > Could someone comment on this issue. I don't find anything related on > <http://wiki.winehq.org/OpenBSD> Its actually not a real problem for Wine, last years code works without NULL pages. Our DOS emulator requires it, as vm86() mode uses 0 based mapping, so DOS programs won't work afterwards. But otherwise I see no dependency. (Perhaps Win16, but I dont think so.) Ciao, Marcus

Nov. 5, 2009

Wine on OpenBSD, Theo de Raadt

by Yann Droneaud

Hi, In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt is criticising Linux page 0 handling. He argue that Linux allows page 0 mapping only for Wine. And OpenBSD won't allow page 0 mapping for security reasons (and performance reasons). Since Wine seems to be working on other *BSD and derivative systems, is this a problem ? Could someone comment on this issue. I don't find anything related on <http://wiki.winehq.org/OpenBSD> Regards. -- Yann Droneaud

Nov. 5, 2009

Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

by Paul Chitescu

On Wednesday 04 November 2009 11:45:38 pm Juan Lang wrote: > Hi Paul, > > I imagine this is to avoid checking prov if CryptAcquireContextW > fails. In that case, wouldn't it be better to check the return value > of CryptAcquireContextW? > --Juan Checking the return value of CryptAcquireContextW() is also possible but I took the path of minimal change in the source. Besides, I consider passing pointers to uninitialized variables a bad programming practice. Paul

Nov. 5, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Paul Vriens

On 11/05/2009 10:11 AM, Paul Vriens wrote: > On 11/04/2009 09:45 PM, Reece Dunn wrote: >> 2009/11/4 Paul Vriens<paul.vriens.wine(a)gmail.com>: >>> Hi, >>> >>> Just noticed that we have 1 test failure on Vista+ for the >>> advapi32/eventlog >>> tests. I was sure I've tested these from Win95 up to Win7. >>> >>> When I run tests I want to do this as Administrator, so on Vista+ I >>> select >>> 'Run as Administrator' to start a command prompt, or to launch winetest. >>> >>> Running the mentioned crosscompiled tests is no problem unless you do >>> this >>> from the actual home directory (or any subdirectory) of the user that >>> logged >>> in. >>> >>> Winetest runs most of it's test in the %TEMP% directory and hence we see >>> this failure. But I have no clue why (yet). >>> >>> Anyone? >> > > Hi Reece, > >> Ah, I see. This is the failure on test.winehq.org, correct? > > Yes. I'm in the process of writing loads of eventlog tests while keeping > track of possible failures on test.winehq.org. > >> >> eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5 >> >> 5 is ERROR_ACCESS_DENIED. >> >> The create_backup function does not have any error checking -- what >> happens when you put the return values for these calls, and the >> GetLastError in ok checks, e.g. >> >> ok(DeleteFileA(filename), "error deleting the backup event log file"); >> ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS, >> got %d", GetLastError()); >> >> - Reece > > Deleting the file works just fine. both in create_backup() and > test_clear(). > > What makes it even more weird is that I have the same error when I run > these tests as the user (not admin). > > I also don't get any UAC prompts in either case. Turning UAC off doesn't > make a difference. > > I don't see any logical explanation why the function returns a different > error. The fact that the function fails anyway makes me consider using a > second possible last error for that particular test. > Found it. The eventlog service runs under an account that doesn't have the necessary rights for a users home directory. This account is the actual one performing some of the actions. -- Cheers, Paul.

Nov. 5, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Paul Vriens

On 11/04/2009 09:45 PM, Reece Dunn wrote: > 2009/11/4 Paul Vriens<paul.vriens.wine(a)gmail.com>: >> Hi, >> >> Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog >> tests. I was sure I've tested these from Win95 up to Win7. >> >> When I run tests I want to do this as Administrator, so on Vista+ I select >> 'Run as Administrator' to start a command prompt, or to launch winetest. >> >> Running the mentioned crosscompiled tests is no problem unless you do this >> from the actual home directory (or any subdirectory) of the user that logged >> in. >> >> Winetest runs most of it's test in the %TEMP% directory and hence we see >> this failure. But I have no clue why (yet). >> >> Anyone? > Hi Reece, > Ah, I see. This is the failure on test.winehq.org, correct? Yes. I'm in the process of writing loads of eventlog tests while keeping track of possible failures on test.winehq.org. > > eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5 > > 5 is ERROR_ACCESS_DENIED. > > The create_backup function does not have any error checking -- what > happens when you put the return values for these calls, and the > GetLastError in ok checks, e.g. > > ok(DeleteFileA(filename), "error deleting the backup event log file"); > ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS, > got %d", GetLastError()); > > - Reece Deleting the file works just fine. both in create_backup() and test_clear(). What makes it even more weird is that I have the same error when I run these tests as the user (not admin). I also don't get any UAC prompts in either case. Turning UAC off doesn't make a difference. I don't see any logical explanation why the function returns a different error. The fact that the function fails anyway makes me consider using a second possible last error for that particular test. -- Cheers, Paul.

Nov. 5, 2009

Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

by Juan Lang

Hi Paul, I imagine this is to avoid checking prov if CryptAcquireContextW fails. In that case, wouldn't it be better to check the return value of CryptAcquireContextW? --Juan

Nov. 4, 2009

Comment request: wineconsole: Fix Alt+F10 sent when F10 pressed.

by Erich Hoover

I thought this patch was pretty straightforward, comments? http://www.winehq.org/pipermail/wine-patches/2009-October/080779.html Erich Hoover ehoover(a)mines.edu

Nov. 4, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Reece Dunn

2009/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prompt, or to launch winetest. > > Running the mentioned crosscompiled tests is no problem unless you do this > from the actual home directory (or any subdirectory) of the user that logged > in. > > Winetest runs most of it's test in the %TEMP% directory and hence we see > this failure. But I have no clue why (yet). > > Anyone? Ah, I see. This is the failure on test.winehq.org, correct? eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5 5 is ERROR_ACCESS_DENIED. The create_backup function does not have any error checking -- what happens when you put the return values for these calls, and the GetLastError in ok checks, e.g. ok(DeleteFileA(filename), "error deleting the backup event log file"); ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS, got %d", GetLastError()); - Reece

Nov. 4, 2009

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet

by Eric Pouech

Paul Bolle a écrit : > Add support for the qAttached packet. Main benefit is that if gdb was > attached to a debuggee and it quits it will now ask if it should detach > from the debuggee instead of asking whether the debuggee should be > killed. (It still will ask whether the debuggee should be killed if it > launched the debuggee itself). > > Signed-off-by: Paul Bolle <pebolle(a)tiscali.nl> > --- > Would it be better to add a new member to gdbctx instead of using a > separate variable (qAttached_reply)? > yes, inclusion in gdbctx is preferred (and storage should rather be an integer rather than a string pointer) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Nov. 4, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Reece Dunn

2009/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prompt, or to launch winetest. > > Running the mentioned crosscompiled tests is no problem unless you do this > from the actual home directory (or any subdirectory) of the user that logged > in. > > Winetest runs most of it's test in the %TEMP% directory and hence we see > this failure. But I have no clue why (yet). > > Anyone? What are the errors you are experiencing? Are you getting access denied errors? If so, it may be due to the different file access permissions. What happens when you create/delete the files produced by winetest in the %TEMP% directory in the explorer GUI? Do you get/need a UAC prompt for it to work? Have you tried adding UAC information to the manifest if this is the case? Sorry I can't help out any further as I abandoned Vista a long time ago ^_^. - Reece

Nov. 4, 2009

Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Paul Vriens

Hi, Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog tests. I was sure I've tested these from Win95 up to Win7. When I run tests I want to do this as Administrator, so on Vista+ I select 'Run as Administrator' to start a command prompt, or to launch winetest. Running the mentioned crosscompiled tests is no problem unless you do this from the actual home directory (or any subdirectory) of the user that logged in. Winetest runs most of it's test in the %TEMP% directory and hence we see this failure. But I have no clue why (yet). Anyone? -- Cheers, Paul.

Nov. 4, 2009

Re: winex11.drv: Implement FIXME in AlphaBlend

by Roderick Colenbrander

Hi Peter, I didn't see this patch before because I was away at that time. The SourceConstantAlpha part looks correct to me. It might make sense to calculate blendfn.SourceConstantAlpha / 255 before the loop, so that it isn't recalculated each time. The other half of your patch is a separate change and it would require a separate patch. The part looks suspicious though. I don't understand why you need special locking there. Roderick On Mon, Oct 26, 2009 at 4:39 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > > > commit df78de34a06e32be9f37a3b34fe68e5b088a8578 > Author: Peter Urbanec <winehq.org(a)urbanec.net> > Date: Mon Oct 26 21:29:00 2009 +1100 > > Implement source alpha plus SourceConstantAlpha combined transparency. > Add DIB locking to prevent node icon rendering errors in Fusion composition flow views. > > diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c > index 90503bf..26dc262 100644 > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -1956,9 +1956,6 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > return FALSE; > } > > - if ((blendfn.AlphaFormat & AC_SRC_ALPHA) && blendfn.SourceConstantAlpha != 0xff) > - FIXME("Ignoring SourceConstantAlpha %d for AC_SRC_ALPHA\n", blendfn.SourceConstantAlpha); > - > if(dib.dsBm.bmBitsPixel != 32) { > FIXME("not a 32 bpp dibsection\n"); > return FALSE; > @@ -1979,11 +1976,35 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > if (blendfn.AlphaFormat & AC_SRC_ALPHA) > { > - for(; y >= y2; y--) > + if (blendfn.SourceConstantAlpha == 0xff) > { > - memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > + for(; y >= y2; y--) > + { > + memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > widthSrc * 4); > - dstbits += (top_down ? -1 : 1) * widthSrc; > + dstbits += (top_down ? -1 : 1) * widthSrc; > + } > + } > + else > + { > + /* Source alpha plus SourceConstantAlpha */ > + for(; y >= y2; y--) > + { > + int x; > + DWORD *srcbits = (DWORD *)((char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes) + xSrc; > + for (x = 0; x < widthSrc; x++) > + { > + DWORD argb = *srcbits++; > + BYTE *s = (BYTE *) &argb; > + s[0] = (s[0] * blendfn.SourceConstantAlpha) / 255; > + s[1] = (s[1] * blendfn.SourceConstantAlpha) / 255; > + s[2] = (s[2] * blendfn.SourceConstantAlpha) / 255; > + s[3] = (s[3] * blendfn.SourceConstantAlpha) / 255; > + *dstbits++ = argb; > + } > + if (top_down) /* we traversed the row forward so we should go back by two rows */ > + dstbits -= 2 * widthSrc; > + } > } > } > else > @@ -2006,6 +2027,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > } > > + X11DRV_LockDIBSection( devDst, DIB_Status_GdiMod ); > dst_pict = get_xrender_picture(devDst); > > wine_tsx11_lock(); > @@ -2017,6 +2039,8 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > if(!src_format) > { > WARN("Unable to find a picture format supporting alpha, make sure X is running at 24-bit\n"); > + wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > return FALSE; > } > > @@ -2055,6 +2079,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > XDestroyImage(image); > > wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > HeapFree(GetProcessHeap(), 0, data); > return TRUE; > } > > > >

Nov. 4, 2009

Re: mshtml/tests: Fix events test when pointer is on a corner.

by Jacek Caban

Hi Nicolas, Nicolas Le Cam wrote: > 2009/10/30 Jacek Caban <jacek(a)codeweavers.com>: > >> Hi Nicolas, >> >> Nicolas Le Cam wrote: >> >>> Hi Jacek, >>> >>> Thanks for feedback. >>> It should handle pointer in every corners IMHO, the left corner can >>> cause failures in winetest. >>> >>> I'll try to find a better solution. Do you have any hints ? >>> >>> >> The test in line 472 is invalid. It looks like all we can do is check if >> get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x >> call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's >> all we can do. The same applies to get_client[XY] and get_offset[XY] tests. >> >> >> Thanks,git br >> Jacek >> >> >> > Hi Jacek, > > I did what you've suggested (patch's attached for reference) but I > don't think it's the right solution. > Test passes on Wine and Windows with such a patch, but we're now > ignoring the fact that values are completely different on Wine (only > -1 and 0) and Windows (cursor's position relative to something). > > I'm trying to find a way to compare values against results from > GetCursorPos and friends. What do you think about that, could that be > a solution ? > I think your patch might go to Wine. If you can find a solution with more strict tests, that would be even better, but I'm afraid that GetCursorPos might be problematic. We won't know until we try. Thanks, Jacek

Nov. 4, 2009

Re: Please write audio tests (was: Playing ULAW sample correctly?)

by Gert van den Berg

On Wed, Nov 4, 2009 at 12:48, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Hi, > >>1. generate a PCM sine wave tone (like winmm/tests/wave.c); > Actually any repetitive signal may not be good enough for general purpose, > sine or square. Perhaps add some change in volume? > > For instance, there currently is a bug somewhere that causes Wine to > repeat the first second of an intro animation's sound (bug #18182, comment #3) > instead of continuing. This would probably not be detected. > > Also, the µ-law speech sample I fed to the MCI produces > stuttering. Perhaps that would not be heard with a sine wave, > if the periods match. > A chirp (frequency sweep) might help for most of these issues? (Another sound with volume sweeps might be needed for other issues?) Chirps are quite easy to generate. (I'm not familiar with Wine's code yet though...) http://en.wikipedia.org/wiki/Chirp Gert

Nov. 4, 2009

Re: winmm/tests: Add MCI waveaudio tests.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > +START_TEST(mci) > +{ > + HWND hwnd; > + hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100, > + 0, 0, 0, NULL); > + test_openCloseWAVE(hwnd); > + test_recordWAVE(hwnd); > + test_playWAVE(hwnd); > + test_asyncWAVE(hwnd); > + test_AutoOpenWAVE(hwnd); > + if(1) DeleteFile("tempfile.wav"); This fails to delete the file, probably because it's still open somewhere. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

RE: how to install a windows service in wine?

by Zhaohui Wang

Sorry, I didn't find the user list at the beginning, now I moved to there. -----Original Message----- From: Juan Lang [mailto:juan.lang(a)gmail.com] Sent: Tuesday, November 03, 2009 10:25 PM To: Zhaohui Wang Cc: wine-devel(a)winehq.org Subject: Re: how to install a windows service in wine? > I am using wine 1.1.32, can anyone tell me how to install a windows > service(say NETBIOS) in wine? Wrong list, you want wine-users instead. --Juan

Nov. 4, 2009

Re: mciwave: Eliminate superfluous logs.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > - WARN after ExitThread is superfluous (and not present in most other code) Most likely the ExitThread should be removed. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

Re: mciwave: Use volatile on slot modified from recorder thread.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > From b45e51940a42016e25a5c3a144968d81248927ed Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= <hoehle(a)users.sourceforge.net> > Date: Mon, 2 Nov 2009 23:49:42 +0100 > Subject: [PATCH] mciwave: Use volatile on slot modified from recorder thread. That's wrong. If there is proper synchronization you don't need volatile, and if there isn't volatile won't magically fix it. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

Please write audio tests (was: Playing ULAW sample correctly?)

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, >1. generate a PCM sine wave tone (like winmm/tests/wave.c); Actually any repetitive signal may not be good enough for general purpose, sine or square. Perhaps add some change in volume? For instance, there currently is a bug somewhere that causes Wine to repeat the first second of an intro animation's sound (bug #18182, comment #3) instead of continuing. This would probably not be detected. Also, the µ-law speech sample I fed to the MCI produces stuttering. Perhaps that would not be heard with a sine wave, if the periods match. Still it's better to have a test than currently no test at all! >It is also quite simple to generate sine waves without any trig. Code for sine is already in winmm/tests/wave.c No need to reinvent. Regards, Jörg Höhle

Nov. 4, 2009

Re: msi: Initialize string pointer to NULL

by Nathan Gallaher

Kirill, I see what you're getting at. The valgrind error comes about when we call get_column_info in streams.c. No string is allocated for table_name there, so the pointer remains uninitialized. I am unfamiliar with the streams use case, but looking at tests/db.c:test_streamtable(), I think that the correct tablename to be returning is '_Streams'. Would you agree? Thanks, ~Nathan On Sun, 1 Nov 2009, Kirill K. Smirnov wrote: > Hi Nathan, >> + haystack_table_name = NULL; >> r = table->ops->get_column_info( table, i, &col_name, NULL, >> NULL, &haystack_table_name ); >> if( r != ERROR_SUCCESS ) > > I'm afraid, but this patch silences valgrind only, but does not solves the > problem. It seems to me, that if table->ops->get_column_info() succeeds, it > initializes haystack_table_name, and if it fails, we do not use > haystack_table_name at all (we immediately return from this function). Thus, > the problem lies somewhere in get_column_info(). > > So it is useless (and harmful, because it confuses valgrind) to initialize it > like this. > > -- > Kirill >

Nov. 3, 2009

Re: how to install a windows service in wine?

by Juan Lang

> I am using wine 1.1.32, can anyone tell me how to install a windows > service(say NETBIOS) in wine? Wrong list, you want wine-users instead. --Juan

Nov. 3, 2009

how to install a windows service in wine?

by Zhaohui Wang

Hi all I am using wine 1.1.32, can anyone tell me how to install a windows service(say NETBIOS) in wine? I saw there is a services.exe running, but I didn't find any document on winehq saying how to add new wine services. I appreciate your help Best Regards Zhao Wang

Nov. 3, 2009

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W

by Juan Lang

> + store = CertOpenSystemStoreA(0, pszCertStoreName); > > This looks wrong to me ... To me too :) Thanks! --Juan

Nov. 3, 2009

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W

by Stefan Leichter

Am Tuesday 03 November 2009 23:32:42 schrieb Juan Lang: > These were too easy to pass up. > --Juan +BOOL WINAPI CertAddEncodedCertificateToSystemStoreW(LPCWSTR pszCertStoreName, + const BYTE *pbCertEncoded, DWORD cbCertEncoded) +{ [snip] + store = CertOpenSystemStoreA(0, pszCertStoreName); This looks wrong to me ... Bye Stefan

Nov. 3, 2009

RE: Please write audio tests (was: Playing ULAW sample correctly?)

by Nicklas Börjesson

>Or use a goertzel detector for the transmitted tone(s). >It is also quite simple to generate sine waves without any trig. Just another, less advanced, idea, Even easier would making a really slow square wave(~0.5 Hz) that follows a simple pattern, like 80, 80, 80, -80, -80, -80, 80, 80, 80...for 5 seconds. Then one would easily be able to find the signal in the data without any advanced tricks. Just (signal<0) or not for a specified period would suffice as detection. Maybe stutter and sound quality would not be tested, however it would be a simple first step. BTW, wouldn't stutter affect a straight line as much as it would a sound wave? If you know that the wave isn't a wave but is supposed to follow a straight line, wouldn't then all deviations be stutter? The soundsystem doesn't treat a stream of similar bytes any different from a sine wave, does it? Of course, this will obviously not work through a microphone, but I can't see how that loop would be relevant to test. Being hardware and all. //Nicklas

Nov. 3, 2009

Re: Please write audio tests (was: Playing ULAW sample correctly?)

by David Laight

On Tue, Nov 03, 2009 at 07:48:29PM +0200, Damjan Jovanovic wrote: > On Tue, Nov 3, 2009 at 3:33 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > > > > Wine would benefit from a test in msacm32/tests/ sketched as follows: > > 0. choose some base frequency like 11025Hz; > > 1. generate a PCM sine wave tone (like winmm/tests/wave.c); > > 2. convert it to ?-law via the ACM functions; > > 3. play it via winmm if wine_interactive is set (like in wave.c) > > 4. convert it back and apply some delta function to tell if it's > > ? close enough to the original sine, > > ? i.e. mechanically verify that the round-trip worked. > > You'd need to verify the energy in the discrete Fourier transform of > the signal at the frequency you're testing for, is say 90% of the > total signal energy. Or use a goertzel detector for the transmitted tone(s). It is also quite simple to generate sine waves without any trig. David -- David Laight: david(a)l8s.co.uk

Nov. 3, 2009

Re: Please write audio tests (was: Playing ULAW sample correctly?)

by Damjan Jovanovic

On Tue, Nov 3, 2009 at 3:33 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Hi, > > Eric Pouech wrote: >>> It is not acceptable that µ-law code bit-rots because of >>lack of continuous >>> testing (assuming it worked the day it was checked in). > >>actually, you can add a (small) wave file in the test program (and >>create on the fly the needed file) >>we already test some .exe this way in winetest > One could do without real .wav files: > > Wine would benefit from a test in msacm32/tests/ sketched as follows: > 0. choose some base frequency like 11025Hz; > 1. generate a PCM sine wave tone (like winmm/tests/wave.c); > 2. convert it to µ-law via the ACM functions; > 3. play it via winmm if wine_interactive is set (like in wave.c) > 4. convert it back and apply some delta function to tell if it's > close enough to the original sine, > i.e. mechanically verify that the round-trip worked. You'd need to verify the energy in the discrete Fourier transform of the signal at the frequency you're testing for, is say 90% of the total signal energy. wave.c however does this instead: if (winetest_interactive && (device != WAVE_MAPPER)) { trace("Playing a 5 seconds reference tone.\n"); trace("All subsequent tones should be identical to this one.\n"); trace("Listen for stutter, changes in pitch, volume, etc.\n"); ...which is a human verification not an automated one... And recording from the microphone while playing seems like bad news, surrounding noise levels are unpredictable, hardware might not be present, etc. Any other idea how to play and record without using the microphone? Maybe we should test against the implementation in a tool like sox instead? > 5. repeat 2-4 for > - ADPCM > - IMAADPCM > - GSM6.10 (is available) > - .... > - actually, better enumerate all ACM converters and call them in turn > rather than hard-code a fixed set of them. > > I'll not write that, as the MCI will probably keep me busy until the end of the year. > > Any volunteer who wants to provide this? > Regards, > Jörg Höhle. > > > Damjan Jovanovic

Nov. 3, 2009

windows chromium testsuite valgrind warnings

by Dan Kegel

For what it's worth, here are the valgrind warnings from a run of my current subset of the chromium test suite under valgrind+wine: http://kegel.com/wine/chromium/valgrind-logs/errors.html Mostly they're leaks. That's good news. For the few nonleak warnings, I already filed http://bugs.winehq.org/show_bug.cgi?id=20567 for the des one in http://kegel.com/wine/chromium/valgrind-logs/base_unittests/RSAPrivateKeyUn… http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureCreato… and http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureVerifi… and http://bugs.winehq.org/show_bug.cgi?id=20553 for the first one in http://kegel.com/wine/chromium/valgrind-logs/unit_tests/TableViewTest.log and am puzzling over the crash later in TableViewTest (though maybe once I clear up the first error, the crash will go away). The leaks aren't quite as important. I filed a few so far: http://bugs.winehq.org/show_bug.cgi?id=20544 shell32 imagelist memory leak on unload? http://bugs.winehq.org/show_bug.cgi?id=20545 memory leak in MMDRV_Init on exit? http://bugs.winehq.org/show_bug.cgi?id=20548 Memory leak in pending overlapped I/O? http://bugs.winehq.org/show_bug.cgi?id=20551 user32 clipboard memory leaks http://bugs.winehq.org/show_bug.cgi?id=20552 Memory leak in alloc_thread_tls? and http://bugs.winehq.org/show_bug.cgi?id=20549 secur32 memory leak on exit? which is already closed (it's an upstream issue and/or notabug). Of those, I'm only worried about 20548 and 20551. - Dan

Nov. 3, 2009

Please write audio tests (was: Playing ULAW sample correctly?)

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, Eric Pouech wrote: >> It is not acceptable that µ-law code bit-rots because of >lack of continuous >> testing (assuming it worked the day it was checked in). >actually, you can add a (small) wave file in the test program (and >create on the fly the needed file) >we already test some .exe this way in winetest One could do without real .wav files: Wine would benefit from a test in msacm32/tests/ sketched as follows: 0. choose some base frequency like 11025Hz; 1. generate a PCM sine wave tone (like winmm/tests/wave.c); 2. convert it to µ-law via the ACM functions; 3. play it via winmm if wine_interactive is set (like in wave.c) 4. convert it back and apply some delta function to tell if it's close enough to the original sine, i.e. mechanically verify that the round-trip worked. 5. repeat 2-4 for - ADPCM - IMAADPCM - GSM6.10 (is available) - .... - actually, better enumerate all ACM converters and call them in turn rather than hard-code a fixed set of them. I'll not write that, as the MCI will probably keep me busy until the end of the year. Any volunteer who wants to provide this? Regards, Jörg Höhle.

Nov. 3, 2009

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)

by Charles Davis

Charles Davis wrote: > Alexandre Julliard wrote: >> Charles Davis <cdavis(a)mymail.mines.edu> writes: >> >>> I thought I fixed all the issues. What's wrong with my patches now? >> Many things, it's a lot more complicated than that. For instance you >> can't just kill the fstab support, this needs to be preserved somehow, >> probably on the mountmgr side. Also you can't have a single file >> descriptor per device, you need one for each open. >> > OK, I can do that. > > I've decided to do the open in mountmgr, so I can have it handle changes > to the fstab while it's running. So, I'm working on implementing > IRP_MJ_CREATE support (which is the standard way for drivers to handle > open requests). I've attached a first stab at that. Can you take a look? > I'm pretty sure there's something I'm missing. > > BTW, I'm on #winehackers as I write this (my nick is cdavis5x). > > Chip > > Please disregard both my emails. (The second one was because my email client complained that it failed to send the email.) That patch I sent is riddled with problems. (I should know better by now, but apparently, I don't. Once again, I jumped the gun, so to speak.) I'll have a better version ready by tomorrow.

Nov. 2, 2009

Re: mshtml/tests: Fix events test when pointer is on a corner.

by Nicolas Le Cam

2009/10/30 Jacek Caban <jacek(a)codeweavers.com>: > Hi Nicolas, > > Nicolas Le Cam wrote: >> >> Hi Jacek, >> >> Thanks for feedback. >> It should handle pointer in every corners IMHO, the left corner can >> cause failures in winetest. >> >> I'll try to find a better solution. Do you have any hints ? >> > > The test in line 472 is invalid. It looks like all we can do is check if > get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x > call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's > all we can do. The same applies to get_client[XY] and get_offset[XY] tests. > > > Thanks,git br > Jacek > > Hi Jacek, I did what you've suggested (patch's attached for reference) but I don't think it's the right solution. Test passes on Wine and Windows with such a patch, but we're now ignoring the fact that values are completely different on Wine (only -1 and 0) and Windows (cursor's position relative to something). I'm trying to find a way to compare values against results from GetCursorPos and friends. What do you think about that, could that be a solution ? Thanks, Nicolas Le Cam

Nov. 2, 2009

Re: eventlog tests and writing/clearing the logs

by Paul Vriens

On 11/02/2009 05:51 PM, mellery wrote: > Hi, > > Will this involve implementing advapi:RegisterTraceGuidsW, and can I > help at all? > > Thanks, > Mike Event tracing is totally different from event logging. Be my guest to pick that up ;) Maybe it's a good idea to split the advapi32/eventlog.c into eventlog.c and eventtrace.c once the tracing is fleshed out a bit more. Particularly if we move most of functionality to services.exe (as on Windows). -- Cheers, Paul.

Nov. 2, 2009

Re: eventlog tests and writing/clearing the logs

by Paul Vriens

On 11/02/2009 05:39 PM, Nikolay Sivov wrote: > On Mon, Nov 2, 2009 at 7:35 PM, Paul Vriens<paul.vriens.wine(a)gmail.com> wrote: >> >> Any thoughts on this? Correct approach? >> > > Do you plan to implement a real logging or what all of this is for? If you mean, get functional event logging into Wine, the answer is yes. -- Cheers, Paul.

Nov. 2, 2009

Re: gdi32: add testcases for copying an EMF from a NULL bitmap

by Austin English

On Mon, Nov 2, 2009 at 10:09 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On Mon, Nov 2, 2009 at 8:27 AM, Austin English <austinenglish(a)gmail.com> wrote: >> Testcase for bug 4553 > > Are you sure? I don't see any related patches here. > >> >> -- >> -Austin >> > > Why there's no wine failure in this test? Apparently part of the problem has already been fixed, as the testcase passes but the program still crashes. I sent the testcase by itself to prevent it from regressing. Actually, there was a typo in the original e-mail, it's bug 4543, see http://bugs.winehq.org/show_bug.cgi?id=4543#c17. -- -Austin

Nov. 2, 2009