November 2009 - Wine-Devel - list.winehq.org

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Paul Vriens

On 11/04/2009 09:45 PM, Reece Dunn wrote: > 2009/11/4 Paul Vriens<paul.vriens.wine(a)gmail.com>: >> Hi, >> >> Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog >> tests. I was sure I've tested these from Win95 up to Win7. >> >> When I run tests I want to do this as Administrator, so on Vista+ I select >> 'Run as Administrator' to start a command prompt, or to launch winetest. >> >> Running the mentioned crosscompiled tests is no problem unless you do this >> from the actual home directory (or any subdirectory) of the user that logged >> in. >> >> Winetest runs most of it's test in the %TEMP% directory and hence we see >> this failure. But I have no clue why (yet). >> >> Anyone? > Hi Reece, > Ah, I see. This is the failure on test.winehq.org, correct? Yes. I'm in the process of writing loads of eventlog tests while keeping track of possible failures on test.winehq.org. > > eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5 > > 5 is ERROR_ACCESS_DENIED. > > The create_backup function does not have any error checking -- what > happens when you put the return values for these calls, and the > GetLastError in ok checks, e.g. > > ok(DeleteFileA(filename), "error deleting the backup event log file"); > ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS, > got %d", GetLastError()); > > - Reece Deleting the file works just fine. both in create_backup() and test_clear(). What makes it even more weird is that I have the same error when I run these tests as the user (not admin). I also don't get any UAC prompts in either case. Turning UAC off doesn't make a difference. I don't see any logical explanation why the function returns a different error. The fact that the function fails anyway makes me consider using a second possible last error for that particular test. -- Cheers, Paul.

Nov. 5, 2009

Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

by Juan Lang

Hi Paul, I imagine this is to avoid checking prov if CryptAcquireContextW fails. In that case, wouldn't it be better to check the return value of CryptAcquireContextW? --Juan

Nov. 4, 2009

Comment request: wineconsole: Fix Alt+F10 sent when F10 pressed.

by Erich Hoover

I thought this patch was pretty straightforward, comments? http://www.winehq.org/pipermail/wine-patches/2009-October/080779.html Erich Hoover ehoover(a)mines.edu

Nov. 4, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Reece Dunn

2009/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prompt, or to launch winetest. > > Running the mentioned crosscompiled tests is no problem unless you do this > from the actual home directory (or any subdirectory) of the user that logged > in. > > Winetest runs most of it's test in the %TEMP% directory and hence we see > this failure. But I have no clue why (yet). > > Anyone? Ah, I see. This is the failure on test.winehq.org, correct? eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5 5 is ERROR_ACCESS_DENIED. The create_backup function does not have any error checking -- what happens when you put the return values for these calls, and the GetLastError in ok checks, e.g. ok(DeleteFileA(filename), "error deleting the backup event log file"); ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS, got %d", GetLastError()); - Reece

Nov. 4, 2009

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet

by Eric Pouech

Paul Bolle a écrit : > Add support for the qAttached packet. Main benefit is that if gdb was > attached to a debuggee and it quits it will now ask if it should detach > from the debuggee instead of asking whether the debuggee should be > killed. (It still will ask whether the debuggee should be killed if it > launched the debuggee itself). > > Signed-off-by: Paul Bolle <pebolle(a)tiscali.nl> > --- > Would it be better to add a new member to gdbctx instead of using a > separate variable (qAttached_reply)? > yes, inclusion in gdbctx is preferred (and storage should rather be an integer rather than a string pointer) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Nov. 4, 2009

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Reece Dunn

2009/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prompt, or to launch winetest. > > Running the mentioned crosscompiled tests is no problem unless you do this > from the actual home directory (or any subdirectory) of the user that logged > in. > > Winetest runs most of it's test in the %TEMP% directory and hence we see > this failure. But I have no clue why (yet). > > Anyone? What are the errors you are experiencing? Are you getting access denied errors? If so, it may be due to the different file access permissions. What happens when you create/delete the files produced by winetest in the %TEMP% directory in the explorer GUI? Do you get/need a UAC prompt for it to work? Have you tried adding UAC information to the manifest if this is the case? Sorry I can't help out any further as I abandoned Vista a long time ago ^_^. - Reece

Nov. 4, 2009

Weird error for the advapi32/eventlog tests on Vista+ when running winetest

by Paul Vriens

Hi, Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog tests. I was sure I've tested these from Win95 up to Win7. When I run tests I want to do this as Administrator, so on Vista+ I select 'Run as Administrator' to start a command prompt, or to launch winetest. Running the mentioned crosscompiled tests is no problem unless you do this from the actual home directory (or any subdirectory) of the user that logged in. Winetest runs most of it's test in the %TEMP% directory and hence we see this failure. But I have no clue why (yet). Anyone? -- Cheers, Paul.

Nov. 4, 2009

Re: winex11.drv: Implement FIXME in AlphaBlend

by Roderick Colenbrander

Hi Peter, I didn't see this patch before because I was away at that time. The SourceConstantAlpha part looks correct to me. It might make sense to calculate blendfn.SourceConstantAlpha / 255 before the loop, so that it isn't recalculated each time. The other half of your patch is a separate change and it would require a separate patch. The part looks suspicious though. I don't understand why you need special locking there. Roderick On Mon, Oct 26, 2009 at 4:39 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > > > commit df78de34a06e32be9f37a3b34fe68e5b088a8578 > Author: Peter Urbanec <winehq.org(a)urbanec.net> > Date: Mon Oct 26 21:29:00 2009 +1100 > > Implement source alpha plus SourceConstantAlpha combined transparency. > Add DIB locking to prevent node icon rendering errors in Fusion composition flow views. > > diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c > index 90503bf..26dc262 100644 > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -1956,9 +1956,6 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > return FALSE; > } > > - if ((blendfn.AlphaFormat & AC_SRC_ALPHA) && blendfn.SourceConstantAlpha != 0xff) > - FIXME("Ignoring SourceConstantAlpha %d for AC_SRC_ALPHA\n", blendfn.SourceConstantAlpha); > - > if(dib.dsBm.bmBitsPixel != 32) { > FIXME("not a 32 bpp dibsection\n"); > return FALSE; > @@ -1979,11 +1976,35 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > if (blendfn.AlphaFormat & AC_SRC_ALPHA) > { > - for(; y >= y2; y--) > + if (blendfn.SourceConstantAlpha == 0xff) > { > - memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > + for(; y >= y2; y--) > + { > + memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > widthSrc * 4); > - dstbits += (top_down ? -1 : 1) * widthSrc; > + dstbits += (top_down ? -1 : 1) * widthSrc; > + } > + } > + else > + { > + /* Source alpha plus SourceConstantAlpha */ > + for(; y >= y2; y--) > + { > + int x; > + DWORD *srcbits = (DWORD *)((char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes) + xSrc; > + for (x = 0; x < widthSrc; x++) > + { > + DWORD argb = *srcbits++; > + BYTE *s = (BYTE *) &argb; > + s[0] = (s[0] * blendfn.SourceConstantAlpha) / 255; > + s[1] = (s[1] * blendfn.SourceConstantAlpha) / 255; > + s[2] = (s[2] * blendfn.SourceConstantAlpha) / 255; > + s[3] = (s[3] * blendfn.SourceConstantAlpha) / 255; > + *dstbits++ = argb; > + } > + if (top_down) /* we traversed the row forward so we should go back by two rows */ > + dstbits -= 2 * widthSrc; > + } > } > } > else > @@ -2006,6 +2027,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > } > > + X11DRV_LockDIBSection( devDst, DIB_Status_GdiMod ); > dst_pict = get_xrender_picture(devDst); > > wine_tsx11_lock(); > @@ -2017,6 +2039,8 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > if(!src_format) > { > WARN("Unable to find a picture format supporting alpha, make sure X is running at 24-bit\n"); > + wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > return FALSE; > } > > @@ -2055,6 +2079,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > XDestroyImage(image); > > wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > HeapFree(GetProcessHeap(), 0, data); > return TRUE; > } > > > >

Nov. 4, 2009

Re: mshtml/tests: Fix events test when pointer is on a corner.

by Jacek Caban

Hi Nicolas, Nicolas Le Cam wrote: > 2009/10/30 Jacek Caban <jacek(a)codeweavers.com>: > >> Hi Nicolas, >> >> Nicolas Le Cam wrote: >> >>> Hi Jacek, >>> >>> Thanks for feedback. >>> It should handle pointer in every corners IMHO, the left corner can >>> cause failures in winetest. >>> >>> I'll try to find a better solution. Do you have any hints ? >>> >>> >> The test in line 472 is invalid. It looks like all we can do is check if >> get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x >> call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's >> all we can do. The same applies to get_client[XY] and get_offset[XY] tests. >> >> >> Thanks,git br >> Jacek >> >> >> > Hi Jacek, > > I did what you've suggested (patch's attached for reference) but I > don't think it's the right solution. > Test passes on Wine and Windows with such a patch, but we're now > ignoring the fact that values are completely different on Wine (only > -1 and 0) and Windows (cursor's position relative to something). > > I'm trying to find a way to compare values against results from > GetCursorPos and friends. What do you think about that, could that be > a solution ? > I think your patch might go to Wine. If you can find a solution with more strict tests, that would be even better, but I'm afraid that GetCursorPos might be problematic. We won't know until we try. Thanks, Jacek

Nov. 4, 2009

Re: Please write audio tests (was: Playing ULAW sample correctly?)

by Gert van den Berg

On Wed, Nov 4, 2009 at 12:48, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Hi, > >>1. generate a PCM sine wave tone (like winmm/tests/wave.c); > Actually any repetitive signal may not be good enough for general purpose, > sine or square. Perhaps add some change in volume? > > For instance, there currently is a bug somewhere that causes Wine to > repeat the first second of an intro animation's sound (bug #18182, comment #3) > instead of continuing. This would probably not be detected. > > Also, the µ-law speech sample I fed to the MCI produces > stuttering. Perhaps that would not be heard with a sine wave, > if the periods match. > A chirp (frequency sweep) might help for most of these issues? (Another sound with volume sweeps might be needed for other issues?) Chirps are quite easy to generate. (I'm not familiar with Wine's code yet though...) http://en.wikipedia.org/wiki/Chirp Gert

Nov. 4, 2009