November 2009 - Wine-Devel - list.winehq.org

Re: winmm/tests: Add MCI waveaudio tests.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > +START_TEST(mci) > +{ > + HWND hwnd; > + hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100, > + 0, 0, 0, NULL); > + test_openCloseWAVE(hwnd); > + test_recordWAVE(hwnd); > + test_playWAVE(hwnd); > + test_asyncWAVE(hwnd); > + test_AutoOpenWAVE(hwnd); > + if(1) DeleteFile("tempfile.wav"); This fails to delete the file, probably because it's still open somewhere. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

RE: how to install a windows service in wine?

by Zhaohui Wang

Sorry, I didn't find the user list at the beginning, now I moved to there. -----Original Message----- From: Juan Lang [mailto:juan.lang(a)gmail.com] Sent: Tuesday, November 03, 2009 10:25 PM To: Zhaohui Wang Cc: wine-devel(a)winehq.org Subject: Re: how to install a windows service in wine? > I am using wine 1.1.32, can anyone tell me how to install a windows > service(say NETBIOS) in wine? Wrong list, you want wine-users instead. --Juan

Nov. 4, 2009

Re: mciwave: Eliminate superfluous logs.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > - WARN after ExitThread is superfluous (and not present in most other code) Most likely the ExitThread should be removed. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

Re: mciwave: Use volatile on slot modified from recorder thread.

by Alexandre Julliard

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > From b45e51940a42016e25a5c3a144968d81248927ed Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= <hoehle(a)users.sourceforge.net> > Date: Mon, 2 Nov 2009 23:49:42 +0100 > Subject: [PATCH] mciwave: Use volatile on slot modified from recorder thread. That's wrong. If there is proper synchronization you don't need volatile, and if there isn't volatile won't magically fix it. -- Alexandre Julliard julliard(a)winehq.org

Nov. 4, 2009

Please write audio tests (was: Playing ULAW sample correctly?)

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, >1. generate a PCM sine wave tone (like winmm/tests/wave.c); Actually any repetitive signal may not be good enough for general purpose, sine or square. Perhaps add some change in volume? For instance, there currently is a bug somewhere that causes Wine to repeat the first second of an intro animation's sound (bug #18182, comment #3) instead of continuing. This would probably not be detected. Also, the µ-law speech sample I fed to the MCI produces stuttering. Perhaps that would not be heard with a sine wave, if the periods match. Still it's better to have a test than currently no test at all! >It is also quite simple to generate sine waves without any trig. Code for sine is already in winmm/tests/wave.c No need to reinvent. Regards, Jörg Höhle

Nov. 4, 2009

Re: msi: Initialize string pointer to NULL

by Nathan Gallaher

Kirill, I see what you're getting at. The valgrind error comes about when we call get_column_info in streams.c. No string is allocated for table_name there, so the pointer remains uninitialized. I am unfamiliar with the streams use case, but looking at tests/db.c:test_streamtable(), I think that the correct tablename to be returning is '_Streams'. Would you agree? Thanks, ~Nathan On Sun, 1 Nov 2009, Kirill K. Smirnov wrote: > Hi Nathan, >> + haystack_table_name = NULL; >> r = table->ops->get_column_info( table, i, &col_name, NULL, >> NULL, &haystack_table_name ); >> if( r != ERROR_SUCCESS ) > > I'm afraid, but this patch silences valgrind only, but does not solves the > problem. It seems to me, that if table->ops->get_column_info() succeeds, it > initializes haystack_table_name, and if it fails, we do not use > haystack_table_name at all (we immediately return from this function). Thus, > the problem lies somewhere in get_column_info(). > > So it is useless (and harmful, because it confuses valgrind) to initialize it > like this. > > -- > Kirill >

Nov. 4, 2009

Re: how to install a windows service in wine?

by Juan Lang

> I am using wine 1.1.32, can anyone tell me how to install a windows > service(say NETBIOS) in wine? Wrong list, you want wine-users instead. --Juan

Nov. 4, 2009

how to install a windows service in wine?

by Zhaohui Wang

Hi all I am using wine 1.1.32, can anyone tell me how to install a windows service(say NETBIOS) in wine? I saw there is a services.exe running, but I didn't find any document on winehq saying how to add new wine services. I appreciate your help Best Regards Zhao Wang

Nov. 4, 2009

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W

by Juan Lang

> + store = CertOpenSystemStoreA(0, pszCertStoreName); > > This looks wrong to me ... To me too :) Thanks! --Juan

Nov. 3, 2009

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W

by Stefan Leichter

Am Tuesday 03 November 2009 23:32:42 schrieb Juan Lang: > These were too easy to pass up. > --Juan +BOOL WINAPI CertAddEncodedCertificateToSystemStoreW(LPCWSTR pszCertStoreName, + const BYTE *pbCertEncoded, DWORD cbCertEncoded) +{ [snip] + store = CertOpenSystemStoreA(0, pszCertStoreName); This looks wrong to me ... Bye Stefan

Nov. 3, 2009