December 2009 - Wine-Devel - list.winehq.org

RFC: winediag script

by Roderick Colenbrander

Hi, Over the years I have assisted a lot of people setting up Wine. In a lot of cases Wine doesn't work well because of missing libraries, pulseaudio, misconfigured display drivers and so on. I have written a script called 'winediag' which attempts to scan a system for the most common problems. Right now it contains mostly display driver related checks and a few basic audio / printing checks. I hope people have suggestions for most tests e.g. network tests (/etc/hosts, samba), more thorough driver checks and son. What do you guys think about it so far? (BTW I'm not a shell guru, so I would love to get some positive feedback) Thanks, Roderick Colenbrander

Dec. 2, 2009

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).

by James Mckenzie

Peter Rosin <peda(a)lysator.liu.se> >Subject: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine). > > AUTHORS is not a developer editable file. Resubmit without this change. When you have submitted enough changes to Wine, you name will be added by AJ. James McKenzie

Dec. 2, 2009

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).

by Charles Davis

You don't get added to AUTHORS until you've hacked on Wine enough. I learned that the hard way when I tried to put my name at the top of an already-existing file. Chip

Dec. 2, 2009

Valgrind cleanup status

by Dan Kegel

The logs of valgrind errors at http://kegel.com/wine/valgrind/logs/ are showing a nice downward trend: date files errors nonleak errors 2009-10-23 84 2383 339 2009-10-26 82 2344 319 2009-10-27 82 2318 294 2009-10-28 83 2325 294 2009-10-29 80 2279 253 2009-10-30 81 2304 280 2009-11-03 80 2612 301 2009-11-04 78 2290 276 2009-11-05 79 2295 268 2009-11-09 73 2215 254 2009-11-10 75 2266 296 2009-11-11 75 2236 263 2009-11-13 72 2264 234 2009-11-16 69 1724 222 2009-11-17 69 1711 221 2009-11-18 88 1736 253 2009-11-19 85 1696 247 2009-11-26 76 1628 168 2009-11-27 88 1797 302 2009-11-30 76 1779 288 2009-12-01 73 1723 230 The spike at 11-27 was when I started running with my heap tail corruption detection patch; those errors were present before, but not detected. Thanks to everyone who's been chipping away at these warnings. (Part of the decline has been knowing which suppressions to add, but that's ok, cleaner logs are good.) I'm mostly worried about nonleak errors for now, so I might be undercounting leak errors somewhat. As always, more help with these would be welcome. Some of the errors aren't that hard to deal with (but at the same time, some of them look easy but are subtle, so take care). - Dan

Dec. 2, 2009

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.

by Alexandre Julliard

Dan Kegel <dank(a)kegel.com> writes: > On Tue, Dec 1, 2009 at 11:22 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Validation should only happen when explicitly requested. > > Should I submit a separate patch to remove the existing small arena > validation from RtlFreeHeap and RtlReAllocateHeap, then? No. These are not here as debug aids, but to catch some cases of bad pointers passed from apps that could cause heap corruption. There's no evidence that the same thing is necessary for large blocks. -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2009

Re: New winetricks 20091125: new verbs ie7, alsa, fbo, pbuffer, ...

by Dan Kegel

>> Could it be possible to "fix" mdac as well? Because of wine now having a more >> or less stubbed oledb32.dll, apps that need mdac don't run properly anymore. >> Simple solution is to set oledb32 to native, before the mdac installer is >> started, (and leave it to native afterwards) Could that be added to winetricks? > > Fixed in svn. In the future, please e-mail me/Dan directly, rather > than all of wine-devel. And/or file a bug at http://code.google.com/p/winezeug Thanks for the tip!

Dec. 2, 2009

Re: Silencing RtlNtStatusToDosErrorNoTeb() a bit

by Wolfram Sang

Hello Dmitry, thanks for your fast reply. Sorry, I might be still missing something, as I am a bit confused with some details. Dmitry Timoshkov wrote: >> Another solution might be to define, let's say, ERROR_WINE_FIXME for all >> real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. > > If a FIXME is not appropriate it should be replaced by a WARN. > Although most of the places it's used are the places with missing > functionality. Well, that's what the fixme does in more than 99% of the cases. The proper return value is unknown and ERROR_MR_MID_NOT_FOUND is returned as a best fit. Those cases should be fixed somewhen. There is just one exception (so far), which does not need the fixme because ERROR_MR_MID_NOT_FOUND is the intended answer. This is the one I want to silence, no need for a WARN here? > A real solution for the problem above is to write a test case I'd think there is one already? wsa(a)katana:~/Tools/wine$ grep 'STATUS_MESSAGE_NOT_FOUND' dlls/ntdll/tests/error.c cmp(STATUS_MESSAGE_NOT_FOUND, ERROR_MR_MID_NOT_FOUND); > and add a mapping for missing status code(s). Which would be my second proposal? Regards, Wolfram

Dec. 2, 2009

Re: Silencing RtlNtStatusToDosErrorNoTeb() a bit

by Dmitry Timoshkov

"Wolfram Sang" <wolfram(a)the-dreams.de> wrote: > Another solution might be to define, let's say, ERROR_WINE_FIXME for all > real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. If a FIXME is not appropriate it should be replaced by a WARN. Although most of the places it's used are the places with missing functionality. A real solution for the problem above is to write a test case and add a mapping for missing status code(s). -- Dmitry.

Dec. 2, 2009

Re: New winetricks 20091125: new verbs ie7, alsa, fbo, pbuffer, ...

by Austin English

On Fri, Nov 27, 2009 at 3:57 PM, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Dan Kegel <dank <at> kegel.com> writes: > >> >> Pie's in the oven, time for another winetricks release. >> > > Could it be possible to "fix" mdac as well? Because of wine now having a more > or less stubbed oledb32.dll, apps that need mdac don't run properly anymore. > Simple solution is to set oledb32 to native, before the mdac installer is > started, (and leave it to native afterwards) Could that be added to winetricks? Fixed in svn. In the future, please e-mail me/Dan directly, rather than all of wine-devel. -- -Austin

Dec. 2, 2009

Re: [3/5] imagehlp: Implement ImageAddCertificate

by Owen Rudge

> The virtual address is not necessarily the same as the disk offset. Actually, it seems that the security directory is one of the few places where a disk offset is intentionally used. Trying to compensate for the virtual address results in failure in this case. I have been amending the code to make it more robust however, and shall submit a revised version tomorrow. -- Owen Rudge http://www.owenrudge.net/

Dec. 1, 2009