February 2009 - Wine-Devel - list.winehq.org

Re: msctf: add internal function for handling TfClientIds

by James Mckenzie

Alexandre Julliard <julliard(a)winehq.org> wrote on Feb 23: > >Aric Stewart <aric(a)codeweavers.com> writes: > >> + /* If i understand this correctly at most a process should generate >> + * only a handful of these... But in case I am wrong */ >> + if (id_last == 65535) >> + { >> + ERR("TfClientIds generated exceeds USHORT limit\n"); >> + return 0x0; >> + } >> + id_last++; >> + id->id = MAKELONG(id_last, magic); >> + id->data = data; >> + list_add_head(&clientids,&id->entry); > >Using an array index would be cleaner than having to search through the >list everytime you use an id. > Also, aren't linked lists inefficient as well. Searching through them can be very intense, unless they are small (< 5 elements). Anything larger than this and an array would be more efficient. James McKenzie

Feb. 23, 2009

Re: [7/7] setupapi/tests: start dialog.c test file with a test for SetupPromptForDiskA

by Ricardo Filipe

sure, i'll do that and resend :) thanks for your feedback. 2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com> > > Hi, > > Could you turn that skip() into a win_skip()? Usually it's a good idea to > do a > SetLastError(0xdeadbeef or something like that) before calling the > function, > especially because you are relying on that last error for the ok() test. > > -- > Cheers, > > Paul. > > >

Feb. 23, 2009

Re: ole32: change a pointer cast from DWORD to DWORD_PTR

by Rob Shearman

2009/2/22 Austin English <austinenglish(a)gmail.com>: > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index b8ddba8..7360f66 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -2007,7 +2007,7 @@ HRESULT WINAPI CoRegisterClassObject( > * Use the address of the chain node as the cookie since we are sure it's > * unique. FIXME: not on 64-bit platforms. > */ > - newClass->dwCookie = (DWORD)newClass; > + newClass->dwCookie = (DWORD_PTR)newClass; > > /* > * Since we're making a copy of the object pointer, we have to increase its Since dwCookie is of type DWORD this is just hiding the problem. The correct solution is to store a process-wide index and then to increase this every time a class object is registered and use it for the cookie. CoRevokeClassObject already looks through the list of registered classes to find the cookie so this doesn't need to be changed. -- Rob Shearman

Feb. 23, 2009

Re: Win to Lin Library Wrapper

by Seth Shelnutt

I still don't see what the harm is in having support for .so's. I mean even if it brings partial compatibility to the dlls vs so's isn't it worth it? That is more than we have right now in Wine. What was the last version to have the built in support? I'd like to see if I can't update it, and port it to the latest GIT of Wine and see how it does. See if it works as well as the CUDA wrapper, or the CAL wrapper. See if there is a benefit or not to having this support. Thanks, Seth Shelnutt

Feb. 23, 2009

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

by Nicolas Le Cam

2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Is .NET installed (any version)? > > -- > Cheers, > > Paul. > Can't remember. I will check and report back this evening. Nicolas Le Cam

Feb. 23, 2009

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

by Paul Vriens

Nicolas Le Cam wrote: > 2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>: >> Nicolas Le Cam wrote: >>> 2009/2/23 Francois Gouget <fgouget(a)free.fr>: >>>> On Sun, 22 Feb 2009, Nicolas Le Cam wrote: >>>> >>>>> This avoid a messagebox in regression tests on systems that don't have >>>>> GdiPlus. >>>> This seems wrong because winetest.exe is already supposed to check for >>>> missing dlls. If I remember correctly this was done explicitely so that >>>> individual tests would not have to dynamically link everywhere. >>>> >>>> Also I tested on a platform that does not have gdiplus, and I did not >>>> get a message box. In fact, on that platform, winetest did not extract >>>> gdiplus_test.exe, which also seems very wrong to me. >>>> >>>> So I think that if there's any issue, it's on the winetest.exe side. >>>> >>>> -- >>>> Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ >>>> "Lotto: A tax on people who are bad at math." -- unknown >>>> "Windows: Microsoft's tax on computer illiterates." -- WE7U >>>> >>>> >>>> >>> Thanks, >>> >>> On my w2k pro when I launch the winetest obtained from >>> test.winehq.org, I get a MessageBox saying gdiplus is missing, and >>> there's already some tests that load dlls dynamically (advpack, >>> cryptui, fusion) so thought it was the right way. >>> >>> I will have a look on the winetest side. >>> >>> Nicolas Le Cam >>> >>> >>> >> The reason you see this is because next to a normal LoadLibrary we also use the >> .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but >> will trough LoadLibraryShim. As winetest now thinks the library is there it will >> try to launch "gdiplus_test.exe --list" and that of course fails. >> >> Not sure how to approach this. >> >> -- >> Cheers, >> >> Paul. >> >> >> > > This shouldn't be the case on my box as gdiplus is not present by > default on W2K, and should be manually installed (not available > through windows update), or installed by a third party app. > My test box is a clean install without any third apps, except > PDFCreator to simulate a printer to test this part of the suite. I > will check if it has gdiplus bundled in. > > Nicolas Le Cam > Is .NET installed (any version)? -- Cheers, Paul.

Feb. 23, 2009

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

by Nicolas Le Cam

2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Nicolas Le Cam wrote: >> 2009/2/23 Francois Gouget <fgouget(a)free.fr>: >>> On Sun, 22 Feb 2009, Nicolas Le Cam wrote: >>> >>>> This avoid a messagebox in regression tests on systems that don't have >>>> GdiPlus. >>> >>> This seems wrong because winetest.exe is already supposed to check for >>> missing dlls. If I remember correctly this was done explicitely so that >>> individual tests would not have to dynamically link everywhere. >>> >>> Also I tested on a platform that does not have gdiplus, and I did not >>> get a message box. In fact, on that platform, winetest did not extract >>> gdiplus_test.exe, which also seems very wrong to me. >>> >>> So I think that if there's any issue, it's on the winetest.exe side. >>> >>> -- >>> Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ >>> "Lotto: A tax on people who are bad at math." -- unknown >>> "Windows: Microsoft's tax on computer illiterates." -- WE7U >>> >>> >>> >> >> Thanks, >> >> On my w2k pro when I launch the winetest obtained from >> test.winehq.org, I get a MessageBox saying gdiplus is missing, and >> there's already some tests that load dlls dynamically (advpack, >> cryptui, fusion) so thought it was the right way. >> >> I will have a look on the winetest side. >> >> Nicolas Le Cam >> >> >> > The reason you see this is because next to a normal LoadLibrary we also use the > .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but > will trough LoadLibraryShim. As winetest now thinks the library is there it will > try to launch "gdiplus_test.exe --list" and that of course fails. > > Not sure how to approach this. > > -- > Cheers, > > Paul. > > > This shouldn't be the case on my box as gdiplus is not present by default on W2K, and should be manually installed (not available through windows update), or installed by a third party app. My test box is a clean install without any third apps, except PDFCreator to simulate a printer to test this part of the suite. I will check if it has gdiplus bundled in. Nicolas Le Cam

Feb. 23, 2009

Re: msctf: add internal function for handling TfClientIds

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > + /* If i understand this correctly at most a process should generate > + * only a handful of these... But in case I am wrong */ > + if (id_last == 65535) > + { > + ERR("TfClientIds generated exceeds USHORT limit\n"); > + return 0x0; > + } > + id_last++; > + id->id = MAKELONG(id_last, magic); > + id->data = data; > + list_add_head(&clientids,&id->entry); Using an array index would be cleaner than having to search through the list everytime you use an id. -- Alexandre Julliard julliard(a)winehq.org

Feb. 23, 2009

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

by Paul Vriens

Nicolas Le Cam wrote: > 2009/2/23 Francois Gouget <fgouget(a)free.fr>: >> On Sun, 22 Feb 2009, Nicolas Le Cam wrote: >> >>> This avoid a messagebox in regression tests on systems that don't have >>> GdiPlus. >> >> This seems wrong because winetest.exe is already supposed to check for >> missing dlls. If I remember correctly this was done explicitely so that >> individual tests would not have to dynamically link everywhere. >> >> Also I tested on a platform that does not have gdiplus, and I did not >> get a message box. In fact, on that platform, winetest did not extract >> gdiplus_test.exe, which also seems very wrong to me. >> >> So I think that if there's any issue, it's on the winetest.exe side. >> >> -- >> Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ >> "Lotto: A tax on people who are bad at math." -- unknown >> "Windows: Microsoft's tax on computer illiterates." -- WE7U >> >> >> > > Thanks, > > On my w2k pro when I launch the winetest obtained from > test.winehq.org, I get a MessageBox saying gdiplus is missing, and > there's already some tests that load dlls dynamically (advpack, > cryptui, fusion) so thought it was the right way. > > I will have a look on the winetest side. > > Nicolas Le Cam > > > The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails. Not sure how to approach this. -- Cheers, Paul.

Feb. 23, 2009

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

by Nicolas Le Cam

2009/2/23 Francois Gouget <fgouget(a)free.fr>: > On Sun, 22 Feb 2009, Nicolas Le Cam wrote: > >> This avoid a messagebox in regression tests on systems that don't have >> GdiPlus. > > > This seems wrong because winetest.exe is already supposed to check for > missing dlls. If I remember correctly this was done explicitely so that > individual tests would not have to dynamically link everywhere. > > Also I tested on a platform that does not have gdiplus, and I did not > get a message box. In fact, on that platform, winetest did not extract > gdiplus_test.exe, which also seems very wrong to me. > > So I think that if there's any issue, it's on the winetest.exe side. > > -- > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > "Lotto: A tax on people who are bad at math." -- unknown > "Windows: Microsoft's tax on computer illiterates." -- WE7U > > > Thanks, On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way. I will have a look on the winetest side. Nicolas Le Cam

Feb. 23, 2009