February 2009 - Wine-Devel - list.winehq.org

Re: Greatings

by Austin English

On Fri, Feb 20, 2009 at 3:15 PM, Piotr Skólski <sql7(a)wp.pl> wrote: > Hi. > I want help you. > I know c glibc and svn. > I don't know git(but i'm leraning) and winapi(i don't know how learn without > windows). > Where my skils will be usefull. > I have StarCraft and i want help you with dib engine but my skils are still > too low (i don't know how patch my git tree with max dib engine). To patch: http://wiki.winehq.org/Patching -- -Austin

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Erich Hoover

On Sun, Feb 22, 2009 at 2:34 PM, Jérôme Gardou <jerome.gardou(a)gmail.com>wrote: > Chris Robinson a écrit : > >> Having the information there of why it crashed would be nice too, >> especially if it's hard to reproduce. Knowing what the fault was, and where >> (with a backtrace if possible) can give the more development-inclined people >> information of where to look for the issue, instead of needlessly trying to >> make it crash again or go digging around in log files. >> >> >> > Well, that was the intent of my patch : ReportFault is made to give windows > developers information about why the application catched an exception. There > is no reason why wine people could not use it. By the way, is there an easy > way to know if wine was launched from console or not? > Wine may have a macro or function to check for you, but I am not aware of it. In any application you can check to see if getenv("TERM") is empty, if it has a value then the application was launched from a console. Erich Hoover ehoover(a)mines.edu

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Jérôme Gardou

Chris Robinson a écrit : > Having the information there of why it crashed would be nice too, especially > if it's hard to reproduce. Knowing what the fault was, and where (with a > backtrace if possible) can give the more development-inclined people > information of where to look for the issue, instead of needlessly trying to > make it crash again or go digging around in log files. > > Well, that was the intent of my patch : ReportFault is made to give windows developers information about why the application catched an exception. There is no reason why wine people could not use it. By the way, is there an easy way to know if wine was launched from console or not?

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Chris Robinson

On Sunday 22 February 2009 1:15:42 pm Erich Hoover wrote: > On Sun, Feb 22, 2009 at 2:08 PM, Jérôme Gardou <jerome.gardou(a)gmail.com>wrote: > > And ReportFault would be "Your application crashed because of unexpected > > behaviour. Please report a bug to http://bugs.winehq.org. Don't forget to > > attach /tmp/wine.0.log. Please be kind and search for existing bug before > > reporting." > > For the people I know that sounds like it would work. Provided that that > message appeared as a dialog (if run without a terminal) and they wouldn't > need to do anything special to activate the feature then I think that would > help a lot for the non-terminal-savvy folks. Having the information there of why it crashed would be nice too, especially if it's hard to reproduce. Knowing what the fault was, and where (with a backtrace if possible) can give the more development-inclined people information of where to look for the issue, instead of needlessly trying to make it crash again or go digging around in log files.

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Erich Hoover

On Sun, Feb 22, 2009 at 2:08 PM, Jérôme Gardou <jerome.gardou(a)gmail.com>wrote: > Erich Hoover a écrit : > >> I know quite a few people (my converts) that run applications (mostly >> games) where they launch the application from an icon and there is no >> console. They've complained to me every once in a while that they would >> much prefer a dialog informed them when their application crashes. >> Personally, I think that fatal errors (including things like "a DLL could >> not be found") should launch a dialog if a terminal is not available (if >> "TERM" is not set). >> >> Erich Hoover >> ehoover(a)mines.edu <mailto:ehoover(a)mines.edu> >> > > Why not writing directly debug output in a file instead of redirecting it > to stderr. After all, Xorg has its own log, why not /tmp/wine.0.log ? > > And ReportFault would be "Your application crashed because of unexpected > behaviour. Please report a bug to http://bugs.winehq.org. Don't forget to > attach /tmp/wine.0.log. Please be kind and search for existing bug before > reporting." > For the people I know that sounds like it would work. Provided that that message appeared as a dialog (if run without a terminal) and they wouldn't need to do anything special to activate the feature then I think that would help a lot for the non-terminal-savvy folks. Erich Hoover ehoover(a)mines.edu

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Jérôme Gardou

Erich Hoover a écrit : > I know quite a few people (my converts) that run applications (mostly > games) where they launch the application from an icon and there is no > console. They've complained to me every once in a while that they > would much prefer a dialog informed them when their application > crashes. Personally, I think that fatal errors (including things like > "a DLL could not be found") should launch a dialog if a terminal is > not available (if "TERM" is not set). > > Erich Hoover > ehoover(a)mines.edu <mailto:ehoover(a)mines.edu> Why not writing directly debug output in a file instead of redirecting it to stderr. After all, Xorg has its own log, why not /tmp/wine.0.log ? And ReportFault would be "Your application crashed because of unexpected behaviour. Please report a bug to http://bugs.winehq.org. Don't forget to attach /tmp/wine.0.log. Please be kind and search for existing bug before reporting."

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Erich Hoover

On Sun, Feb 22, 2009 at 1:34 PM, Jérôme Gardou <jerome.gardou(a)gmail.com>wrote: > ... > I'm not sure > that we want to reproduce windows XP behaviour here (understand "Your > application encountered an unexpected error. What do you want to do : > send report/do not send) which annoys most people, and is not that useful. > Most wine users, when their app crashes, open a bug report and attach > the console log. If the log contains information got from ReportFault, > developers will gain some time, and have the preceding context of the call. > > Just my 2 cents :-) > I know quite a few people (my converts) that run applications (mostly games) where they launch the application from an icon and there is no console. They've complained to me every once in a while that they would much prefer a dialog informed them when their application crashes. Personally, I think that fatal errors (including things like "a DLL could not be found") should launch a dialog if a terminal is not available (if "TERM" is not set). Erich Hoover ehoover(a)mines.edu

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Jérôme Gardou

Chris Robinson a écrit : > On Sunday 22 February 2009 12:09:01 pm Austin English wrote: > >> On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou <jerome.gardou(a)gmail.com> >> > wrote: > >>> Jérôme Gardou a écrit : >>> >>>> This should help debugging applications which performs their own >>>> exception handling. >>>> >>> After a bit of thinking, I think that this should be displayed each time >>> the function is called. Is there any macro in wine/debug.h which would >>> display a message, even when WINEDEBUG is set to "-all" ? >>> >> MESSAGE() >> Thanks ! > > Perhaps a MessageBox or some fancier dialog would be better. MSDN says it can > behave differently depending on how the user has their system configured.. > what kind of options are available? > > > The aim of this patch is to provide some information to wine developers when an application crashes because of an unexpected behaviour of the winapi implementation. In this case, the implementation is WINE, and fixmes/traces etc... are currently displayed in console. I'm not sure that we want to reproduce windows XP behaviour here (understand "Your application encountered an unexpected error. What do you want to do : send report/do not send) which annoys most people, and is not that useful. Most wine users, when their app crashes, open a bug report and attach the console log. If the log contains information got from ReportFault, developers will gain some time, and have the preceding context of the call. Just my 2 cents :-)

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Chris Robinson

On Sunday 22 February 2009 12:09:01 pm Austin English wrote: > On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou <jerome.gardou(a)gmail.com> wrote: > > Jérôme Gardou a écrit : > >> This should help debugging applications which performs their own > >> exception handling. > > > > After a bit of thinking, I think that this should be displayed each time > > the function is called. Is there any macro in wine/debug.h which would > > display a message, even when WINEDEBUG is set to "-all" ? > > MESSAGE() Perhaps a MessageBox or some fancier dialog would be better. MSDN says it can behave differently depending on how the user has their system configured.. what kind of options are available?

Feb. 22, 2009

Re: faultrep:display useful information in ReportFault

by Austin English

On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou <jerome.gardou(a)gmail.com> wrote: > Jérôme Gardou a écrit : >> This should help debugging applications which performs their own >> exception handling. > After a bit of thinking, I think that this should be displayed each time > the function is called. Is there any macro in wine/debug.h which would > display a message, even when WINEDEBUG is set to "-all" ? > > > MESSAGE() -- -Austin

Feb. 22, 2009