Wine-Devel

By thread

wine-devel@list.winehq.org

February 2009

143 participants
988 messages

Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu

by Austin English

2009/2/20 Rein Klazes <wijn(a)online.nl>: > Hi, > > See subject. > > Rein. > > > > A testcase would be helpful. -- -Austin

Feb. 20, 2009

Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu

by Peter Oberndorfer

On Freitag 20 Februar 2009, Rein Klazes wrote: > Hi, > > See subject. > > Rein. > Hi, mostly minor code style comments. > if( hMenu ) { > + MENUINFO minfo; > + MENUITEMINFOW miteminfo; > POPUPMENU* menu = MENU_GetMenu(hMenu); > menu->wFlags |= MF_SYSMENU | MF_POPUP; > SetMenuDefaultItem(hMenu, SC_CLOSE, FALSE); > + > + minfo.cbSize = sizeof( MENUINFO); > + minfo.dwStyle = MNS_CHECKORBMP; > + minfo.fMask = MIM_STYLE; > + SetMenuInfo( hMenu, &minfo); > + > + miteminfo.cbSize = sizeof( MENUITEMINFOW); > + miteminfo.fMask = MIIM_BITMAP; > + miteminfo.hbmpItem = HBMMENU_POPUP_CLOSE; > + SetMenuItemInfoW( hMenu, SC_CLOSE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_RESTORE; > + SetMenuItemInfoW( hMenu, SC_RESTORE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_MAXIMIZE; > + SetMenuItemInfoW( hMenu, SC_MAXIMIZE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_MINIMIZE; > + SetMenuItemInfoW( hMenu, SC_MINIMIZE, FALSE, &miteminfo); > } I think this part deserves a bit more spacing to be readable. Something like the above looks better IMO. Also there is some inconsistent spacing around the beginning and end ()/{} which does not match the rest of the file. > + logfont.lfHeight = min( h, w) - 2 ; > + TextOutW( hdc, rect->left, rect->top, bmchr, 1); double space after '=' and ',' > case (INT_PTR)HBMMENU_POPUP_CLOSE: > + bmchr[0] = 0x72; > + break; > case (INT_PTR)HBMMENU_POPUP_RESTORE: > + bmchr[0] = 0x32; > + break; > case (INT_PTR)HBMMENU_POPUP_MAXIMIZE: > + bmchr[0] = 0x31; > + break; > case (INT_PTR)HBMMENU_POPUP_MINIMIZE: > + bmchr[0] = 0x30; > + break; The constants seem to be equal to DFCS_CAPTION... I just tried to use DrawFrameControl but it seems to always draw a border around the images. And i did not find the right parameters for not drawing a border. It could save some code for font setup but i guess it is not usable for this :-( > + TRACE(" height %d rect %s\n", logfont.lfHeight, wine_dbgstr_rect( rect)); leftover from debugging or is it still needed? Greetings Peter

Feb. 20, 2009

Re: Wine download page usability problem

by Matt 'Murph' Finnicum

For me, it got Gentoo just fine. using: www-client/mozilla-firefox-3.1_beta2-r1 "You're using Firefox 3.1 on Gentoo Linux!" --Murph On Fri, Feb 20, 2009 at 12:45 PM, Daniel Verkamp <daniel(a)drv.nu> wrote: > On Fri, Feb 20, 2009 at 12:40 PM, Dan Kegel <dank(a)kegel.com> wrote: > [...] >> Next idea: why don't we detect the user's distro via javascript, and >> put a targeted link to the 'right' package above the table? >> >> Please try http://kegel.com/wine/distro.html >> and let me know if it detects your distro properly, >> I'll fix it up as needed. >> >> I'm kind of excited about this technique for cleaning up install flows... >> - Dan >> > > On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) > the page just detects "unknown distribution Linux". > > Thanks, > -- Daniel Verkamp > > >

Feb. 20, 2009

Re: Wine download page usability problem

by Daniel Verkamp

On Fri, Feb 20, 2009 at 12:55 PM, Dan Kegel <dank(a)kegel.com> wrote: > On Fri, Feb 20, 2009 at 10:45 AM, Daniel Verkamp <daniel(a)drv.nu> wrote: >>> Please try http://kegel.com/wine/distro.html >>> and let me know if it detects your distro properly, >> >> On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) >> the page just detects "unknown distribution Linux". > > Try it now... > Indeed, works now. (As a side note, since there are no Gentoo packages on the download page, maybe it makes sense to point the user at some appropriate documentation about how to install it.)

Feb. 20, 2009

Re: Wine download page usability problem

by Dan Kegel

On Fri, Feb 20, 2009 at 10:53 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> Next idea: why don't we detect the user's distro via javascript, and >> put a targeted link to the 'right' package above the table? > > Can we also have a non-Javascript page, please? People with > accessibility issues, and crufty old curmudgeons like me who disable > Javascript by default, would appreciate it. Of course. I think we should only have a single page, and if Javascript is active, it should simply work better.

Feb. 20, 2009

Re: Wine download page usability problem

by Dan Kegel

On Fri, Feb 20, 2009 at 10:45 AM, Daniel Verkamp <daniel(a)drv.nu> wrote: >> Please try http://kegel.com/wine/distro.html >> and let me know if it detects your distro properly, > > On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) > the page just detects "unknown distribution Linux". Try it now...

Feb. 20, 2009

Re: Wine download page usability problem

by Juan Lang

> Next idea: why don't we detect the user's distro via javascript, and > put a targeted link to the 'right' package above the table? Can we also have a non-Javascript page, please? People with accessibility issues, and crufty old curmudgeons like me who disable Javascript by default, would appreciate it. --Juan

Feb. 20, 2009

Re: Wine download page usability problem

by IneedAname

On Fri, 20 Feb 2009 10:40:28 -0800 Dan Kegel <dank(a)kegel.com> wrote: > Please try http://kegel.com/wine/distro.html > and let me know if it detects your distro properly, > I'll fix it up as needed. It does not my detect distro version. Can that be done?

Feb. 20, 2009

Re: Wine download page usability problem

by Daniel Verkamp

On Fri, Feb 20, 2009 at 12:40 PM, Dan Kegel <dank(a)kegel.com> wrote: [...] > Next idea: why don't we detect the user's distro via javascript, and > put a targeted link to the 'right' package above the table? > > Please try http://kegel.com/wine/distro.html > and let me know if it detects your distro properly, > I'll fix it up as needed. > > I'm kind of excited about this technique for cleaning up install flows... > - Dan > On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) the page just detects "unknown distribution Linux". Thanks, -- Daniel Verkamp

Feb. 20, 2009

Re: Wine download page usability problem

by Dan Kegel

On Fri, Feb 20, 2009 at 9:55 AM, Jeremy White <jwhite(a)winehq.org> wrote: > I can see that it consumes vertical white space, and I > can get over myself. I remove my objection :-/. Thanks! Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan

Feb. 20, 2009

← Newer
1
...
19
20
21
22
23
24
25
...
99
Older →

Jump to page: