February 2009 - Wine-Devel - list.winehq.org

Re: [12/13] fusion: Sort the list of assemblies built during enumeration.

by James Hawkins

On Thu, Feb 19, 2009 at 5:06 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > This hopefully fixes the test failures on Alexandre's machine. > This isn't how it's done on Windows. On Windows, the order is based solely on directory enumeration, which we don't try to match in Wine. The fix is to check for all N results N times, where N is the number of assemblies enumerated. -- James Hawkins

Feb. 19, 2009

Re: [13/13] fusion: Add tests for the IAssemblyEnum interface.

by Hans Leidekker

Hi Paul, > These tests crash on Vista with .NET 3.5 (not sure about other platforms/.NET > versions yet). The enum_gac_assemblies function relies on the fact that > ffd.cFileName contains 2 underscores. On Vista however I see some assemblies > with a different format for the cFileName like: > > 6.0.0.0_en_31bf3856ad364e35 Yes, that test simply ignores the culture attribute. Is that one of your own machines? If so, can you try this patch? -Hans

Feb. 19, 2009

Re: [4/5] dxgi: Convert DXGI_FORMAT values to WINED3DFORMAT values.

by Henri Verbeet

2009/2/19 Stefan Dösinger <stefandoesinger(a)gmx.at>: > Am Donnerstag, 19. Februar 2009 17:03:37 schrieb Henri Verbeet: > > I haven't looked at all the different formats yet, just a general question: > Why did you choose to keep the WINED3D formats and not use the DXGI formats > in wined3d? I'm not saying that there's anything wrong with that, I'm just > curious what lead to that decision. I was inclined to do it the other way > around, mostly because of the generic and specific(ie SINT, UINT, SRGB) > formats in DXGI. > Not all of those formats have a DXGI equivalent. Where a DXGI equivalent exists I'm using that, and we'll probably want to change the naming of the other formats to be consistent with the DXGI formats eventually.

Feb. 19, 2009

Re: [13/13] fusion: Add tests for the IAssemblyEnum interface.

by Paul Vriens

Hans Leidekker wrote: > -Hans > > > ------------------------------------------------------------------------ > > Hi Hans, These tests crash on Vista with .NET 3.5 (not sure about other platforms/.NET versions yet). The enum_gac_assemblies function relies on the fact that ffd.cFileName contains 2 underscores. On Vista however I see some assemblies with a different format for the cFileName like: 6.0.0.0_en_31bf3856ad364e35 This explains the (first) crash as we dereference a pointer. So doing something like this fixes that piece: else if (depth == 1) { - ptr = strstr(ffd.cFileName, "__"); + CHAR version[MAX_PATH]; + + lstrcpyA(version, ffd.cFileName); + ptr = strstr(version, "_"); *ptr = '\0'; - ptr += 2; + ptr = strrchr(ffd.cFileName, '_'); + ptr += 1; sprintf(buf, "Version=%s, Culture=neutral, PublicKeyToken=%s", - ffd.cFileName, ptr); + version, ptr); This seems to work fine but than it crashes again while trying to free the memory "HeapFree(GetProcessHeap(), 0, asmname->data);" in test_enumerate. Just ignoring those HeapFree's doesn't fix it as we crash again later on. -- Cheers, Paul.

Feb. 19, 2009

Re: [4/5] dxgi: Convert DXGI_FORMAT values to WINED3DFORMAT values.

by Stefan Dösinger

Am Donnerstag, 19. Februar 2009 17:03:37 schrieb Henri Verbeet: I haven't looked at all the different formats yet, just a general question: Why did you choose to keep the WINED3D formats and not use the DXGI formats in wined3d? I'm not saying that there's anything wrong with that, I'm just curious what lead to that decision. I was inclined to do it the other way around, mostly because of the generic and specific(ie SINT, UINT, SRGB) formats in DXGI.

Feb. 19, 2009

Re: msctf/tests: Don't import uuid library cause it could break crosstest

by Nikolay Sivov

Austin English wrote: > On Thu, Feb 19, 2009 at 9:21 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > >> Changelog: >> - Don't import uuid library cause it could break crosstest >> >> >From 26890998dc20bd31c2d23b8b59dfaf664ca98dc0 Mon Sep 17 00:00:00 2001 >> From: Nikolay Sivov <bunglehead(a)gmail.com> >> Date: Thu, 19 Feb 2009 10:20:32 -0500 >> Subject: Don't import uuid library cause it could break crosstest >> >> --- >> dlls/msctf/tests/Makefile.in | 2 +- >> dlls/msctf/tests/inputprocessor.c | 1 + >> 2 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/msctf/tests/Makefile.in b/dlls/msctf/tests/Makefile.in >> index 669f5a1..0d7aba8 100644 >> --- a/dlls/msctf/tests/Makefile.in >> +++ b/dlls/msctf/tests/Makefile.in >> @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. >> SRCDIR = @srcdir@ >> VPATH = @srcdir@ >> TESTDLL = msctf.dll >> -IMPORTS = uuid ole32 user32 kernel32 >> +IMPORTS = ole32 user32 kernel32 >> >> CTESTS = \ >> inputprocessor.c >> diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c >> index 200a0d4..2e71eec 100644 >> --- a/dlls/msctf/tests/inputprocessor.c >> +++ b/dlls/msctf/tests/inputprocessor.c >> @@ -33,6 +33,7 @@ static ITfInputProcessorProfiles* g_ipp; >> static LANGID gLangid; >> >> DEFINE_GUID(CLSID_FakeService, 0xEDE1A7AD,0x66DE,0x47E0,0xB6,0x20,0x3E,0x92,0xF8,0x24,0x6B,0xF3); >> +DEFINE_GUID(CLSID_TF_InputProcessorProfiles, 0x33c53a50,0xf456,0x4884,0xb0,0x49,0x85,0xfd,0x64,0x3e,0xcf,0xed); >> >> static HRESULT initialize(void) >> { >> -- >> 1.5.6.5 >> >> >> >> >> >> > > AJ beat you to it: > http://source.winehq.org/git/wine.git/?a=commitdiff;h=cd656fa7f68bc86f78be2… > > Yeah, I see :).

Feb. 19, 2009

Re: revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf

by Steven Edwards

On Thu, Feb 19, 2009 at 5:43 AM, Francois Gouget <fgouget(a)free.fr> wrote: > A little bit of explanation would be nice... I thought the Changelog in the patch would explain enough. MSG_WAITALL is not defined on Cygwin when building wininet or winhttp without it. Since I can't rebuild all of Wine and I've not checked on MSVC to see if its just a w32api thing, maybe this one should be held off. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 19, 2009

Re: msctf/tests: Don't import uuid library cause it could break crosstest

by Paul Vriens

Nikolay Sivov wrote: > Changelog: > - Don't import uuid library cause it could break crosstest > >>From 26890998dc20bd31c2d23b8b59dfaf664ca98dc0 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Thu, 19 Feb 2009 10:20:32 -0500 > Subject: Don't import uuid library cause it could break crosstest > > --- > dlls/msctf/tests/Makefile.in | 2 +- > dlls/msctf/tests/inputprocessor.c | 1 + > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/msctf/tests/Makefile.in b/dlls/msctf/tests/Makefile.in > index 669f5a1..0d7aba8 100644 > --- a/dlls/msctf/tests/Makefile.in > +++ b/dlls/msctf/tests/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = msctf.dll > -IMPORTS = uuid ole32 user32 kernel32 > +IMPORTS = ole32 user32 kernel32 > > CTESTS = \ > inputprocessor.c > diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c > index 200a0d4..2e71eec 100644 > --- a/dlls/msctf/tests/inputprocessor.c > +++ b/dlls/msctf/tests/inputprocessor.c > @@ -33,6 +33,7 @@ static ITfInputProcessorProfiles* g_ipp; > static LANGID gLangid; > > DEFINE_GUID(CLSID_FakeService, 0xEDE1A7AD,0x66DE,0x47E0,0xB6,0x20,0x3E,0x92,0xF8,0x24,0x6B,0xF3); > +DEFINE_GUID(CLSID_TF_InputProcessorProfiles, 0x33c53a50,0xf456,0x4884,0xb0,0x49,0x85,0xfd,0x64,0x3e,0xcf,0xed); > > static HRESULT initialize(void) > { Hi Already fixed in Git: http://source.winehq.org/git/wine.git/?a=commit;h=cd656fa7f68bc86f78be21c67… -- Cheers, Paul.

Feb. 19, 2009

Re: msctf/tests: Don't import uuid library cause it could break crosstest

by Austin English

On Thu, Feb 19, 2009 at 9:21 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > Changelog: > - Don't import uuid library cause it could break crosstest > > >From 26890998dc20bd31c2d23b8b59dfaf664ca98dc0 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Thu, 19 Feb 2009 10:20:32 -0500 > Subject: Don't import uuid library cause it could break crosstest > > --- > dlls/msctf/tests/Makefile.in | 2 +- > dlls/msctf/tests/inputprocessor.c | 1 + > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/msctf/tests/Makefile.in b/dlls/msctf/tests/Makefile.in > index 669f5a1..0d7aba8 100644 > --- a/dlls/msctf/tests/Makefile.in > +++ b/dlls/msctf/tests/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = msctf.dll > -IMPORTS = uuid ole32 user32 kernel32 > +IMPORTS = ole32 user32 kernel32 > > CTESTS = \ > inputprocessor.c > diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c > index 200a0d4..2e71eec 100644 > --- a/dlls/msctf/tests/inputprocessor.c > +++ b/dlls/msctf/tests/inputprocessor.c > @@ -33,6 +33,7 @@ static ITfInputProcessorProfiles* g_ipp; > static LANGID gLangid; > > DEFINE_GUID(CLSID_FakeService, 0xEDE1A7AD,0x66DE,0x47E0,0xB6,0x20,0x3E,0x92,0xF8,0x24,0x6B,0xF3); > +DEFINE_GUID(CLSID_TF_InputProcessorProfiles, 0x33c53a50,0xf456,0x4884,0xb0,0x49,0x85,0xfd,0x64,0x3e,0xcf,0xed); > > static HRESULT initialize(void) > { > -- > 1.5.6.5 > > > > > AJ beat you to it: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cd656fa7f68bc86f78be2… -- -Austin

Feb. 19, 2009

Re: Status of USB driver support?

by Alexander Morozov

> Unhandled exception: unimplemented function > usbd.sys.USBD_GetUSBDIVersion called in 32-bit code (0x7ee2e923) Should implement USBD_GetUSBDIVersion to fix this.

Feb. 19, 2009